Michael S. Tsirkin m...@redhat.com writes:
On Mon, Mar 09, 2015 at 05:43:19PM +1030, Rusty Russell wrote:
I think it's a good idea to merge these patches (maybe except the
!TASK_RUNNING thing) sooner rather than later, to make sure people have
the time to test the fixes properly. Would you
Michael S. Tsirkin m...@redhat.com writes:
Subject: [PATCH] virtio_mmio: fix access width for mmio
Just for the record:
Applied.
Thanks,
Rusty.
Going over the virtio mmio code, I noticed that it doesn't correctly
access modern device config values using natural accessors: it uses
readb to
Ohad Ben-Cohen o...@wizery.com writes:
On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin m...@redhat.com wrote:
On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote:
virtio spec requires that all drivers set DRIVER_OK
before using devices. While rpmsg isn't yet
included in the
Thomas Huth th...@linux.vnet.ibm.com writes:
On Wed, 25 Feb 2015 16:11:27 +0100
Cornelia Huck cornelia.h...@de.ibm.com wrote:
On Wed, 25 Feb 2015 15:36:02 +0100
Michael S. Tsirkin m...@redhat.com wrote:
virtio balloon has this code:
wait_event_interruptible(vb-config_change,
Cornelia Huck cornelia.h...@de.ibm.com writes:
On Wed, 4 Mar 2015 11:25:56 +0100
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Mar 04, 2015 at 04:44:54PM +1030, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell
Michael S. Tsirkin m...@redhat.com writes:
virtio spec requires that all drivers set DRIVER_OK
before using devices. While rpmsg isn't yet
included in the virtio 1 spec, previous spec versions
also required this.
virtio rpmsg violates this rule: is calls kick
before setting DRIVER_OK.
The
Michael S. Tsirkin m...@redhat.com writes:
Hi Rusty!
There are a bunch of (mostly virtio 1.0 related) fixes for virtio
that need to go into 4.0 I think.
virtio_blk: typo fix
virtio_blk: fix comment for virtio 1.0
OK, I've added these two. I tend to be overcautious after the
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote:
Thomas Huth th...@linux.vnet.ibm.com writes:
On Thu, 26 Feb 2015 11:50:42 +1030
Rusty Russell ru...@rustcorp.com.au wrote:
Thomas Huth th...@linux.vnet.ibm.com writes:
Hi all
Thomas Huth th...@linux.vnet.ibm.com writes:
On Thu, 26 Feb 2015 11:50:42 +1030
Rusty Russell ru...@rustcorp.com.au wrote:
Thomas Huth th...@linux.vnet.ibm.com writes:
Hi all,
with the recent kernel 3.19, I get a kernel warning when I start my
KVM guest on s390 with virtio balloon
Thomas Huth th...@linux.vnet.ibm.com writes:
Hi all,
with the recent kernel 3.19, I get a kernel warning when I start my
KVM guest on s390 with virtio balloon enabled:
The deeper problem is that virtio_ccw_get_config just silently fails on
OOM.
Neither get_config nor set_config are expected
laptop, and a BE and LE guest
on a BE powerpc machine, to check that all combinations work correctly.
If others test too, that would be appreciated!
Cheers,
Rusty.
From 95ac91554ed602f856a2a5fcc25eaffcad1b1c8d Mon Sep 17 00:00:00 2001
From: Rusty Russell ru...@rustcorp.com.au
Date: Tue, 24 Feb 2015
version
Rusty Russell (53):
virtio-pci: define layout for virtio 1.0
virtio_pci: macros for PCI layout offsets
virtio: define VIRTIO_PCI_CAP_PCI_CFG in header.
virtio: Don't expose legacy block features when VIRTIO_BLK_NO_LEGACY
defined.
virtio: Don't expose legacy config
Luis R. Rodriguez mcg...@do-not-panic.com writes:
From: Luis R. Rodriguez mcg...@suse.com
The general documentation we have for pv_ops is currenty present
on the IA64 docs, but since this documentation covers IA64 xen
enablement and IA64 Xen support got ripped out a while ago
through commit
Amos Kong ak...@redhat.com writes:
From: Rusty Russell ru...@rustcorp.com.au
The previous patch added one potential problem: we can still be
reading from a hwrng when it's unregistered. Add a wait for zero
in the hwrng_unregister path.
v4: add cleanup_done flag to insure that cleanup
Amos Kong ak...@redhat.com writes:
From: Rusty Russell ru...@rustcorp.com.au
current_rng holds one reference, and we bump it every time we want
to do a read from it.
This means we only hold the rng_mutex to grab or drop a reference,
so accessing /sys/devices/virtual/misc/hw_random
Herbert Xu herb...@gondor.apana.org.au writes:
On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote:
From: Rusty Russell ru...@rustcorp.com.au
The previous patch added one potential problem: we can still be
reading from a hwrng when it's unregistered. Add a wait for zero
without a lock, which could change (eg. to NULL)
underneath it.
v3: initialize kref (thanks Amos Kong)
v2: fix missing put_rng() on exit path (thanks Amos Kong)
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index
Amos Kong ak...@redhat.com writes:
From: Rusty Russell ru...@rustcorp.com.au
current_rng holds one reference, and we bump it every time we want
to do a read from it.
This means we only hold the rng_mutex to grab or drop a reference,
so accessing /sys/devices/virtual/misc/hw_random
Jason Wang jasow...@redhat.com writes:
Below should be useful for some experiments Jason is doing.
I thought I'd send it out for early review/feedback.
event idx feature allows us to defer interrupts until
a specific # of descriptors were used.
Sometimes it might be useful to get an
Michael S. Tsirkin m...@redhat.com writes:
Defer config changed notifications that arrive during
probe/scan/freeze/restore.
This will allow drivers to set DRIVER_OK earlier, without worrying about
racing with config change interrupts.
This change will also benefit old hypervisors (before
Cornelia Huck cornelia.h...@de.ibm.com writes:
Note that we care only about the fields still in use for virtio v1.0.
Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com
Hi Cornelia,
Cornelia Huck cornelia.h...@de.ibm.com writes:
With virtio-1, we support more than 32 feature bits. Let's make
vdev-guest_features depend on the number of supported feature bits,
allowing us to grow the feature bits automatically.
It's a judgement call, but I would say that simply using
Michael S. Tsirkin m...@redhat.com writes:
virtio spec 0.9.X requires DRIVER_OK to be set before
VQs are used, but some drivers use VQs before probe
function returns.
Since DRIVER_OK is set after probe, this violates the spec.
Even though under virtio 1.0 transitional devices support this
Amos Kong ak...@redhat.com writes:
I started a QEMU (non-smp) guest with one virtio-rng device, and read
random data from /dev/hwrng by dd:
# dd if=/dev/hwrng of=/dev/null
In the same time, if I check hwrng attributes from sysfs by cat:
# cat /sys/class/misc/hw_random/rng_*
The cat
under the rng_mutex), but
a standard pattern.
This also solves the problem that the hwrng_fillfn thread was
accessing current_rng without a lock, which could change (eg. to NULL)
underneath it.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/char/hw_random/core.c | 135
Another interesting anti-pattern.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/char/hw_random/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 6a34feca6b43..96fa06716e95 100644
--- a/drivers/char
(it leaves the current lock untouched), just adds a
lock to protect the read function and the static buffers, in preparation
for transition.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/char/hw_random/core.c | 20 +---
1 file changed, 17 insertions(+), 3
Interesting anti-pattern.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/char/hw_random/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index b4a21e9521cf..6a34feca6b43 100644
The previous patch added one potential problem: we can still be
reading from a hwrng when it's unregistered. Add a wait for zero
in the hwrng_unregister path.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/char/hw_random/core.c | 5 +
1 file changed, 5 insertions(+)
diff
Amos Kong ak...@redhat.com writes:
On Sun, Sep 14, 2014 at 01:12:58AM +0800, Amos Kong wrote:
On Thu, Sep 11, 2014 at 09:08:03PM +0930, Rusty Russell wrote:
Amos Kong ak...@redhat.com writes:
When I check hwrng attributes in sysfs, cat process always gets
stuck if guest has only 1 vcpu
Amit Shah amit.s...@redhat.com writes:
On (Wed) 10 Sep 2014 [14:11:37], Amos Kong wrote:
Before we really unregister the hwrng device, reading will get stuck if
the virtio device is reset. We should return error for reading when we
start to remove the device.
Signed-off-by: Amos Kong
Amos Kong ak...@redhat.com writes:
When I check hwrng attributes in sysfs, cat process always gets
stuck if guest has only 1 vcpu and uses a slow rng backend.
Currently we check if there is any tasks waiting to be run on
current cpu in rng_dev_read() by need_resched(). But need_resched()
Amit Shah amit.s...@redhat.com writes:
On (Wed) 10 Sep 2014 [14:11:36], Amos Kong wrote:
When we try to hot-remove a busy virtio-rng device from QEMU monitor,
the device can't be hot-removed. Because virtio-rng driver hangs at
wait_for_completion_killable().
This patch exits the waiting by
Michael S. Tsirkin m...@redhat.com writes:
Below should be useful for some experiments Jason is doing.
I thought I'd send it out for early review/feedback.
Compiled-only at this point.
It's not a terrible idea, but it will come down to how effective it is
in practice.
I'm tempted to make it
Jan Kiszka jan.kis...@siemens.com writes:
On 2014-06-12 04:27, Rusty Russell wrote:
Henning Schild henning.sch...@siemens.com writes:
It was also never implemented, and remains a thought experiment.
However, implementing it in lguest should be fairly easy.
The reason why a trusted helper
Henning Schild henning.sch...@siemens.com writes:
Hi,
i am working on the jailhouse[1] project and am currently looking at
inter-VM communication. We want to connect guests directly with virtual
consoles based on shared memory. The code complexity in the hypervisor
should be minimal, it
Vlad Zolotarov vl...@cloudius-systems.com writes:
Rusty, hi!
I'd like to ask for a small clarification about the virtio spec.
The virtio specification is put the way that it allows the out-of-order
completions in general. Although it states that it's mostly relevant to
the virtio-blk it
Alexander Graf ag...@suse.de writes:
On 05/07/2014 11:57 AM, Marc Zyngier wrote:
How virtio implementations should determine their endianness is
a spec question, I think; at any rate QEMU and kvmtool ought to
agree on how it's done. I think the most recent suggestion on the
QEMU mailing list
Qin Chuanyu qinchua...@huawei.com writes:
udp packet use 2 buffers at least, one for vnet_hdr and
one for skb-data.
we could change the threshold from 2 to 3, so the udp packet
which data buff only using single desc will gain from this.
the guest would avoid from allocating memory
Luiz Capitulino lcapitul...@redhat.com writes:
On Fri, 17 Jan 2014 09:10:47 +1030
Rusty Russell ru...@rustcorp.com.au wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
From: Luiz capitulino lcapitul...@redhat.com
This commit adds support to a new virtqueue called message virtqueue
Luiz Capitulino lcapitul...@redhat.com writes:
From: Luiz capitulino lcapitul...@redhat.com
This commit adds support to a new virtqueue called message virtqueue.
OK, this needs a lot of thought (especially since reworking the virtio
balloon is on the TODO list for the OASIS virtio technical
Jason Wang jasow...@redhat.com writes:
From: Asias He asias.he...@gmail.com
vqs are freed in virtscsi_freeze but the hotcpu_notifier is not
unregistered. We will have a use-after-free usage when the notifier
callback is called after virtscsi_freeze.
Fixes:
Jason Wang jasow...@redhat.com writes:
On 10/28/2013 04:01 PM, Asias He wrote:
vqs are freed in virtscsi_freeze but the hotcpu_notifier is not
unregistered. We will have a use-after-free usage when the notifier
callback is called after virtscsi_freeze.
Signed-off-by: Asias He
Luiz Capitulino lcapitul...@redhat.com writes:
According to the virtio spec, the device configuration field
that should be updated after an inflation or deflation
operation is the 'actual' field, not the 'num_pages' one.
Commit 855e0c5288177bcb193f6f6316952d2490478e1c swapped them
in
Pawel Moll pawel.m...@arm.com writes:
On Tue, 2013-11-05 at 03:36 +, Rusty Russell wrote:
This particular can is empty - all worms already escaped :-)
I just thought that if you wait for 1.0, it will always be
little-endian, and if the current qemu only supported little-endian your
life
Rusty Russell ru...@rustcorp.com.au writes:
Pawel Moll pawel.m...@arm.com writes:
On Fri, 2013-10-11 at 15:36 +0100, Marc Zyngier wrote:
As virtio-mmio config registers are specified to be little-endian,
using readl() to read the magic value and then memcmp() to check it
fails on BE (as readl
Marc Zyngier marc.zyng...@arm.com writes:
On 14/10/13 09:21, Rusty Russell wrote:
Marc Zyngier marc.zyng...@arm.com writes:
This small patch series adds just enough kernel infrastructure and
fixes to allow a BE guest to use virtio-mmio on a LE host, provided
that the host actually supports
: virtio_config: introduce size-based accessors.
This lets the us do endian conversion if necessary, and insulates the
drivers from that change.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index 29b9104..e62acdd 100644
it by encoding the magic value as an integer instead of a string.
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Pawel Moll pawel.m...@arm.com
Signed-off-by: Marc Zyngier marc.zyng...@arm.com
---
drivers/virtio/virtio_mmio.c | 2 +-
1 file changed, 1 insertion(+), 1
kvm-arm64/be-on-le-3.12-rc4
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Pawel Moll pawel.m...@arm.com
We are changing the spec to make everything LE instead of
the native endian.
I think that'll fix the issue in a cleaner way.
While I agree
Pawel Moll pawel.m...@arm.com writes:
On Mon, 2013-10-14 at 11:46 +0100, Michael S. Tsirkin wrote:
What I meant is that under the proposed scheme, users with
existing v1 drivers must configure a v1 device explicitly.
According to the plan, drivers will be updated so they can
work with both
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Oct 14, 2013 at 06:50:48PM +0200, Paolo Bonzini wrote:
Il 14/10/2013 17:36, Marc Zyngier ha scritto:
Devices are fine in QEMU, it's only the generic parts (rings) that are
missing AFAICT.
So if I understand correctly how it works,
Asias He as...@redhat.com writes:
vscsi-num_queues counts the number of request virtqueue which does not
include the control and event virtqueue. It is wrong to subtract
VIRTIO_SCSI_VQ_BASE from vscsi-num_queues.
This patch fixes the following panic.
Applied.
Thanks,
Rusty.
(qemu)
Michael S. Tsirkin m...@redhat.com writes:
virtio_ring.h uses mb() and friends, make
it pull in asm/barrier.h itself, not rely
on other headers to do it.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Applied.
Thanks,
Rusty.
PS. I'll squeeze these into this merge window, since they're
Michael S. Tsirkin m...@redhat.com writes:
This fixes build for the vringh test:
[linux]$ make -C tools/virtio/
make: Entering directory `/home/mst/scm/linux/tools/virtio'
cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
-fno-strict-overflow -fno-strict-aliasing -fno-common -MMD
Chegu Vinod chegu_vi...@hp.com writes:
On 6/30/2013 11:22 PM, Rusty Russell wrote:
Chegu Vinod chegu_vi...@hp.com writes:
Hello,
Lots (~700+) of the following messages are showing up in the dmesg of a
3.10-rc1 based kernel (Host OS is running on a large socket count box
with HT
Chegu Vinod chegu_vi...@hp.com writes:
On 7/1/2013 10:49 PM, Rusty Russell wrote:
Chegu Vinod chegu_vi...@hp.com writes:
On 6/30/2013 11:22 PM, Rusty Russell wrote:
module: do percpu allocation after uniqueness check. No, really!
v3.8-rc1-5-g1fb9341 was supposed to stop parallel kvm loads
Alex Williamson alex.william...@redhat.com writes:
On Mon, 2013-06-17 at 13:56 +1000, Benjamin Herrenschmidt wrote:
On Sun, 2013-06-16 at 21:13 -0600, Alex Williamson wrote:
IOMMU groups themselves don't provide security, they're accessed by
interfaces like VFIO, which provide the
Alex Williamson alex.william...@redhat.com writes:
On Mon, 2013-06-17 at 13:56 +1000, Benjamin Herrenschmidt wrote:
On Sun, 2013-06-16 at 21:13 -0600, Alex Williamson wrote:
IOMMU groups themselves don't provide security, they're accessed by
interfaces like VFIO, which provide the
Linda Walsh l...@tlinx.org writes:
Should we have any expectation that a module name and it's filename
should be equivalent?
I was writing an auto-complete script for modprobe so it wouldn't give
me the option to double load a module (I'd have to manually type it in if
I really wanted it).
Anthony Liguori aligu...@us.ibm.com writes:
Hi Rusty,
Rusty Russell ru...@rustcorp.com.au writes:
Anthony Liguori aligu...@us.ibm.com writes:
4) Do virtio-pcie, make it PCI-e friendly (drop the IO BAR completely), give
it a new device/vendor ID. Continue to use virtio-pci for existing
Michael S. Tsirkin m...@redhat.com writes:
By my count, net still has 7 feature bits left, so I don't think the
feature bits are likely to be a limitation in the next 6 months?
Yes but you wanted a generic transport feature bit
for flexible SG layout.
Are you happy with
Anthony Liguori aligu...@us.ibm.com writes:
4) Do virtio-pcie, make it PCI-e friendly (drop the IO BAR completely), give
it a new device/vendor ID. Continue to use virtio-pci for existing
devices potentially adding virtio-{net,blk,...}-pcie variants for
people that care to use them.
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Jun 03, 2013 at 09:56:15AM +0930, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote:
Rusty Russell ru...@rustcorp.com.au writes:
Anthony Liguori aligu
Michael S. Tsirkin m...@redhat.com writes:
On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote:
Rusty Russell ru...@rustcorp.com.au writes:
Anthony Liguori aligu...@us.ibm.com writes:
Forcing a guest driver change is a really big
deal and I see no reason to do that unless
Luiz Capitulino lcapitul...@redhat.com writes:
1. s/These are devices are/These devices are
2. s/Thefirst/The first
3. s/, Guest should/. Guest should
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
virtio-spec.lyx | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Michael S. Tsirkin m...@redhat.com writes:
On Thu, May 30, 2013 at 01:28:26PM +0930, Rusty Russell wrote:
Yet the structure definitions are descriptive, capturing layout, size
and endianness in natural a format readable by any C programmer.
From an API design point of view, here
Anthony Liguori anth...@codemonkey.ws writes:
Michael S. Tsirkin m...@redhat.com writes:
On Thu, May 30, 2013 at 08:40:47AM -0500, Anthony Liguori wrote:
Stefan Hajnoczi stefa...@gmail.com writes:
On Thu, May 30, 2013 at 7:23 AM, Rusty Russell ru...@rustcorp.com.au
wrote:
Anthony
Stefan Hajnoczi stefa...@gmail.com writes:
On Thu, May 30, 2013 at 7:23 AM, Rusty Russell ru...@rustcorp.com.au wrote:
On the receive side, what can we do better than readv? If we need to
return to userspace to tell the guest that we've got a new packet, we
don't win on latency. We might
Anthony Liguori anth...@codemonkey.ws writes:
Rusty Russell ru...@rustcorp.com.au writes:
On Fri, May 24, 2013 at 08:47:58AM -0500, Anthony Liguori wrote:
FWIW, I think what's more interesting is using vhost-net as a networking
backend with virtio-net in QEMU being what's guest facing
the device originally asked for.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
diff --git a/drivers/virtio/virtio_pci-common.h
b/drivers/virtio/virtio_pci-common.h
index ba1bf81..0e3143b 100644
--- a/drivers/virtio/virtio_pci-common.h
+++ b/drivers/virtio/virtio_pci-common.h
@@ -82,6 +82,9
Jens Axboe ax...@kernel.dk writes:
On Wed, Feb 27 2013, Rusty Russell wrote:
Aurelien Jarno aurel...@aurel32.net writes:
Hi,
I have noticed that virtio-rng only returns zero for kernels = 2.6.33
built with CONFIG_HW_RANDOM=m. This is a bit much too predictable for a
random generator
Anthony Liguori aligu...@us.ibm.com writes:
Rusty Russell ru...@rustcorp.com.au writes:
Anthony Liguori aligu...@us.ibm.com writes:
Michael S. Tsirkin m...@redhat.com writes:
+case offsetof(struct virtio_pci_common_cfg, device_feature_select):
+return proxy-device_feature_select
Michael S. Tsirkin m...@redhat.com writes:
On Fri, May 24, 2013 at 08:47:58AM -0500, Anthony Liguori wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Fri, May 24, 2013 at 05:41:11PM +0800, Jason Wang wrote:
On 05/23/2013 04:50 PM, Michael S. Tsirkin wrote:
Hey guys,
I've updated
Anthony Liguori aligu...@us.ibm.com writes:
Michael S. Tsirkin m...@redhat.com writes:
+case offsetof(struct virtio_pci_common_cfg, device_feature_select):
+return proxy-device_feature_select;
Oh dear no... Please use defines like the rest of QEMU.
It is pretty ugly.
Yet the
Paolo Bonzini pbonz...@redhat.com writes:
Il 28/05/2013 19:32, Michael S. Tsirkin ha scritto:
+
+switch (addr) {
+case offsetof(struct virtio_pci_common_cfg,
device_feature_select):
+return proxy-device_feature_select;
Oh dear no... Please use defines like
Michael S. Tsirkin m...@redhat.com writes:
Fix issues observed with the new layout code, seen
when implementing device in qemu:
- use of uXX in uapi header
- incorrect readonly tag on one field
- unconditional warning breaks builds with -Werr
Signed-off-by: Michael S.
Jason Wang jasow...@redhat.com writes:
On 05/22/2013 05:59 PM, Zang Hongyong wrote:
On 2013/5/20 15:43, Michael S. Tsirkin wrote:
On Mon, May 20, 2013 at 02:11:19AM +, Qinchuanyu wrote:
Yes, I don't think we want to create threads even more aggressively
in all cases. I'm worried about
Michael S. Tsirkin m...@redhat.com writes:
Macro VIRTIO_PCI_CONFIG assumes that userspace actually has a structure
with a field named msix_enabled. Add VIRTIO_PCI_CONFIG_OFF that gets
the msix_enabled by value instead, to make it useful for userspace. We
still keep VIRTIO_PCI_CONFIG around
David Howells dhowe...@redhat.com writes:
Rusty Russell ru...@rustcorp.com.au wrote:
Macro still isn't usable, because userspace can't know whether it's the
new or old.
We need to either remove it from UAPI, or rename it to
VIRTIO_PCI_CONFIG_OFF.
Surely, if userspace is using
Michael S. Tsirkin m...@redhat.com writes:
macro VIRTIO_PCI_CONFIG except in the unlikely event userspace
actually has a structure with a field named msix_enabled.
Get the msix_enabled by value instead, to make it useful
for userspace.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Macro
Joe Perches j...@perches.com writes:
On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote:
[]
Other users are using memcpy_fromiovec and friends outside net. It seems
a good idea to put
Michael S. Tsirkin m...@redhat.com writes:
uapi should use __u32 not u32.
Fix a macro in virtio_console.h which uses u32.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Ouch. Added CC:stable, and put into fixes. Mainly because it's
embarrassing :)
Cheers,
Rusty.
--
To unsubscribe from
Nicholas A. Bellinger n...@linux-iscsi.org writes:
On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure.
From Randy Dunlap:
'''
on x86_64
Asias He as...@redhat.com writes:
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure.
From Randy Dunlap:
'''
on x86_64:
ERROR
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure.
From Randy Dunlap:
'''
on x86_64:
ERROR: memcpy_fromiovec [drivers/vhost/vhost_scsi.ko] undefined!
It needs to depend on NET since net/core/
Michael S. Tsirkin m...@redhat.com writes:
On Tue, May 07, 2013 at 02:13:44PM +0930, Rusty Russell wrote:
AFAICT we should always do zero copy.
It seems not to be a win for small packets.
I speculate the issue is that ring space isn't released as promptly.
Further, we can't do it safely
Michael S. Tsirkin m...@redhat.com writes:
On Mon, May 06, 2013 at 03:41:36PM +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
Asias He (3):
vhost: Remove vhost_enable_zcopy in vhost.h
vhost: Move VHOST_NET_FEATURES to net.c
vhost: Make vhost a separate module
I
Asias He as...@redhat.com writes:
Asias He (3):
vhost: Remove vhost_enable_zcopy in vhost.h
vhost: Move VHOST_NET_FEATURES to net.c
vhost: Make vhost a separate module
I like these cleanups, MST pleasee apply.
I have some other cleanups which are on hold for the moment pending
MST's
Laszlo Ersek ler...@redhat.com writes:
On 04/23/13 06:05, Rusty Russell wrote:
Laszlo Ersek ler...@redhat.com writes:
Hi,
(I'm not subscribed to either list,)
using the word descriptor is misleading in the following sections:
Yes, I like the use of 'descriptor chains
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Apr 24, 2013 at 09:51:57AM +0300, Pekka Enberg wrote:
Hi,
On 04/23/2013 12:35 PM, Eric Northup wrote:
Do you care about guests with drivers that don't negotiate
VIRTIO_NET_F_MRG_RXBUF?
On Wed, Apr 24, 2013 at 5:51 AM, Sasha Levin
Sasha Levin sasha.le...@oracle.com writes:
Due to MQ support we may allocate a whole bunch of rx queues but
never use them. With this patch we'll safe the space used by
the receive buffers until they are actually in use:
Thanks, applied!
Cheers,
Rusty.
sh-4.2# free -h
total
Sasha Levin sasha.le...@oracle.com writes:
Due to MQ support we may allocate a whole bunch of rx queues but
never use them. With this patch we'll safe the space used by
the receive buffers until they are actually in use:
Idea is good, implementation needs a tiny tweak:
@@ -912,8 +913,13 @@
Asias He as...@redhat.com writes:
On Mon, Apr 22, 2013 at 04:17:04PM +0300, Michael S. Tsirkin wrote:
+ evt = kzalloc(sizeof(*evt), GFP_KERNEL);
I think kzalloc not needed here, you init all fields.
Not really! evt-event.lun[4-7] is not initialized. It
Laszlo Ersek ler...@redhat.com writes:
Hi,
(I'm not subscribed to either list,)
using the word descriptor is misleading in the following sections:
Yes, I like the use of 'descriptor chains'. This is a definite
improvement.
Here's the diff I ended up with (massaged to minimize it).
Thanks!
Sasha Levin sasha.le...@oracle.com writes:
Add basic documentation for virtio-9p. I can expand more on device operation,
but I don't think there's anything significant enough for the spec to be
mentioned there. Please let me know if I'm wrong.
Signed-off-by: Sasha Levin sasha.le...@oracle.com
Michael S. Tsirkin m...@redhat.com writes:
On Sun, Apr 14, 2013 at 11:59:42AM -0400, Sasha Levin wrote:
On 04/14/2013 11:53 AM, Michael S. Tsirkin wrote:
Initializing them only when they're actually needed will do the trick
here.
Not initializing, adding the buffers. In the current
Sasha Levin sasha.le...@oracle.com writes:
On 04/11/2013 12:36 PM, Will Deacon wrote:
Hello folks,
Here's the latest round of ARM fixes and updates for kvmtool. Most of
this is confined to the arm/ subdirectory, with the exception of a fix
to the virtio-mmio vq definitions due to the
Asias He as...@redhat.com writes:
On Sat, Apr 06, 2013 at 09:40:13AM +0100, James Bottomley wrote:
Well, I haven't had time to look at anything other than the patch I
commented on. I'm happy with your fix, so you can add my acked by to
that one. Since it's going through the virtio tree,
Michael S. Tsirkin m...@redhat.com writes:
Rusty's currently doing some reorgs of -net let's delay
cleanups there to avoid stepping on each other's toys.
Let's focus on scsi here.
E.g. any chance framing assumptions can be fixed in 3.10?
I am waiting for your removal of the dma-compelete
1 - 100 of 640 matches
Mail list logo
