Re: [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Stephan Bärwolf
On 02/01/12 11:27, Avi Kivity wrote: +static bool vendor_intel(struct x86_emulate_ctxt *ctxt) +{ + u32 eax, ebx, ecx, edx; Just to be clean: Shouldn't eax and ecx be initialized to zero? regards Stephan + + return ctxt-ops-get_cpuid(ctxt, eax, ebx, ecx, edx) + ebx

Re: [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests

2012-02-01 Thread Stephan Bärwolf
On 02/01/12 11:50, Avi Kivity wrote: On 02/01/2012 12:45 PM, Stephan Bärwolf wrote: On 02/01/12 11:27, Avi Kivity wrote: +static bool vendor_intel(struct x86_emulate_ctxt *ctxt) +{ + u32 eax, ebx, ecx, edx; Just to be clean: Shouldn't eax and ecx be initialized to zero? Either

Re: [PATCH 0/2] KVM guest-kernel panics double fault

2012-01-16 Thread Stephan Bärwolf
Okay, thx to hear a second opinion. Then everything is ok, have a nice day. regards Stephan On 01/16/12 10:58, Marcelo Tosatti wrote: On Sun, Jan 15, 2012 at 08:44:50PM +0100, Stephan Bärwolf wrote: Thank you for applying this, Marcelo. I fear we (or me after I agreed) did some mistake

Re: [PATCH 0/2] KVM guest-kernel panics double fault

2012-01-15 Thread Stephan Bärwolf
://git.kernel.org/?p=virt/kvm/kvm.git;a=commit;h=0769c5de24621141c953fbe1f943582d37cb4244 http://git.kernel.org/?p=virt/kvm/kvm.git;a=commit;h=e28ba7bb020f07193bc000453c8775e9d2c0dda7 -- Dipl.-Inf. Stephan Bärwolf Ilmenau University of Technology, Integrated Communication Systems Group Phone

[PATCH 0/2] KVM guest-kernel panics double fault

2012-01-12 Thread Stephan Bärwolf
and not like Intel. (which would have to #UD ...) While the crash is bad (esp. for admins using VMs to isolate), because every unpriv. user can execute 0f05 - the misbehaviour with GenuineIntel-cpuid is just a blemish. Best regards, Stephan Bärwolf Stephan Baerwolf (2): KVM: extend struct

[PATCH 1/2] KVM: extend struct x86_emulate_ops with get_cpuid

2012-01-12 Thread Stephan Bärwolf
From a8f796f81979094b81cb74535632786ce1ccf9bb Mon Sep 17 00:00:00 2001 From: Stephan Baerwolf stephan.baerw...@tu-ilmenau.de Date: Sun, 8 Jan 2012 23:25:59 + Subject: [PATCH 1/2] KVM: extend struct x86_emulate_ops with get_cpuid In order to be able to proceed checks on CPU-specific properties

[PATCH 2/2] KVM: fix missing illegal instruction-trap in protected modes

2012-01-12 Thread Stephan Bärwolf
From d62ca9897e9970d777aec1d399318b0df44489bd Mon Sep 17 00:00:00 2001 From: Stephan Baerwolf stephan.baerw...@tu-ilmenau.de Date: Sun, 8 Jan 2012 02:03:47 + Subject: [PATCH 2/2] KVM: fix missing illegal instruction-trap in protected modes On hosts without this patch, 32bit guests will crash

Re: [PATCH 2/2] KVM: fix missing illegal instruction-trap in protected modes

2012-01-11 Thread Stephan Bärwolf
On 01/11/12 20:09, Marcelo Tosatti wrote: On Tue, Jan 10, 2012 at 03:26:49PM +0100, Stephan Bärwolf wrote: From 2168285ffb30716f30e129c3ce98ce42d19c4d4e Mon Sep 17 00:00:00 2001 From: Stephan Baerwolf stephan.baerw...@tu-ilmenau.de Date: Sun, 8 Jan 2012 02:03:47 + Subject: [PATCH 2/2] KVM

Re: [PATCH 2/2] KVM: fix missing illegal instruction-trap in protected modes

2012-01-11 Thread Stephan Bärwolf
On 01/11/12 22:21, Marcelo Tosatti wrote: On Wed, Jan 11, 2012 at 09:01:10PM +0100, Stephan Bärwolf wrote: On 01/11/12 20:09, Marcelo Tosatti wrote: On Tue, Jan 10, 2012 at 03:26:49PM +0100, Stephan Bärwolf wrote: From 2168285ffb30716f30e129c3ce98ce42d19c4d4e Mon Sep 17 00:00:00 2001 From

[PATCH 0/2] KVM guest-kernel panics double fault

2012-01-10 Thread Stephan Bärwolf
and not like Intel. (which would have to #UD ...) While the crash is bad (esp. for admins using VMs to isolate), because every unpriv. user can execute 0f05 - the misbehaviour with GenuineIntel-cpuid is just a blemish. Best regards, Stephan Bärwolf Stephan Baerwolf (2): KVM: extend struct

[PATCH 1/2] KVM: extend struct x86_emulate_ops with get_cpuid

2012-01-10 Thread Stephan Bärwolf
From c603d51a02539c89dec05fd54de336b282b1cc12 Mon Sep 17 00:00:00 2001 From: Stephan Baerwolf stephan.baerw...@tu-ilmenau.de Date: Sun, 8 Jan 2012 23:25:59 + Subject: [PATCH 1/2] KVM: extend struct x86_emulate_ops with get_cpuid In order to be able to proceed checks on CPU-specific properties

[PATCH 2/2] KVM: fix missing illegal instruction-trap in protected modes

2012-01-10 Thread Stephan Bärwolf
From 2168285ffb30716f30e129c3ce98ce42d19c4d4e Mon Sep 17 00:00:00 2001 From: Stephan Baerwolf stephan.baerw...@tu-ilmenau.de Date: Sun, 8 Jan 2012 02:03:47 + Subject: [PATCH 2/2] KVM: fix missing illegal instruction-trap in protected modes On hosts without this patch, 32bit guests will crash