[BUG] virtio-pci queue allocation not page-aligned

2008-12-02 Thread Hollis Blanchard
I just spent a number of hours tracking this one down, and I'm not too thrilled about it. vp_find_vq() does the memory allocation for virtio PCI rings, and it uses kzalloc() to do it. This is bad because the ring memory *must* be page-aligned. According to Anthony, at the time this code was

Re: [BUG] virtio-pci queue allocation not page-aligned

2008-12-02 Thread Anthony Liguori
Hollis Blanchard wrote: Finally, we could use the interface intended for exactly this purpose: the page allocator. If there's some problem with high memory, don't allocate it with GFP_HIGHMEM. Can you work up a patch to do this? Regards, Anthony Liguori -- To unsubscribe from this list:

Re: [BUG] virtio-pci queue allocation not page-aligned

2008-12-02 Thread Rusty Russell
On Wednesday 03 December 2008 05:38:21 Hollis Blanchard wrote: I just spent a number of hours tracking this one down, and I'm not too thrilled about it. vp_find_vq() does the memory allocation for virtio PCI rings, and it uses kzalloc() to do it. This is bad because the ring memory *must* be

Re: [BUG] virtio-pci queue allocation not page-aligned

2008-12-02 Thread Hollis Blanchard
On Wed, 2008-12-03 at 08:35 +1030, Rusty Russell wrote: On Wednesday 03 December 2008 05:38:21 Hollis Blanchard wrote: I just spent a number of hours tracking this one down, and I'm not too thrilled about it. vp_find_vq() does the memory allocation for virtio PCI rings, and it uses