Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-22 Thread Avi Kivity
On 10/15/2009 04:58 PM, Glauber Costa wrote: The motivation for relative adjustment is when you have a jitter resistant place to gather timing information (like the kernel, which can disable interrupts and preemption), then pass it on to kvm without losing information due to scheduling. For

Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-15 Thread Glauber Costa
On Thu, Oct 15, 2009 at 09:46:52AM +0900, Avi Kivity wrote: On 10/13/2009 09:46 PM, Glauber Costa wrote: On Tue, Oct 13, 2009 at 03:31:08PM +0300, Avi Kivity wrote: On 10/13/2009 03:28 PM, Glauber Costa wrote: Do we want an absolute or relative adjustment?

Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-14 Thread Avi Kivity
On 10/13/2009 09:46 PM, Glauber Costa wrote: On Tue, Oct 13, 2009 at 03:31:08PM +0300, Avi Kivity wrote: On 10/13/2009 03:28 PM, Glauber Costa wrote: Do we want an absolute or relative adjustment? What exactly do you mean? Absolute adjustment: clock = t

Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-13 Thread Glauber Costa
On Mon, Oct 12, 2009 at 10:53:26AM +0200, Avi Kivity wrote: On 10/06/2009 07:24 PM, Glauber Costa wrote: When we migrate a kvm guest that uses pvclock between two hosts, we may suffer a large skew. This is because there can be significant differences between the monotonic clock of the hosts

Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-13 Thread Avi Kivity
On 10/13/2009 03:28 PM, Glauber Costa wrote: Do we want an absolute or relative adjustment? What exactly do you mean? Absolute adjustment: clock = t Relative adjustment: clock += t -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to

Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-13 Thread Glauber Costa
On Tue, Oct 13, 2009 at 03:31:08PM +0300, Avi Kivity wrote: On 10/13/2009 03:28 PM, Glauber Costa wrote: Do we want an absolute or relative adjustment? What exactly do you mean? Absolute adjustment: clock = t Relative adjustment: clock += t The delta is absolute, but the

Re: [PATCH] allow userspace to adjust kvmclock offset

2009-10-12 Thread Avi Kivity
On 10/06/2009 07:24 PM, Glauber Costa wrote: When we migrate a kvm guest that uses pvclock between two hosts, we may suffer a large skew. This is because there can be significant differences between the monotonic clock of the hosts involved. When a new host with a much larger monotonic time

[PATCH] allow userspace to adjust kvmclock offset

2009-10-06 Thread Glauber Costa
When we migrate a kvm guest that uses pvclock between two hosts, we may suffer a large skew. This is because there can be significant differences between the monotonic clock of the hosts involved. When a new host with a much larger monotonic time starts running the guest, the view of time will be