Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-25 Thread Avi Kivity
On 04/25/2010 04:27 PM, Stefan Hajnoczi wrote: From: Stefan Hajnoczi The MALLOC_TRACE output didn't look useful when I tried it either. Instead I used the following to find origin of the leak. Still very basic but works better with qemu_malloc() and friends. This is just a hack but I wanted t

Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-25 Thread Stefan Hajnoczi
From: Stefan Hajnoczi The MALLOC_TRACE output didn't look useful when I tried it either. Instead I used the following to find origin of the leak. Still very basic but works better with qemu_malloc() and friends. This is just a hack but I wanted to share it in case someone finds it useful in th

Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-25 Thread Avi Kivity
On 04/21/2010 11:13 PM, Leszek Urbanski wrote: <20100421200358.gh24...@us.ibm.com>; from Ryan Harper on Wed, Apr 21, 2010 at 15:03:58 -0500 Debugging with mtrace() also pointed to the iovec code as the culprit. I've not used mtrace before, could you dump your command invocation fo

Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-21 Thread Leszek Urbanski
<20100421200358.gh24...@us.ibm.com>; from Ryan Harper on Wed, Apr 21, 2010 at 15:03:58 -0500 > > Debugging with mtrace() also pointed to the iovec code as the culprit. > > I've not used mtrace before, could you dump your command invocation for > the list? I know other's would be glad to see an

Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-21 Thread Ryan Harper
* Leszek Urbanski [2010-04-21 14:59]: > <20100421183536.gg24...@us.ibm.com>; from Ryan Harper on Wed, Apr 21, 2010 at > 13:35:36 -0500 > > * Stefan Hajnoczi [2010-04-21 13:27]: > > > A new iovec array is allocated when creating a merged write request. > > > This patch ensures that the iovec arra

Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-21 Thread Leszek Urbanski
<20100421183536.gg24...@us.ibm.com>; from Ryan Harper on Wed, Apr 21, 2010 at 13:35:36 -0500 > * Stefan Hajnoczi [2010-04-21 13:27]: > > A new iovec array is allocated when creating a merged write request. > > This patch ensures that the iovec array is deleted in addition to its > > qiov owner. >

Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-21 Thread Brian Jackson
On Wednesday 21 April 2010 13:35:36 Ryan Harper wrote: > * Stefan Hajnoczi [2010-04-21 13:27]: > > A new iovec array is allocated when creating a merged write request. > > This patch ensures that the iovec array is deleted in addition to its > > qiov owner. > > Nice catch. Send this to qemu-deve

Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-21 Thread Ryan Harper
* Stefan Hajnoczi [2010-04-21 13:27]: > A new iovec array is allocated when creating a merged write request. > This patch ensures that the iovec array is deleted in addition to its > qiov owner. Nice catch. Send this to qemu-devel and Avi and merge into qemu-kvm once it's commited there. > > S

[PATCH] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-21 Thread Stefan Hajnoczi
A new iovec array is allocated when creating a merged write request. This patch ensures that the iovec array is deleted in addition to its qiov owner. Signed-off-by: Stefan Hajnoczi --- block.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index e89