Re: [PATCH] kvm: x86: vmx: NULL out hwapic_isr_update() in case of !enable_apicv

2014-12-23 Thread Paolo Bonzini
On 23/12/2014 03:05, Tiejun Chen wrote: In most cases calling hwapic_isr_update(), we always check if kvm_apic_vid_enabled() == 1, but actually, kvm_apic_vid_enabled() - kvm_x86_ops-vm_has_apicv() - vmx_vm_has_apicv() or '0' in svm case - return enable_apicv

[PATCH] kvm: x86: vmx: NULL out hwapic_isr_update() in case of !enable_apicv

2014-12-22 Thread Tiejun Chen
In most cases calling hwapic_isr_update(), we always check if kvm_apic_vid_enabled() == 1, but actually, kvm_apic_vid_enabled() - kvm_x86_ops-vm_has_apicv() - vmx_vm_has_apicv() or '0' in svm case - return enable_apicv irqchip_in_kernel(kvm) So its a little cost to recall