Re: [PATCH] virtio-blk: put request that was created to retrieve the device id

2010-10-08 Thread Rusty Russell
On Fri, 10 Sep 2010 06:30:42 am Mike Snitzer wrote: On Thu, Sep 09 2010 at 4:30pm -0400, Ryan Harper ry...@us.ibm.com wrote: * Mike Snitzer snit...@redhat.com [2010-09-09 15:15]: On Thu, Sep 09 2010 at 3:43pm -0400, Mike Snitzer snit...@redhat.com wrote: # while true ; do cat

Re: [PATCH] virtio-blk: put request that was created to retrieve the device id

2010-09-21 Thread Christoph Hellwig
On Fri, Sep 17, 2010 at 09:58:48AM -0500, Ryan Harper wrote: Since __bio_map_kern() sets up bio-bi_end_io = bio_map_kern_endio (which does a bio_put(bio)) doesn't that ensure we don't leak? Indeed, that should take care of it. -- To unsubscribe from this list: send the line unsubscribe kvm in

Re: [PATCH] virtio-blk: put request that was created to retrieve the device id

2010-09-17 Thread Ryan Harper
* Christoph Hellwig h...@infradead.org [2010-09-09 16:18]: On Thu, Sep 09, 2010 at 05:00:42PM -0400, Mike Snitzer wrote: diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 1260628..831e75c 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c

[PATCH] virtio-blk: put request that was created to retrieve the device id

2010-09-09 Thread Mike Snitzer
On Thu, Sep 09 2010 at 4:30pm -0400, Ryan Harper ry...@us.ibm.com wrote: * Mike Snitzer snit...@redhat.com [2010-09-09 15:15]: On Thu, Sep 09 2010 at 3:43pm -0400, Mike Snitzer snit...@redhat.com wrote: Interestingly, just this loop: while true ; do cat /sys/block/vda/serial

Re: [PATCH] virtio-blk: put request that was created to retrieve the device id

2010-09-09 Thread Christoph Hellwig
On Thu, Sep 09, 2010 at 05:00:42PM -0400, Mike Snitzer wrote: diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 1260628..831e75c 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -199,6 +199,7 @@ static int virtblk_get_id(struct gendisk