Re: [PATCH] virtio-net: fix data corruption with OOM

2009-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2009 at 12:11:51PM +1030, Rusty Russell wrote: On Mon, 26 Oct 2009 03:33:40 am Michael S. Tsirkin wrote: virtio net used to unlink skbs from send queues on error, but ever since 48925e372f04f5e35fec6269127c62b2c71ab794 we do not do this. This causes guest data corruption and

Re: [PATCH] virtio-net: fix data corruption with OOM

2009-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2009 at 12:11:51PM +1030, Rusty Russell wrote: On Mon, 26 Oct 2009 03:33:40 am Michael S. Tsirkin wrote: virtio net used to unlink skbs from send queues on error, but ever since 48925e372f04f5e35fec6269127c62b2c71ab794 we do not do this. This causes guest data corruption and

Re: [PATCH] virtio-net: fix data corruption with OOM

2009-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2009 at 12:11:51PM +1030, Rusty Russell wrote: On Mon, 26 Oct 2009 03:33:40 am Michael S. Tsirkin wrote: virtio net used to unlink skbs from send queues on error, but ever since 48925e372f04f5e35fec6269127c62b2c71ab794 we do not do this. This causes guest data corruption and

Re: [PATCH] virtio-net: fix data corruption with OOM

2009-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2009 at 08:42:43PM +0200, Michael S. Tsirkin wrote: On Mon, Oct 26, 2009 at 12:11:51PM +1030, Rusty Russell wrote: On Mon, 26 Oct 2009 03:33:40 am Michael S. Tsirkin wrote: virtio net used to unlink skbs from send queues on error, but ever since

Re: [PATCH] virtio-net: fix data corruption with OOM

2009-10-26 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 26 Oct 2009 11:07:13 +0200 Another, and hopefully the last, note, is that git-am can only handle Subject/From lines at the beginning of the message. So git style of the mail would be ... I think it's weird. We could invent some kind of

[PATCH] virtio-net: fix data corruption with OOM

2009-10-25 Thread Michael S. Tsirkin
virtio net used to unlink skbs from send queues on error, but ever since 48925e372f04f5e35fec6269127c62b2c71ab794 we do not do this. This causes guest data corruption and crashes with vhost since net core can requeue the skb or free it without it being taken off the list. This patch fixes this by

Re: [PATCH] virtio-net: fix data corruption with OOM

2009-10-25 Thread Rusty Russell
On Mon, 26 Oct 2009 03:33:40 am Michael S. Tsirkin wrote: virtio net used to unlink skbs from send queues on error, but ever since 48925e372f04f5e35fec6269127c62b2c71ab794 we do not do this. This causes guest data corruption and crashes with vhost since net core can requeue the skb or free it