Re: [PATCH] virtio_net: add link status handling

2009-01-09 Thread Mark McLoughlin
Hi Dave, On Wed, 2009-01-07 at 18:18 +, Mark McLoughlin wrote: On Fri, 2008-12-12 at 18:34 +1030, Rusty Russell wrote: Not quite what I was after. I've taken the original patch, added the masking change. I'll test here and feed to DaveM. This never got pushed to davem, did it? What

Re: [PATCH] virtio_net: add link status handling

2009-01-07 Thread Mark McLoughlin
Hi Rusty, On Fri, 2008-12-12 at 18:34 +1030, Rusty Russell wrote: On Thursday 11 December 2008 05:04:44 Mark McLoughlin wrote: On Tue, 2008-12-09 at 21:11 -0600, Anthony Liguori wrote: Rusty Russell wrote: On Wednesday 10 December 2008 08:02:14 Anthony Liguori wrote: It would be

Re: [PATCH] virtio_net: add link status handling

2008-12-12 Thread Rusty Russell
On Thursday 11 December 2008 05:04:44 Mark McLoughlin wrote: On Tue, 2008-12-09 at 21:11 -0600, Anthony Liguori wrote: Rusty Russell wrote: On Wednesday 10 December 2008 08:02:14 Anthony Liguori wrote: It would be nice if the virtio-net card wrote some acknowledgement that it has

[PATCH] virtio_net: add link status handling

2008-12-09 Thread Mark McLoughlin
Allow the host to inform us that the link is down by adding a VIRTIO_NET_F_STATUS which indicates that device status is available in virtio_net config. This is currently useful for simulating link down conditions (e.g. using proposed qemu 'set_link' monitor command) but would also be needed if we

Re: [PATCH] virtio_net: add link status handling

2008-12-09 Thread Rusty Russell
On Wednesday 10 December 2008 08:02:14 Anthony Liguori wrote: Mark McLoughlin wrote: Allow the host to inform us that the link is down by adding a VIRTIO_NET_F_STATUS which indicates that device status is available in virtio_net config. This is currently useful for simulating link down

Re: [PATCH] virtio_net: add link status handling

2008-12-09 Thread Rusty Russell
On Tuesday 09 December 2008 20:49:33 Mark McLoughlin wrote: Allow the host to inform us that the link is down by adding a VIRTIO_NET_F_STATUS which indicates that device status is available in virtio_net config. This has been a TODO for a while, thanks! + if (vi-status == v) +

Re: [PATCH] virtio_net: add link status handling

2008-12-09 Thread Anthony Liguori
Rusty Russell wrote: On Wednesday 10 December 2008 08:02:14 Anthony Liguori wrote: Mark McLoughlin wrote: Allow the host to inform us that the link is down by adding a VIRTIO_NET_F_STATUS which indicates that device status is available in virtio_net config. This is currently useful