Re: [PATCH] vnc: threaded server depends on io-thread

2011-03-09 Thread Peter Lieven
Am 09.03.2011 um 11:41 schrieb Corentin Chary: The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. The IO-Thread provides appropriate locking primitives to avoid that. This patch makes CONFIG_VNC_THREAD

[PATCH] vnc: threaded server depends on io-thread

2011-03-09 Thread Corentin Chary
The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. The IO-Thread provides appropriate locking primitives to avoid that. This patch makes CONFIG_VNC_THREAD depends on CONFIG_IO_THREAD, and add lock and unlock calls

Re: [PATCH] vnc: threaded server depends on io-thread

2011-03-09 Thread Corentin Chary
The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. The IO-Thread provides appropriate locking primitives to avoid that. This patch makes CONFIG_VNC_THREAD depends on CONFIG_IO_THREAD, and add lock and unlock

Re: [PATCH] vnc: threaded server depends on io-thread

2011-03-09 Thread Stefan Hajnoczi
On Wed, Mar 9, 2011 at 10:57 AM, Corentin Chary corentin.ch...@gmail.com wrote: The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. The IO-Thread provides appropriate locking primitives to avoid that. This patch

Re: [PATCH] vnc: threaded server depends on io-thread

2011-03-09 Thread Jan Kiszka
On 2011-03-09 12:05, Stefan Hajnoczi wrote: On Wed, Mar 9, 2011 at 10:57 AM, Corentin Chary corentin.ch...@gmail.com wrote: The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. The IO-Thread provides appropriate

Re: [PATCH] vnc: threaded server depends on io-thread

2011-03-09 Thread Peter Lieven
Am 09.03.2011 um 12:25 schrieb Jan Kiszka: On 2011-03-09 12:05, Stefan Hajnoczi wrote: On Wed, Mar 9, 2011 at 10:57 AM, Corentin Chary corentin.ch...@gmail.com wrote: The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race

Re: [PATCH] vnc: threaded server depends on io-thread

2011-03-09 Thread Jan Kiszka
On 2011-03-09 12:32, Peter Lieven wrote: Am 09.03.2011 um 12:25 schrieb Jan Kiszka: On 2011-03-09 12:05, Stefan Hajnoczi wrote: On Wed, Mar 9, 2011 at 10:57 AM, Corentin Chary corentin.ch...@gmail.com wrote: The threaded VNC servers messed up with QEMU fd handlers without any kind of

Re: [PATCH] vnc: threaded server depends on io-thread

2011-03-09 Thread Jan Kiszka
On 2011-03-09 11:41, Corentin Chary wrote: The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. The IO-Thread provides appropriate locking primitives to avoid that. This patch makes CONFIG_VNC_THREAD depends on

Re: [PATCH] vnc: threaded server depends on io-thread

2011-03-09 Thread Peter Lieven
Am 09.03.2011 um 12:42 schrieb Jan Kiszka: On 2011-03-09 11:41, Corentin Chary wrote: The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. The IO-Thread provides appropriate locking primitives to avoid that.