Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-04-30 Thread Luis R. Rodriguez
On Tue, Apr 22, 2014 at 12:43 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Tue, Mar 18, 2014 at 02:22:43PM -0700, Luis R. Rodriguez wrote: On Tue, Mar 18, 2014 at 01:46:49PM -0700, Cong Wang wrote: On Fri, Mar 14, 2014 at 6:39 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Thu, Mar 13,

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-04-30 Thread Vlad Yasevich
On 04/22/2014 03:43 PM, Luis R. Rodriguez wrote: On Tue, Mar 18, 2014 at 02:22:43PM -0700, Luis R. Rodriguez wrote: On Tue, Mar 18, 2014 at 01:46:49PM -0700, Cong Wang wrote: On Fri, Mar 14, 2014 at 6:39 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Thu, Mar 13, 2014 at 11:26:25AM -0700,

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-04-30 Thread Luis R. Rodriguez
On Wed, Apr 30, 2014 at 04:04:34PM -0400, Vlad Yasevich wrote: On 04/22/2014 03:43 PM, Luis R. Rodriguez wrote: diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 54d207d..dcd9378 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -315,6 +315,8 @@ netdev_features_t

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-04-30 Thread Vlad Yasevich
On 04/30/2014 06:59 PM, Luis R. Rodriguez wrote: On Wed, Apr 30, 2014 at 04:04:34PM -0400, Vlad Yasevich wrote: On 04/22/2014 03:43 PM, Luis R. Rodriguez wrote: diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 54d207d..dcd9378 100644 --- a/net/bridge/br_if.c +++

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-04-22 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 02:22:43PM -0700, Luis R. Rodriguez wrote: On Tue, Mar 18, 2014 at 01:46:49PM -0700, Cong Wang wrote: On Fri, Mar 14, 2014 at 6:39 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Thu, Mar 13, 2014 at 11:26:25AM -0700, Cong Wang wrote: On Wed, Mar 12, 2014 at 8:15

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-03-18 Thread Cong Wang
On Fri, Mar 14, 2014 at 6:39 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Thu, Mar 13, 2014 at 11:26:25AM -0700, Cong Wang wrote: On Wed, Mar 12, 2014 at 8:15 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: spin_unlock_bh(p-br-lock); +

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-03-18 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 01:46:49PM -0700, Cong Wang wrote: On Fri, Mar 14, 2014 at 6:39 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Thu, Mar 13, 2014 at 11:26:25AM -0700, Cong Wang wrote: On Wed, Mar 12, 2014 at 8:15 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote:

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-03-14 Thread Luis R. Rodriguez
On Thu, Mar 13, 2014 at 11:26:25AM -0700, Cong Wang wrote: On Wed, Mar 12, 2014 at 8:15 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: spin_lock_bh(p-br-lock); err = br_setport(p, tb); + changed =

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-03-13 Thread Cong Wang
On Wed, Mar 12, 2014 at 8:15 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: spin_lock_bh(p-br-lock); err = br_setport(p, tb); + changed = br_stp_recalculate_bridge_id(p-br); Looks like you only want to check if the mac

[PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-03-12 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com If netlink is used to tune a port we currently don't trigger a new recalculation of the bridge id, ensure that happens just as if we're adding a new net_device onto the bridge. Cc: Stephen Hemminger step...@networkplumber.org Cc: