Re: [PATCH 3/9] kvm: qemu: Remove virtio_net tx ring-full heuristic

2008-07-25 Thread Mark McLoughlin
On Fri, 2008-07-25 at 02:22 +0300, Dor Laor wrote: Mark McLoughlin wrote: virtio_net tries to guess when it has received a tx notification from the guest whether it indicates that the guest has no more room in the tx ring and it should immediately flush the queued buffers. ... -if

Re: [PATCH 3/9] kvm: qemu: Remove virtio_net tx ring-full heuristic

2008-07-25 Thread Mark McLoughlin
On Fri, 2008-07-25 at 10:30 +1000, Rusty Russell wrote: On Friday 25 July 2008 09:22:53 Dor Laor wrote: Mark McLoughlin wrote: vq-vring.used-flags = ~VRING_USED_F_NO_NOTIFY; qemu_del_timer(n-tx_timer); n-tx_timer_active = 0; As stated by newer messages, we should handle the

[PATCH 3/9] kvm: qemu: Remove virtio_net tx ring-full heuristic

2008-07-24 Thread Mark McLoughlin
virtio_net tries to guess when it has received a tx notification from the guest whether it indicates that the guest has no more room in the tx ring and it should immediately flush the queued buffers. The heuristic is based on the fact that there are 128 buffer entries in the ring and each packet

Re: [PATCH 3/9] kvm: qemu: Remove virtio_net tx ring-full heuristic

2008-07-24 Thread Dor Laor
Mark McLoughlin wrote: virtio_net tries to guess when it has received a tx notification from the guest whether it indicates that the guest has no more room in the tx ring and it should immediately flush the queued buffers. The heuristic is based on the fact that there are 128 buffer entries in

Re: [PATCH 3/9] kvm: qemu: Remove virtio_net tx ring-full heuristic

2008-07-24 Thread Rusty Russell
On Friday 25 July 2008 09:22:53 Dor Laor wrote: Mark McLoughlin wrote: vq-vring.used-flags = ~VRING_USED_F_NO_NOTIFY; qemu_del_timer(n-tx_timer); n-tx_timer_active = 0; As stated by newer messages, we should handle the first tx notification if the timer wasn't active to