Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-19 Thread Paolo Bonzini
Il 10/06/2013 19:03, Gleb Natapov ha scritto: On Mon, Jun 10, 2013 at 10:43:52PM +0900, Takuya Yoshikawa wrote: On Mon, 10 Jun 2013 16:39:37 +0800 Xiao Guangrong xiaoguangrong.e...@gmail.com wrote: On 06/10/2013 03:56 PM, Gleb Natapov wrote: On Fri, Jun 07, 2013 at 04:51:22PM +0800, Xiao

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-19 Thread Xiao Guangrong
On 06/19/2013 07:08 PM, Paolo Bonzini wrote: Il 10/06/2013 19:03, Gleb Natapov ha scritto: On Mon, Jun 10, 2013 at 10:43:52PM +0900, Takuya Yoshikawa wrote: On Mon, 10 Jun 2013 16:39:37 +0800 Xiao Guangrong xiaoguangrong.e...@gmail.com wrote: On 06/10/2013 03:56 PM, Gleb Natapov wrote: On

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-19 Thread Paolo Bonzini
Il 07/06/2013 10:51, Xiao Guangrong ha scritto: Changelog: V3: All of these changes are from Gleb's review: 1) rename RET_MMIO_PF_EMU to RET_MMIO_PF_EMULATE. 2) smartly adjust kvm generation number in kvm_current_mmio_generatio() to avoid kvm_memslots-generation overflow. V2:

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-18 Thread Paolo Bonzini
Il 07/06/2013 10:51, Xiao Guangrong ha scritto: Changelog: V3: All of these changes are from Gleb's review: 1) rename RET_MMIO_PF_EMU to RET_MMIO_PF_EMULATE. 2) smartly adjust kvm generation number in kvm_current_mmio_generatio() to avoid kvm_memslots-generation overflow. V2:

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-18 Thread Marcelo Tosatti
On Mon, Jun 17, 2013 at 07:59:15PM +0800, Xiao Guangrong wrote: Sorry for the delay reply since i was on vacation. On 06/15/2013 10:22 AM, Takuya Yoshikawa wrote: On Thu, 13 Jun 2013 21:08:21 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, Jun 07, 2013 at 04:51:22PM +0800,

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-18 Thread Xiao Guangrong
On 06/18/2013 10:26 PM, Paolo Bonzini wrote: Il 07/06/2013 10:51, Xiao Guangrong ha scritto: Changelog: V3: All of these changes are from Gleb's review: 1) rename RET_MMIO_PF_EMU to RET_MMIO_PF_EMULATE. 2) smartly adjust kvm generation number in kvm_current_mmio_generatio() to

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-17 Thread Xiao Guangrong
Sorry for the delay reply since i was on vacation. On 06/15/2013 10:22 AM, Takuya Yoshikawa wrote: On Thu, 13 Jun 2013 21:08:21 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, Jun 07, 2013 at 04:51:22PM +0800, Xiao Guangrong wrote: - Where is the generation number increased?

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-14 Thread Takuya Yoshikawa
On Thu, 13 Jun 2013 21:08:21 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, Jun 07, 2013 at 04:51:22PM +0800, Xiao Guangrong wrote: - Where is the generation number increased? Looks like when a new slot is installed in update_memslots() because it's based on slots-generation. This

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-13 Thread Marcelo Tosatti
On Fri, Jun 07, 2013 at 04:51:22PM +0800, Xiao Guangrong wrote: Changelog: V3: All of these changes are from Gleb's review: 1) rename RET_MMIO_PF_EMU to RET_MMIO_PF_EMULATE. 2) smartly adjust kvm generation number in kvm_current_mmio_generatio() to avoid kvm_memslots-generation

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-10 Thread Gleb Natapov
On Fri, Jun 07, 2013 at 04:51:22PM +0800, Xiao Guangrong wrote: Changelog: V3: All of these changes are from Gleb's review: 1) rename RET_MMIO_PF_EMU to RET_MMIO_PF_EMULATE. 2) smartly adjust kvm generation number in kvm_current_mmio_generatio() to avoid kvm_memslots-generation

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-10 Thread Xiao Guangrong
On 06/10/2013 03:56 PM, Gleb Natapov wrote: On Fri, Jun 07, 2013 at 04:51:22PM +0800, Xiao Guangrong wrote: Changelog: V3: All of these changes are from Gleb's review: 1) rename RET_MMIO_PF_EMU to RET_MMIO_PF_EMULATE. 2) smartly adjust kvm generation number in

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-10 Thread Takuya Yoshikawa
On Mon, 10 Jun 2013 16:39:37 +0800 Xiao Guangrong xiaoguangrong.e...@gmail.com wrote: On 06/10/2013 03:56 PM, Gleb Natapov wrote: On Fri, Jun 07, 2013 at 04:51:22PM +0800, Xiao Guangrong wrote: Looks good to me, but doesn't tis obsolete kvm_mmu_zap_mmio_sptes() and sp-mmio_cached, so they

Re: [PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-10 Thread Gleb Natapov
On Mon, Jun 10, 2013 at 10:43:52PM +0900, Takuya Yoshikawa wrote: On Mon, 10 Jun 2013 16:39:37 +0800 Xiao Guangrong xiaoguangrong.e...@gmail.com wrote: On 06/10/2013 03:56 PM, Gleb Natapov wrote: On Fri, Jun 07, 2013 at 04:51:22PM +0800, Xiao Guangrong wrote: Looks good to me, but

[PATCH v3 0/6] KVM: MMU: fast invalidate all mmio sptes

2013-06-07 Thread Xiao Guangrong
Changelog: V3: All of these changes are from Gleb's review: 1) rename RET_MMIO_PF_EMU to RET_MMIO_PF_EMULATE. 2) smartly adjust kvm generation number in kvm_current_mmio_generatio() to avoid kvm_memslots-generation overflow. V2: - rename kvm_mmu_invalid_mmio_spte to