Re: [PATCH v5 12/13] ARM: KVM: Fix guest view of MPIDR

2011-12-13 Thread Avi Kivity
On 12/12/2011 09:43 PM, Christoffer Dall wrote: ok, focus will be on patch readability for next round then. thanks. Great, please try to keep your submarine surfaced for longer periods of time so we can interact better. -- error compiling committee.c: too many arguments to function -- To

Re: [PATCH v5 12/13] ARM: KVM: Fix guest view of MPIDR

2011-12-13 Thread Christoffer Dall
On Tue, Dec 13, 2011 at 4:46 AM, Avi Kivity a...@redhat.com wrote: On 12/12/2011 09:43 PM, Christoffer Dall wrote: ok, focus will be on patch readability for next round then. thanks. Great, please try to keep your submarine surfaced for longer periods of time so we can interact better. we

Re: [PATCH v5 12/13] ARM: KVM: Fix guest view of MPIDR

2011-12-12 Thread Christoffer Dall
On Mon, Dec 12, 2011 at 12:44 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 12/12/11 17:39, Christoffer Dall wrote: On Mon, Dec 12, 2011 at 9:32 AM, Avi Kivity a...@redhat.com wrote: On 12/11/2011 12:25 PM, Christoffer Dall wrote: From: Marc Zyngier marc.zyng...@arm.com A guest may need to

Re: [PATCH v5 12/13] ARM: KVM: Fix guest view of MPIDR

2011-12-12 Thread Avi Kivity
On 12/11/2011 12:25 PM, Christoffer Dall wrote: From: Marc Zyngier marc.zyng...@arm.com A guest may need to know which CPU it has booted on (and Linux does). Now that we can run KVM on a SMP host, QEMU may be running on any s/QEMU/userspace/ CPU. In that case, directly reading MPIDR will

Re: [PATCH v5 12/13] ARM: KVM: Fix guest view of MPIDR

2011-12-12 Thread Christoffer Dall
On Mon, Dec 12, 2011 at 9:32 AM, Avi Kivity a...@redhat.com wrote: On 12/11/2011 12:25 PM, Christoffer Dall wrote: From: Marc Zyngier marc.zyng...@arm.com A guest may need to know which CPU it has booted on (and Linux does). Now that we can run KVM on a SMP host, QEMU may be running on any

Re: [PATCH v5 12/13] ARM: KVM: Fix guest view of MPIDR

2011-12-12 Thread Marc Zyngier
On 12/12/11 17:39, Christoffer Dall wrote: On Mon, Dec 12, 2011 at 9:32 AM, Avi Kivity a...@redhat.com wrote: On 12/11/2011 12:25 PM, Christoffer Dall wrote: From: Marc Zyngier marc.zyng...@arm.com A guest may need to know which CPU it has booted on (and Linux does). Now that we can run KVM

[PATCH v5 12/13] ARM: KVM: Fix guest view of MPIDR

2011-12-11 Thread Christoffer Dall
From: Marc Zyngier marc.zyng...@arm.com A guest may need to know which CPU it has booted on (and Linux does). Now that we can run KVM on a SMP host, QEMU may be running on any CPU. In that case, directly reading MPIDR will give an inconsistent view on the guest CPU number (among other problems).