KVM: x86: better fix for race between nmi injection and enabling nmi window (v2)

2011-04-01 Thread Marcelo Tosatti
From: Gleb Natapov g...@redhat.com Fix race between nmi injection and enabling nmi window in a simpler way. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com v2: document benign race. diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index bfd7763..e6bdc14 100644 --- a/arch/x86/kvm/x86.c

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-31 Thread Avi Kivity
On 03/30/2011 08:47 PM, Gleb Natapov wrote: On Wed, Mar 30, 2011 at 07:16:34PM +0200, Avi Kivity wrote: On 03/30/2011 06:30 PM, Marcelo Tosatti wrote: Based on Gleb's idea, fix race between nmi injection and enabling nmi window in a simpler way. Signed-off-by: Marcelo

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-31 Thread Gleb Natapov
On Thu, Mar 31, 2011 at 11:23:28AM +0200, Avi Kivity wrote: On 03/30/2011 08:47 PM, Gleb Natapov wrote: On Wed, Mar 30, 2011 at 07:16:34PM +0200, Avi Kivity wrote: On 03/30/2011 06:30 PM, Marcelo Tosatti wrote: Based on Gleb's idea, fix race between nmi injection and enabling nmi window

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-31 Thread Avi Kivity
On 03/31/2011 11:24 AM, Gleb Natapov wrote: On Thu, Mar 31, 2011 at 11:23:28AM +0200, Avi Kivity wrote: On 03/30/2011 08:47 PM, Gleb Natapov wrote: On Wed, Mar 30, 2011 at 07:16:34PM +0200, Avi Kivity wrote: On 03/30/2011 06:30 PM, Marcelo Tosatti wrote: Based on Gleb's idea, fix

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-31 Thread Marcelo Tosatti
On Thu, Mar 31, 2011 at 11:25:46AM +0200, Avi Kivity wrote: snip else if (kvm_cpu_has_interrupt(vcpu) || req_int_win) kvm_x86_ops-enable_irq_window(vcpu); What about the check in inject_pending_events()? Didn't

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-31 Thread Marcelo Tosatti
On Wed, Mar 30, 2011 at 08:47:03PM +0200, Gleb Natapov wrote: On Wed, Mar 30, 2011 at 07:16:34PM +0200, Avi Kivity wrote: On 03/30/2011 06:30 PM, Marcelo Tosatti wrote: Based on Gleb's idea, fix race between nmi injection and enabling nmi window in a simpler way. Signed-off-by: Marcelo

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-31 Thread Gleb Natapov
On Thu, Mar 31, 2011 at 11:25:46AM +0200, Avi Kivity wrote: On 03/31/2011 11:24 AM, Gleb Natapov wrote: On Thu, Mar 31, 2011 at 11:23:28AM +0200, Avi Kivity wrote: On 03/30/2011 08:47 PM, Gleb Natapov wrote: On Wed, Mar 30, 2011 at 07:16:34PM +0200, Avi Kivity wrote: On 03/30/2011

KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-30 Thread Marcelo Tosatti
Based on Gleb's idea, fix race between nmi injection and enabling nmi window in a simpler way. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a6a129f..9a7cc1be 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -5152,6

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-30 Thread Gleb Natapov
On Wed, Mar 30, 2011 at 01:30:28PM -0300, Marcelo Tosatti wrote: Based on Gleb's idea, fix race between nmi injection and enabling nmi window in a simpler way. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com But we need to revert the patch that introduced use of request for NMI first.

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-30 Thread Marcelo Tosatti
On Wed, Mar 30, 2011 at 06:33:22PM +0200, Gleb Natapov wrote: On Wed, Mar 30, 2011 at 01:30:28PM -0300, Marcelo Tosatti wrote: Based on Gleb's idea, fix race between nmi injection and enabling nmi window in a simpler way. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com But we

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-30 Thread Avi Kivity
On 03/30/2011 06:30 PM, Marcelo Tosatti wrote: Based on Gleb's idea, fix race between nmi injection and enabling nmi window in a simpler way. Signed-off-by: Marcelo Tosattimtosa...@redhat.com diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a6a129f..9a7cc1be 100644 ---

Re: KVM: x86: better fix for race between nmi injection and enabling nmi window

2011-03-30 Thread Gleb Natapov
On Wed, Mar 30, 2011 at 07:16:34PM +0200, Avi Kivity wrote: On 03/30/2011 06:30 PM, Marcelo Tosatti wrote: Based on Gleb's idea, fix race between nmi injection and enabling nmi window in a simpler way. Signed-off-by: Marcelo Tosattimtosa...@redhat.com diff --git a/arch/x86/kvm/x86.c