Re: KVM call minutes for Sept 21

2010-09-27 Thread Avi Kivity
On 09/26/2010 10:25 PM, Joerg Roedel wrote: btw, speaking of drastic changes to nsvm, one thing I'd like to see is the replacement of those kmaps with something like put_user_try() and put_user_catch(). It should be as fast (or faster) than kmaps, and not affect preemptibility. Yes, I

Re: KVM call minutes for Sept 21

2010-09-27 Thread Gleb Natapov
On Mon, Sep 27, 2010 at 10:36:57AM +0200, Avi Kivity wrote: On 09/26/2010 10:25 PM, Joerg Roedel wrote: btw, speaking of drastic changes to nsvm, one thing I'd like to see is the replacement of those kmaps with something like put_user_try() and put_user_catch(). It should be as fast

Re: KVM call minutes for Sept 21

2010-09-27 Thread Avi Kivity
On 09/27/2010 04:18 PM, Gleb Natapov wrote: On Mon, Sep 27, 2010 at 10:36:57AM +0200, Avi Kivity wrote: On 09/26/2010 10:25 PM, Joerg Roedel wrote: btw, speaking of drastic changes to nsvm, one thing I'd like to see is the replacement of those kmaps with something like

Re: KVM call minutes for Sept 21

2010-09-26 Thread Avi Kivity
On 09/22/2010 09:20 PM, Joerg Roedel wrote: On Wed, Sep 22, 2010 at 07:47:06PM +0200, Gleb Natapov wrote: On Wed, Sep 22, 2010 at 06:29:00PM +0200, Nadav Har'El wrote: In any case, while I obviously agree that it's your prerogative not to merge code that you consider ugly, I still

Re: KVM call minutes for Sept 21

2010-09-26 Thread Nadav Har'El
On Sun, Sep 26, 2010, Avi Kivity wrote about Re: KVM call minutes for Sept 21: Don't worry, I want to merge nvmx as soon as possible (but not sooner). Thanks, I'm happy to hear that. So I don't think there has been any lack of reviews. I don't think that getting more reviews is the most

Re: KVM call minutes for Sept 21

2010-09-26 Thread Avi Kivity
On 09/26/2010 04:28 PM, Nadav Har'El wrote: I'm worried about maintaining core vmx after nvmx is merged, not nvmx itself. There are simply many more things to consider when making a change. Right, but how can we avoid this issue, assuming that you do want nvmx in? We can't avoid it.

Re: KVM call minutes for Sept 21

2010-09-26 Thread Joerg Roedel
On Sun, Sep 26, 2010 at 04:03:13PM +0200, Avi Kivity wrote: I don't expect drastic changes, but then, I still don't understand it well. Part of the review process is the maintainer becoming familiar (and, in some cases, comfortable) with the code. The nit-picking is often just me

Re: KVM call minutes for Sept 21

2010-09-22 Thread Gleb Natapov
On Wed, Sep 22, 2010 at 02:04:38AM +0200, Nadav Har'El wrote: Hi, thanks for the summary. I also listened-in on the call. I'm glad these issues are being discussed. On Tue, Sep 21, 2010, Chris Wright wrote about KVM call minutes for Sept 21: Nested VMX - looking for forward progress

Re: KVM call minutes for Sept 21

2010-09-22 Thread Nadav Har'El
On Wed, Sep 22, 2010, Gleb Natapov wrote about Re: KVM call minutes for Sept 21: There is only one outstanding serious issue from my point of view: event injection path. I want it to be similar to how nested SVM handles it. I don't see why it can't be done the same way for VMX too. The way

Re: KVM call minutes for Sept 21

2010-09-22 Thread Gleb Natapov
On Wed, Sep 22, 2010 at 06:29:00PM +0200, Nadav Har'El wrote: On Wed, Sep 22, 2010, Gleb Natapov wrote about Re: KVM call minutes for Sept 21: There is only one outstanding serious issue from my point of view: event injection path. I want it to be similar to how nested SVM handles it. I

Re: KVM call minutes for Sept 21

2010-09-22 Thread Nadav Har'El
On Tue, Sep 21, 2010, Chris Wright wrote about Re: KVM call minutes for Sept 21: People keep looking for reasons to justify the cost of the effort, dunno why because it's cool isn't good enough ;) At any rate, that was mainly a question of how it might be useful for production kind

Re: KVM call minutes for Sept 21

2010-09-22 Thread Anthony Liguori
On 09/22/2010 12:49 PM, Nadav Har'El wrote: On Tue, Sep 21, 2010, Chris Wright wrote about Re: KVM call minutes for Sept 21: People keep looking for reasons to justify the cost of the effort, dunno why because it's cool isn't good enough ;) At any rate, that was mainly a question of how

Re: KVM call minutes for Sept 21

2010-09-22 Thread Joerg Roedel
On Wed, Sep 22, 2010 at 07:47:06PM +0200, Gleb Natapov wrote: On Wed, Sep 22, 2010 at 06:29:00PM +0200, Nadav Har'El wrote: In any case, while I obviously agree that it's your prerogative not to merge code that you consider ugly, I still don't see any particular problem to start with

Re: KVM call minutes for Sept 21

2010-09-22 Thread Joerg Roedel
On Wed, Sep 22, 2010 at 01:03:55PM -0500, Anthony Liguori wrote: On 09/22/2010 12:49 PM, Nadav Har'El wrote: On Tue, Sep 21, 2010, Chris Wright wrote about Re: KVM call minutes for Sept 21: People keep looking for reasons to justify the cost of the effort, dunno why because it's cool

Re: KVM call minutes for Sept 21

2010-09-22 Thread Joerg Roedel
On Wed, Sep 22, 2010 at 07:49:43PM +0200, Nadav Har'El wrote: I believe that in the current state of the code, nested VMX adds little complexity to the non-nested code - just a few if's. Of course, it also adds a lot of new code, but none of this code gets run in the non-nested case. As it

Re: KVM call minutes for Sept 21

2010-09-22 Thread Nadav Har'El
On Wed, Sep 22, 2010, Gleb Natapov wrote about Re: KVM call minutes for Sept 21: are reworked even if maintained. Nadav said that he doesn't even know how this part of code is working. This is worrying. Hi, I just wanted to clarify that reason I don't know exactly how this specific part

KVM call minutes for Sept 21

2010-09-21 Thread Chris Wright
Nested VMX - looking for forward progress and better collaboration between the Intel and IBM teams - needs more review (not a new issue) - use cases - work todo - merge baseline patch - looks pretty good - review is finding mostly small things at this point - need some correctness

Re: KVM call minutes for Sept 21

2010-09-21 Thread Anthony Liguori
On 09/21/2010 01:05 PM, Chris Wright wrote: Nested VMX - looking for forward progress and better collaboration between the Intel and IBM teams - needs more review (not a new issue) - use cases - work todo - merge baseline patch - looks pretty good - review is finding mostly small

Re: KVM call minutes for Sept 21

2010-09-21 Thread Nadav Har'El
Hi, thanks for the summary. I also listened-in on the call. I'm glad these issues are being discussed. On Tue, Sep 21, 2010, Chris Wright wrote about KVM call minutes for Sept 21: Nested VMX - looking for forward progress and better collaboration between the Intel and IBM teams I'll be very

Re: KVM call minutes for Sept 21

2010-09-21 Thread Chris Wright
* Nadav Har'El (n...@math.technion.ac.il) wrote: On Tue, Sep 21, 2010, Chris Wright wrote about KVM call minutes for Sept 21: Nested VMX - looking for forward progress and better collaboration between the Intel and IBM teams I'll be very happy if anyone, be it from Intel or somewhere