Re: [patch] VFIO: platform: reset: fix a warning message condition

On Thu, 2015-12-17 at 15:27 +0300, Dan Carpenter wrote: > This loop ends with count set to -1 and not zero so the warning > message > isn't printed when it should be.  I've fixed this by change the > postop > to a preop. > > Fixes: 0990822c9866 ('VFIO: platform: reset: AMD xgbe reset module') >

Re: [patch] VFIO: platform: reset: fix a warning message condition

Hi Dan, thanks for pointing this out. Reviewed-by: Eric Auger I add Thomas in CC since the bug also exists in the native driver I think (drivers/net/ethernet/amd/xgbe/drivers/net/ethernet/amd/xgbe /xgbe-dev.c, xgbe_exit function). Best Regards Eric On 12/17/2015 01:27

Re: [patch] VFIO: platform: reset: fix a warning message condition

On Thu, Dec 17, 2015 at 01:45:52PM +0100, Eric Auger wrote: > I add Thomas in CC since the bug also exists in the native driver I > think (drivers/net/ethernet/amd/xgbe/drivers/net/ethernet/amd/xgbe > /xgbe-dev.c, xgbe_exit function). > Thanks, but I sent a patch for that one already. (These