Re: [PATCH 2/3] KVM: x86: Saverestore interrupt shadow mask

2010-02-17 Thread Gleb Natapov
On Tue, Feb 16, 2010 at 10:06:12PM -1000, Zachary Amsden wrote: On 02/16/2010 02:39 PM, Marcelo Tosatti wrote: On Mon, Feb 15, 2010 at 10:45:42AM +0100, Jan Kiszka wrote: The interrupt shadow created by STI or MOV-SS-like operations is part of the VCPU state and must be preserved across

Re: [PATCH 2/3] KVM: x86: Saverestore interrupt shadow mask

2010-02-17 Thread Jan Kiszka
Zachary Amsden wrote: On 02/16/2010 02:39 PM, Marcelo Tosatti wrote: On Mon, Feb 15, 2010 at 10:45:42AM +0100, Jan Kiszka wrote: The interrupt shadow created by STI or MOV-SS-like operations is part of the VCPU state and must be preserved across migration. Transfer it in the spare

Re: KVM: add doc note about PIO/MMIO completion API

2010-02-17 Thread Avi Kivity
On 02/14/2010 10:17 AM, Avi Kivity wrote: --- a/Documentation/kvm/api.txt +++ b/Documentation/kvm/api.txt @@ -820,6 +820,11 @@ executed a memory-mapped I/O instruction which could not be satisfied by kvm. The 'data' member contains the written data if 'is_write' is true, and should be

Re: KVM: use desc_ptr struct instead of kvm private descriptor_table

2010-02-17 Thread Avi Kivity
On 02/16/2010 10:51 AM, Gleb Natapov wrote: x86 arch defines desc_ptr for idt/gdt pointers, no need to define another structure in kvm code. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in

Re: [PATCH] qemu-kvm: pcnet APROMWE bit location

2010-02-17 Thread Avi Kivity
On 02/14/2010 09:30 AM, Chris Kilgour wrote: I don't subscribe to the list, so please excuse any breach of etiquette. According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2. Please send this to the qemu mailing list, qemu-de...@nongnu.org, as this code is shared between qemu

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-17 Thread OHMURA Kei
We think? I mean - yes, I think so too. But have you actually measured it? How much improvement are we talking here? Is it still faster when a bswap is involved? Thanks for pointing out. I will post the data for x86 later. However, I don't have a test environment to check the impact of bswap.

[RFC] Balloon support for device assignment

2010-02-17 Thread borove
Currently device assignment forces pinning the entire guest memory. The following kernel and qemu patches add balloon support for device assignment. When the balloon inflates, the corresponding pages are unmapped from the IOMMU and unpinned, and accordingly they are remapped and pinned when

[RFC] QEMU: Balloon support for device assignment

2010-02-17 Thread borove
From: Eran Borovik bor...@il.ibm.com This patch adds modifications to allow correct balloon operation when a virtual guest uses a direct assigned device. The modifications include a new interface between qemu and kvm to allow mapping and unmapping the pages from the IOMMU as well as pinning and

[RFC] KVM: Balloon support for device assignment

2010-02-17 Thread borove
From: Eran Borovik bor...@il.ibm.com This patch adds modifications to allow correct balloon operation when a virtual guest uses a direct assigned device. The modifications include a new interface between qemu and kvm to allow mapping and unmapping the pages from the IOMMU as well as pinning and

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-17 Thread Alexander Graf
On 17.02.2010, at 10:42, OHMURA Kei wrote: We think? I mean - yes, I think so too. But have you actually measured it? How much improvement are we talking here? Is it still faster when a bswap is involved? Thanks for pointing out. I will post the data for x86 later. However, I don't have

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-17 Thread Avi Kivity
On 02/17/2010 11:42 AM, OHMURA Kei wrote: We think? I mean - yes, I think so too. But have you actually measured it? How much improvement are we talking here? Is it still faster when a bswap is involved? Thanks for pointing out. I will post the data for x86 later. However, I don't have a test

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-17 Thread Alexander Graf
On 17.02.2010, at 10:47, Avi Kivity wrote: On 02/17/2010 11:42 AM, OHMURA Kei wrote: We think? I mean - yes, I think so too. But have you actually measured it? How much improvement are we talking here? Is it still faster when a bswap is involved? Thanks for pointing out. I will post the

Re: [RFC] KVM: Balloon support for device assignment

2010-02-17 Thread Avi Kivity
On 02/17/2010 11:43 AM, bor...@il.ibm.com wrote: From: Eran Borovikbor...@il.ibm.com This patch adds modifications to allow correct balloon operation when a virtual guest uses a direct assigned device. The modifications include a new interface between qemu and kvm to allow mapping and unmapping

Re: [RFC] QEMU: Balloon support for device assignment

2010-02-17 Thread Avi Kivity
On 02/17/2010 11:43 AM, bor...@il.ibm.com wrote: From: Eran Borovikbor...@il.ibm.com This patch adds modifications to allow correct balloon operation when a virtual guest uses a direct assigned device. The modifications include a new interface between qemu and kvm to allow mapping and unmapping

Re: [PATCH v2] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Gleb Natapov
On Tue, Feb 16, 2010 at 10:11:06AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 09:05:40AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Mon, Feb 15, 2010 at 03:53:04PM +0100, Jan Kiszka wrote: We intercept #BP while in guest debugging mode. As VM exits due to

Re: [PATCH] Build fix for #define KVM_DEBUG

2010-02-17 Thread Avi Kivity
On 02/17/2010 04:41 AM, Tsuyoshi Ozawa wrote: shadow_efer was renamed to efer, so this should be modified rather than deleted. OK. The new patch uses efer instead of deleting shadow_efer Excuse me, and what should I do next ? Copy Jan - he maintains kvm-kmod, and probably

Recommended network driver for a windows KVM guest

2010-02-17 Thread carlopmart
Hi all, I need to install several windows KVM (rhel5.4 host fully updated) guests for iSCSI boot. iSCSI servers are Solaris/OpenSolaris storage servers and I need to boot windows guests (2008R2 and Win7) using gpxe. Can i use virtio net dirver during windows install or e1000 driver?? Many

Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Gleb Natapov
On Mon, Feb 15, 2010 at 02:20:31PM +0100, Jan Kiszka wrote: Jan Kiszka wrote: Gleb Natapov wrote: Lets check if SVM works. I can do that if you tell me how. - Fire up some Linux guest with gdb installed - Attach gdb to gdbstub of the VM - Set a soft breakpoint in guest kernel,

Re: [PATCH v2] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Avi Kivity
On 02/17/2010 12:43 PM, Gleb Natapov wrote: And, again: This is an _existing_ user space ABI. We could only provide an alternative, but we have to maintain what is there at least for some longer grace period. But it was always broken for SVM and was broken for VMX for a year and nobody

Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Gleb Natapov
On Wed, Feb 17, 2010 at 01:11:36PM +0200, Avi Kivity wrote: On 02/15/2010 03:30 PM, Gleb Natapov wrote: I just did this on our primary AMD platform (Embedded Opteron, 13KS EE), and it just worked. But this is a fairly new processor. Consequently, it reports NextRIP support via cpuid

Re: [PATCH v2] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Gleb Natapov
On Wed, Feb 17, 2010 at 01:13:29PM +0200, Avi Kivity wrote: On 02/17/2010 12:43 PM, Gleb Natapov wrote: And, again: This is an _existing_ user space ABI. We could only provide an alternative, but we have to maintain what is there at least for some longer grace period. But it was always

Re: [PATCH v2] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Feb 17, 2010 at 01:13:29PM +0200, Avi Kivity wrote: On 02/17/2010 12:43 PM, Gleb Natapov wrote: And, again: This is an _existing_ user space ABI. We could only provide an alternative, but we have to maintain what is there at least for some longer grace period.

Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Feb 17, 2010 at 01:11:36PM +0200, Avi Kivity wrote: On 02/15/2010 03:30 PM, Gleb Natapov wrote: I just did this on our primary AMD platform (Embedded Opteron, 13KS EE), and it just worked. But this is a fairly new processor. Consequently, it reports NextRIP

Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Jan Kiszka
Gleb Natapov wrote: On Mon, Feb 15, 2010 at 02:20:31PM +0100, Jan Kiszka wrote: Jan Kiszka wrote: Gleb Natapov wrote: Lets check if SVM works. I can do that if you tell me how. - Fire up some Linux guest with gdb installed - Attach gdb to gdbstub of the VM - Set a soft breakpoint in guest

Re: [PATCH] Build fix for #define KVM_DEBUG

2010-02-17 Thread Jan Kiszka
Avi Kivity wrote: On 02/17/2010 04:41 AM, Tsuyoshi Ozawa wrote: shadow_efer was renamed to efer, so this should be modified rather than deleted. OK. The new patch uses efer instead of deleting shadow_efer Excuse me, and what should I do next ? Copy Jan - he maintains

Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Gleb Natapov
On Wed, Feb 17, 2010 at 12:24:19PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Feb 17, 2010 at 01:11:36PM +0200, Avi Kivity wrote: On 02/15/2010 03:30 PM, Gleb Natapov wrote: I just did this on our primary AMD platform (Embedded Opteron, 13KS EE), and it just worked. But this

Re: [PATCH 0/4] qemu-kvm: prepare for adding eventfd usage to upstream

2010-02-17 Thread Avi Kivity
On 02/11/2010 01:09 AM, Paolo Bonzini wrote: This patch series morphs the code in qemu-kvm's eventfd so that it looks like the code in upstream qemu. Patch 4 is not yet in upstream QEMU, I'm submitting it first to qemu-kvm to avoid conflicts. Applied, thanks. -- error compiling

Re: [PATCH] [uq/master] use eventfd for iothread

2010-02-17 Thread Avi Kivity
On 02/11/2010 01:23 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzinipbonz...@redhat.com Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH] KVM: inject #UD in 64bit mode from instruction that are not valid there

2010-02-17 Thread Avi Kivity
On 02/11/2010 02:43 PM, Gleb Natapov wrote: Some instruction are obsolete in a long mode. Inject #UD. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH v2] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Gleb Natapov
On Wed, Feb 17, 2010 at 12:23:39PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Feb 17, 2010 at 01:13:29PM +0200, Avi Kivity wrote: On 02/17/2010 12:43 PM, Gleb Natapov wrote: And, again: This is an _existing_ user space ABI. We could only provide an alternative, but we have to

Re: [PATCH v3 0/4] KVM: rework of Fix x86 emulator's fault propagations

2010-02-17 Thread Avi Kivity
On 02/12/2010 08:50 AM, Takuya Yoshikawa wrote: This is the rework of Fix x86 emulator's fault propagations. -- http://www.spinics.net/lists/kvm/msg28874.html I read the review comments from Avi, Marcelo and Gleb and removed some parts which should be done with more care: descriptor related

[PATCH 01/20] KVM: Fix Codestyle in virt/kvm/coalesced_mmio.c

2010-02-17 Thread Avi Kivity
From: Jochen Maes jochen.m...@sejo.be Fixed 2 codestyle issues in virt/kvm/coalesced_mmio.c Signed-off-by: Jochen Maes jochen.m...@sejo.be Signed-off-by: Avi Kivity a...@redhat.com --- virt/kvm/coalesced_mmio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 18/20] KVM: Plan obsolescence of kernel allocated slots, paravirt mmu

2010-02-17 Thread Avi Kivity
These features are unused by modern userspace and can go away. Paravirt mmu needs to stay a little longer for live migration. Signed-off-by: Avi Kivity a...@redhat.com --- Documentation/feature-removal-schedule.txt | 30 1 files changed, 30 insertions(+), 0

[PATCH 20/20] KVM: x86 emulator: disallow opcode 82 in 64-bit mode

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Instructions with opcode 82 are not valid in 64 bit mode. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/emulate.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 17/20] KVM: x86 emulator: Add LOCK prefix validity checking

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Instructions which are not allowed to have LOCK prefix should generate #UD if one is used. [avi: fold opcode 82 fix from another patch] Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/emulate.c | 97

[PATCH 08/20] KVM: ppc/booke: Set ESR and DEAR when inject interrupt to guest

2010-02-17 Thread Avi Kivity
From: Liu Yu yu@freescale.com Old method prematurely sets ESR and DEAR. Move this part after we decide to inject interrupt, which is more like hardware behave. Signed-off-by: Liu Yu yu@freescale.com Acked-by: Hollis Blanchard hol...@penguinppc.org Acked-by: Alexander Graf ag...@suse.de

[PATCH 15/20] KVM: x86 emulator: Fix popf emulation

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com POPF behaves differently depending on current CPU mode. Emulate correct logic to prevent guest from changing flags that it can't change otherwise. Signed-off-by: Gleb Natapov g...@redhat.com Cc: sta...@kernel.org Signed-off-by: Avi Kivity a...@redhat.com ---

[PATCH 19/20] KVM: x86 emulator: code style cleanup

2010-02-17 Thread Avi Kivity
From: Wei Yongjun yj...@cn.fujitsu.com Just remove redundant semicolon. Signed-off-by: Wei Yongjun yj...@cn.fujitsu.com Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/emulate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c

[PATCH 14/20] KVM: x86 emulator: Check IOPL level during io instruction emulation

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Make emulator check that vcpu is allowed to execute IN, INS, OUT, OUTS, CLI, STI. Signed-off-by: Gleb Natapov g...@redhat.com Cc: sta...@kernel.org Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/kvm/emulate.c

[PATCH 16/20] KVM: x86 emulator: Check CPL level during privilege instruction emulation

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Add CPL checking in case emulator is tricked into emulating privilege instruction from userspace. Signed-off-by: Gleb Natapov g...@redhat.com Cc: sta...@kernel.org Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/emulate.c | 35

[PATCH 09/20] KVM: do not store wqh in irqfd

2010-02-17 Thread Avi Kivity
From: Michael S. Tsirkin m...@redhat.com wqh is unused, so we do not need to store it in irqfd anymore Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com --- virt/kvm/eventfd.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git

[PATCH 04/20] KVM: PIT: unregister kvm irq notifier if fail to create pit

2010-02-17 Thread Avi Kivity
From: Wei Yongjun yj...@cn.fujitsu.com If fail to create pit, we should unregister kvm irq notifier which register in kvm_create_pit(). Signed-off-by: Wei Yongjun yj...@cn.fujitsu.com Acked-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com ---

[PATCH 02/20] KVM: MMU: Add tracepoint for guest page aging

2010-02-17 Thread Avi Kivity
Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/mmu.c | 11 --- include/trace/events/kvm.h | 22 ++ 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index b8da671..7397932 100644 ---

[PATCH 06/20] KVM: cleanup the failure path of KVM_CREATE_IRQCHIP ioctrl

2010-02-17 Thread Avi Kivity
From: Wei Yongjun yj...@cn.fujitsu.com If we fail to init ioapic device or the fail to setup the default irq routing, the device register by kvm_create_pic() and kvm_ioapic_init() remain unregister. This patch fixed to do this. Signed-off-by: Wei Yongjun yj...@cn.fujitsu.com Signed-off-by: Avi

[PATCH 03/20] KVM: VMX: Rename VMX_EPT_IGMT_BIT to VMX_EPT_IPAT_BIT

2010-02-17 Thread Avi Kivity
From: Sheng Yang sh...@linux.intel.com Following the new SDM. Now the bit is named Ignore PAT memory type. Signed-off-by: Sheng Yang sh...@linux.intel.com Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/include/asm/vmx.h |2 +- arch/x86/kvm/vmx.c |4 ++-- 2 files changed,

Re: [PATCH 2/2] KVM: SVM: Make stepping out of NMI handlers more robust

2010-02-17 Thread Gleb Natapov
On Tue, Feb 16, 2010 at 12:08:58PM +0200, Gleb Natapov wrote: Besides this, proper #DB forwarding to the guest was missing. During NMI injection? How to reproduce? Inject, e.g., an NMI over code with TF set. A bit harder is placing a guest HW breakpoint at the spot the NMI handler

[PATCH 12/20] KVM: x86 emulator: Add Virtual-8086 mode of emulation

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com For some instructions CPU behaves differently for real-mode and virtual 8086. Let emulator know which mode cpu is in, so it will not poke into vcpu state directly. Signed-off-by: Gleb Natapov g...@redhat.com Cc: sta...@kernel.org Signed-off-by: Avi Kivity

[PATCH 13/20] KVM: x86 emulator: fix memory access during x86 emulation

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Currently when x86 emulator needs to access memory, page walk is done with broadest permission possible, so if emulated instruction was executed by userspace process it can still access kernel memory. Fix that by providing correct memory access to page walker

[PATCH 10/20] KVM: x86 emulator: Add group8 instruction decoding

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Use groups mechanism to decode 0F BA instructions. Signed-off-by: Gleb Natapov g...@redhat.com Cc: sta...@kernel.org Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/emulate.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff

[PATCH 11/20] KVM: x86 emulator: Add group9 instruction decoding

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Use groups mechanism to decode 0F C7 instructions. Signed-off-by: Gleb Natapov g...@redhat.com Cc: sta...@kernel.org Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/emulate.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff

[PATCH 07/20] KVM: ia64: destroy ioapic device if fail to setup default irq routing

2010-02-17 Thread Avi Kivity
From: Wei Yongjun yj...@cn.fujitsu.com If KVM_CREATE_IRQCHIP fail due to kvm_setup_default_irq_routing(), ioapic device is not destroyed and kvm-arch.vioapic is not set to NULL, this may cause KVM_GET_IRQCHIP and KVM_SET_IRQCHIP access to unexcepted memory. Signed-off-by: Wei Yongjun

[PATCH 00/20] KVM updates for the 2.6.34 merge window (batch 4/4)

2010-02-17 Thread Avi Kivity
This is the first of four batches of patches for the 2.6.34 merge window. KVM changes for this cycle include: - rdtscp support - powerpc server-class updates - much improved large-guest scaling (now up to 64 vcpus) - improved guest fpu handling - initial Hyper-V emulation - better swapping

[PATCH 05/20] KVM: kvm-arch.vioapic should be NULL if kvm_ioapic_init() failure

2010-02-17 Thread Avi Kivity
From: Wei Yongjun yj...@cn.fujitsu.com kvm-arch.vioapic should be NULL in case of kvm_ioapic_init() failure due to cannot register io dev. Signed-off-by: Wei Yongjun yj...@cn.fujitsu.com Signed-off-by: Avi Kivity a...@redhat.com --- virt/kvm/ioapic.c |4 +++- 1 files changed, 3

[patch] x86: kvm: Convert i8254/i8259 locks to raw_spinlocks

2010-02-17 Thread Thomas Gleixner
The i8254/i8259 locks need to be real spinlocks on preempt-rt. Convert them to raw_spinlock. No change for !RT kernels. Signed-off-by: Thomas Gleixner t...@linutronix.de --- arch/x86/kvm/i8254.c | 10 +- arch/x86/kvm/i8254.h |2 +- arch/x86/kvm/i8259.c | 31

Re: [PATCH 2/3] KVM: x86: Saverestore interrupt shadow mask

2010-02-17 Thread Marcelo Tosatti
On Wed, Feb 17, 2010 at 11:10:07AM +0200, Gleb Natapov wrote: On Wed, Feb 17, 2010 at 10:03:58AM +0100, Jan Kiszka wrote: Also, as Avi mentioned it would be better to avoid this. Is it not possible to disallow migration while interrupt shadow is present? Which means disallowing

Re: [PATCH 00/18] KVM: PPC: Virtualize Gekko guests

2010-02-17 Thread Alexander Graf
On 09.02.2010, at 13:27, Avi Kivity wrote: On 02/09/2010 01:13 PM, Alexander Graf wrote: Avi Kivity wrote: On 02/09/2010 01:00 PM, Alexander Graf wrote: That's pretty impressive (never saw x86 with this exit rate) but it's more than 1000 times slower than the hardware,

Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Feb 17, 2010 at 12:32:05PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Mon, Feb 15, 2010 at 02:20:31PM +0100, Jan Kiszka wrote: Jan Kiszka wrote: Gleb Natapov wrote: Lets check if SVM works. I can do that if you tell me how. - Fire up some Linux guest with

Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Gleb Natapov
On Wed, Feb 17, 2010 at 04:13:11PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Feb 17, 2010 at 12:32:05PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Mon, Feb 15, 2010 at 02:20:31PM +0100, Jan Kiszka wrote: Jan Kiszka wrote: Gleb Natapov wrote: Lets check if SVM works. I

buildbot failure in qemu-kvm on disable_kvm_i386_out_of_tree

2010-02-17 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_i386_out_of_tree on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_i386_out_of_tree/builds/216 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2010-02-17 Thread qemu-kvm
The Buildbot has detected a new failure of default_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_x86_64_debian_5_0/builds/277 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build: b1_qemu_kvm_1

buildbot failure in qemu-kvm on disable_kvm_x86_64_debian_5_0

2010-02-17 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_x86_64_debian_5_0/builds/267 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

buildbot failure in qemu-kvm on disable_kvm_x86_64_out_of_tree

2010-02-17 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_x86_64_out_of_tree on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_x86_64_out_of_tree/builds/216 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

buildbot failure in qemu-kvm on disable_kvm_i386_debian_5_0

2010-02-17 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_i386_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_i386_debian_5_0/builds/268 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

Re: [PATCH 00/18] KVM: PPC: Virtualize Gekko guests

2010-02-17 Thread Avi Kivity
On 02/17/2010 06:23 PM, Alexander Graf wrote: On 17.02.2010, at 17:03, Avi Kivity wrote: On 02/17/2010 04:56 PM, Alexander Graf wrote: So I changed to code according to your input by making all FPU calls explicit, getting rid of all binary patching. On the PowerStation again I'm

buildbot failure in qemu-kvm on default_i386_debian_5_0

2010-02-17 Thread qemu-kvm
The Buildbot has detected a new failure of default_i386_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_i386_debian_5_0/builds/279 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build: b1_qemu_kvm_2

buildbot failure in qemu-kvm on default_i386_out_of_tree

2010-02-17 Thread qemu-kvm
The Buildbot has detected a new failure of default_i386_out_of_tree on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_i386_out_of_tree/builds/216 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build: b1_qemu_kvm_2

[PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache

2010-02-17 Thread Jes Sorensen
Hi, Comparing the features tested for in get_para_features() with the kvm_feature_names in target-i386/helper.c, I noticed that we didn't list the cr3_cache feature in the real name table. I presume this is unintentional so here's a patch to correct it. Cheers, Jes commit

[ kvm-Bugs-2915201 ] Nested kvm (SVM)

2010-02-17 Thread SourceForge.net
Bugs item #2915201, was opened at 2009-12-15 16:35 Message generated for change (Comment added) made by jbl001 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2915201group_id=180599 Please note that this message will contain a full copy of the comment

Re: [RFC] KVM: Balloon support for device assignment

2010-02-17 Thread Muli Ben-Yehuda
On Wed, Feb 17, 2010 at 12:27:09PM +0200, Avi Kivity wrote: On 02/17/2010 11:43 AM, bor...@il.ibm.com wrote: From: Eran Borovikbor...@il.ibm.com This patch adds modifications to allow correct balloon operation when a virtual guest uses a direct assigned device. The modifications include a

Re: [PATCH 00/18] KVM: PPC: Virtualize Gekko guests

2010-02-17 Thread Alexander Graf
On 17.02.2010, at 17:34, Avi Kivity wrote: On 02/17/2010 06:23 PM, Alexander Graf wrote: On 17.02.2010, at 17:03, Avi Kivity wrote: On 02/17/2010 04:56 PM, Alexander Graf wrote: So I changed to code according to your input by making all FPU calls explicit, getting rid of all

Re: [PATCH] kvm-kmod: Build fix for #define KVM_DEBUG

2010-02-17 Thread Tsuyoshi Ozawa
Copy Jan - he maintains kvm-kmod, and probably didn't see your patch. Yes, I did. Proper subject prefixing can help a lot here... I'm sorry for I forgot to prefix kvm-kmod and thank you for telling me this. I mind this from now. Could you please repost, avoiding that the patch is

Re: [PATCH] kvm-kmod: Build fix for #define KVM_DEBUG

2010-02-17 Thread Jan Kiszka
Tsuyoshi Ozawa wrote: Copy Jan - he maintains kvm-kmod, and probably didn't see your patch. Yes, I did. Proper subject prefixing can help a lot here... I'm sorry for I forgot to prefix kvm-kmod and thank you for telling me this. I mind this from now. Could you please repost, avoiding

[ kvm-Bugs-2915201 ] Nested kvm (SVM)

2010-02-17 Thread SourceForge.net
Bugs item #2915201, was opened at 2009-12-15 17:35 Message generated for change (Comment added) made by alex_williamson You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2915201group_id=180599 Please note that this message will contain a full copy of the

Re: [PATCH 2/2] KVM: SVM: Make stepping out of NMI handlers more robust

2010-02-17 Thread Jan Kiszka
Gleb Natapov wrote: On Tue, Feb 16, 2010 at 12:08:58PM +0200, Gleb Natapov wrote: Besides this, proper #DB forwarding to the guest was missing. During NMI injection? How to reproduce? Inject, e.g., an NMI over code with TF set. A bit harder is placing a guest HW breakpoint at the spot the NMI

Re: [PATCH v2] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Feb 17, 2010 at 12:23:39PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Feb 17, 2010 at 01:13:29PM +0200, Avi Kivity wrote: On 02/17/2010 12:43 PM, Gleb Natapov wrote: And, again: This is an _existing_ user space ABI. We could only provide an alternative,

Re: [PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache

2010-02-17 Thread Marcelo Tosatti
On Wed, Feb 17, 2010 at 06:44:12PM +0100, Jes Sorensen wrote: Hi, Comparing the features tested for in get_para_features() with the kvm_feature_names in target-i386/helper.c, I noticed that we didn't list the cr3_cache feature in the real name table. I presume this is unintentional so

Re: [PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache

2010-02-17 Thread Jes Sorensen
On 02/17/10 22:08, Marcelo Tosatti wrote: The KVM_CAP_CR3_CACHE reference can be removed since the feature was never implemented/included. Ok that works too, would you rather a patch to remove all references to it, or leave it in in case someone decides to pick it up later? Cheers, Jes --

Re: [PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache

2010-02-17 Thread Marcelo Tosatti
On Wed, Feb 17, 2010 at 10:26:56PM +0100, Jes Sorensen wrote: On 02/17/10 22:08, Marcelo Tosatti wrote: The KVM_CAP_CR3_CACHE reference can be removed since the feature was never implemented/included. Ok that works too, would you rather a patch to remove all references to it, or leave it in

[patch uq/master 1/4] qemu: block SIGCHLD in vcpu thread(s)

2010-02-17 Thread Marcelo Tosatti
Otherwise a vcpu thread can run the sigchild handler causing waitpid() from iothread to fail. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu/vl.c === --- qemu.orig/vl.c +++ qemu/vl.c @@ -3514,6 +3514,7 @@ static void

[patch uq/master 4/4] qemu: kvm: remove pre-entry exit_request check with iothread enabled

2010-02-17 Thread Marcelo Tosatti
With SIG_IPI blocked vcpu loop exit notification happens via -EAGAIN from KVM_RUN. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu/kvm-all.c === --- qemu.orig/kvm-all.c +++ qemu/kvm-all.c @@ -753,11 +753,13 @@ int

[patch uq/master 2/4] qemu: kvm specific wait_io_event

2010-02-17 Thread Marcelo Tosatti
In KVM mode the global mutex is released when vcpus are executing, which means acquiring the fairness mutex is not required. Also for KVM there is one thread per vcpu, so tcg_has_work is meaningless. Add a new qemu_wait_io_event_common function to hold common code between TCG/KVM.

[patch uq/master 3/4] qemu: kvm: consume internal signal with sigtimedwait

2010-02-17 Thread Marcelo Tosatti
Change the way the internal qemu signal, used for communication between iothread and vcpus, is handled. Block and consume it with sigtimedwait on the outer vcpu loop, which allows more precise timing control. Change from standard signal (SIGUSR1) to real-time one, so multiple signals are not

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-17 Thread OHMURA Kei
We think? I mean - yes, I think so too. But have you actually measured it? How much improvement are we talking here? Is it still faster when a bswap is involved? Thanks for pointing out. I will post the data for x86 later. However, I don't have a test environment to check the impact of bswap.

Re: [PATCH v2] KVM: VMX: Update instruction length on intercepted BP

2010-02-17 Thread Gleb Natapov
On Wed, Feb 17, 2010 at 08:17:28PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Feb 17, 2010 at 12:23:39PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Feb 17, 2010 at 01:13:29PM +0200, Avi Kivity wrote: On 02/17/2010 12:43 PM, Gleb Natapov wrote: And, again: This is an

Re: [PATCH 00/18] KVM: PPC: Virtualize Gekko guests

2010-02-17 Thread Avi Kivity
On 02/17/2010 08:07 PM, Alexander Graf wrote: On 17.02.2010, at 17:34, Avi Kivity wrote: On 02/17/2010 06:23 PM, Alexander Graf wrote: On 17.02.2010, at 17:03, Avi Kivity wrote: On 02/17/2010 04:56 PM, Alexander Graf wrote: So I changed to code according to

Re: [PATCH 2/2] KVM: SVM: Make stepping out of NMI handlers more robust

2010-02-17 Thread Gleb Natapov
On Wed, Feb 17, 2010 at 08:16:45PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 12:08:58PM +0200, Gleb Natapov wrote: Besides this, proper #DB forwarding to the guest was missing. During NMI injection? How to reproduce? Inject, e.g., an NMI over code with TF set. A

[COMMIT master] Merge branch 'upstream-merge'

2010-02-17 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com * upstream-merge: (159 commits) crisv10: Prettify. sparc32 fix spurious dma interrupts v2 Revert Sparc32: improve DMA controller IRQ debugging cris: Add support for CRISv10 translation. cris: Use tcg_gen_movi_tl. cris: Add v10 style

[COMMIT master] kvm: vmxcap: detect 1GB EPT page support

2010-02-17 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/kvm/scripts/vmxcap b/kvm/scripts/vmxcap index b7f58ac..08fd120 100755 --- a/kvm/scripts/vmxcap +++ b/kvm/scripts/vmxcap @@ -196,6 +196,7 @@ controls = [ 8: 'Paging-structure memory type UC',

[COMMIT master] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-17 Thread Avi Kivity
From: OHMURA Kei ohmura@lab.ntt.co.jp dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. But We think that dirty-bitmap-traveling by long size is faster than by byte size especially when most of memory is not dirty. Signed-off-by: OHMURA Kei ohmura@lab.ntt.co.jp

[COMMIT master] KVM: use desc_ptr struct instead of kvm private descriptor_table

2010-02-17 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com x86 arch defines desc_ptr for idt/gdt pointers, no need to define another structure in kvm code. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/include/asm/kvm_host.h

[COMMIT master] KVM: add doc note about PIO/MMIO completion API

2010-02-17 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com Document that partially emulated instructions leave the guest state inconsistent, and that the kernel will complete operations before checking for pending signals. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity

Sonia added you as a friend on eYari

2010-02-17 Thread eYari
Hi, You are receiving this email because Sonia wants to tell you about this website which will analyze your horoscope and answer your Astrology questions free. Please click on the link below or copy and paste the URL into your browser:

Re: [PATCH 00/18] KVM: PPC: Virtualize Gekko guests

2010-02-17 Thread Alexander Graf
On 09.02.2010, at 13:27, Avi Kivity wrote: On 02/09/2010 01:13 PM, Alexander Graf wrote: Avi Kivity wrote: On 02/09/2010 01:00 PM, Alexander Graf wrote: That's pretty impressive (never saw x86 with this exit rate) but it's more than 1000 times slower than the hardware,

Re: [PATCH 00/18] KVM: PPC: Virtualize Gekko guests

2010-02-17 Thread Avi Kivity
On 02/17/2010 04:56 PM, Alexander Graf wrote: So I changed to code according to your input by making all FPU calls explicit, getting rid of all binary patching. On the PowerStation again I'm running this code (simplified to the important instructions) using kvmctl: li r2,

Re: [PATCH 00/18] KVM: PPC: Virtualize Gekko guests

2010-02-17 Thread Alexander Graf
On 17.02.2010, at 17:34, Avi Kivity wrote: On 02/17/2010 06:23 PM, Alexander Graf wrote: On 17.02.2010, at 17:03, Avi Kivity wrote: On 02/17/2010 04:56 PM, Alexander Graf wrote: So I changed to code according to your input by making all FPU calls explicit, getting rid of all

Re: [PATCH 00/18] KVM: PPC: Virtualize Gekko guests

2010-02-17 Thread Avi Kivity
On 02/17/2010 08:07 PM, Alexander Graf wrote: On 17.02.2010, at 17:34, Avi Kivity wrote: On 02/17/2010 06:23 PM, Alexander Graf wrote: On 17.02.2010, at 17:03, Avi Kivity wrote: On 02/17/2010 04:56 PM, Alexander Graf wrote: So I changed to code according to