RE: [PATCH] KVM: x86: Add lowest-priority support for vt-d posted-interrupts

> -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On > Behalf Of Radim Krcmár > Sent: Friday, December 11, 2015 10:38 PM > To: Wu, Feng > Cc: pbonz...@redhat.com; kvm@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re:

Re: [PATCH] vgaarb: fix signal handling in vga_get()

Hi On Mon, Dec 14, 2015 at 9:19 AM, Kirill A. Shutemov wrote: > On Thu, Dec 10, 2015 at 11:28:58AM +0100, David Herrmann wrote: >> Hi >> >> On Mon, Nov 30, 2015 at 3:17 AM, Kirill A. Shutemov >> wrote: >> > There are few defects in vga_get() related

Re: [PATCH] target-i386: check vcpu features before accessing MSR_TSC_AUX

On 14/12/2015 12:07, Haozhong Zhang wrote: > This patch fix a bug that prevents VM rebooting on recent versions of > KVM (from commit 9dbe6cf). > > kvm_get_msrs() is called to save guest MSR_TSC_AUX and other MSRs across > rebooting. It only checks whether KVM exposes MSR_TSC_AUX to userspace.

[PATCH] target-i386: check vcpu features before accessing MSR_TSC_AUX

This patch fix a bug that prevents VM rebooting on recent versions of KVM (from commit 9dbe6cf). kvm_get_msrs() is called to save guest MSR_TSC_AUX and other MSRs across rebooting. It only checks whether KVM exposes MSR_TSC_AUX to userspace. However, if vcpu does not support rdtscp (e.g. kvm64),

Re: [PATCH] vgaarb: fix signal handling in vga_get()

On Mon, Dec 14, 2015 at 11:20:00AM +0100, David Herrmann wrote: > Hi > > On Mon, Dec 14, 2015 at 9:19 AM, Kirill A. Shutemov > wrote: > > On Thu, Dec 10, 2015 at 11:28:58AM +0100, David Herrmann wrote: > >> Hi > >> > >> On Mon, Nov 30, 2015 at 3:17 AM, Kirill A. Shutemov >

Re: [Qemu-devel] live migration vs device assignment (motivation)

On Sun, Dec 13, 2015 at 11:47:44PM +0800, Lan, Tianyu wrote: > > > On 12/11/2015 1:16 AM, Alexander Duyck wrote: > >On Thu, Dec 10, 2015 at 6:38 AM, Lan, Tianyu wrote: > >> > >> > >>On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote: > > Ideally, it is able to

Re: [PATCH 08/11] KVM: MMU: use page track for non-leaf shadow pages

On 12/01/2015 02:26 AM, Xiao Guangrong wrote: non-leaf shadow pages are always write protected, it can be the user of page track Signed-off-by: Xiao Guangrong --- arch/x86/include/asm/kvm_page_track.h | 8 + arch/x86/kvm/mmu.c| 26

Re: [Qemu-devel] live migration vs device assignment (motivation)

On Fri, Dec 11, 2015 at 03:32:04PM +0800, Lan, Tianyu wrote: > > > On 12/11/2015 12:11 AM, Michael S. Tsirkin wrote: > >On Thu, Dec 10, 2015 at 10:38:32PM +0800, Lan, Tianyu wrote: > >> > >> > >>On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote: > Ideally, it is able to leave guest driver

Re: [PATCH v3 22/22] arm64: KVM: Remove weak attributes

On Mon, Dec 07, 2015 at 10:53:38AM +, Marc Zyngier wrote: > As we've now switched to the new world switch implementation, > remove the weak attributes, as nobody is supposed to override > it anymore. > > Signed-off-by: Marc Zyngier Acked-by: Christoffer Dall

Re: [PATCH v3 10/22] arm64: KVM: Implement guest entry

On Mon, Dec 07, 2015 at 10:53:26AM +, Marc Zyngier wrote: > Contrary to the previous patch, the guest entry is fairly different > from its assembly counterpart, mostly because it is only concerned > with saving/restoring the GP registers, and nothing else. > > Signed-off-by: Marc Zyngier

[PATCH] KVM: VMX: Fix host initiated access to guest MSR_TSC_AUX

The current handling of accesses to guest MSR_TSC_AUX returns error if vcpu does not support rdtscp, though those accesses are initiated by host. This can result in the reboot failure of some versions of QEMU. This patch fixes this issue by passing those host initiated accesses for further

[PATCH v1] kvm/x86: Remove Hyper-V SynIC timer stopping

It's possible that guest send us Hyper-V EOM at the middle of Hyper-V SynIC timer running, so we start processing of Hyper-V SynIC timers in vcpu context and stop the Hyper-V SynIC timer uncoditionally and lose time expiration which Windows 2012R2 guest expects. The patch fixes such situation by

Re: [PATCH v1] kvm/x86: Remove Hyper-V SynIC timer stopping

On 14/12/2015 16:33, Andrey Smetanin wrote: > It's possible that guest send us Hyper-V EOM at the middle > of Hyper-V SynIC timer running, so we start processing of Hyper-V > SynIC timers in vcpu context and stop the Hyper-V SynIC timer > uncoditionally and lose time expiration which Windows

Re: [PATCH] KVM: MTRR: fix fixed MTRR segment look up

On 14/12/2015 15:39, Alexis D...t wrote: > It fixes the slow-down of VM running with pci-passthrough, since some MTRR > range changed from MTRR_TYPE_WRBACK to MTRR_TYPE_UNCACHABLE. > > Fixes: fa61213746a ("KVM: MTRR: simplify kvm_mtrr_get_guest_memory_type") > Bugzilla:

Re: [PATCH] KVM: MTRR: fix fixed MTRR segment look up

>From what I see in my case, it was especially gfn from 0x0 to 0xA0 which are deadly impacted by the wrong cache property. 2015-12-14 16:36 GMT+01:00 Paolo Bonzini : > > > On 14/12/2015 15:39, Alexis D...t wrote: >> It fixes the slow-down of VM running with pci-passthrough,

Re: [PATCH 0/1] virtio/s390: one fix

On Mon, Dec 14, 2015 at 04:02:33PM +0100, Cornelia Huck wrote: > On Thu, 3 Dec 2015 17:23:59 +0100 > Cornelia Huck wrote: > > > Michael, > > > > here's one fix for the virtio-ccw driver. > > > > Patch is against master, as your git branches on mst/vhost.git seem > >

[Bug 107561] 4.2 breaks PCI passthrough in QEMU/KVM

https://bugzilla.kernel.org/show_bug.cgi?id=107561 Paolo Bonzini changed: What|Removed |Added Attachment #197081|0 |1 is obsolete|

Re: [PATCH] KVM: MTRR: fix fixed MTRR segment look up

On 14/12/2015 17:06, Alexis D...t wrote: > From what I see in my case, it was especially gfn from 0x0 to 0xA0 > which are deadly impacted by the wrong cache property. Yes, indeed. I'll send the patch to Linus this week; I've now posted to the BZ a second patch for GFNs above 4GB. Paolo >

Re: [PATCH 04/11] KVM: page track: add the framework of guest page tracking

Hi Guangrong, I am starting to review this series, and should have some comments or questions, you can determine whether they are valuable :) See below. On 12/01/2015 02:26 AM, Xiao Guangrong wrote: The array, gfn_track[mode][gfn], is introduced in memory slot for every guest page, this is

ARM64/KVM: Bad page state in process iperf

Hi All, I am running "iperf" in KVM guest on ARM64 machine and observing below crash. = $iperf -c 3.3.3.3 -P 4 -t 0 -i 5 -w 90k Client connecting to 3.3.3.3, TCP port 5001 TCP window size: 180 KByte

Re: [PATCH 05/11] KVM: page track: introduce kvm_page_track_{add,remove}_page

On 12/01/2015 02:26 AM, Xiao Guangrong wrote: These two functions are the user APIs: - kvm_page_track_add_page(): add the page to the tracking pool after that later specified access on that page will be tracked - kvm_page_track_remove_page(): remove the page from the tracking pool, the

Re: [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

On Sun, Dec 13, 2015 at 01:28:31PM -0800, Alexander Duyck wrote: > This patch is meant to provide the guest with a way of flagging DMA pages > as being dirty to the host when using a direct-assign device within a > guest. The advantage to this approach is that it is fairly simple, however > It

Re: kvmclock doesn't work, help?

On 11/12/2015 22:57, Andy Lutomirski wrote: > I'm still not seeing the issue. > > The formula is: > > (((rdtsc - pvti->tsc_timestamp) * pvti->tsc_to_system_mul) >> > pvti->tsc_shift) + pvti->system_time > > Obviously, if you reset pvti->tsc_timestamp to the current tsc value > after

Re: [PATCH] target-i386: check vcpu features before accessing MSR_TSC_AUX

On 12/14/15 12:51, Paolo Bonzini wrote: > > > On 14/12/2015 12:07, Haozhong Zhang wrote: > > This patch fix a bug that prevents VM rebooting on recent versions of > > KVM (from commit 9dbe6cf). > > > > kvm_get_msrs() is called to save guest MSR_TSC_AUX and other MSRs across > > rebooting. It

Re: [RFC PATCH 0/3] x86: Add support for guest DMA dirty page tracking

On Mon, Dec 14, 2015 at 03:20:26PM +0800, Yang Zhang wrote: > On 2015/12/14 13:46, Alexander Duyck wrote: > >On Sun, Dec 13, 2015 at 9:22 PM, Yang Zhang wrote: > >>On 2015/12/14 12:54, Alexander Duyck wrote: > >>> > >>>On Sun, Dec 13, 2015 at 6:27 PM, Yang Zhang

Re: kvmclock doesn't work, help?

On Fri, Dec 11, 2015 at 01:57:23PM -0800, Andy Lutomirski wrote: > On Thu, Dec 10, 2015 at 1:32 PM, Marcelo Tosatti wrote: > > On Wed, Dec 09, 2015 at 01:10:59PM -0800, Andy Lutomirski wrote: > >> I'm trying to clean up kvmclock and I can't get it to work at all. My > >>

Re: [PATCH] target-i386: check vcpu features before accessing MSR_TSC_AUX

On 14/12/2015 14:54, Haozhong Zhang wrote: >> > That commit is not in any released kernel. > Right, it's currently only in kvm next. But I assume it would finally come > into a released kernel. Yes, but until it is, it's easier (and better) to fix KVM instead of QEMU. > > It's better if we

[PATCH] KVM: MTRR: fix fixed MTRR segment look up

It fixes the slow-down of VM running with pci-passthrough, since some MTRR range changed from MTRR_TYPE_WRBACK to MTRR_TYPE_UNCACHABLE. Fixes: fa61213746a ("KVM: MTRR: simplify kvm_mtrr_get_guest_memory_type") Bugzilla: (https://bugzilla.kernel.org/show_bug.cgi?id=107561) Signed-off-by: Alexis

Re: [PATCH 0/1] virtio/s390: one fix

On Thu, 3 Dec 2015 17:23:59 +0100 Cornelia Huck wrote: > Michael, > > here's one fix for the virtio-ccw driver. > > Patch is against master, as your git branches on mst/vhost.git seem > to be quite old. Is there some branch I can base my own branch on, > or do you

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

Hi, Comments below: On Thu, Dec 10, 2015 at 02:41:21PM -0500, Ashok Raj wrote: > This patch adds basic enumeration, control msr's required to support > Local Machine Check Exception Support (LMCE). > > - Added Local Machine Check definitions, changed MCG_CAP > - Added support for

Re: [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

On Mon, Dec 14, 2015 at 6:00 AM, Michael S. Tsirkin wrote: > On Sun, Dec 13, 2015 at 01:28:31PM -0800, Alexander Duyck wrote: >> This patch is meant to provide the guest with a way of flagging DMA pages >> as being dirty to the host when using a direct-assign device within a >>

Re: [PATCH v1] kvm/x86: Remove Hyper-V SynIC timer stopping

On 12/14/2015 07:09 PM, Paolo Bonzini wrote: On 14/12/2015 16:33, Andrey Smetanin wrote: It's possible that guest send us Hyper-V EOM at the middle of Hyper-V SynIC timer running, so we start processing of Hyper-V SynIC timers in vcpu context and stop the Hyper-V SynIC timer uncoditionally

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

On Mon, Dec 14, 2015 at 02:23:56PM -0200, Eduardo Habkost wrote: > > -#define MCE_CAP_DEF (MCG_CTL_P|MCG_SER_P) > > +#define MCE_CAP_DEF (MCG_CTL_P|MCG_SER_P|MCG_LMCE_P) > > This makes mcg_cap change when upgrading QEMU. > > VMs with MCG_LMCE_P enabled shouldn't be migratable to hosts >

Re: [PATCH v1] kvm/x86: Remove Hyper-V SynIC timer stopping

On 12/14/2015 07:09 PM, Paolo Bonzini wrote: On 14/12/2015 16:33, Andrey Smetanin wrote: It's possible that guest send us Hyper-V EOM at the middle of Hyper-V SynIC timer running, so we start processing of Hyper-V SynIC timers in vcpu context and stop the Hyper-V SynIC timer uncoditionally

Re: [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

On Mon, Dec 14, 2015 at 08:34:00AM -0800, Alexander Duyck wrote: > > This way distro can use a guest agent to disable > > dirtying until before migration starts. > > Right. For a v2 version I would definitely want to have some way to > limit the scope of this. My main reason for putting this

Re: kvmclock doesn't work, help?

On Mon, Dec 14, 2015 at 10:07:21AM -0800, Andy Lutomirski wrote: > On Fri, Dec 11, 2015 at 3:48 PM, Marcelo Tosatti wrote: > > On Fri, Dec 11, 2015 at 01:57:23PM -0800, Andy Lutomirski wrote: > >> On Thu, Dec 10, 2015 at 1:32 PM, Marcelo Tosatti > >>

Re: [PATCH backport v3.12..v3.14 2/4] MIPS: KVM: Fix ASID restoration logic

On 12/11/2015, 06:06 PM, James Hogan wrote: > commit 002374f371bd02df864cce1fe85d90dc5b292837 upstream. Applied 2/4 -- 4/4 to 3.12. Thanks. -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > On Mon, Dec 14, 2015 at 05:37:38PM +0100, Borislav Petkov wrote: > > > > ... and obviously LMCE is vendor-specific so it cannot be enabled on > > !Intel guests with a define like that. mce_init() in qemu should check > > vendor too. >

Re: [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

On Mon, Dec 14, 2015 at 9:20 AM, Michael S. Tsirkin wrote: > On Mon, Dec 14, 2015 at 08:34:00AM -0800, Alexander Duyck wrote: >> > This way distro can use a guest agent to disable >> > dirtying until before migration starts. >> >> Right. For a v2 version I would definitely want

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

On Mon, Dec 14, 2015 at 05:37:38PM +0100, Borislav Petkov wrote: > > ... and obviously LMCE is vendor-specific so it cannot be enabled on > !Intel guests with a define like that. mce_init() in qemu should check > vendor too. > > The same mistake was done with SER_P but that's much harder to

Re: kvmclock doesn't work, help?

On Fri, Dec 11, 2015 at 3:48 PM, Marcelo Tosatti wrote: > On Fri, Dec 11, 2015 at 01:57:23PM -0800, Andy Lutomirski wrote: >> On Thu, Dec 10, 2015 at 1:32 PM, Marcelo Tosatti wrote: >> > On Wed, Dec 09, 2015 at 01:10:59PM -0800, Andy Lutomirski wrote: >>

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

Hi Eduardo, Thanks for the feedback. All the suggestions make sense.. On Mon, Dec 14, 2015 at 02:23:56PM -0200, Eduardo Habkost wrote: > > +static void feature_control_init(X86CPU *cpu) > > +{ > > + CPUX86State *cenv = >env; > > + > > + cenv->msr_ia32_feature_control = ((1<<20) | (1<<0)); >

Re: [PATCH] vgaarb: fix signal handling in vga_get()

On Thu, Dec 10, 2015 at 11:28:58AM +0100, David Herrmann wrote: > Hi > > On Mon, Nov 30, 2015 at 3:17 AM, Kirill A. Shutemov > wrote: > > There are few defects in vga_get() related to signal hadning: > > > > - we shouldn't check for pending signals for

Re: [PATCH kvm-unit-tests 3/6] x86/pmu: expect failure with nmi_watchdog

On Mon, Dec 14, 2015 at 10:24:18PM +0100, Radim Krčmář wrote: > Host's nmi_watchdog takes one slot, making the "all counters" unit-test > fail. We know exactly what happens, mark it as expected failure. > > PMU test is now executed regardless of host_nmi_watchdog. > > Signed-off-by: Radim

Re: [PATCH kvm-unit-tests 2/6] x86/*: report skipped tests

On Mon, Dec 14, 2015 at 10:24:17PM +0100, Radim Krčmář wrote: > No care to consistency or exhaustivity was given. > > (svm-disabled test should be redone and it's weird that x86/hyperv_synic > is about the only one that does report_skip when unsupported.) > > Signed-off-by: Radim Krčmář

Re: [PATCH kvm-unit-tests 4/6] run_tests: generalize check

On Mon, Dec 14, 2015 at 10:24:19PM +0100, Radim Krčmář wrote: > config attribute "check" is currently unused. > Provide a simple implementation instead of removing it. > > Signed-off-by: Radim Krčmář > --- > run_tests.sh | 15 --- > 1 file changed, 4

Re: [PATCH kvm-unit-tests 1/6] lib/report: allow test skipping

On Mon, Dec 14, 2015 at 04:00:19PM -0600, Andrew Jones wrote: > On Mon, Dec 14, 2015 at 10:24:16PM +0100, Radim Krčmář wrote: > > This patch allows us to explicitly mark a unit-test as skipped. > > If all unit-tests were skipped, the whole test is reported as skipped as > > well. This also

Re: [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

On Mon, Dec 14, 2015 at 12:52 PM, Michael S. Tsirkin wrote: > On Mon, Dec 14, 2015 at 09:59:13AM -0800, Alexander Duyck wrote: >> On Mon, Dec 14, 2015 at 9:20 AM, Michael S. Tsirkin wrote: >> > On Mon, Dec 14, 2015 at 08:34:00AM -0800, Alexander Duyck wrote: >>

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > This is mostly harmless.. since the MCG_CAP space is shared and has no > conflict between vendors. Also just the CAP being set has no effect. Of course it does - we check SER_P in machine_check_poll() and when I emulate an AMD guest

Re: [PATCH kvm-unit-tests 1/6] lib/report: allow test skipping

On Mon, Dec 14, 2015 at 10:24:16PM +0100, Radim Krčmář wrote: > This patch allows us to explicitly mark a unit-test as skipped. > If all unit-tests were skipped, the whole test is reported as skipped as > well. This also includes the case where no report()s were done, but > the test still ended

Re: kvmclock doesn't work, help?

On Mon, Dec 14, 2015 at 02:44:15PM +0100, Paolo Bonzini wrote: > > > On 11/12/2015 22:57, Andy Lutomirski wrote: > > I'm still not seeing the issue. > > > > The formula is: > > > > (((rdtsc - pvti->tsc_timestamp) * pvti->tsc_to_system_mul) >> > > pvti->tsc_shift) + pvti->system_time > > > >

Re: [PATCH kvm-unit-tests 0/6] Improve the output of test runners

On Mon, Dec 14, 2015 at 10:24:15PM +0100, Radim Krčmář wrote: > This series is a mix of patches that change the output of run_tests.sh > and x86-run. The output of ./run_tests.sh now looks like this: > > > PASS apic (14 tests, 0 unexpected failures) > > PASS ioapic (19 tests, 0 unexpected

Re: kvmclock doesn't work, help?

On Mon, Dec 14, 2015 at 2:00 PM, Marcelo Tosatti wrote: > On Mon, Dec 14, 2015 at 02:44:15PM +0100, Paolo Bonzini wrote: >> >> >> On 11/12/2015 22:57, Andy Lutomirski wrote: >> > I'm still not seeing the issue. >> > >> > The formula is: >> > >> > (((rdtsc -

Re: [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

On Mon, Dec 14, 2015 at 09:59:13AM -0800, Alexander Duyck wrote: > On Mon, Dec 14, 2015 at 9:20 AM, Michael S. Tsirkin wrote: > > On Mon, Dec 14, 2015 at 08:34:00AM -0800, Alexander Duyck wrote: > >> > This way distro can use a guest agent to disable > >> > dirtying until before

[PATCH kvm-unit-tests 0/6] Improve the output of test runners

This series is a mix of patches that change the output of run_tests.sh and x86-run. The output of ./run_tests.sh now looks like this: > PASS apic (14 tests, 0 unexpected failures) > PASS ioapic (19 tests, 0 unexpected failures) > PASS smptest (1 tests, 0 unexpected failures) > PASS smptest3 (1

[PATCH kvm-unit-tests 1/6] lib/report: allow test skipping

This patch allows us to explicitly mark a unit-test as skipped. If all unit-tests were skipped, the whole test is reported as skipped as well. This also includes the case where no report()s were done, but the test still ended with report_summary(). When the whole test is skipped, ./run_tests.sh

[PATCH kvm-unit-tests 2/6] x86/*: report skipped tests

No care to consistency or exhaustivity was given. (svm-disabled test should be redone and it's weird that x86/hyperv_synic is about the only one that does report_skip when unsupported.) Signed-off-by: Radim Krčmář --- x86/apic.c | 7 +++ x86/emulator.c | 2

[PATCH kvm-unit-tests 5/6] x86/hyperv_synic: check for support before testing

It's not easy to distinguish successful unit-test from failed QEMU, so we check for presence of the needed feature before hand. x86/hyperv_synic is "skip" instead of "PASS", without KVM/QEMU support. Signed-off-by: Radim Krčmář --- Probably not the nicest solution around

[PATCH kvm-unit-tests 4/6] run_tests: generalize check

config attribute "check" is currently unused. Provide a simple implementation instead of removing it. Signed-off-by: Radim Krčmář --- run_tests.sh | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/run_tests.sh b/run_tests.sh index

[PATCH kvm-unit-tests 3/6] x86/pmu: expect failure with nmi_watchdog

Host's nmi_watchdog takes one slot, making the "all counters" unit-test fail. We know exactly what happens, mark it as expected failure. PMU test is now executed regardless of host_nmi_watchdog. Signed-off-by: Radim Krčmář --- x86/pmu.c | 9 -

[PATCH kvm-unit-tests 6/6] run_tests: print summary

Add shortened SUMMARY line into the output (in parentheses). Might be interesting and hopefully won't break too many scripts. Signed-off-by: Radim Krčmář --- run_tests.sh | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/run_tests.sh

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

On Mon, Dec 14, 2015 at 11:37:16PM +0100, Borislav Petkov wrote: > On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > > This is mostly harmless.. since the MCG_CAP space is shared and has no > > conflict between vendors. Also just the CAP being set has no effect. > > Of course it does