Re: [PATCH 4/5] KVM: x86: RSI/RDI/RCX are zero-extended when affected by string ops

2014-04-22 Thread Nadav Amit
Gleb, On 4/20/14, 12:26 PM, Gleb Natapov wrote: On Fri, Apr 18, 2014 at 07:11:33AM +0300, Nadav Amit wrote: When using address-size override prefix with string instructions in long-mode, ESI/EDI/ECX are zero extended if they are affected by the instruction (incremented/decremented).

Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-22 Thread Michael S. Tsirkin
On Mon, Apr 21, 2014 at 06:40:17PM -0300, Marcelo Tosatti wrote: On Sun, Apr 13, 2014 at 04:10:22PM +0300, Michael S. Tsirkin wrote: It seems that it's easy to implement the EOI assist on top of the PV EOI feature: simply convert the page address to the format expected by PV EOI.

commit 0bf1457f0cfca7b mm: vmscan: do not swap anon pages just because free+file is low causes heavy performance regression on paging

2014-04-22 Thread Christian Borntraeger
While preparing/testing some KVM on s390 patches for the next merge window (target is kvm/next which is based on 3.15-rc1) I faced a very severe performance hickup on guest paging (all anonymous memory). All memory bound guests are in D state now and the system is barely unusable. Reverting

[GIT PULL 10/54] KVM: s390: Exploiting generic userspace interface for cmma

2014-04-22 Thread Christian Borntraeger
From: Dominik Dingel din...@linux.vnet.ibm.com To enable CMMA and to reset its state we use the vm kvm_device ioctls, encapsulating attributes within the KVM_S390_VM_MEM_CTRL group. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger

[GIT PULL 08/54] KVM: s390: Per-vm kvm device controls

2014-04-22 Thread Christian Borntraeger
From: Dominik Dingel din...@linux.vnet.ibm.com We sometimes need to get/set attributes specific to a virtual machine and so need something else than ONE_REG. Let's copy the KVM_DEVICE approach, and define the respective ioctls for the vm file descriptor. Signed-off-by: Dominik Dingel

[GIT PULL 0/54] KVM: s390: Features and Fixes for 3.16

2014-04-22 Thread Christian Borntraeger
://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/kvm-s390-20140422 for you to fetch changes up to e325fe69aa37b485635521568651642791d6d140: KVM: s390: Factor out handle_itdb to handle TX aborts (2014-04-22 13:24:54 +0200

Re: commit 0bf1457f0cfca7b mm: vmscan: do not swap anon pages just because free+file is low causes heavy performance regression on paging

2014-04-22 Thread Christian Borntraeger
On 22/04/14 12:55, Christian Borntraeger wrote: While preparing/testing some KVM on s390 patches for the next merge window (target is kvm/next which is based on 3.15-rc1) I faced a very severe performance hickup on guest paging (all anonymous memory). All memory bound guests are in D state

Re: Bug - IP Address

2014-04-22 Thread Stefan Hajnoczi
On Sat, Apr 19, 2014 at 11:41:33AM +0200, Ivan Stojcevic (Tronyx) wrote: I just found a very sensitive bug in KVM and Xen platforms. Easily if you have VPS hosted on Xen or KVM you can assign yourself a IPv4 address for free and bypass regular system with billing. I tried this on many VPS

Re: Who signed gemu-1.7.1.tar.bz2?

2014-04-22 Thread Stefan Hajnoczi
On Wed, Apr 02, 2014 at 05:40:23PM -0700, Alex Davis wrote: and where is their gpg key? Michael Roth mdr...@linux.vnet.ibm.com is doing releases: http://pgp.mit.edu/pks/lookup?op=vindexsearch=0x3353C9CEF108B584 $ gpg --verify qemu-2.0.0.tar.bz2.sig gpg: Signature made Thu 17 Apr 2014 03:49:55

Re: [Qemu-devel] Who signed gemu-1.7.1.tar.bz2?

2014-04-22 Thread Peter Maydell
On 22 April 2014 14:31, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Apr 02, 2014 at 05:40:23PM -0700, Alex Davis wrote: and where is their gpg key? Michael Roth mdr...@linux.vnet.ibm.com is doing releases: http://pgp.mit.edu/pks/lookup?op=vindexsearch=0x3353C9CEF108B584 $ gpg

Re: Who signed gemu-1.7.1.tar.bz2?

2014-04-22 Thread Michael Roth
Quoting Stefan Hajnoczi (2014-04-22 08:31:08) On Wed, Apr 02, 2014 at 05:40:23PM -0700, Alex Davis wrote: and where is their gpg key? Michael Roth mdr...@linux.vnet.ibm.com is doing releases: http://pgp.mit.edu/pks/lookup?op=vindexsearch=0x3353C9CEF108B584 $ gpg --verify

[kvm-kmod PATCH 2/2] sync: copy linux/vfio.h from kvm source tree

2014-04-22 Thread gsomlo
Signed-off-by: Gabriel Somlo so...@cmu.edu --- vfio.c gets copied by sync, and it needs vfio.h. I don't think there's an easy way to #define ourselves out of this one, copying vfio.h into kvm-kmod/include/linux/ seems to be the path of least resistance... Thanks, Gabriel P.S. I'm not a

[kvm-kmod PATCH 1/2] Provide VFIO_DMA_CC_IOMMU and *cpu_notifier* functions for kernels 3.15

2014-04-22 Thread gsomlo
Signed-off-by: Gabriel Somlo so...@cmu.edu --- Jan, I upgraded my fedora 20 box to 3.13.10-200.fc20.x86_64 today, and noticed that in order to build the latest kvm via kvm-kmod, I need these two patches (second patch to follow shortly). Thanks, Gabriel x86/external-module-compat.h | 10

Re: commit 0bf1457f0cfca7b mm: vmscan: do not swap anon pages just because free+file is low causes heavy performance regression on paging

2014-04-22 Thread Rafael Aquini
On Tue, Apr 22, 2014 at 10:40:17AM -0400, Rik van Riel wrote: On 04/22/2014 07:57 AM, Christian Borntraeger wrote: On 22/04/14 12:55, Christian Borntraeger wrote: While preparing/testing some KVM on s390 patches for the next merge window (target is kvm/next which is based on 3.15-rc1) I

Re: [kvm-kmod PATCH 2/2] sync: copy linux/vfio.h from kvm source tree

2014-04-22 Thread Jan Kiszka
On 2014-04-22 16:52, gso...@gmail.com wrote: Signed-off-by: Gabriel Somlo so...@cmu.edu --- vfio.c gets copied by sync, and it needs vfio.h. I don't think there's an easy way to #define ourselves out of this one, copying vfio.h into kvm-kmod/include/linux/ seems to be the path of least

Re: commit 0bf1457f0cfca7b mm: vmscan: do not swap anon pages just because free+file is low causes heavy performance regression on paging

2014-04-22 Thread Johannes Weiner
Hi Christian, On Tue, Apr 22, 2014 at 12:55:37PM +0200, Christian Borntraeger wrote: While preparing/testing some KVM on s390 patches for the next merge window (target is kvm/next which is based on 3.15-rc1) I faced a very severe performance hickup on guest paging (all anonymous memory).

Re: commit 0bf1457f0cfca7b mm: vmscan: do not swap anon pages just because free+file is low causes heavy performance regression on paging

2014-04-22 Thread Rik van Riel
On 04/22/2014 07:57 AM, Christian Borntraeger wrote: On 22/04/14 12:55, Christian Borntraeger wrote: While preparing/testing some KVM on s390 patches for the next merge window (target is kvm/next which is based on 3.15-rc1) I faced a very severe performance hickup on guest paging (all

Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

2014-04-22 Thread Ben Hutchings
On Mon, 2014-04-21 at 12:26 +0100, Luis Henriques wrote: Hi David, On Thu, Mar 27, 2014 at 03:29:56PM -0400, David Miller wrote: From: Zoltan Kiss zoltan.k...@citrix.com Date: Wed, 26 Mar 2014 22:37:45 + skb_zerocopy can copy elements of the frags array between skbs, but it

Re: [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs

2014-04-22 Thread Bandan Das
Paolo Bonzini pbonz...@redhat.com writes: Il 21/04/2014 15:20, Bandan Das ha scritto: +for (i = j = 0; i max_shadow_read_write_fields; i++) { + Extra empty line. Not a big deal, but... +switch (shadow_read_write_fields[i]) { +case GUEST_BNDCFGS: +

Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

2014-04-22 Thread Zoltan Kiss
On 22/04/14 16:38, Ben Hutchings wrote: On Mon, 2014-04-21 at 12:26 +0100, Luis Henriques wrote: Hi David, On Thu, Mar 27, 2014 at 03:29:56PM -0400, David Miller wrote: From: Zoltan Kiss zoltan.k...@citrix.com Date: Wed, 26 Mar 2014 22:37:45 + skb_zerocopy can copy elements of the frags

Re: commit 0bf1457f0cfca7b mm: vmscan: do not swap anon pages just because free+file is low causes heavy performance regression on paging

2014-04-22 Thread Christian Borntraeger
On 22/04/14 17:06, Johannes Weiner wrote: Hi Christian, On Tue, Apr 22, 2014 at 12:55:37PM +0200, Christian Borntraeger wrote: While preparing/testing some KVM on s390 patches for the next merge window (target is kvm/next which is based on 3.15-rc1) I faced a very severe performance

Re: [kvm-kmod PATCH 2/2] sync: copy linux/vfio.h from kvm source tree

2014-04-22 Thread Gabriel L. Somlo
On Tue, Apr 22, 2014 at 04:57:32PM +0200, Jan Kiszka wrote: On 2014-04-22 16:52, gso...@gmail.com wrote: Signed-off-by: Gabriel Somlo so...@cmu.edu --- vfio.c gets copied by sync, and it needs vfio.h. I don't think there's an easy way to #define ourselves out of this one, copying

Re: commit 0bf1457f0cfca7b mm: vmscan: do not swap anon pages just because free+file is low causes heavy performance regression on paging

2014-04-22 Thread Rafael Aquini
On Tue, Apr 22, 2014 at 11:06:56AM -0400, Johannes Weiner wrote: Hi Christian, On Tue, Apr 22, 2014 at 12:55:37PM +0200, Christian Borntraeger wrote: While preparing/testing some KVM on s390 patches for the next merge window (target is kvm/next which is based on 3.15-rc1) I faced a very

[patch 0/2] expose invariant tsc flag for kvm guests

2014-04-22 Thread Marcelo Tosatti
see patches for details. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs

2014-04-22 Thread Paolo Bonzini
Il 22/04/2014 12:25, Bandan Das ha scritto: + if (j i) + shadow_read_write_fields[j] = + shadow_read_write_fields[i]; + j++; ... you need to respin anyway because the j++ is wrong. It should be inside the if.

[patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-22 Thread Marcelo Tosatti
Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states. This is not the case if migration to a host with different TSC frequency is allowed, or if savevm is performed. So block migration/savevm. Also do not expose invariant tsc flag

[patch 1/2] target-i386: support invariant tsc flag

2014-04-22 Thread Marcelo Tosatti
Expose Invariant TSC flag, if KVM is enabled. From Intel documentation: 17.13.1 Invariant TSC The time stamp counter in newer processors may support an enhancement, referred to as invariant TSC. Processor’s support for invariant TSC is indicated by CPUID.8007H:EDX[8]. The invariant TSC will

[PATCH 3.13] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

2014-04-22 Thread Ben Hutchings
From: Zoltan Kiss zoltan.k...@citrix.com commit 36d5fe6a000790f56039afe26834265db0a3ad4c upstream. skb_zerocopy can copy elements of the frags array between skbs, but it doesn't orphan them. Also, it doesn't handle errors, so this patch takes care of that as well, and modify the callers

Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-22 Thread Marcelo Tosatti
On Tue, Apr 22, 2014 at 12:11:47PM +0300, Michael S. Tsirkin wrote: On Mon, Apr 21, 2014 at 06:40:17PM -0300, Marcelo Tosatti wrote: On Sun, Apr 13, 2014 at 04:10:22PM +0300, Michael S. Tsirkin wrote: It seems that it's easy to implement the EOI assist on top of the PV EOI feature: simply

Re: [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-22 Thread Marcelo Tosatti
On Tue, Apr 22, 2014 at 04:10:44PM -0300, Marcelo Tosatti wrote: Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states. This is not the case if migration to a host with different TSC frequency is allowed, or if savevm is

Re: [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs

2014-04-22 Thread Bandan Das
Paolo Bonzini pbonz...@redhat.com writes: Il 22/04/2014 12:25, Bandan Das ha scritto: + if (j i) + shadow_read_write_fields[j] = + shadow_read_write_fields[i]; + j++; ... you need to respin anyway

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-04-22 Thread Luis R. Rodriguez
On Wed, Mar 19, 2014 at 7:05 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Tue, Mar 18, 2014 at 08:10:56PM -0700, Stephen Hemminger wrote: On Wed, 12 Mar 2014 20:15:25 -0700 Luis R. Rodriguez mcg...@do-not-panic.com wrote: As it is now if you add create a bridge it gets started with a

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-04-22 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 02:22:43PM -0700, Luis R. Rodriguez wrote: On Tue, Mar 18, 2014 at 01:46:49PM -0700, Cong Wang wrote: On Fri, Mar 14, 2014 at 6:39 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Thu, Mar 13, 2014 at 11:26:25AM -0700, Cong Wang wrote: On Wed, Mar 12, 2014 at 8:15

Re: [PATCH 1/2] KVM: async_pf: kill the unnecessary use_mm/unuse_mm async_pf_execute()

2014-04-22 Thread Christian Borntraeger
On 21/04/14 15:25, Oleg Nesterov wrote: async_pf_execute() has no reasons to adopt apf-mm, gup(current, mm) should work just fine even if current has another or NULL -mm. Recently kvm_async_page_present_sync() was added insedie the use_mm section, but it seems that it doesn't need current-mm

Re: [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-22 Thread Eduardo Habkost
On Tue, Apr 22, 2014 at 04:10:44PM -0300, Marcelo Tosatti wrote: Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states. This is not the case if migration to a host with different TSC frequency is allowed, or if savevm is

Re: [PATCH 2/2] KVM: async_pf: mm-mm_users can not pin apf-mm

2014-04-22 Thread Christian Borntraeger
On 21/04/14 15:26, Oleg Nesterov wrote: get_user_pages(mm) is simply wrong if mm-mm_users == 0 and exit_mmap/etc was already called (or is in progress), mm-mm_count can only pin mm-pgd and mm_struct itself. Change kvm_setup_async_pf/async_pf_execute to inc/dec mm-mm_users.

Re: [PATCH 1/2] KVM: async_pf: kill the unnecessary use_mm/unuse_mm async_pf_execute()

2014-04-22 Thread Christian Borntraeger
On 22/04/14 22:15, Christian Borntraeger wrote: On 21/04/14 15:25, Oleg Nesterov wrote: async_pf_execute() has no reasons to adopt apf-mm, gup(current, mm) should work just fine even if current has another or NULL -mm. Recently kvm_async_page_present_sync() was added insedie the use_mm

Re: [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-22 Thread Marcelo Tosatti
On Tue, Apr 22, 2014 at 05:38:07PM -0300, Eduardo Habkost wrote: On Tue, Apr 22, 2014 at 04:10:44PM -0300, Marcelo Tosatti wrote: Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states. This is not the case if migration to a

Re: [PATCH v3 0/3] nVMX: Fixes to run Xen as L1

2014-04-22 Thread Marcelo Tosatti
On Sat, Apr 19, 2014 at 06:17:43PM -0400, Bandan Das wrote: Minor changes to enable Xen as a L1 hypervisor. Tested with a Haswell host, Xen-4.3 L1 and debian6 L2 Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-22 Thread Michael S. Tsirkin
On Tue, Apr 22, 2014 at 04:26:48PM -0300, Marcelo Tosatti wrote: On Tue, Apr 22, 2014 at 12:11:47PM +0300, Michael S. Tsirkin wrote: On Mon, Apr 21, 2014 at 06:40:17PM -0300, Marcelo Tosatti wrote: On Sun, Apr 13, 2014 at 04:10:22PM +0300, Michael S. Tsirkin wrote: It seems that it's

[PATCH v3 0/4] live migration dirty bitmap support for ARMv7

2014-04-22 Thread Mario Smarduch
Hi, this the third iteration of live migration support for the time being on ARMv7. The patches depend on Eric Augers patch for memory regions. Changes since v2: - move initial VM write protect to memory region architecture prepare function (needed to make dirty logging function generic) -

[PATCH v3 1/4] add ARMv7 HYP API to flush VM TLBs without address param

2014-04-22 Thread Mario Smarduch
Add HYP interface for global VM TLB invalidation without address parameter. - Added ARM version of kvm_flush_remote_tlbs() Signed-off-by: Mario Smarduch m.smard...@samsung.com --- arch/arm/include/asm/kvm_asm.h |1 + arch/arm/include/asm/kvm_host.h |2 ++ arch/arm/kvm/interrupts.S

[PATCH v3 2/4] live migration support for initial write protect of VM

2014-04-22 Thread Mario Smarduch
Support for live migration initial write protect. - moved write protect to architecture memory region prepare function. This way you can fail, abort migration without keep track of migration status. - Above also allows to generalize read dirty log function with x86 - Added stage2_mark_pte_ro()

[PATCH v3 4/4] add 2nd stage page fault handling during live migration

2014-04-22 Thread Mario Smarduch
- added pte_index() to add to pmd pfn Signed-off-by: Mario Smarduch m.smard...@samsung.com --- arch/arm/kvm/mmu.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c index 52d4dd6..61ee812 100644 ---

[PATCH v3 3/4] live migration support for VM dirty log management

2014-04-22 Thread Mario Smarduch
- made kvm_vm_ioctl_get_dirty_log() generic moved to kvm_main.c, deleted arm,x86 versions - optimized kvm_mmu_write_protected_pt_masked() to skip upper table lookups Signed-off-by: Mario Smarduch m.smard...@samsung.com --- arch/arm/include/asm/kvm_host.h |3 ++ arch/arm/kvm/arm.c

Re: [patch 1/2] target-i386: support invariant tsc flag

2014-04-22 Thread Paolo Bonzini
Il 22/04/2014 15:10, Marcelo Tosatti ha scritto: +case 0x8007: +*eax = 0; +*ebx = 0; +*ecx = 0; + +if (kvm_enabled()) { +*edx = env-features[FEAT_8000_0007_EDX]; +} else { +*edx = 0; +} I think TCG is able to

Re: [patch 1/2] target-i386: support invariant tsc flag

2014-04-22 Thread Eduardo Habkost
On Tue, Apr 22, 2014 at 08:26:36PM -0400, Paolo Bonzini wrote: Il 22/04/2014 15:10, Marcelo Tosatti ha scritto: +case 0x8007: +*eax = 0; +*ebx = 0; +*ecx = 0; + +if (kvm_enabled()) { +*edx = env-features[FEAT_8000_0007_EDX]; +}

Re: [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-22 Thread Eduardo Habkost
On Tue, Apr 22, 2014 at 06:27:59PM -0300, Marcelo Tosatti wrote: On Tue, Apr 22, 2014 at 05:38:07PM -0300, Eduardo Habkost wrote: On Tue, Apr 22, 2014 at 04:10:44PM -0300, Marcelo Tosatti wrote: Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all

Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-22 Thread Marcelo Tosatti
On Wed, Apr 23, 2014 at 01:12:49AM +0300, Michael S. Tsirkin wrote: On Tue, Apr 22, 2014 at 04:26:48PM -0300, Marcelo Tosatti wrote: On Tue, Apr 22, 2014 at 12:11:47PM +0300, Michael S. Tsirkin wrote: On Mon, Apr 21, 2014 at 06:40:17PM -0300, Marcelo Tosatti wrote: On Sun, Apr 13, 2014

Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-22 Thread Michael S. Tsirkin
On Tue, Apr 22, 2014 at 10:57:48PM -0300, Marcelo Tosatti wrote: On Wed, Apr 23, 2014 at 01:12:49AM +0300, Michael S. Tsirkin wrote: On Tue, Apr 22, 2014 at 04:26:48PM -0300, Marcelo Tosatti wrote: On Tue, Apr 22, 2014 at 12:11:47PM +0300, Michael S. Tsirkin wrote: On Mon, Apr 21, 2014