Re: About cpu_set, CPU hotplug and related subjects

2010-04-21 Thread Kevin O'Connor
On Mon, Apr 19, 2010 at 04:34:54PM -0300, Lucas Meneghel Rodrigues wrote: After doing some reading it seems to me that the reason why that is not happening is because SeaBIOS still doesn't have code to support CPU hot plugging as BochsBIOS did. As I understand it, the hotplug support was only

Re: [PATCH] Support for booting from virtio disks

2010-05-09 Thread Kevin O'Connor
On Sun, May 09, 2010 at 06:23:49PM +0300, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Thanks Gleb - it looks good to me. One thing I noticed - the virtio-pci.c file is missing a license statement and virtio-ring.c states GPL instead of LGPL.

Re: [PATCHv3] Support for booting from virtio disks

2010-05-10 Thread Kevin O'Connor
On Mon, May 10, 2010 at 11:36:37AM +0300, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapov g...@redhat.com Thanks - commit 89acfa3f. The patch had some compile errors on gcc3.4 and gcc4.5 - I went ahead and committed an

Re: [SeaBIOS] [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Kevin O'Connor
On Tue, May 11, 2010 at 10:04:25AM +0100, Stefan Hajnoczi wrote: From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and CMOS_BIOS_BOOTFLAG2 from non-volatile memory. The values index into bev[], which contains IPL entries (the drives). Is the order of bev[] entries well-defined?

Re: [SeaBIOS] [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Kevin O'Connor
On Tue, May 11, 2010 at 03:47:40PM +0300, Gleb Natapov wrote: On Tue, May 11, 2010 at 08:45:29AM -0400, Kevin O'Connor wrote: On Tue, May 11, 2010 at 10:04:25AM +0100, Stefan Hajnoczi wrote: From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and CMOS_BIOS_BOOTFLAG2 from non

Re: Qemu-KVM with 3x IDE HDD + CDROM not working

2010-05-15 Thread Kevin O'Connor
On Wed, May 12, 2010 at 03:19:26PM +0200, Peter Lieven wrote: Hi Qemu/KVM Devel Team, if I create a VM with more than 2 harddisks and a CDROM Image and want to boot from CDROM this is not working. From my understanding at least 3 IDE Drives + 1 IDE CDROM should work. cmdline:

Re: [Qemu-devel] [PATCHv2] seabios: enable io/memory unconditionally

2009-10-08 Thread Kevin O'Connor
Hi Michael, On Thu, Oct 08, 2009 at 05:53:46PM +0200, Michael S. Tsirkin wrote: VGA adapters need to claim memory and i/o transactions even if they do not have any i/o or memory bars. E.g. PCI spec, page 297, gives an example of such a device: Programming interface b

Re: [PATCHv2] seabios: enable io/memory unconditionally

2009-10-12 Thread Kevin O'Connor
On Mon, Oct 12, 2009 at 11:59:29AM +0200, Michael S. Tsirkin wrote: VGA adapters need to claim memory and i/o transactions even if they do not have any i/o or memory bars. E.g. PCI spec, page 297, gives an example of such a device: I've modified your patch slightly (to use new

Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant

2009-10-12 Thread Kevin O'Connor
On Mon, Oct 12, 2009 at 08:44:56AM -0500, Anthony Liguori wrote: Gleb Natapov wrote BTW, I don't think it's write-protected and it probably should be? AFAIR it is not writable on plain qemu. KVM wants it to be writable for the TPR optimization. Historically, it was read-only in

Re: SeaBIOS cdrom regression with Vista

2009-11-17 Thread Kevin O'Connor
On Tue, Nov 17, 2009 at 03:21:31PM +0200, Avi Kivity wrote: qemu-kvm's switch to seabios uncovered a regression with cdrom handling. Vista x64 no longer recognizes the cdrom, while pc-bios still works. Installing works, but that uses int 13, not the native driver. Haven't investigated

Re: [Qemu-devel] Re: SeaBIOS cdrom regression with Vista

2009-11-18 Thread Kevin O'Connor
On Wed, Nov 18, 2009 at 12:19:20AM -0500, Kevin O'Connor wrote: On Tue, Nov 17, 2009 at 03:21:31PM +0200, Avi Kivity wrote: qemu-kvm's switch to seabios uncovered a regression with cdrom handling. Vista x64 no longer recognizes the cdrom, while pc-bios still works. Installing works

Re: Issues building seabios

2009-11-19 Thread Kevin O'Connor
On Thu, Nov 19, 2009 at 03:10:20PM +0200, Avi Kivity wrote: Trying to debug the cdrom issue, I see Compiling whole program out/ccode32.o src/util.c: In function ‘__end_thread’: src/util.c:183: internal compiler error: in simplify_subreg, at simplify-rtx.c:5055 (with F12's gcc (GCC)

Re: SeaBIOS cdrom regression with Vista

2009-11-20 Thread Kevin O'Connor
On Wed, Nov 18, 2009 at 12:19:20AM -0500, Kevin O'Connor wrote: On Tue, Nov 17, 2009 at 03:21:31PM +0200, Avi Kivity wrote: qemu-kvm's switch to seabios uncovered a regression with cdrom handling. Vista x64 no longer recognizes the cdrom, while pc-bios still works. Installing works

Re: SeaBIOS cdrom regression with Vista

2009-11-20 Thread Kevin O'Connor
On Fri, Nov 20, 2009 at 01:03:51PM -0500, Kevin O'Connor wrote: I've looked into this, and it looks like the cdrom is left in an odd state. At this point, I think SeaBIOS is tickling a bug outside of seabios (eg, in Vista or qemu). I would appreciate it someone with cdrom knowledge of qemu

Re: Issues building seabios

2009-11-20 Thread Kevin O'Connor
On Thu, Nov 19, 2009 at 04:02:06PM +0200, Avi Kivity wrote: On 11/19/2009 03:39 PM, Kevin O'Connor wrote: Long story short - this is the result of gcc's -combine being fragile. It's possible to avoid by compiling seabios with make COMPSTRAT=1. We may need to change the default. That works

Re: SeaBIOS cdrom regression with Vista

2009-11-20 Thread Kevin O'Connor
On Fri, Nov 20, 2009 at 02:08:03PM -0500, Kevin O'Connor wrote: On Fri, Nov 20, 2009 at 01:03:51PM -0500, Kevin O'Connor wrote: I've looked into this, and it looks like the cdrom is left in an odd state. At this point, I think SeaBIOS is tickling a bug outside of seabios (eg, in Vista

SeaBIOS mailing list

2009-12-14 Thread Kevin O'Connor
There is now a mailing list for discussions on SeaBIOS. To join the mailing list, please visit: http://www.seabios.org/mailman/listinfo/seabios Mails can be sent to seab...@seabios.org. To reduce spam, non-member posts to the list will be moderated. -Kevin -- To unsubscribe from this list:

Re: SeaBIOS mailing list

2009-12-15 Thread Kevin O'Connor
On Tue, Dec 15, 2009 at 11:30:36AM +0200, Gleb Natapov wrote: On Mon, Dec 14, 2009 at 10:48:49PM -0500, Kevin O'Connor wrote: There is now a mailing list for discussions on SeaBIOS. To join the mailing list, please visit: http://www.seabios.org/mailman/listinfo/seabios Mails can

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Kevin O'Connor
Thanks Gleb. On Wed, Dec 23, 2009 at 05:29:25PM +0200, Gleb Natapov wrote: - + sizeof(struct mpt_intsrc) * 18); + + sizeof(struct mpt_intsrc) * 34); [...] +foreachpci(bdf, max) { +int pin = pci_config_readb(bdf, PCI_INTERRUPT_PIN); +int

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2009 at 08:45:07PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 01:11:43PM -0500, Kevin O'Connor wrote: Why only increase the allocated storage for intsrc by 16? The loop above seems like it could add a large number of entries. Unfortunately we have to allocate all

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2009 at 09:56:23PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 02:48:24PM -0500, Kevin O'Connor wrote: On Wed, Dec 23, 2009 at 08:45:07PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 01:11:43PM -0500, Kevin O'Connor wrote: Why only increase the allocated

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2009 at 10:35:55PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 03:26:55PM -0500, Kevin O'Connor wrote: BTW, this is only intended for PCI bus zero entries, right? (In theory, one could map a card with a bridge into kvm..) Mptable should have description for each

Re: [PATCHv2] provide correct pci routing information in mptable

2009-12-24 Thread Kevin O'Connor
On Thu, Dec 24, 2009 at 02:29:43PM +0200, Gleb Natapov wrote: OpenBSD uses irq routing from mptable, but doesn't create it correctly for PCI bus. This patch adds PCI routing info into mptable. Thanks - commit 928d4dff. -Kevin -- To unsubscribe from this list: send the line unsubscribe kvm in

Re: [kvm] Re: [PATCH 0/5] bios: 4G updates

2008-10-12 Thread Kevin O'Connor
Hi, On Thu, Oct 02, 2008 at 03:33:58PM +0300, Avi Kivity wrote: Alex Williamson wrote: It works, so I pushed it out. Alex, can you rebase your bios patches on top of current HEAD? I updated and resent the first patch in the 4 patch follow-on to this one. The remaining 3 patches

Re: [kvm] Re: [PATCH 0/5] bios: 4G updates

2008-10-14 Thread Kevin O'Connor
On Tue, Oct 14, 2008 at 05:29:12PM +0200, Avi Kivity wrote: As an aside, is there any interest in using SeaBIOS with kvm? There is a great interest. I just don't know time frame for this. Avi? I'd like the seabios repository to be a git submodule, so we don't have to

Re: [kvm] Re: [PATCH 0/5] bios: 4G updates

2008-10-15 Thread Kevin O'Connor
On Wed, Oct 15, 2008 at 07:46:49PM +0200, Avi Kivity wrote: Kevin O'Connor wrote: There is already code specific to qemu and coreboot. I don't see any issues with having a CONFIG_KVM build option. Most kvm specific patches would actually be fairly generic features that haven't been

Re: [Qemu-devel] [PATCH 0/3] Add BIOS splash image support

2008-12-17 Thread Kevin O'Connor
On Tue, Dec 16, 2008 at 10:06:54PM +0200, Blue Swirl wrote: On 12/16/08, Laurent Vivier laurent.viv...@bull.net wrote: This series of patches adds a nice BIOS startup splash screen. It adds a -splash option allowing to specify the picture file name (a 640x480 (or less) and true color

Re: [PATCH][v2] kvm-userspace: Load PCI option ROMs

2009-01-04 Thread Kevin O'Connor
On Sun, Jan 04, 2009 at 07:28:50PM +0200, Avi Kivity wrote: Leendert van Doorn wrote: Avi wrote: This is worrying as it will cause us to diverge from upstream bochs bios. Yep. I'll create a less invasive patch. I've been looking at SEABIOS which seems a much better alternative but the GPLv3

Alt SeaBIOS SSDT cpu hotplug

2010-07-06 Thread Kevin O'Connor
Hi, I've been playing with the cpu hotplug SSDT changes. Attached is a proposal for an alternative method of adding ACPI support. The idea is to continue to build a dynamic SSDT based on CountCPUs and MaxCountCPUs. The dynamic SSDT entries just call methods in the main DSDT. This is

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-07 Thread Kevin O'Connor
On Wed, Jul 07, 2010 at 01:22:49PM +0300, Gleb Natapov wrote: On Wed, Jul 07, 2010 at 12:57:05AM -0400, Kevin O'Connor wrote: The CPUS package stores references to the Processor objects, and the CPON package stores the state of which cpus are active. With this info, hopefully

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-08 Thread Kevin O'Connor
On Thu, Jul 08, 2010 at 03:54:10PM +0300, Gleb Natapov wrote: On Wed, Jul 07, 2010 at 07:26:07PM -0400, Kevin O'Connor wrote: On Wed, Jul 07, 2010 at 01:22:49PM +0300, Gleb Natapov wrote: On Wed, Jul 07, 2010 at 12:57:05AM -0400, Kevin O'Connor wrote: The CPUS package stores references

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-08 Thread Kevin O'Connor
On Thu, Jul 08, 2010 at 09:19:13PM +0800, Liu, Jinsong wrote: Avi Kivity wrote: Very nice. I thought about doing this but abandoned it as unmaintainable. Using external functions and the ID variable, however, reduces the mess to tolerable proportions, and gains us a lot of flexibility.

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-11 Thread Kevin O'Connor
On Sat, Jul 10, 2010 at 12:41:18AM +0800, Liu, Jinsong wrote: Kevin O'Connor wrote: I've tested this under linux - there were a few bugs in the previous patch. I also had to replace the dynamically created CPUS array with a dynamically created NTFY method - which is a bit more complicated

Re: [RFC PATCH v3 0/3] Add segment limit checks to emulator

2010-07-24 Thread Kevin O'Connor
On Mon, Jul 12, 2010 at 04:13:06PM +0300, Avi Kivity wrote: Does SeaBIOS use big real mode now? SeaBIOS calls option roms in big real mode. This is required by the relevant specs. See the transition16big function in src/romlayout.S. It briefly jumps to an address at 0xffxxx during the

Re: [RFC PATCH v3 0/3] Add segment limit checks to emulator

2010-07-24 Thread Kevin O'Connor
On Sat, Jul 24, 2010 at 11:45:22AM -0400, Kevin O'Connor wrote: On Mon, Jul 12, 2010 at 04:13:06PM +0300, Avi Kivity wrote: Does SeaBIOS use big real mode now? SeaBIOS calls option roms in big real mode. This is required by the relevant specs. See the transition16big function in src

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-24 Thread Kevin O'Connor
On Sat, Jul 10, 2010 at 12:41:18AM +0800, Liu, Jinsong wrote: Kevin O'Connor wrote: On Thu, Jul 08, 2010 at 09:19:13PM +0800, Liu, Jinsong wrote: Avi Kivity wrote: Very nice. I thought about doing this but abandoned it as unmaintainable. Using external functions and the ID variable

Re: [RFC PATCH v3 0/3] Add segment limit checks to emulator

2010-07-25 Thread Kevin O'Connor
On Sun, Jul 25, 2010 at 11:54:20AM +0300, Avi Kivity wrote: On 07/24/2010 06:45 PM, Kevin O'Connor wrote: On Mon, Jul 12, 2010 at 04:13:06PM +0300, Avi Kivity wrote: Does SeaBIOS use big real mode now? SeaBIOS calls option roms in big real mode. This is required by the relevant specs

Re: [RFC PATCH v3 0/3] Add segment limit checks to emulator

2010-07-25 Thread Kevin O'Connor
On Sun, Jul 25, 2010 at 11:55:47AM +0300, Avi Kivity wrote: On 07/24/2010 07:16 PM, Kevin O'Connor wrote: On Sat, Jul 24, 2010 at 11:45:22AM -0400, Kevin O'Connor wrote: On Mon, Jul 12, 2010 at 04:13:06PM +0300, Avi Kivity wrote: Does SeaBIOS use big real mode now? SeaBIOS calls option roms

Re: [RFC PATCH v3 0/3] Add segment limit checks to emulator

2010-07-25 Thread Kevin O'Connor
On Sun, Jul 25, 2010 at 12:42:46PM -0400, Kevin O'Connor wrote: On Sun, Jul 25, 2010 at 11:55:47AM +0300, Avi Kivity wrote: What conditions are needed to trigger this path? This can't occur under normal operation, since it will fail badly with kvm on Intel. It's called on every boot

Re: [RFC PATCH v3 0/3] Add segment limit checks to emulator

2010-07-25 Thread Kevin O'Connor
On Sun, Jul 25, 2010 at 09:34:38PM +0300, Avi Kivity wrote: On 07/25/2010 08:19 PM, Kevin O'Connor wrote: Only the ljmpw is in big real mode with a code address64K - the Disable protected mode code is technically in 16bit protected mode. I'm not sure if that helps explain why it works

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-30 Thread Kevin O'Connor
On Sat, Jul 31, 2010 at 01:22:59AM +0800, Liu, Jinsong wrote: Liu, Jinsong wrote: Kevin O'Connor wrote: On Sat, Jul 10, 2010 at 12:41:18AM +0800, Liu, Jinsong wrote: Kevin O'Connor wrote: I've tested this under linux - there were a few bugs in the previous patch. I also had to replace

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-01 Thread Kevin O'Connor
On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong wrote: Kevin, This patch still has issue, It can boot Windows 2008 DataCenter, however, when run cpu_set cpu online command, windows 2008 Datacenter system shutdown at once. Thanks for testing. I've inspected the generated DSDT and

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-02 Thread Kevin O'Connor
On Mon, Aug 02, 2010 at 10:12:31AM +0200, Alexander Graf wrote: On 02.08.2010, at 07:49, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong wrote: It seems the Windows acpi interpreter is significantly different from the Linux one. The only guess I have

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-03 Thread Kevin O'Connor
On Tue, Aug 03, 2010 at 05:00:49PM +0800, Liu, Jinsong wrote: I just test your new patch with Windows 2008 DataCenter at my platform, it works OK! We can hot-add new cpus and they appear at Device Manager. (BTW, yesterday I test your new patch with linux 2.6.32 hvm, it works fine, we can

Re: [Qemu-devel] Anyone seeing huge slowdown launching qemu with Linux 2.6.35?

2010-08-04 Thread Kevin O'Connor
On Wed, Aug 04, 2010 at 06:01:54PM +0300, Gleb Natapov wrote: On Wed, Aug 04, 2010 at 09:50:55AM -0500, Anthony Liguori wrote: On 08/04/2010 09:38 AM, Gleb Natapov wrote: ROM does not muck with the e820. It uses PMM to allocate memory and the memory it gets is marked as reserved in e820

Re: [Qemu-devel] Anyone seeing huge slowdown launching qemu with Linux 2.6.35?

2010-08-04 Thread Kevin O'Connor
On Wed, Aug 04, 2010 at 06:25:52PM +0300, Gleb Natapov wrote: On Wed, Aug 04, 2010 at 09:57:17AM -0500, Anthony Liguori wrote: There are better ways like using string I/O and optimizing the PIO path in the kernel. That should cut down the 1s slow down with a 100MB initrd by a bit. But

Re: [PATCH 2/2] AMD IOMMU support

2010-08-17 Thread Kevin O'Connor
On Sun, Aug 15, 2010 at 10:57:27PM +0300, Eduard - Gabriel Munteanu wrote: This initializes the AMD IOMMU and creates ACPI tables for it. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro There's some questions with how best to create ACPI tables in SeaBIOS/qemu. Can you

[SeaBIOS] [PATCH] Make MTRR region 0xc0000-0x100000 be cached.

2010-01-01 Thread Kevin O'Connor
The current MTRR code in SeaBIOS uses uncached ram for 0xc-0x10. This seems overly pessimistic as write protect should be sufficient. (Note, a WP mtrr does not prevent writes - it is a caching strategy for memory that can be read-only.) I'm not sure how much KVM really uses the MTRRs,

Re: [PATCH] Seabios - read e820 reserve from qemu_cfg

2010-01-25 Thread Kevin O'Connor
On Mon, Jan 25, 2010 at 05:46:42PM +0100, Jes Sorensen wrote: Hi, Right now KVM/QEMU relies on hard coded values in Seabios for the reserved area for the TSS pages and the EPT page. I'd like to suggest we change this to pass the value from QEMU via qemu-cfg making it possible to move it

Re: [PATCH] Seabios - read e820 table from qemu_cfg

2010-01-29 Thread Kevin O'Connor
On Fri, Jan 29, 2010 at 10:03:55AM +0100, Jes Sorensen wrote: On 01/28/10 05:39, Kevin O'Connor wrote: The advantage being that it should be possible to write one set of helper functions in both qemu and seabios that can then be used to pass arbitrary content. The only issue here is that I

Re: [PATCH] Seabios - read e820 table from qemu_cfg

2010-02-13 Thread Kevin O'Connor
On Mon, Feb 08, 2010 at 11:31:40AM +0100, Jes Sorensen wrote: On 01/28/10 05:39, Kevin O'Connor wrote: As a side note, it should probably do the e820 map check even for qemu users (ie, not just kvm). Hi Kevin, Here is an updated version of the patch which does the e820 read

Re: [PATCH 1/2] qemu-kvm: extboot: Keep variables in RAM

2010-02-19 Thread Kevin O'Connor
On Fri, Feb 19, 2010 at 11:37:04AM -0800, H. Peter Anvin wrote: On 02/19/2010 10:17 AM, Jan Kiszka wrote: Stefan posted a virtio-blk driver for gPXE. I like this approach because it's generally useful (gPXE can be used with any BIOS). Does it allow a unified boot device selection,

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-03 Thread Kevin O'Connor
On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: The regression seems to be caused by seabios commit d7e998f. Kevin, the failure can be seen on the attached screenshot, which happens on the first reboot of WinXP 32 installation (after copying files etc). Sorry - I also noticed

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-05 Thread Kevin O'Connor
On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote: On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: The regression seems to be caused by seabios commit d7e998f. Kevin, the failure can be seen

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Kevin O'Connor
On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: +/* + * This function returns device list as an array in a below format: + * +-+-+---+-+---+-- + * | n | l1 | devpath1| l2 | devpath2 | ... + *

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Kevin O'Connor
On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: Why not just return a newline separated list that is null terminated? Doing it like this will needlessly complicate firmware side. How do you know how much memory

Re: seabios 0.6.1 regression

2010-11-15 Thread Kevin O'Connor
On Mon, Nov 15, 2010 at 06:09:45PM +0200, Avi Kivity wrote: On 11/15/2010 05:49 PM, Avi Kivity wrote: On 11/15/2010 05:41 PM, Avi Kivity wrote: I think it's a miscompile. out/code16.o: 1a4: 3e ds 1a5: 6c insb (%dx),%es:(%edi) Note no

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Kevin O'Connor
On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: Why not just return a newline

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-19 Thread Kevin O'Connor
On Tue, Nov 16, 2010 at 09:22:45AM +0200, Gleb Natapov wrote: On Mon, Nov 15, 2010 at 09:52:19PM -0500, Kevin O'Connor wrote: I also have an ulterior motive here. If the boot order is exposed as a newline separated list via an entry in QEMU_CFG_FILE_DIR, then this becomes free for coreboot

Re: [PATCHv6 00/16] boot order specification

2010-11-23 Thread Kevin O'Connor
Hi Gleb, On Tue, Nov 23, 2010 at 05:31:41PM +0200, Gleb Natapov wrote: Anthony, Blue No comments on this patch series for almost a week. Can it be applied? My apologies - I haven't had time to review. On Wed, Nov 17, 2010 at 06:43:47PM +0200, Gleb Natapov wrote: I am using open firmware

Re: [PATCHv6 00/16] boot order specification

2010-11-27 Thread Kevin O'Connor
On Wed, Nov 24, 2010 at 12:03:11PM +0200, Gleb Natapov wrote: On Tue, Nov 23, 2010 at 08:19:07PM -0500, Kevin O'Connor wrote: On Tue, Nov 23, 2010 at 05:31:41PM +0200, Gleb Natapov wrote: On Wed, Nov 17, 2010 at 06:43:47PM +0200, Gleb Natapov wrote: I am using open firmware naming scheme

Re: [PATCHv6 00/16] boot order specification

2010-11-27 Thread Kevin O'Connor
On Sat, Nov 27, 2010 at 06:22:16PM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 10:41:10AM -0500, Kevin O'Connor wrote: On Wed, Nov 24, 2010 at 12:03:11PM +0200, Gleb Natapov wrote: BEV should be easy. When you register BEV found on pci card you search for device path to that pci

Re: [PATCHv6 00/16] boot order specification

2010-11-27 Thread Kevin O'Connor
On Sat, Nov 27, 2010 at 07:06:19PM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 11:49:39AM -0500, Kevin O'Connor wrote: On Sat, Nov 27, 2010 at 06:22:16PM +0200, Gleb Natapov wrote: Yeah. I looked at the Seabios code. The simplest would be to change device path to point to rom

Re: [PATCHv6 00/16] boot order specification

2010-11-27 Thread Kevin O'Connor
On Sat, Nov 27, 2010 at 08:15:42PM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 12:47:26PM -0500, Kevin O'Connor wrote: I don't think seabios should try to parse the path. Instead, I think seabios should build a name for each device it finds using the same algorithm that qemu uses

Re: [PATCHv6 00/16] boot order specification

2010-11-27 Thread Kevin O'Connor
Trimming CC list, adding seabios list. On Sat, Nov 27, 2010 at 09:04:24PM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 01:40:12PM -0500, Kevin O'Connor wrote: On Sat, Nov 27, 2010 at 08:15:42PM +0200, Gleb Natapov wrote: Qemu does not know that Seabios needs optionrom to boot from

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Kevin O'Connor
On Sun, Nov 28, 2010 at 09:45:34AM +0200, Gleb Natapov wrote: On Sat, Nov 27, 2010 at 04:07:45PM -0500, Kevin O'Connor wrote: On Sat, Nov 27, 2010 at 09:04:24PM +0200, Gleb Natapov wrote: Suppose we add SCSI support to Seabios and suppose SCSI card Seabios can natively boot from has

Re: [PATCHv6 00/16] boot order specification

2010-11-29 Thread Kevin O'Connor
On Sun, Nov 28, 2010 at 08:47:34PM +0200, Gleb Natapov wrote: On Sun, Nov 28, 2010 at 12:15:44PM -0500, Kevin O'Connor wrote: It's unclear to me how SeaBIOS is supposed to do that. Suppose we have /p...@i0cf8/s...@3/d...@0,0 with boot index 5 in boot devices list and suppose pci device

Re: [PATCHv6 00/16] boot order specification

2010-11-29 Thread Kevin O'Connor
On Mon, Nov 29, 2010 at 11:50:45AM +0100, Gerd Hoffmann wrote: If scsi card has optionrom with only one bcv then Seabios can determine its boot order from device path, so why not provide user with this option today? It's unclear to me how SeaBIOS is supposed to do that. Try to keep track of

Re: [PATCHv6 00/16] boot order specification

2010-11-30 Thread Kevin O'Connor
On Tue, Nov 30, 2010 at 04:01:00PM +0200, Gleb Natapov wrote: On Mon, Nov 29, 2010 at 08:34:03PM -0500, Kevin O'Connor wrote: On Sun, Nov 28, 2010 at 08:47:34PM +0200, Gleb Natapov wrote: If you let go to the idea of exact matching of string built by qemu in Seabios it will be easy to see

Re: [PATCHv6 00/16] boot order specification

2010-12-01 Thread Kevin O'Connor
On Wed, Dec 01, 2010 at 02:27:40PM +0200, Gleb Natapov wrote: On Tue, Nov 30, 2010 at 09:53:32PM -0500, Kevin O'Connor wrote: BTW, what's the plan for handling SCSI adapters? Lets say a user has a scsi card with three drives (lun 1, lun 3, lun 5) that show up as 3 bcvs (lun1, lun3, lun5

Re: [PATCHv6 00/16] boot order specification

2010-12-02 Thread Kevin O'Connor
On Thu, Dec 02, 2010 at 02:30:42PM +0200, Gleb Natapov wrote: On Wed, Dec 01, 2010 at 09:25:40PM -0500, Kevin O'Connor wrote: You're thinking in terms of which device to boot, which does make this difficult. However, it's equally valid to think in terms of which boot method to invoke

Re: USB Passthrough 1.1 performance problem...

2010-12-31 Thread Kevin O'Connor
On Tue, Dec 14, 2010 at 12:02:03PM +0200, Avi Kivity wrote: That could certainly be optimized. If the BAR is all along in its page, both on guest and host (if not, we can migrate it, at least on the host), we can use the same offset within the page on the host as it appears on the guest, and

Re: [PATCH 1/4] pci: expand tabs to spaces in pci_ids.h and pci_regs.h

2010-09-02 Thread Kevin O'Connor
On Sat, Aug 28, 2010 at 06:02:55PM +0300, Eduard - Gabriel Munteanu wrote: The conversion was done using the GNU 'expand' tool (default settings) to make it obey the SeaBIOS coding style. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Thanks Eduard. Patch 1 - I don't

Re: cpu hotplug

2010-09-19 Thread Kevin O'Connor
On Sun, Sep 19, 2010 at 08:38:12AM +0200, Gleb Natapov wrote: On Sat, Sep 18, 2010 at 08:27:54PM +0200, Conrad Wood wrote: hm... after upgrading to seabios 0.6.1 and qemu-kvm 0.13.50 (git today) I get: [...] any ideas ? Known problem in qemu. There was a patch for this, but qemu

Re: cpu hotplug

2010-09-19 Thread Kevin O'Connor
On Sun, Sep 19, 2010 at 03:29:35PM +0200, Conrad Wood wrote: On Sun, 2010-09-19 at 09:26 -0400, Kevin O'Connor wrote: On Sun, Sep 19, 2010 at 08:38:12AM +0200, Gleb Natapov wrote: Known problem in qemu. There was a patch for this, but qemu maintainers think it is not good enough. Old

Re: cpu hotplug

2010-09-19 Thread Kevin O'Connor
On Sun, Sep 19, 2010 at 03:40:45PM +0200, Gleb Natapov wrote: halted state is not the way to check for whether cpu is online or offline. cpu may be online but executing hlt instruction so its state will be halted, but cpu itself is online. Actually with kvm today you are not able to check

Re: cpu hotplug

2010-09-19 Thread Kevin O'Connor
On Sun, Sep 19, 2010 at 04:07:50PM +0200, Conrad Wood wrote: 1) Thanks for clarifying online vs halted - that makes sense and is probably part of what confused me. I need to get the online/offline status of cpus, not if they are halted or not. I understand this is currently not possible with

Re: cpu hotplug

2010-09-19 Thread Kevin O'Connor
On Sun, Sep 19, 2010 at 05:53:47PM +0200, Gleb Natapov wrote: On Sun, Sep 19, 2010 at 05:44:00PM +0200, Conrad Wood wrote: However after step 7 the guest can turn the cpu online again by issuing echo 1 /sys/devices/.../cpuX/online There will be no /sys/devices/.../cpuX/online in

Re: cpu hotplug

2010-09-19 Thread Kevin O'Connor
On Sun, Sep 19, 2010 at 06:24:33PM +0200, Conrad Wood wrote: a script with my exact steps is below. Result is reproducible. [...] echo Ejecting CPU #4 echo cpu_set 4 offline | nc ${MONITORHOST} ${MONITORPORT} /dev/null printInfo echo Setting all available cpus to online... ssh -lroot

Re: cpu hotplug

2010-09-19 Thread Kevin O'Connor
On Sun, Sep 19, 2010 at 06:12:14PM +0200, Gleb Natapov wrote: On Sun, Sep 19, 2010 at 12:04:51PM -0400, Kevin O'Connor wrote: I'm confused. The cpu_set x offline doesn't appear to do anything for me. It does not disable the cpu, nor does it inform the guest to disable the cpu

Re: cpu hotplug

2010-09-20 Thread Kevin O'Connor
On Mon, Sep 20, 2010 at 08:50:17AM +0200, Gleb Natapov wrote: On Sun, Sep 19, 2010 at 06:03:31PM -0400, Kevin O'Connor wrote: I was wrong. The cpu_set x offline does send an event to the guest OS. SeaBIOS even forwards the event along - as far as I can tell a Notify(CPxx, 3) event

Re: [PATCH] support piix PAM registers in KVM

2010-09-25 Thread Kevin O'Connor
On Tue, Sep 21, 2010 at 04:06:01PM -0300, Marcelo Tosatti wrote: On Tue, Sep 21, 2010 at 02:31:42PM +0200, Gleb Natapov wrote: Without this BIOS fails to remap 0xf memory from ROM to RAM so writes to F-segment modify ROM content instead of memory copy. Since QEMU does not reloads ROMs

Re: system_powerdown not working for qemu-kvm 0.12.4?

2010-10-12 Thread Kevin O'Connor
On Tue, Oct 12, 2010 at 08:49:58AM +0200, Avi Kivity wrote: On 10/11/2010 07:53 PM, Ruben Kerkhof wrote: 5c99b6c984682ddb1d4543a7e27a1f4ca633e6a6 is the first bad commit commit 5c99b6c984682ddb1d4543a7e27a1f4ca633e6a6 Author: Kevin O'Connorke...@koconnor.net Gleb, Kevin, any ideas?

Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT

2010-10-23 Thread Kevin O'Connor
On Thu, Oct 21, 2010 at 12:07:17PM +0200, Avi Kivity wrote: How do we manage the stable series wrt this issue? qemu-kvm-0.12.5 has a regression within the stable series that this patch fixes. qemu 0.12.5 does not, but only because it does not emulate polarity in the I/O APIC correctly.

Re: [PATCHv2 0/8 RFC] boot order specification

2010-10-31 Thread Kevin O'Connor
On Sun, Oct 31, 2010 at 01:40:01PM +0200, Gleb Natapov wrote: This is current sate of the patch series for people to comment on. I tried to use open firmware naming scheme to specify device path names. The patch series produce names like these: for pci machine:

Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT

2010-10-31 Thread Kevin O'Connor
On Wed, Oct 27, 2010 at 03:27:58PM +0200, Avi Kivity wrote: On the last kvm conf call Anthony said that he'll be happy to include an updated seabios with qemu 0.13.1, so a new release would be appreciated. I branched and tagged rel-0.6.1.1. It only has 6d5a2172 cherry-picked into it. -Kevin

Re: [PATCH] seabios/pci: enable 64 bit bar on seabios

2012-11-02 Thread Kevin O'Connor
On Fri, Nov 02, 2012 at 01:42:08PM +0800, Xudong Hao wrote: 64 bit bar sizing and MMIO allocation. The 64 bit window is placed above high memory, top down from the end of guest physical address space. Your patch seems to be against an old version of SeaBIOS. The latest SeaBIOS already supports

Re: KVM cpu limitations

2011-08-09 Thread Kevin O'Connor
On Tue, Aug 09, 2011 at 02:32:02PM -0400, John Paul Walters wrote: I've enabled debugging in seabios (#define DEBUG_BIOS) and get the output below. Note that with the help of folks in the KVM irc channel I'm able to start a 254 core instance using the KVM tool, so the problem seems to be

Re: HPET configuration in Seabios (was: Re: windows workload: many ept_violation and mmio exits)

2011-08-28 Thread Kevin O'Connor
On Sun, Aug 28, 2011 at 10:42:49PM +0200, Jan Kiszka wrote: On 2011-08-28 20:54, Alexander Graf wrote: On 28.08.2011, at 02:42, Avi Kivity wrote: On 08/26/2011 08:32 AM, ya su wrote: hi,Avi: I met the same problem, tons of hpet vm_exits(vector 209, fault address is in the

Re: [PATCH] add acpi pmtimer support

2012-08-13 Thread Kevin O'Connor
On Mon, Aug 13, 2012 at 03:04:10PM +0200, Gerd Hoffmann wrote: This patch makes seabios use the acpi pmtimer instead of tsc for timekeeping. The pmtimer has a fixed frequency and doesn't need calibration, thus it doesn't suffer from calibration errors due to a loaded host machine. It looks

Re: [Qemu-devel] Big real mode use in ipxe

2012-08-19 Thread Kevin O'Connor
On Sun, Aug 19, 2012 at 06:07:05PM +0300, Avi Kivity wrote: ipxe contains the following snippet: /* Copy ROM to image source PMM block */ pushw %es xorw%ax, %ax movw%ax, %es movl%esi, %edi xorl%esi, %esi movzbl romheader_size,

Re: [Qemu-devel] [ipxe-devel] Big real mode use in ipxe

2012-08-19 Thread Kevin O'Connor
On Sun, Aug 19, 2012 at 04:34:50PM +0100, Michael Brown wrote: On Sunday 19 Aug 2012 16:07:05 Avi Kivity wrote: (and that seabios needs changes to either work in big real mode, or to put the processor back into big real mode after returning from a PMM service. If seabios switches into

Re: [PATCH v2] add acpi pmtimer support

2012-09-02 Thread Kevin O'Connor
On Tue, Aug 14, 2012 at 07:29:19AM +0200, Gerd Hoffmann wrote: This patch makes seabios use the acpi pmtimer instead of tsc for timekeeping. The pmtimer has a fixed frequency and doesn't need calibration, thus it doesn't suffer from calibration errors due to a loaded host machine. The patch

Re: [SeaBIOS] [PATCH v3] add acpi pmtimer support

2012-09-05 Thread Kevin O'Connor
On Wed, Sep 05, 2012 at 07:28:15AM +0200, Gerd Hoffmann wrote: This patch makes seabios use the acpi pmtimer instead of tsc for timekeeping. The pmtimer has a fixed frequency and doesn't need calibration, thus it doesn't suffer from calibration errors due to a loaded host machine. [ v3:

Re: [PATCH 3/3] support readonly memory feature in qemu

2012-09-10 Thread Kevin O'Connor
On Mon, Sep 10, 2012 at 11:25:38AM +0200, Jan Kiszka wrote: On 2012-09-09 17:45, Avi Kivity wrote: On 09/07/2012 11:50 AM, Jan Kiszka wrote: +} else { +cpu_physical_memory_rw(run-mmio.phys_addr, + run-mmio.data, +

Re: [PATCH 3/3] support readonly memory feature in qemu

2012-09-11 Thread Kevin O'Connor
On Tue, Sep 11, 2012 at 11:15:50AM -0500, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-11 05:02, Kevin O'Connor wrote: The easiest way to fix this is to change QEMU to boot with the area read-write. There's no real gain in booting with the memory read-only

Re: [SeaBIOS PATCH v3] hotplug: Add device per func in ACPI DSDT tables

2011-12-13 Thread Kevin O'Connor
On Tue, Dec 06, 2011 at 07:32:55PM -0500, Amos Kong wrote: - Original Message - On Tue, Dec 06, 2011 at 01:39:35PM +0800, Amos Kong wrote: Only func 0 is registered to guest driver (we can only found func 0 in slot-funcs list of driver), the other functions could not be cleaned

Re: [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-13 Thread Kevin O'Connor
On Fri, Jan 13, 2012 at 12:11:30PM +0100, Vasilis Liaskovitis wrote: Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com The SeaBIOS change is okay with me, but the qemu/kvm change needs to be accepted first. [...] Method (CPEJ, 2, NotSerialized) {

Re: [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-19 Thread Kevin O'Connor
On Thu, Jan 19, 2012 at 03:02:30PM +0100, Vasilis Liaskovitis wrote: On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote: [...] Method (CPEJ, 2, NotSerialized) { // _EJ0 method - eject callback +Store(ShiftLeft(1, Arg0), PRE

Re: [PATCH RFC] seabios: add OSHP method stub

2012-02-13 Thread Kevin O'Connor
On Mon, Feb 13, 2012 at 11:33:08AM +0200, Michael S. Tsirkin wrote: To allow guests to load the native SHPC driver for a bridge, we must declare an OSHP method for the appropriate device which lets the OS take control of the SHPC. As we don't access SHPC at the moment, we don't need to do

  1   2   >