Am 14.09.2010 17:11, schrieb Anthony Liguori:
On 09/14/2010 09:47 AM, Chris Wright wrote:
0.13
- if all goes well...tomorrow
To tag, it may be thursday for announcement. I need to run a regression
run tonight.
qed/qcow2
- increase concurrency, performance
To achieve
Am 15.09.2010 14:26, schrieb Anthony Liguori:
On 09/15/2010 03:30 AM, Kevin Wolf wrote:
Am 14.09.2010 17:11, schrieb Anthony Liguori:
On 09/14/2010 09:47 AM, Chris Wright wrote:
0.13
- if all goes well...tomorrow
To tag, it may be thursday for announcement. I need
Am 15.09.2010 15:21, schrieb Anthony Liguori:
On 09/15/2010 07:38 AM, Kevin Wolf wrote:
No, we don't really care if the L2 entry is on disk. If the guest want
to have its data safe it needs to issue an explicit flush anyway. The
only thing we want to achieve with bdrv_write_sync is to maintain
Am 15.09.2010 15:52, schrieb Anthony Liguori:
On 09/15/2010 08:30 AM, Kevin Wolf wrote:
Am 15.09.2010 15:21, schrieb Anthony Liguori:
On 09/15/2010 07:38 AM, Kevin Wolf wrote:
No, we don't really care if the L2 entry is on disk. If the guest want
to have its data safe it needs
Am 30.09.2010 07:07, schrieb Nicholas A. Bellinger:
From: Nicholas Bellinger n...@linux-iscsi.org
Greetings Paul, Jan, Kevin and co,
This series is against my v0.12.5 qemu-kvm.git that contains QEMU SCSI layer
SGL passthrough from Gerd Hoffman, 8708EM2 MegaSas emulation from Dr. Hannes
Am 23.09.2010 04:21, schrieb Yehuda Sadeh Weinraub:
Following up on this one, I'd like to know whether there is any
pending issue preventing rbd from being included upstream.
Basically for me the only problem at the moment is a lack of reviews. If
nobody else picks it up, I'll get to it
Am 19.10.2010 19:09, schrieb Anthony Liguori:
On 10/19/2010 11:54 AM, Ayal Baron wrote:
- Anthony Liguorianth...@codemonkey.ws wrote:
On 10/19/2010 07:48 AM, Dor Laor wrote:
On 10/19/2010 04:11 AM, Chris Wright wrote:
* Juan Quintela (quint...@redhat.com) wrote:
Am 26.10.2010 15:23, schrieb Stefan Hajnoczi:
When an image is created with -o preallocate, ensure that we only call
preallocate() if the image was indeed opened successfully. Also use
bdrv_delete() instead of bdrv_close() to avoid leaking the
BlockDriverState structure.
This fixes the
Am 11.12.2012 15:45, schrieb Juan Quintela:
Anthony Liguori aligu...@us.ibm.com wrote:
Kevin Wolf kw...@redhat.com writes:
Am 10.12.2012 14:59, schrieb Juan Quintela:
Hi
Please send in any agenda topics you are interested in.
Can probably be answered on the list, but what is the status
Am 29.06.2011 16:25, schrieb Johannes Stezenbach:
On Linux x86_64 host with 32bit userspace, running
qemu or even just qemu-img create -f qcow2 some.img 1G
causes a kernel warning:
ioctl32(qemu-img:5296): Unknown cmd fd(3) cmd(5326){t:'S';sz:0}
arg(7fff) on some.img
Am 30.06.2011 13:48, schrieb Stefan Hajnoczi:
On Wed, Jun 29, 2011 at 4:41 PM, Marcelo Tosatti mtosa...@redhat.com wrote:
On Wed, Jun 29, 2011 at 11:08:23AM +0100, Stefan Hajnoczi wrote:
In the future we could add a 'base' argument to block_stream. If base
is specified then data contained in
Am 30.06.2011 16:36, schrieb Marcelo Tosatti:
4. Live block copy API and high-level control - the main code that
adds the live block copy feature. Existing patches by Marcelo, can be
restructured to use common core by Marcelo.
Can use your proposed block_stream interface, with a
Am 05.07.2011 16:32, schrieb Marcelo Tosatti:
On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote:
On 07/05/2011 03:58 PM, Marcelo Tosatti wrote:
On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote:
On Tue, Jul 5, 2011 at 9:01 AM, Dor Laordl...@redhat.com wrote:
I tried to
Am 05.07.2011 20:18, schrieb Marcelo Tosatti:
On Tue, Jul 05, 2011 at 04:37:08PM +0100, Stefan Hajnoczi wrote:
On Tue, Jul 5, 2011 at 3:32 PM, Marcelo Tosatti mtosa...@redhat.com wrote:
On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote:
On 07/05/2011 03:58 PM, Marcelo Tosatti wrote:
On
Am 06.07.2011 12:39, schrieb Stefan Hajnoczi:
On Wed, Jul 6, 2011 at 10:15 AM, Kaushal Shriyan
kaushalshri...@gmail.com wrote:
Is there a way to resize the Hard Disk of VM ?
You can use qemu-img resize on a disk image that is currently not in use:
qemu-img resize filename +10G
For running
Am 10.07.2011 20:08, schrieb Pekka Enberg:
Hi Ingo,
* Pekka Enberg penb...@kernel.org wrote:
This series fixes QCOW locking issues and implements delayed metadata
writeout.
This improves performance of writeout to QCOW2 images that don't have
clusters
and L2 tables allocated on-disk.
Am 11.07.2011 11:41, schrieb Pekka Enberg:
Hi Kevin,
On Mon, Jul 11, 2011 at 12:31 PM, Kevin Wolf kw...@redhat.com wrote:
I would love to try out your code occasionally myself, but so far I have
been to lazy to build a guest kernel only to be able to test it. Having
to deal with the huge
Am 11.07.2011 15:34, schrieb Stefan Hajnoczi:
On Mon, Jul 11, 2011 at 2:02 PM, Hannes Reinecke h...@suse.de wrote:
Hi all,
these are some fixes I found during debugging my megasas HBA emulation.
This time I've sent them as a separate patchset for inclusion.
All of them have been acked, so
Am 11.07.2011 15:02, schrieb Hannes Reinecke:
Hi all,
these are some fixes I found during debugging my megasas HBA emulation.
This time I've sent them as a separate patchset for inclusion.
All of them have been acked, so please apply.
Hannes Reinecke (4):
iov: Update parameter usage in
Am 19.07.2011 08:31, schrieb Hannes Reinecke:
On 07/12/2011 03:37 PM, Kevin Wolf wrote:
Am 11.07.2011 15:02, schrieb Hannes Reinecke:
Hi all,
these are some fixes I found during debugging my megasas HBA emulation.
This time I've sent them as a separate patchset for inclusion.
All of them
Am 22.07.2011 10:21, schrieb Pekka Enberg:
On Thu, 21 Jul 2011, Kevin Wolf wrote:
Hm, I must have missed this patch on the KVM mailing list...
It wasn't on the list, sorry.
You should also error out before creating a new L2 table as its refcount
would have to be updated, too. On the other
referenced
clusters with zero reference count after
dd if=/dev/zero of=/mnt/tmp
where '/mnt' is freshly generated QCOW2 image.
Cc: Asias He asias.he...@gmail.com
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: Kevin Wolf kw...@redhat.com
Cc: Prasad Joshi
Am 25.07.2011 10:30, schrieb Pekka Enberg:
Hi Alexander,
On Mon, Jul 25, 2011 at 11:14 AM, Alexander Graf ag...@suse.de wrote:
So i wanted to have a lightweight tool that allows me to test KVM and
tools/kvm/ does that very nicely: i type './kvm run' and i can test a
native bzImage (which
Am 22.07.2011 16:51, schrieb Hannes Reinecke:
Not every command is support for any device type. This patch adds
a check for rejecting unsupported commands.
Signed-off-by: Hannes Reinecke h...@suse.de
---
hw/scsi-disk.c | 104
+++-
1
Am 22.07.2011 16:51, schrieb Hannes Reinecke:
Not every command is support for any device type. This patch adds
a check for rejecting unsupported commands.
Signed-off-by: Hannes Reinecke h...@suse.de
We do emulate SEEK (6), but it's not in your scsi_cmd_table at all.
---
hw/scsi-disk.c |
Am 22.07.2011 16:51, schrieb Hannes Reinecke:
Markus Armbruster pointed out that not every SCSI command is supported
for a given device type. Based on his patch and suggestiongs this series
cleans up the SCSI device type and adds a check for supported commands.
Hannes Reinecke (6):
Am 04.08.2011 16:20, schrieb Philipp Hahn:
Hello,
it seems like I have discovered a bug in qemu-0.14.1 which corrupts Qcow2
image files when using internal snapshots.
I tied this both on an amd64 host running our Debian bases UCS distribution
(using pure qemu-kvm_0.14 and pure
Am 08.08.2011 15:00, schrieb Anthony Liguori:
On 08/08/2011 07:56 AM, Avi Kivity wrote:
QEMU deals with a lot of fixed width integer types; their names
(uint64_t etc) are clumsy to use and take up a lot of space.
Following Linux, introduce shorter names, for example U64 for
uint64_t.
Am 14.08.2011 06:04, schrieb Avi Kivity:
In certain circumstances, posix-aio-compat can incur a lot of latency:
- threads are created by vcpu threads, so if vcpu affinity is set,
aio threads inherit vcpu affinity. This can cause many aio threads
to compete for one cpu.
- we can
Am 31.08.2011 09:40, schrieb Jan Kiszka:
On 2011-08-31 02:03, Chris Friesen wrote:
Hi,
I've run into another problem. I configured qemu-kvm-0.15.0 as:
./configure --target-list=i386-softmmu,x86_64-softmmu --disable-sdl
--disable-vnc --disable-curses
Building it, I get:
CC
Am 16.09.2012 12:13, schrieb Peter Lieven:
Hi,
when trying to block migrate a VM from one node to another, the source
VM crashed with the following assertion:
block.c:3829: bdrv_set_in_use: Assertion `bs-in_use != in_use' failed.
Is this sth already addresses/known?
Not that I'm aware
Am 18.09.2012 12:28, schrieb Peter Lieven:
On 09/17/12 22:12, Peter Lieven wrote:
On 09/17/12 10:41, Kevin Wolf wrote:
Am 16.09.2012 12:13, schrieb Peter Lieven:
Hi,
when trying to block migrate a VM from one node to another, the source
VM crashed with the following assertion:
block.c:3829
Am 19.09.2012 07:49, schrieb Peter Lieven:
On 09/18/12 12:31, Kevin Wolf wrote:
Am 18.09.2012 12:28, schrieb Peter Lieven:
On 09/17/12 22:12, Peter Lieven wrote:
On 09/17/12 10:41, Kevin Wolf wrote:
Am 16.09.2012 12:13, schrieb Peter Lieven:
Hi,
when trying to block migrate a VM from one
Am 25.09.2012 14:57, schrieb Anthony Liguori:
Paolo Bonzini pbonz...@redhat.com writes:
Il 24/09/2012 13:28, Juan Quintela ha scritto:
Hi
Please send in any agenda items you are interested in covering.
URI parsing library for glusterfs: libxml2 vs. in-tree fork of the
same code.
The
Ram Pai schrieb:
On Thu, 2009-06-25 at 11:14 +0200, Kevin Wolf wrote:
Ram Pai schrieb:
Copying the qemu-devel mailing list too.
On Wed, 2009-06-24 at 09:58 -0700, Ram Pai wrote:
Problem: It is impossible to feed filenames with the character colon
because
qemu interprets such names
Avi Kivity schrieb:
The qcow block driver format is no longer maintained and likely contains
serious data corruptors. Urge users to stay away for it, and advertise
the new and improved replacement.
Signed-off-by: Avi Kivity a...@redhat.com
vvfat is using qcow internally, so the warning
Amit Shah schrieb:
On (Mon) Jun 29 2009 [17:04:49], Avi Kivity wrote:
The qcow block driver format is no longer maintained and likely contains
serious data corruptors. Urge users to stay away for it, and advertise
the new and improved replacement.
Does this also print the message at the
Anthony Liguori schrieb:
Kevin Wolf wrote:
Avi Kivity schrieb:
The qcow block driver format is no longer maintained and likely contains
serious data corruptors. Urge users to stay away for it, and advertise
the new and improved replacement.
Signed-off-by: Avi Kivity a...@redhat.com
Michael S. Tsirkin schrieb:
This fixes segfault reported by Kevin Wolf,
and simplifies the code in msix_save.
Reported-by: Kevin Wolf kw...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
I can confirm that this fixes the segfault for me.
Kevin
--
To unsubscribe from this list
Andreas Färber schrieb:
I'm confused now. Only recently someone stepped up, saying that qcow2
was broken and that qcow should be used instead for safety reasons.
Now all of a sudden, it's the exact opposite, you're even considering
replacing qcow with qcow2 for vvfat and dropping qcow
Ram Pai schrieb:
Problem: It is impossible to feed filenames with the character colon because
qemu interprets such names as a protocol. For example filename scsi:0, is
interpreted as a protocol by name scsi.
This patch allows user to escape colon characters. For example the above
filename
Anthony Liguori schrieb:
Kevin Wolf wrote:
Ram Pai schrieb:
Problem: It is impossible to feed filenames with the character colon because
qemu interprets such names as a protocol. For example filename scsi:0, is
interpreted as a protocol by name scsi.
This patch allows user to escape
Avi Kivity schrieb:
If you're using an old image, it's worthwhile to regenerate it using
'qemu-img convert' to clear any hidden corruption.
Be careful with that. qemu-img convert doesn't retain snapshots, so
you're only converting whatever the guest currently sees. But at least
checking old
Anthony Liguori schrieb:
Jan Kiszka wrote:
Hmm, I must have missed this: Where is your staging tree hosted?
Right now it's at http://repo.or.cz/w/qemu/aliguori-queue.git but I plan
to move it to git.qemu.org in the next few days.
If I'm not mistaken, the patch qemu-io: Implement
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
Jan Kiszka wrote:
Hmm, I must have missed this: Where is your staging tree hosted?
Right now it's at http://repo.or.cz/w/qemu/aliguori-queue.git but I plan
to move it to git.qemu.org in the next few
Christoph Hellwig schrieb:
On Fri, Jul 10, 2009 at 11:59:25AM -0500, Anthony Liguori wrote:
If I'm not mistaken, the patch qemu-io: Implement
bdrv_get_buffer/bdrv_put_buffer is missing from the queue.
I just did a pull a few hours ago from Christoph's qemu-io tree. I'm
expecting qemu-io
Anthony Liguori schrieb:
Blue Swirl wrote:
Then how about something like:
-drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img
-drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img
-drive name=sdb,if=scsi,unit=1,fnarg -fnarg boo.img
The explicit
Ram Pai schrieb:
On Wed, 2009-07-15 at 22:04 +0100, Jamie Lokier wrote:
What an unhelpful error message... There isn't even a way to find out
the backing file path which the tool is looking for.
Ok. i have introduced a message towards the effect, in the next revision
of the patch. Hope
Ram Pai schrieb:
On Wed, 2009-07-15 at 18:04 +0300, Blue Swirl wrote:
On 7/15/09, Ram Pai linux...@us.ibm.com wrote:
Problem: It is impossible to feed filenames with the character colon because
qemu interprets such names as a protocol. For example filename scsi:0, is
interpreted as a
Jamie Lokier schrieb:
Kevin Wolf wrote:
Can we at least allow \, instead of ,, in parameter parsing, so that the
backslash has the practical benefit of being a single universal escape
character?
Is there a good reason why we cannot simply use \char to escape
_any_ character, in every
Ram Pai schrieb:
Problem: It is impossible to feed filenames with the character colon because
qemu interprets such names as a protocol. For example filename scsi:0, is
interpreted as a protocol by name scsi.
This patch allows user to espace colon characters. For example the above
filename
Ram Pai schrieb:
Copying the qemu-devel mailing list too.
On Wed, 2009-06-24 at 09:58 -0700, Ram Pai wrote:
Problem: It is impossible to feed filenames with the character colon because
qemu interprets such names as a protocol. For example a filename scsi:0,
is interpreted as a protocol by
Am 01.06.2012 10:31, schrieb Kevin Wolf:
Am 01.06.2012 09:57, schrieb Ren, Yongjie:
-Original Message-
From: Marcelo Tosatti [mailto:mtosa...@redhat.com]
Sent: Thursday, May 31, 2012 4:28 AM
To: Ren, Yongjie
Cc: Kevin Wolf; Avi Kivity; kvm@vger.kernel.org; Liu, RongrongX
Subject: Re
Am 06.06.2012 15:35, schrieb Iain J. Watson:
Hello,
I am trying to find a way to use backing files to make snapshots of
running VMs. The idea is I pause the VM, use qemu-img to create a new
disk file with the currently used file as a backing file, swap the
images then unpause the VM.
Am 12.06.2012 03:52, schrieb Marcelo Tosatti:
On Thu, Jun 07, 2012 at 01:13:50PM +0100, Stefan Hajnoczi wrote:
The 1st bad commit in your attached list is abc551bd
More detailed info:
171d2f2249a360d7d623130d3aa991418c53716d good
fd453a24166e36a3d376c9bc221e520e3ee425afgood
Am 13.06.2012 12:28, schrieb Ren, Yongjie:
-Original Message-
From: Marcelo Tosatti [mailto:mtosa...@redhat.com]
Sent: Wednesday, June 13, 2012 7:25 AM
To: Kevin Wolf
Cc: Stefan Hajnoczi; Ren, Yongjie; Avi Kivity; kvm@vger.kernel.org; Liu,
RongrongX; Anthony Liguori
Subject: Re
Am 12.06.2012 19:34, schrieb Avi Kivity:
Null SS is valid in long mode; allow loading it.
Signed-off-by: Avi Kivity a...@redhat.com
The documentation suggests that trying to load it in CPL 3 should still
fail in long mode.
Kevin
--
To unsubscribe from this list: send the line unsubscribe kvm
Am 02.07.2012 19:33, schrieb Eric Blake:
On 07/02/2012 04:16 AM, Juan Quintela wrote:
Hi
Please send in any agenda items you are interested in covering.
Can we discuss the future of 'getfd', the possibility of 'pass-fd', or
even the enhancement of all existing monitor commands to take an
Am 03.07.2012 15:20, schrieb Paolo Bonzini:
Introduce a new feature bit and configuration field that provide
support for toggling the cache mode between writethrough and writeback.
Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with
the spec.
My spec (and my kernel as
Am 03.07.2012 15:20, schrieb Paolo Bonzini:
If the guest does not support flushes, we should run in writethrough mode.
The setting is temporary until the next reset, so that for example the
BIOS will run in writethrough mode while Linux will run with a writeback
cache.
VIRTIO_BLK_F_FLUSH
Am 03.07.2012 15:51, schrieb Paolo Bonzini:
Il 03/07/2012 15:49, Kevin Wolf ha scritto:
If the guest does not support flushes, we should run in writethrough mode.
The setting is temporary until the next reset, so that for example the
BIOS will run in writethrough mode while Linux will run
Am 04.07.2012 14:21, schrieb Paolo Bonzini:
Il 04/07/2012 12:16, Kevin Wolf ha scritto:
Yes. It doesn't override cache=unsafe though.
When the guest doesn't support flushes, cache=writeback is equivalent to
cache=unsafe, so if you want the old behaviour back you can switch to
cache=unsafe
Am 16.07.2012 16:25, schrieb Paolo Bonzini:
Linux will not use these, but a very similar mechanism will be used to
report the condition via virtio-scsi events.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/scsi-bus.c |5 +
hw/scsi-disk.c | 15 +++
Am 01.08.2012 17:52, schrieb Paolo Bonzini:
Il 23/07/2012 18:32, Paolo Bonzini ha scritto:
Il 03/07/2012 15:20, Paolo Bonzini ha scritto:
These patches let virtio-blk use the new support for toggling the cache
mode between writethrough and writeback.
The first patch introduces a new feature
Am 13.12.2011 04:41, schrieb lan,Tianyu:
On 一, 2011-12-12 at 19:15 +0800, Kevin Wolf wrote:
Am 12.12.2011 11:58, schrieb Pekka Enberg:
On Mon, 12 Dec 2011, Kevin Wolf wrote:
@@ -667,14 +722,11 @@ static struct qcow_refcount_block
*qcow_read_refcount_block(struct qcow *q, u64
rft_idx
Am 13.12.2011 04:05, schrieb lan,Tianyu:
Thanks for your review.
On 一, 2011-12-12 at 17:55 +0800, Kevin Wolf wrote:
Am 12.12.2011 03:03, schrieb Lan Tianyu:
This patch enables allocating new refcount blocks and so then kvm tools
could expand qcow2 image much larger.
Signed-off-by: Lan
into the reason = TASK_SWITCH_CALL path. I
searched a bit in the documentation, but didn't find any obvious way
to fix this.
* Yes, I've yet to write a nice testcase for kvm-unittests
Signed-off-by: Kevin Wolf kw...@redhat.com
---
arch/x86/kvm/emulate.c | 13 -
1 files changed
Am 10.01.2012 10:01, schrieb Gleb Natapov:
On Mon, Jan 09, 2012 at 09:10:10PM +0100, Kevin Wolf wrote:
* This works with VMX, but with SVM I have an additional problem: When
trying to exit VM86 (usually by an exception) through a task gate in
the IDT, the code runs into the reason
Am 10.01.2012 10:28, schrieb Kevin Wolf:
Am 10.01.2012 10:01, schrieb Gleb Natapov:
On Mon, Jan 09, 2012 at 09:10:10PM +0100, Kevin Wolf wrote:
* This works with VMX, but with SVM I have an additional problem: When
trying to exit VM86 (usually by an exception) through a task gate
Am 10.01.2012 18:51, schrieb Joerg Roedel:
On Tue, Jan 10, 2012 at 01:30:47PM +0200, Gleb Natapov wrote:
On Tue, Jan 10, 2012 at 12:25:18PM +0100, Kevin Wolf wrote:
Did that now, and it looks like exit_int_info is always 0 during the
task switch intercept for a task gate in the IDT. So special
locally for a while,
but maybe someone else finds it handy, too.
Kevin Wolf (4):
Add run_tests.sh
Add taskswitch testcases to unittest.cfg
Fix i386 build
x86/taskswitch_vm86: Task switches into/out of VM86
config-i386.mak |3 +-
lib/x86/desc.c| 39 +-
lib
This adds a convenient way to run all tests without having to set up
Autotest.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
run_tests.sh | 107 ++
1 files changed, 107 insertions(+), 0 deletions(-)
create mode 100755 run_tests.sh
diff
Signed-off-by: Kevin Wolf kw...@redhat.com
---
x86/unittests.cfg | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index 065020a..dac7d44 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -64,6 +64,18 @@ file
Commit 1d946e07 removed idt, but left a reference to idt in i386-only
code.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
lib/x86/desc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/x86/desc.c b/lib/x86/desc.c
index c268955..770c250 100644
--- a/lib/x86/desc.c
This adds a test case that jumps into VM86 by iret-ing to a TSS and back
to Protected Mode using a task gate in the IDT.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
config-i386.mak |3 +-
lib/x86/desc.c| 37 +-
lib/x86/desc.h| 36
for VMX. For SVM, the logic used to
determine the source of the task switch is buggy, so we can't pass
useful information to the emulator there and just disable the check in
all cases.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
arch/x86/include/asm/kvm_emulate.h |2 +-
arch/x86/include
Setting the segment DPL to 0 for at least the VM86 code segment makes
the VM entry fail on VMX.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
arch/x86/kvm/emulate.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index
Task switches can switch between Protected Mode and VM86. The current
mode must be updated during the task switch emulation so that the new
segment selectors are interpreted correctly and privilege checks
succeed.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
arch/x86/include/asm/kvm_emulate.h
Am 23.01.2012 17:10, schrieb Gleb Natapov:
On Mon, Jan 23, 2012 at 05:07:13PM +0100, Kevin Wolf wrote:
This adds a test case that jumps into VM86 by iret-ing to a TSS and back
to Protected Mode using a task gate in the IDT.
Can you add the test case to taskswitch2.c?
That's actually what I
Am 23.01.2012 17:22, schrieb Gleb Natapov:
On Mon, Jan 23, 2012 at 05:20:22PM +0100, Kevin Wolf wrote:
Am 23.01.2012 17:10, schrieb Gleb Natapov:
On Mon, Jan 23, 2012 at 05:07:13PM +0100, Kevin Wolf wrote:
This adds a test case that jumps into VM86 by iret-ing to a TSS and back
to Protected
Am 24.01.2012 10:51, schrieb Takuya Yoshikawa:
(2012/01/24 1:07), Kevin Wolf wrote:
Commit 1d946e07 removed idt, but left a reference to idt in i386-only
code.
This is already fixed by
commit b319491d278d4e85de7ea967982f7d416f4a44e4
desc: fix build for i386
Whoops, my .git
Am 24.01.2012 10:52, schrieb Gleb Natapov:
On Mon, Jan 23, 2012 at 05:10:46PM +0100, Kevin Wolf wrote:
Currently, all task switches check privileges against the DPL of the
TSS. This is only correct for jmp/call to a TSS. If a task gate is used,
the DPL of this take gate is used for the check
Am 23.01.2012 17:42, schrieb Gleb Natapov:
On Mon, Jan 23, 2012 at 05:32:59PM +0100, Kevin Wolf wrote:
Am 23.01.2012 17:22, schrieb Gleb Natapov:
On Mon, Jan 23, 2012 at 05:20:22PM +0100, Kevin Wolf wrote:
Am 23.01.2012 17:10, schrieb Gleb Natapov:
On Mon, Jan 23, 2012 at 05:07:13PM +0100
Am 24.01.2012 11:17, schrieb Gleb Natapov:
On Tue, Jan 24, 2012 at 11:09:09AM +0100, Kevin Wolf wrote:
+ } else if (reason != TASK_SWITCH_IRET) {
+ dpl = next_tss_desc.dpl;
}
No need parentheses around one statement.
Documentation/CodingStyle says:
This does not apply if only
Am 24.01.2012 11:52, schrieb Gleb Natapov:
On Tue, Jan 24, 2012 at 11:38:24AM +0100, Kevin Wolf wrote:
Am 24.01.2012 11:17, schrieb Gleb Natapov:
On Tue, Jan 24, 2012 at 11:09:09AM +0100, Kevin Wolf wrote:
+} else if (reason != TASK_SWITCH_IRET) {
+dpl
Am 24.01.2012 11:57, schrieb Gleb Natapov:
On Mon, Jan 23, 2012 at 05:10:48PM +0100, Kevin Wolf wrote:
Task switches can switch between Protected Mode and VM86. The current
mode must be updated during the task switch emulation so that the new
segment selectors are interpreted correctly
Am 24.01.2012 12:37, schrieb Gleb Natapov:
On Tue, Jan 24, 2012 at 12:31:48PM +0100, Kevin Wolf wrote:
Am 24.01.2012 11:57, schrieb Gleb Natapov:
On Mon, Jan 23, 2012 at 05:10:48PM +0100, Kevin Wolf wrote:
Task switches can switch between Protected Mode and VM86. The current
mode must
Am 24.01.2012 15:03, schrieb Joerg Roedel:
On Mon, Jan 23, 2012 at 05:10:46PM +0100, Kevin Wolf wrote:
This patch fixes the problem for VMX. For SVM, the logic used to
determine the source of the task switch is buggy, so we can't pass
useful information to the emulator there and just disable
Am 24.01.2012 15:16, schrieb Gleb Natapov:
On Tue, Jan 24, 2012 at 03:15:13PM +0100, Kevin Wolf wrote:
Am 24.01.2012 15:03, schrieb Joerg Roedel:
On Mon, Jan 23, 2012 at 05:10:46PM +0100, Kevin Wolf wrote:
This patch fixes the problem for VMX. For SVM, the logic used to
determine the source
Am 24.01.2012 15:08, schrieb Anthony Liguori:
On 01/24/2012 08:03 AM, Paolo Bonzini wrote:
On 01/24/2012 02:57 PM, Anthony Liguori wrote:
Please send in any agenda items you are interested in covering.
I don't have anything pressing. I vote to cancel the call.
Nothing that cannot be
Am 25.01.2012 17:00, schrieb Joerg Roedel:
On Tue, Jan 24, 2012 at 06:23:50PM +0200, Gleb Natapov wrote:
On Tue, Jan 24, 2012 at 03:24:50PM +0100, Kevin Wolf wrote:
However, task_switch_interception() itself does some more based on the
value of reason, for example it decides whether
Am 27.01.2012 14:34, schrieb Joerg Roedel:
On Fri, Jan 27, 2012 at 01:58:38PM +0100, Kevin Wolf wrote:
Am 25.01.2012 17:00, schrieb Joerg Roedel:
I just retried. I use kvm-kmod and kvm.git with HEAD at ff92e9b5 plus
the tree patches of this series plus a printk to output exit_int_info
Am 27.01.2012 15:17, schrieb Joerg Roedel:
On Fri, Jan 27, 2012 at 02:55:12PM +0100, Kevin Wolf wrote:
Am 27.01.2012 14:34, schrieb Joerg Roedel:
On Fri, Jan 27, 2012 at 01:58:38PM +0100, Kevin Wolf wrote:
Am 25.01.2012 17:00, schrieb Joerg Roedel:
I just retried. I use kvm-kmod and kvm.git
I believe this should work with both VMX and SVM now. Gleb, Jörg, can one of
you test this with SVM? I did some testing on my buggy processor and it looks
as good as it gets, but it would be better if you could confirm.
Kevin Wolf (3):
KVM: x86 emulator: Fix task switch privilege checks
KVM
Currently, all task switches check privileges against the DPL of the
TSS. This is only correct for jmp/call to a TSS. If a task gate is used,
the DPL of this take gate is used for the check instead. Exceptions,
external interrupts and iret shouldn't perform any check.
Signed-off-by: Kevin Wolf kw
Setting the segment DPL to 0 for at least the VM86 code segment makes
the VM entry fail on VMX.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
arch/x86/kvm/emulate.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index
rflags to be updated in the vcpu struct. SVM stores the DPL
of the code segment instead, so we must be sure to give the right one
when updating the selector.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
arch/x86/include/asm/kvm_emulate.h |1 +
arch/x86/kvm/emulate.c | 26
Am 27.01.2012 20:52, schrieb Gleb Natapov:
On Fri, Jan 27, 2012 at 08:23:33PM +0100, Kevin Wolf wrote:
I believe this should work with both VMX and SVM now. Gleb, Jörg, can one of
you test this with SVM? I did some testing on my buggy processor and it looks
as good as it gets, but it would
Am 30.01.2012 09:55, schrieb Gleb Natapov:
On Mon, Jan 30, 2012 at 09:48:33AM +0100, Kevin Wolf wrote:
Am 27.01.2012 20:52, schrieb Gleb Natapov:
On Fri, Jan 27, 2012 at 08:23:33PM +0100, Kevin Wolf wrote:
I believe this should work with both VMX and SVM now. Gleb, Jörg, can one
of
you test
Am 30.01.2012 11:24, schrieb Avi Kivity:
On 01/27/2012 09:23 PM, Kevin Wolf wrote:
Task switches can switch between Protected Mode and VM86. The current
mode must be updated during the task switch emulation so that the new
segment selectors are interpreted correctly and privilege checks
101 - 200 of 298 matches
Mail list logo
