Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Paolo Bonzini
Il 03/07/2013 15:41, Arthur Chunqi Li ha scritto: Fix read/write to IA32_FEATURE_CONTROL MSR in nested environment. Simply return 0x5 when read and generate #GP(0) when write. Delete handling codes in vmx_set_vmx_msr() and generate #GP(0) in handle_wrmsr(). Signed-off-by: Arthur Chunqi Li

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Gleb Natapov
On Thu, Jul 04, 2013 at 09:00:09AM +0200, Paolo Bonzini wrote: Il 03/07/2013 15:41, Arthur Chunqi Li ha scritto: Fix read/write to IA32_FEATURE_CONTROL MSR in nested environment. Simply return 0x5 when read and generate #GP(0) when write. Delete handling codes in vmx_set_vmx_msr() and

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Arthur Chunqi Li
On Thu, Jul 4, 2013 at 3:10 PM, Gleb Natapov g...@redhat.com wrote: On Thu, Jul 04, 2013 at 09:00:09AM +0200, Paolo Bonzini wrote: Il 03/07/2013 15:41, Arthur Chunqi Li ha scritto: Fix read/write to IA32_FEATURE_CONTROL MSR in nested environment. Simply return 0x5 when read and generate

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Gleb Natapov
On Thu, Jul 04, 2013 at 03:21:15PM +0800, Arthur Chunqi Li wrote: On Thu, Jul 4, 2013 at 3:10 PM, Gleb Natapov g...@redhat.com wrote: On Thu, Jul 04, 2013 at 09:00:09AM +0200, Paolo Bonzini wrote: Il 03/07/2013 15:41, Arthur Chunqi Li ha scritto: Fix read/write to IA32_FEATURE_CONTROL MSR

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Gmail
在 2013-7-4，15:24，Gleb Natapov g...@redhat.com 写道： On Thu, Jul 04, 2013 at 03:21:15PM +0800, Arthur Chunqi Li wrote: On Thu, Jul 4, 2013 at 3:10 PM, Gleb Natapov g...@redhat.com wrote: On Thu, Jul 04, 2013 at 09:00:09AM +0200, Paolo Bonzini wrote: Il 03/07/2013 15:41, Arthur Chunqi Li ha

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Gleb Natapov
On Thu, Jul 04, 2013 at 04:16:25PM +0800, Gmail wrote: 在 2013-7-4，15:24，Gleb Natapov g...@redhat.com 写道： On Thu, Jul 04, 2013 at 03:21:15PM +0800, Arthur Chunqi Li wrote: On Thu, Jul 4, 2013 at 3:10 PM, Gleb Natapov g...@redhat.com wrote: On Thu, Jul 04, 2013 at 09:00:09AM +0200, Paolo

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Paolo Bonzini
Il 04/07/2013 09:10, Gleb Natapov ha scritto: On Thu, Jul 04, 2013 at 09:00:09AM +0200, Paolo Bonzini wrote: Il 03/07/2013 15:41, Arthur Chunqi Li ha scritto: Fix read/write to IA32_FEATURE_CONTROL MSR in nested environment. Simply return 0x5 when read and generate #GP(0) when write. Delete

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Gleb Natapov
On Thu, Jul 04, 2013 at 01:01:15PM +0200, Paolo Bonzini wrote: Il 04/07/2013 09:10, Gleb Natapov ha scritto: On Thu, Jul 04, 2013 at 09:00:09AM +0200, Paolo Bonzini wrote: Il 03/07/2013 15:41, Arthur Chunqi Li ha scritto: Fix read/write to IA32_FEATURE_CONTROL MSR in nested environment.

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Paolo Bonzini
Il 04/07/2013 13:12, Gleb Natapov ha scritto: I don't like that it requires a firmware change in order to use nested VMX (at least for hypervisors that read the MSR). Worse emulation and better emulation + new firmware are indistiguishable from the point of view of anyone except the

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Gleb Natapov
On Thu, Jul 04, 2013 at 01:21:51PM +0200, Paolo Bonzini wrote: Il 04/07/2013 13:12, Gleb Natapov ha scritto: I don't like that it requires a firmware change in order to use nested VMX (at least for hypervisors that read the MSR). Worse emulation and better emulation + new firmware are

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Paolo Bonzini
Il 04/07/2013 13:31, Gleb Natapov ha scritto: On Thu, Jul 04, 2013 at 01:21:51PM +0200, Paolo Bonzini wrote: Il 04/07/2013 13:12, Gleb Natapov ha scritto: I don't like that it requires a firmware change in order to use nested VMX (at least for hypervisors that read the MSR). Worse emulation

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Gleb Natapov
On Thu, Jul 04, 2013 at 02:34:11PM +0200, Paolo Bonzini wrote: Il 04/07/2013 13:31, Gleb Natapov ha scritto: On Thu, Jul 04, 2013 at 01:21:51PM +0200, Paolo Bonzini wrote: Il 04/07/2013 13:12, Gleb Natapov ha scritto: I don't like that it requires a firmware change in order to use nested

Re: [PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-04 Thread Arthur Chunqi Li
On Thu, Jul 4, 2013 at 8:43 PM, Gleb Natapov g...@redhat.com wrote: On Thu, Jul 04, 2013 at 02:34:11PM +0200, Paolo Bonzini wrote: Il 04/07/2013 13:31, Gleb Natapov ha scritto: On Thu, Jul 04, 2013 at 01:21:51PM +0200, Paolo Bonzini wrote: Il 04/07/2013 13:12, Gleb Natapov ha scritto: I

[PATCH] KVM : Fix read/write to IA32_FEATURE_CONTROL MSR in nested virt

2013-07-03 Thread Arthur Chunqi Li
Fix read/write to IA32_FEATURE_CONTROL MSR in nested environment. Simply return 0x5 when read and generate #GP(0) when write. Delete handling codes in vmx_set_vmx_msr() and generate #GP(0) in handle_wrmsr(). Signed-off-by: Arthur Chunqi Li yzt...@gmail.com --- arch/x86/kvm/vmx.c |5 + 1