Re: [PATCH 5/5] KVM: MMU: flush tlb out of mmu lock when write-protect the sptes

2014-04-15 Thread Xiao Guangrong
Hi Marcelo, Thanks your time to review it. On 04/09/2014 10:51 PM, Marcelo Tosatti wrote: +/* + * Please note PT_WRITABLE_MASK is not stable since + * 1) fast_page_fault() sets spte from readonly to writable out of mmu-lock or + * 2) kvm_mmu_slot_remove_write_access() and

Re: [PATCH 5/5] KVM: MMU: flush tlb out of mmu lock when write-protect the sptes

2014-04-09 Thread Marcelo Tosatti
On Mon, Mar 10, 2014 at 10:01:49PM +0800, Xiao Guangrong wrote: Now we can flush all the TLBs out of the mmu lock without TLB corruption when write-proect the sptes, it is because: - we have marked large sptes readonly instead of dropping them that means we just change the spte from writable

[PATCH 5/5] KVM: MMU: flush tlb out of mmu lock when write-protect the sptes

2014-03-10 Thread Xiao Guangrong
Now we can flush all the TLBs out of the mmu lock without TLB corruption when write-proect the sptes, it is because: - we have marked large sptes readonly instead of dropping them that means we just change the spte from writable to readonly so that we only need to care the case of changing