Re: [PATCH] kvm tools: Process virito blk requests in separate thread

2012-06-05 Thread Cyrill Gorcunov
On Tue, Jun 05, 2012 at 08:47:17AM +0800, Asias He wrote: I must admit I don't understand this code ;) The data get read into stack variable forever? The data we read itself is not interesting at all. virtio_blk_thread() sleeps on the eventfd bdev-io_efd until notify_vq() writes something

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Avi Kivity
On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Pulled. Thanks. This

Re: [PATCH 1/2] kvm tools: Increase AIO_MAX to 256

2012-06-05 Thread Pekka Enberg
On Mon, 4 Jun 2012, Asias He wrote: The queue size for virtio_blk is 256 and AIO_MAX is 32, we might be short of available aio events if guest issues 32 requests simultaneously. Following error is observed when guest running stressed I/O workload. Info: disk_image__read error: total=-11

Re: [PATCH 2/2] kvm tools: Restart io_submit if it returns EAGAIN

2012-06-05 Thread Pekka Enberg
On Mon, 4 Jun 2012, Asias He wrote: Keep trying if io_submit returns EAGAIN. No need to fail the request. Signed-off-by: Asias He asias.he...@gmail.com Applied, thanks! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Alexander Graf
On 05.06.2012, at 09:42, Avi Kivity a...@redhat.com wrote: On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from:

Re: [PATCH] kvm tools: Process virito blk requests in separate thread

2012-06-05 Thread Pekka Enberg
On Tue, Jun 5, 2012 at 4:03 AM, Asias He asias.he...@gmail.com wrote: On Tue, Jun 5, 2012 at 12:07 AM, Sasha Levin levinsasha...@gmail.com wrote: On Mon, 2012-06-04 at 23:40 +0800, Asias He wrote: All blk requests are processed in notify_vq() which is in the context of ioeventfd thread:

Re: [PATCH 1/2] kvm tools: Increase AIO_MAX to 256

2012-06-05 Thread Asias He
On Tue, Jun 5, 2012 at 3:59 PM, Pekka Enberg penb...@kernel.org wrote: On Mon, 4 Jun 2012, Asias He wrote: The queue size for virtio_blk is 256 and AIO_MAX is 32, we might be short of available aio events if guest issues 32 requests simultaneously. Following error is observed when guest

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Jan Kiszka
On 2012-06-05 10:10, Alexander Graf wrote: On 05.06.2012, at 09:42, Avi Kivity a...@redhat.com wrote: On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote:

[PATCH] KVM: Fix PCI header check on device assignment

2012-06-05 Thread Jan Kiszka
The masking was wrong (must have been 0x7f), and there is no need to re-read the value as pci_setup_device already does this for us. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43339 Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- virt/kvm/assigned-dev.c |4 +--- 1 files

Re: Has any work 3.3 kvm-kmod for rhel 6.2 kernel successfully?

2012-06-05 Thread Jan Kiszka
On 2012-06-05 06:22, ya su wrote: Jan: sorry for late response of your suggestion. I have found the patch which produce this problem, it comes from this one: 7850ac5420803996e2960d15b924021f28e0dffc. I change as the following, it works fine. diff -ur -i

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Anthony Liguori
On 06/05/2012 03:42 PM, Avi Kivity wrote: On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from:

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Avi Kivity
On 06/05/2012 12:02 PM, Anthony Liguori wrote: On 06/05/2012 03:42 PM, Avi Kivity wrote: On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from:

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Andreas Hartmann
Hello Alex, thanks for your efforts! Maybe, you already know that I'm suffering the same problem :-( with a GA-990XA-UD3 (990X chipset). On Mon, 04 Jun 2012 21:44:05 -0600 Alex Williamson alex.william...@redhat.com wrote: [...] I have a setup with an AMD 990FX system and a spare PVR-350 card

Re: [PATCH v2 6/7] kvm,x86: RCU based table free

2012-06-05 Thread Stefano Stabellini
On Mon, 4 Jun 2012, Nikunj A. Dadhania wrote: From: Peter Zijlstra a.p.zijls...@chello.nl get_user_pages_fast() depends on the IPI to hold off page table teardown while they are locklessly walked with interrupts disabled. If a vcpu were to be preempted while in this critical section, another

Re: [PATCH v2 6/7] kvm,x86: RCU based table free

2012-06-05 Thread Nikunj A Dadhania
On Tue, 5 Jun 2012 11:48:02 +0100, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I am also interested in introducing HAVE_RCU_TABLE_FREE on x86 for Xen. Maybe we can pull our efforts together :-) Giving a look at this patch, it doesn't look like it is introducing

Re: [PATCH v2 00/41] postcopy live migration

2012-06-05 Thread Dor Laor
On 06/04/2012 04:38 PM, Isaku Yamahata wrote: On Mon, Jun 04, 2012 at 08:37:04PM +0800, Anthony Liguori wrote: On 06/04/2012 05:57 PM, Isaku Yamahata wrote: After the long time, we have v2. This is qemu part. The linux kernel part is sent separatedly. Changes v1 - v2: - split up patches for

Re: [PATCH v2 6/7] kvm,x86: RCU based table free

2012-06-05 Thread Stefano Stabellini
On Tue, 5 Jun 2012, Nikunj A Dadhania wrote: On Tue, 5 Jun 2012 11:48:02 +0100, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I am also interested in introducing HAVE_RCU_TABLE_FREE on x86 for Xen. Maybe we can pull our efforts together :-) Giving a look at this patch,

Re: [RFC][PATCH] Add support for the GUEST_SMBASE VMCS field for Intel VT-x.

2012-06-05 Thread Matthias Lange
On Sun, May 20, 2012 at 03:39:30PM +0300, Avi Kivity wrote: On 05/18/2012 12:34 PM, Matthias Lange wrote: The following patch adds support for the GUEST_SMBASE field. This allows hypervisors running inside kvm read/write access to this field. I have tested this to work on a Core i5 machine.

Re: [PATCH 1/4] kvm-s390: add capability indicating COW support

2012-06-05 Thread Alexander Graf
On 15.05.2012, at 14:38, Christian Borntraeger wrote: On 15/05/12 14:33, Avi Kivity wrote: On 05/15/2012 03:31 PM, Christian Borntraeger wrote: On 15/05/12 14:24, Avi Kivity wrote: Newer systems allow to write-protect the guest backing memory and let the fault be delivered to the host, thus

Re: [PATCH 2/4] kvm-s390: KVM_GET/SET_ONEREG for s390

2012-06-05 Thread Alexander Graf
On 15.05.2012, at 14:15, Christian Borntraeger wrote: From: Carsten Otte co...@de.ibm.com This patch enables KVM_CAP_ONE_REG for s390 and implements stubs for KVM_GET/SET_ONE_REG. This is based on the ppc implementation. Signed-off-by: Carsten Otte co...@de.ibm.com Signed-off-by:

Re: [PATCH 3/4] kvm-s390: epoch difference and TOD programmable field

2012-06-05 Thread Alexander Graf
On 15.05.2012, at 14:15, Christian Borntraeger wrote: From: Carsten Otte co...@de.ibm.com This patch makes vcpu epoch difference and the TOD programmable field accessible from userspace. This is needed in order to implement a couple of instructions that deal with the time of day clock on

Re: [PATCH 4/4] kvm-s390: onereg for timer related registers

2012-06-05 Thread Alexander Graf
On 15.05.2012, at 14:15, Christian Borntraeger wrote: From: Jason J. herne jjhe...@us.ibm.com Enhance the KVM ONE_REG capability within S390 to allow getting/setting the following special cpu registers: clock comparator and the cpu timer. These are needed for migration. Signed-off-by:

Re: [PATCH 4/4] kvm-s390: onereg for timer related registers

2012-06-05 Thread Christian Borntraeger
On 05/06/12 14:42, Alexander Graf wrote: On 15.05.2012, at 14:15, Christian Borntraeger wrote: From: Jason J. herne jjhe...@us.ibm.com Enhance the KVM ONE_REG capability within S390 to allow getting/setting the following special cpu registers: clock comparator and the cpu timer. These

Re: [PATCH 4/4] kvm-s390: onereg for timer related registers

2012-06-05 Thread Alexander Graf
On 05.06.2012, at 14:57, Christian Borntraeger wrote: On 05/06/12 14:42, Alexander Graf wrote: On 15.05.2012, at 14:15, Christian Borntraeger wrote: From: Jason J. herne jjhe...@us.ibm.com Enhance the KVM ONE_REG capability within S390 to allow getting/setting the following special

Re: [PATCH v2 6/7] kvm,x86: RCU based table free

2012-06-05 Thread Peter Zijlstra
On Tue, 2012-06-05 at 18:34 +0530, Nikunj A Dadhania wrote: PeterZ, is 7/7 alright to be picked? Yeah, I guess it is.. I haven't had time to rework my tlb series yet though. But these two patches together should make it work for x86. -- To unsubscribe from this list: send the line unsubscribe

Re: [RFC][PATCH] Add support for the GUEST_SMBASE VMCS field for Intel VT-x.

2012-06-05 Thread Avi Kivity
On 06/05/2012 02:59 PM, Matthias Lange wrote: On Sun, May 20, 2012 at 03:39:30PM +0300, Avi Kivity wrote: On 05/18/2012 12:34 PM, Matthias Lange wrote: The following patch adds support for the GUEST_SMBASE field. This allows hypervisors running inside kvm read/write access to this field. I

Re: [PATCH v2 6/7] kvm,x86: RCU based table free

2012-06-05 Thread Nikunj A Dadhania
On Tue, 5 Jun 2012 12:58:32 +0100, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Tue, 5 Jun 2012, Nikunj A Dadhania wrote: On Tue, 5 Jun 2012 11:48:02 +0100, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I am also interested in introducing

Re: [PATCH v2 6/7] kvm,x86: RCU based table free

2012-06-05 Thread Stefano Stabellini
On Tue, 5 Jun 2012, Nikunj A Dadhania wrote: On Tue, 5 Jun 2012 12:58:32 +0100, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Tue, 5 Jun 2012, Nikunj A Dadhania wrote: On Tue, 5 Jun 2012 11:48:02 +0100, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote:

Re: [PATCH v2 6/7] kvm,x86: RCU based table free

2012-06-05 Thread Stefano Stabellini
On Tue, 5 Jun 2012, Peter Zijlstra wrote: On Tue, 2012-06-05 at 18:34 +0530, Nikunj A Dadhania wrote: PeterZ, is 7/7 alright to be picked? Yeah, I guess it is.. I haven't had time to rework my tlb series yet though. But these two patches together should make it work for x86. Good. Do you

Re: [PATCH v2 6/7] kvm,x86: RCU based table free

2012-06-05 Thread Peter Zijlstra
On Tue, 2012-06-05 at 14:26 +0100, Stefano Stabellini wrote: On Tue, 5 Jun 2012, Peter Zijlstra wrote: On Tue, 2012-06-05 at 18:34 +0530, Nikunj A Dadhania wrote: PeterZ, is 7/7 alright to be picked? Yeah, I guess it is.. I haven't had time to rework my tlb series yet though. But

Re: [PATCH v2 6/7] kvm,x86: RCU based table free

2012-06-05 Thread Stefano Stabellini
On Tue, 5 Jun 2012, Peter Zijlstra wrote: On Tue, 2012-06-05 at 14:26 +0100, Stefano Stabellini wrote: On Tue, 5 Jun 2012, Peter Zijlstra wrote: On Tue, 2012-06-05 at 18:34 +0530, Nikunj A Dadhania wrote: PeterZ, is 7/7 alright to be picked? Yeah, I guess it is.. I haven't had

Re: KVM entry failed, hardware error

2012-06-05 Thread David Ahern
On 6/4/12 12:28 PM, Johannes Bauer wrote: On 04.06.2012 10:53, Gleb Natapov wrote: On Sun, Jun 03, 2012 at 06:25:33PM +0200, Johannes Bauer wrote: Therefore, I've uploaded the compressed trace.dat file, so you can maybe have a look why the report tool barfs and interpret it correctly. I can't

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Alex Williamson
On Tue, 2012-06-05 at 12:39 +0200, Andreas Hartmann wrote: Hello Alex, thanks for your efforts! Maybe, you already know that I'm suffering the same problem :-( with a GA-990XA-UD3 (990X chipset). My system is a GA-990FXA-UD3, so just a slightly different version of the chipset. On Mon,

[GIT PULL] KVM fix for 3.5-rc1

2012-06-05 Thread Avi Kivity
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master to receive a one-liner fix for a buffer overflow: KVM: Fix buffer overflow in kvm_set_irq() (2012-06-05 16:39:58 +0300) Avi Kivity (1): KVM:

Re: [PATCH] PCI: Mark INTx masking support of Chelsio T310 10GbE NIC as broken

2012-06-05 Thread Jan Kiszka
On 2012-05-25 16:02, Jan Kiszka wrote: According to Alexey, the T310 does not properly support INTx masking as it fails to keep the PCI_STATUS_INTERRUPT bit updated once the interrupt is masked. Mark this adapter as broken so that pci_intx_mask_supported won't report it as compatible.

[PATCH 0/8] Cleanup for virtio/* and disk/*

2012-06-05 Thread Asias He
Asias He (8): kvm tools: Code cleanup for virtio/9p.c kvm tools: Code cleanup for virtio/balloon.c kvm tools: Code cleanup for virtio/blk.c kvm tools: Code cleanup for virtio/console.c kvm tools: Code cleanup for virtio/net.c kvm tools: Code cleanup for disk/core.c kvm tools: Code

[PATCH 1/8] kvm tools: Code cleanup for virtio/9p.c

2012-06-05 Thread Asias He
Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/virtio/9p.c | 58 - 1 file changed, 28 insertions(+), 30 deletions(-) diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c index 3ef1a5f..4108e02 100644 --- a/tools/kvm/virtio/9p.c

[PATCH 2/8] kvm tools: Code cleanup for virtio/balloon.c

2012-06-05 Thread Asias He
Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/virtio/balloon.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/kvm/virtio/balloon.c b/tools/kvm/virtio/balloon.c index 45bd8d3..9f1d9bd 100644 --- a/tools/kvm/virtio/balloon.c +++

[PATCH 3/8] kvm tools: Code cleanup for virtio/blk.c

2012-06-05 Thread Asias He
Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/virtio/blk.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/tools/kvm/virtio/blk.c b/tools/kvm/virtio/blk.c index da92094..9256646 100644 --- a/tools/kvm/virtio/blk.c +++

[PATCH 4/8] kvm tools: Code cleanup for virtio/console.c

2012-06-05 Thread Asias He
Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/virtio/console.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/kvm/virtio/console.c b/tools/kvm/virtio/console.c index 173c312..42472eb 100644 --- a/tools/kvm/virtio/console.c +++

[PATCH 5/8] kvm tools: Code cleanup for virtio/net.c

2012-06-05 Thread Asias He
Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/virtio/net.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/kvm/virtio/net.c b/tools/kvm/virtio/net.c index 35e51aa..50bef74 100644 --- a/tools/kvm/virtio/net.c +++ b/tools/kvm/virtio/net.c @@ -81,8

[PATCH 6/8] kvm tools: Code cleanup for disk/core.c

2012-06-05 Thread Asias He
Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/disk/core.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/tools/kvm/disk/core.c b/tools/kvm/disk/core.c index 58a5877..2b482c6 100644 --- a/tools/kvm/disk/core.c +++

[PATCH 7/8] kvm tools: Code cleanup for disk/qcow.c

2012-06-05 Thread Asias He
Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/disk/qcow.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/kvm/disk/qcow.c b/tools/kvm/disk/qcow.c index b3221c4..ee2992e 100644 --- a/tools/kvm/disk/qcow.c +++ b/tools/kvm/disk/qcow.c @@

[PATCH 8/8] kvm tools: Code cleanup for disk/raw.c

2012-06-05 Thread Asias He
Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/disk/raw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kvm/disk/raw.c b/tools/kvm/disk/raw.c index 42ca9f1..93b2b4e 100644 --- a/tools/kvm/disk/raw.c +++ b/tools/kvm/disk/raw.c @@ -99,7 +99,7 @@ static

Re: [PATCH] KVM: do not iterate over all VMs in mmu_shrink()

2012-06-05 Thread Avi Kivity
On 06/04/2012 02:53 PM, Gleb Natapov wrote: mmu_shrink() needlessly iterates over all VMs even though it will not attempt to free mmu pages from more than one on them. Fix that and also check used mmu pages count outside of VM lock to skip inactive VMs faster. Applied, thanks. -- error

Re: [PATCH v2] Fix migration of real mode guests from host with unrestricted guest to a host without it.

2012-06-05 Thread Avi Kivity
On 05/31/2012 02:49 PM, Orit Wasserman wrote: For example migration between Westmere and Nehelem hosts. The code that fixes the segments for real mode guest was moved from enter_rmode to vmx_set_segments. enter_rmode calls vmx_set_segments for each segment. Applied, thanks. -- error

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Alex Williamson
On Tue, 2012-06-05 at 17:17 +0200, Andreas Hartmann wrote: On Tue, 05 Jun 2012 08:27:05 -0600 Alex Williamson alex.william...@redhat.com wrote: On Tue, 2012-06-05 at 12:39 +0200, Andreas Hartmann wrote: Hello Alex, thanks for your efforts! Maybe, you already know that I'm

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Andreas Hartmann
Andreas Hartmann wrote: [...] I tried to run qemu-system-x86_64 but got this error on startup: qemu-system-x86_64: -device vfio-pci,host=06:07.0,id=hostdev0,bus=pci.0,addr=0x5: vfio: failed to set iommu for container: Operation not permitted qemu-system-x86_64: -device

Re: [PATCH 2/2] Provide fast path for rep ins emulation if possible.

2012-06-05 Thread Avi Kivity
On 05/23/2012 05:08 PM, Gleb Natapov wrote: rep ins emulation is going through emulator now. This is slow because emulator knows how to write back only one datum at a time. This patch provides fast path for the instruction in certain conditions. The conditions are: DF flag is not set,

[PATCH 1/2] kvm tools: Introduce virtio_compat_add_message() helper

2012-06-05 Thread Asias He
This patch introduces a helper virtio_compat_add_message() to simplify adding compat message for virtio device. Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/include/kvm/virtio.h |1 + tools/kvm/virtio/9p.c |7 +-- tools/kvm/virtio/balloon.c |7 +--

[PATCH 2/2] kvm tools: Fix compat message

2012-06-05 Thread Asias He
compat_id is initialized to -1 for each type of device. We should add compat message if the compat_id == -1 which means we haven't added compat message for this type of device. Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/virtio/9p.c |2 +- tools/kvm/virtio/balloon.c |

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Alex Williamson
On Tue, 2012-06-05 at 17:58 +0200, Andreas Hartmann wrote: Andreas Hartmann wrote: [...] I tried to run qemu-system-x86_64 but got this error on startup: qemu-system-x86_64: -device vfio-pci,host=06:07.0,id=hostdev0,bus=pci.0,addr=0x5: vfio: failed to set iommu for container:

[PATCH 1/3 v2] kvm tools: Introduce virtio_compat_add_message() helper

2012-06-05 Thread Asias He
This patch introduces a helper virtio_compat_add_message() to simplify adding compat message for virtio device. Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/include/kvm/virtio.h |1 + tools/kvm/virtio/9p.c |7 +-- tools/kvm/virtio/balloon.c |7 +--

[PATCH 2/3] kvm tools: Fix compat message

2012-06-05 Thread Asias He
compat_id is initialized to -1 for each type of device. We should add compat message if the compat_id == -1 which means we haven't added compat message for this type of device. Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/virtio/9p.c |2 +- tools/kvm/virtio/balloon.c |

[PATCH 3/3] kvm tools: Improve compat message format

2012-06-05 Thread Asias He
- Before: - *** Compatibility Warning *** virtio-blk device was not detected While you have requested a virtio-blk device, the guest kernel did not initialize it. Please make sure that the guest kernel was compiled with CONFIG_VIRTIO_BLK=y enabled in its .config ***

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Andreas Hartmann
Alex Williamson wrote: [...] Yep, I think the previous suggestion about reloading vfio_iommu_type1 with allow_unsafe_interrupts=1 will solve it. Yes! Works now. Success! Works means: Device is seen in VM. I couldn't test it up to now, because I don't have any driver in the VM for this

Re: [PATCH] KVM: Fix PCI header check on device assignment

2012-06-05 Thread Alex Williamson
On Tue, 2012-06-05 at 10:37 +0200, Jan Kiszka wrote: The masking was wrong (must have been 0x7f), and there is no need to re-read the value as pci_setup_device already does this for us. The intent was to mask off the multifunction bit from header_type, but the implementation is clearly wrong.

Re: [PATCH 2/2] Provide fast path for rep ins emulation if possible.

2012-06-05 Thread Gleb Natapov
On Tue, Jun 05, 2012 at 07:07:39PM +0300, Avi Kivity wrote: + + count = (PAGE_SIZE - offset_in_page(linear_addr))/size; + + if (count == 0) /* 'in' crosses page boundry */ + return EMULATE_FAIL; + + count = min(count, rcx); + + r = __kvm_fast_string_pio_in(vcpu,

Re: [PATCH 2/2] Provide fast path for rep ins emulation if possible.

2012-06-05 Thread Alexander Graf
On 24.05.2012, at 12:54, Roedel, Joerg wrote: On Thu, May 24, 2012 at 01:36:51PM +0300, Avi Kivity wrote: On 05/24/2012 01:34 PM, Roedel, Joerg wrote: On Wed, May 23, 2012 at 05:49:31PM +0300, Avi Kivity wrote: On 05/23/2012 05:40 PM, Avi Kivity wrote: On 05/23/2012 05:08 PM, Gleb Natapov

Re: [PATCH 2/2] Provide fast path for rep ins emulation if possible.

2012-06-05 Thread Gleb Natapov
On Tue, Jun 05, 2012 at 07:27:40PM +0200, Alexander Graf wrote: On 24.05.2012, at 12:54, Roedel, Joerg wrote: On Thu, May 24, 2012 at 01:36:51PM +0300, Avi Kivity wrote: On 05/24/2012 01:34 PM, Roedel, Joerg wrote: On Wed, May 23, 2012 at 05:49:31PM +0300, Avi Kivity wrote: On

Re: [PATCH 2/2] Provide fast path for rep ins emulation if possible.

2012-06-05 Thread Alexander Graf
On 05.06.2012, at 19:36, Gleb Natapov wrote: On Tue, Jun 05, 2012 at 07:27:40PM +0200, Alexander Graf wrote: On 24.05.2012, at 12:54, Roedel, Joerg wrote: On Thu, May 24, 2012 at 01:36:51PM +0300, Avi Kivity wrote: On 05/24/2012 01:34 PM, Roedel, Joerg wrote: On Wed, May 23, 2012 at

Re: [PATCH 2/2] Provide fast path for rep ins emulation if possible.

2012-06-05 Thread Gleb Natapov
On Tue, Jun 05, 2012 at 07:41:17PM +0200, Alexander Graf wrote: On 05.06.2012, at 19:36, Gleb Natapov wrote: On Tue, Jun 05, 2012 at 07:27:40PM +0200, Alexander Graf wrote: On 24.05.2012, at 12:54, Roedel, Joerg wrote: On Thu, May 24, 2012 at 01:36:51PM +0300, Avi Kivity wrote:

Re: [PATCH 2/2] Provide fast path for rep ins emulation if possible.

2012-06-05 Thread Gleb Natapov
On Tue, Jun 05, 2012 at 07:41:17PM +0200, Alexander Graf wrote: IIRC it was the size field, but I could be wrong. Please take an old (phenom / barcelona is old enough) machine and create some traces to make 100% sure that all fields you're trying to read out are actually provided. Joerg do

Re: [PATCH 2/2] Provide fast path for rep ins emulation if possible.

2012-06-05 Thread Gleb Natapov
On Tue, Jun 05, 2012 at 08:50:16PM +0300, Gleb Natapov wrote: No, what I'm saying is that the hardware omitted some fields even though they were provided in the spec. IIRC it was the size field, but I could be wrong. Please take an old (phenom / barcelona is old enough) machine and

WARNING: at arch/x86/kernel/kvmclock.c:127

2012-06-05 Thread Frank Arnold
Hi all, I observed the following warning during testing of 3.5-rc1, involving some intensive and random CPU online state toggling through sysfs. It only shows up about 1 out of 500 times. Also, there was no KVM guest running on the system. [ cut here ] WARNING: at

Re: [RFC][PATCH] Add support for the GUEST_SMBASE VMCS field for Intel VT-x.

2012-06-05 Thread Matthias Lange
On Tue, Jun 05, 2012 at 04:09:30PM +0300, Avi Kivity wrote: On 06/05/2012 02:59 PM, Matthias Lange wrote: Do you mean the ABI defined in the Intel Software Developer's manual 3B? Or is vmcs12 only an ABI internal to the kvm module? The latter. We want to be able to live migrate a guest

[Bug 43339] Wrong Pci-Bridge Header Type check.

2012-06-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=43339 Alex Williamson alex.william...@redhat.com changed: What|Removed |Added CC|

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Alex Williamson
On Tue, 2012-06-05 at 18:55 +0200, Andreas Hartmann wrote: Alex Williamson wrote: [...] Yep, I think the previous suggestion about reloading vfio_iommu_type1 with allow_unsafe_interrupts=1 will solve it. Yes! Works now. Success! Works means: Device is seen in VM. I couldn't test it

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Andreas Hartmann
Alex Williamson wrote: On Tue, 2012-06-05 at 18:55 +0200, Andreas Hartmann wrote: Alex Williamson wrote: [...] Yep, I think the previous suggestion about reloading vfio_iommu_type1 with allow_unsafe_interrupts=1 will solve it. Yes! Works now. Success! Works means: Device is seen in

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Alex Williamson
On Tue, 2012-06-05 at 22:37 +0200, Andreas Hartmann wrote: Alex Williamson wrote: On Tue, 2012-06-05 at 18:55 +0200, Andreas Hartmann wrote: Alex Williamson wrote: [...] Yep, I think the previous suggestion about reloading vfio_iommu_type1 with allow_unsafe_interrupts=1 will solve it.

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Andreas Hartmann
Alex Williamson wrote: On Tue, 2012-06-05 at 22:37 +0200, Andreas Hartmann wrote: Alex Williamson wrote: On Tue, 2012-06-05 at 18:55 +0200, Andreas Hartmann wrote: Alex Williamson wrote: [...] Yep, I think the previous suggestion about reloading vfio_iommu_type1 with

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread sheng qiu
test On Tue, Jun 5, 2012 at 5:39 AM, Andreas Hartmann andihartm...@01019freenet.de wrote: Hello Alex, thanks for your efforts! Maybe, you already know that I'm suffering the same problem :-( with a GA-990XA-UD3 (990X chipset). On Mon, 04 Jun 2012 21:44:05 -0600 Alex Williamson

RE: Biweekly KVM Test report, kernel 51bfd299... qemu a1fce560...

2012-06-05 Thread Ren, Yongjie
-Original Message- From: Kevin Wolf [mailto:kw...@redhat.com] Sent: Monday, June 04, 2012 9:51 PM To: Ren, Yongjie Cc: Marcelo Tosatti; Avi Kivity; kvm@vger.kernel.org; Liu, RongrongX Subject: Re: Biweekly KVM Test report, kernel 51bfd299... qemu a1fce560... Am 01.06.2012 10:31,

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Chris Sanders
Alex, This solution appears to be working for me as well on a GA-970-D3. I've been able to pass the Hauppauge 350 through to a Windows XP guest which has installed drivers and loaded it into my recording software (SageTV). I've got a few more things I want to clean up on my qemu start command

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Alex Williamson
On Tue, 2012-06-05 at 22:07 -0500, Chris Sanders wrote: Alex, This solution appears to be working for me as well on a GA-970-D3. I've been able to pass the Hauppauge 350 through to a Windows XP guest which has installed drivers and loaded it into my recording software (SageTV). I've got

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Chris Sanders
Great, glad to hear it.  You can expect performance to get better once we get this upstream.  Interrupts are currently getting bounced through Qemu which adds overhead.  Eventually we'll accelerate them through KVM. I'm still able to play static directly from the device using mplayer, so it

Re: AMD KVM Pci Passthrough reports device busy

2012-06-05 Thread Alex Williamson
On Tue, 2012-06-05 at 22:31 -0500, Chris Sanders wrote: Great, glad to hear it. You can expect performance to get better once we get this upstream. Interrupts are currently getting bounced through Qemu which adds overhead. Eventually we'll accelerate them through KVM. I'm still able to

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Avi Kivity
On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Pulled. Thanks. This

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Alexander Graf
On 05.06.2012, at 09:42, Avi Kivity a...@redhat.com wrote: On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from:

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Jan Kiszka
On 2012-06-05 10:10, Alexander Graf wrote: On 05.06.2012, at 09:42, Avi Kivity a...@redhat.com wrote: On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote:

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Anthony Liguori
On 06/05/2012 03:42 PM, Avi Kivity wrote: On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from:

Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Avi Kivity
On 06/05/2012 12:02 PM, Anthony Liguori wrote: On 06/05/2012 03:42 PM, Avi Kivity wrote: On 06/05/2012 04:58 AM, Anthony Liguori wrote: On 06/05/2012 08:52 AM, Andreas Färber wrote: Am 04.06.2012 07:46, schrieb Anthony Liguori: On 05/22/2012 12:37 AM, Avi Kivity wrote: Please pull from: