Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-23 Thread Kevin Wolf
Am 22.03.2010 23:06, schrieb Anthony Liguori: On 03/22/2010 02:47 PM, Avi Kivity wrote: Having qemu enumerate guests one way or another is not a good idea IMO since it is focused on one guest and doesn't have a system-wide entity. There always needs to be a system wide entity. There are

Re: [Qemu-devel] [PATCH][STABLE] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-22 Thread Kevin Wolf
...@linux.vnet.ibm.com Acked-by: Kevin Wolf kw...@redhat.com Picked it up for my block branch, too, but I think this should be committed immediately by Aurelien. Kevin -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [Qemu-devel] Re: KVM call agenda for Apr 27

2010-04-27 Thread Kevin Wolf
Am 27.04.2010 00:36, schrieb Anthony Liguori: On 04/26/2010 05:12 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: On 04/26/2010 12:26 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. While I don't expect it to be the

Re: KVM call agenda for Apr 27

2010-04-27 Thread Kevin Wolf
Am 27.04.2010 10:56, schrieb Avi Kivity: On 04/27/2010 11:48 AM, Dor Laor wrote: Here's another option: an nbd-like protocol that remotes all BlockDriver operations except read and write over a unix domain socket. The open operation returns an fd (SCM_RIGHTS strikes again) that is used for

Re: KVM call agenda for Apr 27

2010-04-27 Thread Kevin Wolf
Am 27.04.2010 11:32, schrieb Dor Laor: On 04/27/2010 12:22 PM, Avi Kivity wrote: On 04/27/2010 12:08 PM, Dor Laor wrote: On 04/27/2010 11:56 AM, Avi Kivity wrote: On 04/27/2010 11:48 AM, Dor Laor wrote: IMHO the whole thing is way over engineered: a) Having another channel into qemu is

Re: [Qemu-devel] Re: KVM call agenda for Apr 27

2010-04-27 Thread Kevin Wolf
Am 27.04.2010 15:10, schrieb Anthony Liguori: On 04/27/2010 03:53 AM, Kevin Wolf wrote: Am 27.04.2010 00:36, schrieb Anthony Liguori: On 04/26/2010 05:12 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: On 04/26/2010 12:26 PM, Chris Wright wrote

Re: [Qemu-devel] Re: KVM call agenda for Apr 27

2010-04-27 Thread Kevin Wolf
Am 27.04.2010 15:21, schrieb Anthony Liguori: On 04/27/2010 08:18 AM, Kevin Wolf wrote: The watermark is not some complex computed value, but actually the statistic itself. We can get rid of handling a threshold in qemu by just signalling something has changed with this stat. I'm really

Re: [Qemu-devel] Re: KVM call agenda for Apr 27

2010-04-27 Thread Kevin Wolf
Am 27.04.2010 15:48, schrieb Anthony Liguori: On 04/27/2010 08:42 AM, Kevin Wolf wrote: Am 27.04.2010 15:21, schrieb Anthony Liguori: On 04/27/2010 08:18 AM, Kevin Wolf wrote: The watermark is not some complex computed value, but actually the statistic itself. We can get rid

Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath - Assertion

2010-05-04 Thread Kevin Wolf
Am 03.05.2010 23:26, schrieb Peter Lieven: Hi Qemu/KVM Devel Team, i'm using qemu-kvm 0.12.3 with latest Kernel 2.6.33.3. As backend we use open-iSCSI with dm-multipath. Multipath is configured to queue i/o if no path is available. If we create a failure on all paths, qemu starts to

Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath - Assertion

2010-05-04 Thread Kevin Wolf
Am 04.05.2010 13:38, schrieb Peter Lieven: hi kevin, i set a breakpint at bmdma_active_if. the first 2 breaks encountered when the last path in the multipath failed, but the assertion was not true. when i kicked one path back in the breakpoint was reached again, this time leading to an

Re: Endless loop in qcow2_alloc_cluster_offset

2010-05-07 Thread Kevin Wolf
Am 07.05.2010 03:19, schrieb Marcelo Tosatti: On Thu, Nov 19, 2009 at 01:19:55PM +0100, Jan Kiszka wrote: Hi, I just managed to push a qemu-kvm process (git rev. b496fe3431) into an endless loop in qcow2_alloc_cluster_offset, namely over QLIST_FOREACH(old_alloc, s-cluster_allocs,

Re: [Qemu-devel] [RFC PATCH 0/2] Sheepdog: distributed storage system for QEMU

2010-05-14 Thread Kevin Wolf
Am 13.05.2010 16:03, schrieb MORITA Kazutaka: To support snapshot in a protocol, I'd like to call the hander of the protocol driver in the following functions in block.c: bdrv_snapshot_create bdrv_snapshot_goto bdrv_snapshot_delete bdrv_snapshot_list bdrv_save_vmstate

Re: qemu-kvm hangs if multipath device is queing

2010-05-14 Thread Kevin Wolf
chroot_dir = 0x0 run_as = 0x0 env = (struct CPUX86State *) 0x0 show_vnc_port = 0 params = {0x58cc76 order, 0x58cc7c once, 0x58cc81 menu, 0x0} Kevin Wolf wrote: Am 04.05.2010 15:42, schrieb Peter Lieven: hi kevin, you did it *g* looks promising. applied this patched

Re: [Qemu-devel] [RFC PATCH 0/2] Sheepdog: distributed storage system for QEMU

2010-05-14 Thread Kevin Wolf
Am 14.05.2010 11:54, schrieb MORITA Kazutaka: There is another problem to make the sheepdog driver be a protocol; how to deal with protocol specific create_options? For example, sheepdog supports cloning images as a format driver: $ qemu-img create -f sheepdog dst -b sheepdog:src But if

Re: [RFC PATCH v2 3/3] block: add sheepdog driver for distributed storage support

2010-05-14 Thread Kevin Wolf
Am 14.05.2010 11:51, schrieb MORITA Kazutaka: Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. This patch adds a qemu block driver for Sheepdog. Sheepdog features are: - No node in the cluster is special (no

Re: [RFC PATCH v2 2/3] block: call the snapshot handlers of the protocol drivers

2010-05-14 Thread Kevin Wolf
Am 14.05.2010 11:51, schrieb MORITA Kazutaka: When snapshot handlers of the format driver is not defined, it is better to call the ones of the protocol driver. This enables us to implement snapshot support in the protocol driver. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp

Re: [Qemu-devel] [RFC PATCH v3 2/3] block: call the snapshot handlers of the protocol drivers

2010-05-17 Thread Kevin Wolf
Am 17.05.2010 12:19, schrieb MORITA Kazutaka: When snapshot handlers are not defined in the format driver, it is better to call the ones of the protocol driver. This enables us to implement snapshot support in the protocol driver. We need to call bdrv_close() and bdrv_open() handlers of the

Re: [Qemu-devel] Re: [RFC PATCH v3 2/3] block: call the snapshot handlers of the protocol drivers

2010-05-17 Thread Kevin Wolf
Am 17.05.2010 14:19, schrieb MORITA Kazutaka: At Mon, 17 May 2010 13:08:08 +0200, Kevin Wolf wrote: Am 17.05.2010 12:19, schrieb MORITA Kazutaka: int bdrv_snapshot_goto(BlockDriverState *bs, const char *snapshot_id) { BlockDriver *drv = bs-drv; +int

Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath - Assertion

2010-05-18 Thread Kevin Wolf
Am 18.05.2010 13:13, schrieb Peter Lieven: hi, will this patch make it into 0.12.4.1 ? br, peter Anthony, can you please cherry-pick commit 38d8dfa1 into stable-0.12? Kevin Christoph Hellwig wrote: On Tue, May 04, 2010 at 04:01:35PM +0200, Kevin Wolf wrote: Great, I'm going

Re: qemu-kvm hangs if multipath device is queing

2010-05-18 Thread Kevin Wolf
Am 18.05.2010 13:10, schrieb Peter Lieven: hi kevin, here is the backtrace of (hopefully) all threads: ^C Program received signal SIGINT, Interrupt. [Switching to Thread 0x7f39b72656f0 (LWP 10695)] 0x7f39b6c3ea94 in __lll_lock_wait () from /lib/libpthread.so.0 (gdb) thread apply

Re: qemu-kvm hangs if multipath device is queing

2010-05-19 Thread Kevin Wolf
Am 19.05.2010 09:29, schrieb Christoph Hellwig: On Tue, May 18, 2010 at 03:22:36PM +0200, Kevin Wolf wrote: I think it's stuck here in an endless loop: while (laiocb-ret == -EINPROGRESS) qemu_laio_completion_cb(laiocb-ctx); Can you verify this by single-stepping one or two loop

Re: [Qemu-devel] [PATCH 0/2] Fix scsi-generic breakage in upstream qemu-kvm.git

2010-05-20 Thread Kevin Wolf
Am 17.05.2010 18:45, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org Greetings, Attached are the updated patches following hch's comments to fix scsi-generic device breakage with find_image_format() and refresh_total_sectors(). These are being resent as the

Re: [PATCH] add support for protocol driver create_options

2010-05-21 Thread Kevin Wolf
Am 20.05.2010 07:36, schrieb MORITA Kazutaka: This patch enables protocol drivers to use their create options which are not supported by the format. For example, protcol drivers can use a backing_file option with raw format. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Hm,

Re: [PATCH] add support for protocol driver create_options

2010-05-21 Thread Kevin Wolf
Am 20.05.2010 07:36, schrieb MORITA Kazutaka: This patch enables protocol drivers to use their create options which are not supported by the format. For example, protcol drivers can use a backing_file option with raw format. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp ---

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-25 Thread Kevin Wolf
Am 23.05.2010 14:01, schrieb Avi Kivity: On 05/21/2010 12:29 AM, Anthony Liguori wrote: I'd be more interested in enabling people to build these types of storage systems without touching qemu. Both sheepdog and ceph ultimately transmit I/O over a socket to a central daemon, right?

Re: [PATCH] add support for protocol driver create_options

2010-05-25 Thread Kevin Wolf
Am 24.05.2010 08:34, schrieb MORITA Kazutaka: At Fri, 21 May 2010 18:57:36 +0200, Kevin Wolf wrote: Am 20.05.2010 07:36, schrieb MORITA Kazutaka: + +/* + * Append an option list (list) to an option list (dest). + * + * If dest is NULL, a new copy of list is created. + * + * Returns

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-25 Thread Kevin Wolf
Am 25.05.2010 15:25, schrieb Anthony Liguori: On 05/25/2010 06:25 AM, Avi Kivity wrote: On 05/25/2010 02:02 PM, Kevin Wolf wrote: So could we not standardize a protocol for this that both sheepdog and ceph could implement? The protocol already exists, nbd. It doesn't support snapshotting

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-25 Thread Kevin Wolf
Am 25.05.2010 15:25, schrieb Avi Kivity: On 05/25/2010 04:17 PM, Anthony Liguori wrote: On 05/25/2010 04:14 AM, Avi Kivity wrote: On 05/24/2010 10:38 PM, Anthony Liguori wrote: - Building a plugin API seems a bit simpler to me, although I'm to sure if I'd get the idea correctly: The

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-25 Thread Kevin Wolf
Am 25.05.2010 15:55, schrieb Avi Kivity: On 05/25/2010 04:53 PM, Kevin Wolf wrote: I'm still not convinced that we need either. I share Christoph's concern that we would make our life harder for almost no gain. It's probably a very small group of users (if it exists at all) that wants to add

Re: [PATCH] add support for protocol driver create_options

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 04:35, schrieb MORITA Kazutaka: At Tue, 25 May 2010 15:43:17 +0200, Kevin Wolf wrote: Am 24.05.2010 08:34, schrieb MORITA Kazutaka: At Fri, 21 May 2010 18:57:36 +0200, Kevin Wolf wrote: Am 20.05.2010 07:36, schrieb MORITA Kazutaka: + +/* + * Append an option list (list

Re: [Qemu-devel] [PATCH 0/2] Fix scsi-generic breakage in upstream qemu-kvm.git

2010-05-28 Thread Kevin Wolf
Am 27.05.2010 17:56, schrieb Nicholas A. Bellinger: On Thu, 2010-05-20 at 15:18 +0200, Kevin Wolf wrote: Am 17.05.2010 18:45, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org Greetings, Attached are the updated patches following hch's comments to fix scsi

Re: [Qemu-devel] [PATCH 1/1] ceph/rbd block driver for qemu-kvm (v2)

2010-05-28 Thread Kevin Wolf
Am 27.05.2010 21:11, schrieb Christian Brunner: This is a block driver for the distributed file system Ceph (http://ceph.newdream.net/). This driver uses librados (which is part of the Ceph server) for direct access to the Ceph object store and is running entirely in userspace. Therefore it

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-06-01 Thread Kevin Wolf
Hi Christian, Am 31.05.2010 21:31, schrieb Christian Brunner: Hi Kevin, here is an updated patch for the ceph/rbd driver. I hope that everything is fine now. I'll try to get to give it a final review later this week. In the meantime, I would be happy to see another review by someone else.

Re: [Qemu-devel] Latest GIT doesn't work with long device names

2010-06-01 Thread Kevin Wolf
Am 01.06.2010 12:59, schrieb Peter Lieven: Hi, I just compiled latest git to work on Bug #585113 . Unfortunately, I can't start the the VMs with the device mappings generated by our multipath setup. cmdline: /usr/bin/qemu-kvm-devel -net none -drive

Re: [RFC PATCH v4 0/3] Sheepdog: distributed storage system for QEMU

2010-06-02 Thread Kevin Wolf
Am 28.05.2010 04:44, schrieb MORITA Kazutaka: Hi all, This patch adds a block driver for Sheepdog distributed storage system. Please consider for inclusion. Hint for next time: You should remove the RFC from the subject line if you think the patch is ready for inclusion. Otherwise I might

Re: [RFC PATCH v4 3/3] block: add sheepdog driver for distributed storage support

2010-06-02 Thread Kevin Wolf
Am 28.05.2010 04:44, schrieb MORITA Kazutaka: Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. This patch adds a qemu block driver for Sheepdog. Sheepdog features are: - No node in the cluster is special (no

Re: [RFC PATCH v4 3/3] block: add sheepdog driver for distributed storage support

2010-06-04 Thread Kevin Wolf
Am 03.06.2010 18:23, schrieb MORITA Kazutaka: +static void sd_aio_cancel(BlockDriverAIOCB *blockacb) +{ + SheepdogAIOCB *acb = (SheepdogAIOCB *)blockacb; + + acb-canceled = 1; +} Does this provide the right semantics? You haven't really cancelled the request, but you pretend to. So

Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-04 Thread Kevin Wolf
Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and PERSISTENT_RESERVE_IN case in scsi_req_length() to extra the incoming buffer length into SCSIRequest-cmd.xfer, and adds a

Re: Endless loop in qcow2_alloc_cluster_offset

2009-11-19 Thread Kevin Wolf
Hi Jan, Am 19.11.2009 13:19, schrieb Jan Kiszka: (gdb) print ((BDRVQcowState *)bs-opaque)-cluster_allocs.lh_first $5 = (struct QCowL2Meta *) 0xcb3568 (gdb) print *((BDRVQcowState *)bs-opaque)-cluster_allocs.lh_first $6 = {offset = 7417176064, n_start = 0, nb_available = 16, nb_clusters = 0,

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Kevin Wolf
Am 07.12.2009 15:16, schrieb Jan Kiszka: Likely not. What I did was nothing special, and I did not noticed such a crash in the last months. And now it happened again (qemu-kvm head, during kernel installation from network onto local qcow2-disk). Any clever idea how to proceed with this? I

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Kevin Wolf
Am 07.12.2009 15:50, schrieb Jan Kiszka: Jan Kiszka wrote: And now it happened again (qemu-kvm head, during kernel installation from network onto local qcow2-disk). Any clever idea how to proceed with this? I could try to run the step in a loop, hopefully retriggering it once in a (likely

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Kevin Wolf
Am 07.12.2009 17:09, schrieb Jan Kiszka: Kevin Wolf wrote: In qcow_aio_write_cb there isn't much happening between these calls. The only thing that could somehow become dangerous is the qcow_aio_write_cb(req, 0); for queued requests in run_dependent_requests. If m-nb_clusters

Re: [Qemu-devel] Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-08 Thread Kevin Wolf
Am 07.12.2009 16:00, schrieb Kevin Wolf: Am 07.12.2009 15:16, schrieb Jan Kiszka: Likely not. What I did was nothing special, and I did not noticed such a crash in the last months. And now it happened again (qemu-kvm head, during kernel installation from network onto local qcow2-disk). Any

Re: SIGTERM to qemu-kvm process destroys qcow2 image?

2009-12-17 Thread Kevin Wolf
Am 17.12.2009 11:23, schrieb Avi Kivity: On 12/17/2009 11:38 AM, Kenni Lund wrote: 2009/12/17 Avi Kivitya...@redhat.com: On 12/17/2009 02:52 AM, Kenni Lund wrote: Yesterday I entered an invalid boot device as an argument to my qemu-kvm command for my Windows XP machine, causing an

Re: SIGTERM to qemu-kvm process destroys qcow2 image?

2009-12-18 Thread Kevin Wolf
Am 18.12.2009 15:22, schrieb Avi Kivity: If so, I'm quite confused...this should be a standalone image created with a command like qemu-img create -f WindowsXP.img 50G half a year ago on kvm 8x. I don't use libvirt/virt-manager etc. I start qemu-kvm directly from a homemade bash script. I

Re: [PATCH] Use qemu_memalign instead of qemu_malloc

2008-06-25 Thread Kevin Wolf
Anthony Liguori schrieb: Kevin Wolf wrote: Anthony Liguori schrieb: I guess the main block code is not as defensive as I thought it was. This patch uses qemu_memalign to allocate the buffers for IO so that you don't get errors when using O_DIRECT. Actually, the block code should

Re: [PATCH] Use qemu_memalign instead of qemu_malloc

2008-06-25 Thread Kevin Wolf
Anthony Liguori schrieb: Kevin Wolf wrote: Anthony Liguori schrieb: Yes, if it fails, the EINVAL is no surprise. I meant what code path it was using. Obviously we missed something in our patch and I'd like to fix that. Did the error occur on raw images or something like qcow2? It's

Re: [PATCH] Use qemu_memalign instead of qemu_malloc

2008-06-25 Thread Kevin Wolf
Anthony Liguori schrieb: Kevin Wolf wrote: Anthony Liguori schrieb: Kevin Wolf wrote: Anthony Liguori schrieb: Yes, if it fails, the EINVAL is no surprise. I meant what code path it was using. Obviously we missed something in our patch and I'd like to fix that. Did the error

Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: event-tap function is called only when it is on, and requests sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- block.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki

Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: event-tap function is called only when it is on, and requests sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- block.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 14:04, schrieb Yoshiaki Tamura: +static void event_tap_blk_flush(EventTapBlkReq *blk_req) +{ +BlockDriverState *bs; + +bs = bdrv_find(blk_req-device_name); Please store the BlockDriverState in blk_req. This code loops over all block devices and does a string

Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 14:16, schrieb Yoshiaki Tamura: 2011/1/19 Kevin Wolf kw...@redhat.com: Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: event-tap function is called only when it is on, and requests sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-20 Thread Kevin Wolf
Am 20.01.2011 06:19, schrieb Yoshiaki Tamura: +return; +} + +bdrv_aio_writev(bs, blk_req-reqs[0].sector, blk_req-reqs[0].qiov, +blk_req-reqs[0].nb_sectors, blk_req-reqs[0].cb, +blk_req-reqs[0].opaque); Same here. +

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-20 Thread Kevin Wolf
Am 20.01.2011 11:39, schrieb Yoshiaki Tamura: 2011/1/20 Kevin Wolf kw...@redhat.com: Am 20.01.2011 06:19, schrieb Yoshiaki Tamura: +return; +} + +bdrv_aio_writev(bs, blk_req-reqs[0].sector, blk_req-reqs[0].qiov, +blk_req-reqs[0].nb_sectors, blk_req-reqs[0

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-20 Thread Kevin Wolf
Am 20.01.2011 14:50, schrieb Yoshiaki Tamura: 2011/1/20 Kevin Wolf kw...@redhat.com: Am 20.01.2011 11:39, schrieb Yoshiaki Tamura: 2011/1/20 Kevin Wolf kw...@redhat.com: Am 20.01.2011 06:19, schrieb Yoshiaki Tamura: +return; +} + +bdrv_aio_writev(bs, blk_req-reqs[0].sector

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Kevin Wolf
Am 25.01.2011 15:11, schrieb Aurelien Jarno: Luiz Capitulino a écrit : On Mon, 24 Jan 2011 16:06:34 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/24/2011 07:25 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - coroutines for the block

Re: [PATCH 14/19] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush().

2011-01-28 Thread Kevin Wolf
Am 28.01.2011 08:21, schrieb Yoshiaki Tamura: event-tap function is called only when it is on, and requests were sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Acked-by: Kevin Wolf kw...@redhat.com -- To unsubscribe from this list: send the line

Re: [PATCH] sheepdog: support creating images on remote hosts

2011-01-28 Thread Kevin Wolf
Am 27.01.2011 17:33, schrieb MORITA Kazutaka: This patch parses the input filename in sd_create(), and enables us specifying a target server to create sheepdog images. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Thanks, applied to the block branch. Kevin -- To unsubscribe

Re: [Qemu-devel] KVM call minutes for Mar 8

2011-03-09 Thread Kevin Wolf
Am 08.03.2011 16:50, schrieb Chris Wright: QAPI merge plans - should be 100% back compat - qmp moved over - hmp moved over - 1st pass, core infrastructure (includes test framework) - 2nd pass, command conversion - 3rd pass, more controversial bits - adds dependencies: glib and python -

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 13.04.2011 21:26, schrieb Prasad Joshi: The patch only implements the basic read write support for QCOW version 1 images. Many of the QCOW features are not implmented, for example - image creation - snapshot - copy-on-write - encryption Yay, more forks, more code duplication! Have

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 10:07, schrieb Ingo Molnar: * Kevin Wolf kw...@redhat.com wrote: Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're violating the license. AFAICT it's not a copy, it's a reimplementation - and he credited you in the CREDITS file

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 10:15, schrieb Pekka Enberg: * Kevin Wolf kw...@redhat.com wrote: Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're violating the license. Am 14.04.2011 10:07, schrieb Ingo Molnar: AFAICT it's not a copy, it's a reimplementation

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually share code with qemu instead of repeating Xen's mistake of copying code, modifying it until merges are no longer possible and then let

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 10:32, schrieb Pekka Enberg: Hi Kevin! Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually share code with qemu instead of repeating Xen's mistake of copying code, modifying

Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support

2011-04-14 Thread Kevin Wolf
Am 14.04.2011 11:26, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 14.04.2011 10:32, schrieb Pekka Enberg: Hi Kevin! Am 14.04.2011 10:21, schrieb Pekka Enberg: On Thu, Apr 14, 2011 at 11:02 AM, Kevin Wolf kw...@redhat.com wrote: Have you thought about a way to actually

Re: [PATCH] kvm tool: add QCOW verions 1 read/write support

2011-04-15 Thread Kevin Wolf
Am 15.04.2011 08:24, schrieb Pekka Enberg: Hi Christoph, On Wed, Apr 13, 2011 at 08:01:58PM +0100, Prasad Joshi wrote: The patch only implements the basic read write support for QCOW version 1 images. Many of the QCOW features are not implmented, for example On Fri, Apr 15, 2011 at 6:24

Re: Why QCOW1?

2011-04-15 Thread Kevin Wolf
Am 15.04.2011 14:05, schrieb Stefan Hajnoczi: On Fri, Apr 15, 2011 at 12:17 PM, Pekka Enberg penb...@kernel.org wrote: On Fri, Apr 15, 2011 at 1:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Why even use a non-raw image format? The current implementation only does sparse files, but POSIX

Re: [Qemu-devel] Re: KVM call minutes for June 8

2010-06-10 Thread Kevin Wolf
Am 09.06.2010 18:22, schrieb Anthony Liguori: On 06/09/2010 10:31 AM, Daniel P. Berrange wrote: However, libvirt was counting on this feature and on the snapshot commands to switch from the text Monitor. We have two options: 1. Ask them to wait one more release (not so good for us) 2.

Re: [Qemu-devel] Re: KVM call minutes for June 8

2010-06-10 Thread Kevin Wolf
Am 10.06.2010 14:53, schrieb Anthony Liguori: On 06/10/2010 04:43 AM, Kevin Wolf wrote: Huh, why this? Seems I still haven't understood all of qcow2 then... I always thought that there's just a specific offset where VM state starts, but no explicit end. A live snapshot can last

Re: [Qemu-devel] Re: KVM call minutes for June 8

2010-06-10 Thread Kevin Wolf
Am 10.06.2010 16:11, schrieb Avi Kivity: On 06/10/2010 04:08 PM, Kevin Wolf wrote: It's just not seen by the guest because it's saved at a high offset that is after the end of the real disk content, but otherwise it should behave the same as guest data. That's very unfriendly towards

Re: [PATCH v5] block: add sheepdog driver for distributed storage support

2010-06-11 Thread Kevin Wolf
Am 07.06.2010 20:00, schrieb MORITA Kazutaka: Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. This patch adds a qemu block driver for Sheepdog. Sheepdog features are: - No node in the cluster is special (no

Re: [PATCH v5] block: add sheepdog driver for distributed storage support

2010-06-15 Thread Kevin Wolf
Am 14.06.2010 21:48, schrieb MORITA Kazutaka: 3) qemu-io aio_read/write doesn't seem to work well with it. I only get the result of the AIO request when I exit qemu-io. This may be a qemu-io problem or a Sheepdog one. We need to look into this, qemu-io is important for testing and debugging

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Kevin Wolf
Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and PERSISTENT_RESERVE_IN case in scsi_req_length() to extra the incoming buffer length

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 15:03, schrieb Nicholas A. Bellinger: On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 15:09, schrieb Nicholas A. Bellinger: On Wed, 2010-06-16 at 06:03 -0700, Nicholas A. Bellinger wrote: On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n

Re: [PATCH 0/2] [scsi-bus]: Changes for PERSISTENT_RESERVE_OUT and MAINTENANCE CDBs v2

2010-06-16 Thread Kevin Wolf
to Kevin Wolf for pointing out the unnecessary SCSIRequest-cmd.xfer reassignments in scsi_req_length() from the original series. Tested with Linux KVM guests and Megasas 8708EM2 HBA emulation + scsi-generic and TCM_Loop target ports. Signed-off-by: Nicholas A. Bellinger n...@linux-iscsi.org

Re: [Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-06-18 Thread Kevin Wolf
Am 17.06.2010 21:05, schrieb Christian Brunner: Hi Simone, sorry for the late reply. I've been on vacation for a week. Thanks for sending the patch. At first sight your patch looks good. I'll do some testing by the weekend. Kevin also sent me a note about the missing aio support, but I

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Kevin Wolf
Am 06.07.2010 15:26, schrieb Anthony Liguori: On 07/05/2010 09:05 AM, Luiz Capitulino wrote: On Mon, 05 Jul 2010 14:45:23 +0200 Juan Quintelaquint...@redhat.com wrote: Please send in any agenda items you are interested in covering. - 0.13 release I was hoping to do -rc0

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Kevin Wolf
Am 06.07.2010 15:53, schrieb Anthony Liguori: On 07/06/2010 08:37 AM, Kevin Wolf wrote: Am 06.07.2010 15:26, schrieb Anthony Liguori: On 07/05/2010 09:05 AM, Luiz Capitulino wrote: On Mon, 05 Jul 2010 14:45:23 +0200 Juan Quintelaquint...@redhat.com wrote: Please send

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Kevin Wolf
Am 27.07.2010 15:00, schrieb Anthony Liguori: On 07/27/2010 02:19 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: - any additional input on probed_raw? Isn't it a fait accompli? I stopped providing input when commit 79368c81 appeared. No.

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-28 Thread Kevin Wolf
Am 28.07.2010 13:22, schrieb Markus Armbruster: Anthony Liguori anth...@codemonkey.ws writes: On 07/27/2010 10:22 AM, Markus Armbruster wrote: Kevin Wolfkw...@redhat.com writes: Am 27.07.2010 15:00, schrieb Anthony Liguori: On 07/27/2010 02:19 AM, Markus Armbruster wrote:

Re: [Qemu-devel] [PATCH] Fix qemu-img can't create qcow image based on read-only image

2010-01-28 Thread Kevin Wolf
Am 28.01.2010 06:22, schrieb Sheng Yang: Commit 03cbdac7 Disable fall-back to read-only when cannot open drive's file for read-write result in read-only image can't be used as backed image in qemu-img. CC: Naphtali Sprei nsp...@redhat.com Signed-off-by: Sheng Yang sh...@linux.intel.com ---

Re: [Qemu-devel] [PATCH v2] qemu-img: Fix qemu-img can't create qcow image based on read-only image

2010-01-28 Thread Kevin Wolf
Acked-by: Kevin Wolf kw...@redhat.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][RF C/T/D] Unmapped page cache control - via boot parameter

2010-03-16 Thread Kevin Wolf
Am 16.03.2010 10:17, schrieb Avi Kivity: On 03/15/2010 10:23 PM, Chris Webb wrote: Avi Kivitya...@redhat.com writes: On 03/15/2010 10:07 AM, Balbir Singh wrote: Yes, it is a virtio call away, but is the cost of paying twice in terms of memory acceptable? Usually, it

Re: KVM call agenda for Nov 23

2010-11-23 Thread Kevin Wolf
Am 22.11.2010 14:55, schrieb Stefan Hajnoczi: On Mon, Nov 22, 2010 at 1:38 PM, Juan Quintela quint...@redhat.com wrote: Please send in any agenda items you are interested in covering. QCOW2 performance roadmap: * What can be done to achieve near-raw image format performance? * Benchmark

Re: [Qemu-devel] Re: KVM call agenda for Nov 23

2010-11-24 Thread Kevin Wolf
Am 23.11.2010 15:53, schrieb Stefan Hajnoczi: On Tue, Nov 23, 2010 at 2:37 PM, Kevin Wolf kw...@redhat.com wrote: Am 22.11.2010 14:55, schrieb Stefan Hajnoczi: On Mon, Nov 22, 2010 at 1:38 PM, Juan Quintela quint...@redhat.com wrote: Please send in any agenda items you are interested

Re: [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-11-29 Thread Kevin Wolf
Am 27.11.2010 08:12, schrieb Stefan Hajnoczi: On Fri, Nov 26, 2010 at 9:59 PM, Christian Brunner c.m.brun...@gmail.com wrote: Thanks for the review. What am I supposed to do now? Kevin is the block maintainer. His review is the next step, I have CCed him. After that rbd would be ready to

Re: [Qemu-devel] Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy().

2010-11-29 Thread Kevin Wolf
Am 28.11.2010 12:55, schrieb Yoshiaki Tamura: 2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:52PM +0900, Yoshiaki Tamura wrote: Replace bdrv_aio_writev() with bdrv_aio_writev_proxy() to let event-tap capture events from dma-helpers. Signed-off-by: Yoshiaki

Re: [Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-11-29 Thread Kevin Wolf
Am 29.11.2010 09:59, schrieb Kevin Wolf: Am 27.11.2010 08:12, schrieb Stefan Hajnoczi: On Fri, Nov 26, 2010 at 9:59 PM, Christian Brunner c.m.brun...@gmail.com wrote: Thanks for the review. What am I supposed to do now? Kevin is the block maintainer. His review is the next step, I have

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-12-06 Thread Kevin Wolf
Am 17.11.2010 22:42, schrieb Christian Brunner: Here is another update for the ceph storage driver. It includes changes for the annotations Stefan made last week and a bit more things Sage discovered while looking over the driver again. I really hope that this time we are not only close, but

Re: Block device resize detection

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 12:29, schrieb Alexander Graf: On 06.12.2010, at 11:49, Vandeir Eduardo wrote: I have a KVM guest machine, lets name it VMTEST, using an iSCSI LUN as a virtio device. Something like this: disk type='block' device='disk' driver name='qemu' type='raw' cache='none'/ source

Re: [PATCH] ceph/rbd block driver for qemu-kvm (v9)

2010-12-08 Thread Kevin Wolf
Am 06.12.2010 20:53, schrieb Christian Brunner: This is a new version of the rbd driver. The only difference from v8 is a check for a recent librados version in configure. If the librados version is too old, rbd support will be disabled. RBD is an block driver for the distributed file system

Re: [Qemu-devel] Re: KVM call agenda for Jan 11

2011-01-11 Thread Kevin Wolf
Am 10.01.2011 14:32, schrieb Juan Quintela: Juan Quintela quint...@redhat.com wrote: Juan Quintela quint...@redhat.com wrote: Now sent it to the right kvm list. Sorry for the second sent. Please send any agenda items you are interested in covering. - KVM Forum 2011 (Jes). thanks, Juan.

Re: [PATCH] KVM-test: Add a ENOSPC subtest

2011-01-14 Thread Kevin Wolf
Am 14.01.2011 06:28, schrieb Amos Kong: - Original Message - From: Amos Kong ak...@redhat.com KVM guest always pauses on NOSPACE error, this test just repeatedly extend guest disk space and resume guest from paused status. Changes from v2: - Oops! Forgot to update

Linux in VirtualPC in KVM fails

2009-01-09 Thread Kevin Wolf
Hi, let's start with the scenario I tried to use: I have two levels of virtualization. On the physical hardware I run a Linux with KVM. The KVM guest is a Win2k3 VM which runs VirtualPC. In VirtualPC I try to run a Linux again (openSUSE 11.1 to be specific, but that shouldn't matter). The boot

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-11 Thread Kevin Wolf
Jamie Lokier schrieb: Although there are many ways to make Windows blue screen in KVM, in this case I've narrowed it down to the difference in qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83). This must be one of SVN revisions 5003 to 5008 in upstream qemu. Can you narrow it down to one

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-11 Thread Kevin Wolf
Jamie Lokier schrieb: Kevin Wolf wrote: Jamie Lokier schrieb: Although there are many ways to make Windows blue screen in KVM, in this case I've narrowed it down to the difference in qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83). This must be one of SVN revisions 5003 to 5008

Re: qcow2 corruption observed, fixed by reverting old change

2009-02-13 Thread Kevin Wolf
Hi Marc, You should not take qemu-devel out of the CC list. This is where the bugs need to be fixed, they aren't KVM specific. I'm quoting your complete mail to forward it to where it belongs. Marc Bevand schrieb: Jamie Lokier jamie at shareable.org writes: As you see from the subject, I'm

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-16 Thread Kevin Wolf
Jamie Lokier schrieb: Kevin Wolf wrote: Besides reviewing the code over and over again, I think the only real chance is that you can get a non-productive copy of your image and add some debug code so that we can see at least which code path is causing problems. I have a copy of my image

  1   2   3   >