Re: [PATCH v13 01/15] iommu: Introduce attach/detach_pasid_table API

2020-11-18 Thread Jacob Pan
igned-off-by: Jean-Philippe Brucker > Signed-off-by: Liu, Yi L > Signed-off-by: Ashok Raj > Signed-off-by: Jacob Pan > Signed-off-by: Eric Auger > > --- > > v12 -> v13: > - Fix config check > > v11 -> v12: > - add argsz, name the union > --- >

Re: [PATCH v11 01/13] iommu: Introduce attach/detach_pasid_table API

2020-04-15 Thread Jacob Pan
On Wed, 15 Apr 2020 16:52:10 +0200 Auger Eric wrote: > Hi Jacob, > On 4/15/20 12:15 AM, Jacob Pan wrote: > > Hi Eric, > > > > There are some discussions about how to size the uAPI data. > > https://lkml.org/lkml/2020/4/14/939 > > > > I think the pr

Re: [PATCH v11 01/13] iommu: Introduce attach/detach_pasid_table API

2020-04-14 Thread Jacob Pan
ta. If argsz <= minsz, kernel can support the attach_table but must process the data based on flags or config. Does it make sense to you? On Tue, 14 Apr 2020 17:05:55 +0200 Eric Auger wrote: > From: Jacob Pan > > In virtualization use case, when a guest is assigned > a PCI host dev

Re: [PATCH v8 26/29] vfio-pci: Register an iommu fault handler

2019-06-18 Thread Jacob Pan
On Tue, 18 Jun 2019 15:04:36 +0100 Jean-Philippe Brucker wrote: > On 12/06/2019 19:53, Jacob Pan wrote: > >>> You are right, the worst case of the spurious PS is to terminate > >>> the group prematurely. Need to know the scope of the HW damage in > >>> cas

Re: [PATCH v8 26/29] vfio-pci: Register an iommu fault handler

2019-06-12 Thread Jacob Pan
On Tue, 11 Jun 2019 14:14:33 +0100 Jean-Philippe Brucker wrote: > On 10/06/2019 22:31, Jacob Pan wrote: > > On Mon, 10 Jun 2019 13:45:02 +0100 > > Jean-Philippe Brucker wrote: > > > >> On 07/06/2019 18:43, Jacob Pan wrote: > >>&g

Re: [PATCH v8 26/29] vfio-pci: Register an iommu fault handler

2019-06-10 Thread Jacob Pan
On Mon, 10 Jun 2019 13:45:02 +0100 Jean-Philippe Brucker wrote: > On 07/06/2019 18:43, Jacob Pan wrote: > >>> So it seems we agree on the following: > >>> - iommu_unregister_device_fault_handler() will never fail > >>> - iommu driver clean

Re: [PATCH v8 26/29] vfio-pci: Register an iommu fault handler

2019-06-07 Thread Jacob Pan
On Fri, 7 Jun 2019 11:28:13 +0100 Jean-Philippe Brucker wrote: > On 06/06/2019 21:29, Jacob Pan wrote: > >>>>>> iommu_unregister_device_fault_handler(&vdev->pdev->dev); > >>>>> > >>>>> > >>>>> But th

Re: [PATCH v8 26/29] vfio-pci: Register an iommu fault handler

2019-06-06 Thread Jacob Pan
On Thu, 6 Jun 2019 19:54:05 +0100 Jean-Philippe Brucker wrote: > On 05/06/2019 23:45, Jacob Pan wrote: > > On Tue, 4 Jun 2019 18:11:08 +0200 > > Auger Eric wrote: > > > >> Hi Alex, > >> > >> On 6/4/19 12:31 AM, Alex Williamson wrote: >

Re: [PATCH v8 26/29] vfio-pci: Register an iommu fault handler

2019-06-05 Thread Jacob Pan
On Tue, 4 Jun 2019 18:11:08 +0200 Auger Eric wrote: > Hi Alex, > > On 6/4/19 12:31 AM, Alex Williamson wrote: > > On Sun, 26 May 2019 18:10:01 +0200 > > Eric Auger wrote: > > > >> This patch registers a fault handler which records faults in > >> a circular buffer and then signals an eventfd.

Re: [PATCH v8 05/29] iommu: Add a timeout parameter for PRQ response

2019-06-04 Thread Jacob Pan
On Tue, 4 Jun 2019 11:52:18 +0100 Jean-Philippe Brucker wrote: > On 03/06/2019 23:32, Alex Williamson wrote: > > It doesn't seem to make much sense to include this patch without > > also including "iommu: handle page response timeout". Was that one > > lost? Dropped? Lives elsewhere? > > The

Re: [PATCH v8 04/29] iommu: Add recoverable fault reporting

2019-06-04 Thread Jacob Pan
ust be completed by sending a page > > response back to the IOMMU. Add an iommu_page_response() function > > to complete a page fault. > > > > Signed-off-by: Jacob Pan > > Signed-off-by: Jean-Philippe Brucker > > --- > > drivers/iommu/iommu.c | 77 > > +++

Re: [PATCH v7 05/23] iommu: Introduce cache_invalidate API

2019-05-02 Thread Jacob Pan
On Thu, 2 May 2019 11:53:34 +0100 Jean-Philippe Brucker wrote: > On 02/05/2019 07:58, Auger Eric wrote: > > Hi Jean-Philippe, > > > > On 5/1/19 12:38 PM, Jean-Philippe Brucker wrote: > >> On 08/04/2019 13:18, Eric Auger wrote: > >>> +int iommu_cache_invalidate(struct iommu_domain *domain, st

Re: [PATCH v6 05/22] iommu: Introduce cache_invalidate API

2019-03-21 Thread Jacob Pan
tive > >> invalidation: > > > > My mistake: I meant dev-IOTLB and domain granularity are N/A > > Ah OK, no worries. > > How do we proceed further with those user APIs? Besides the comment to > be adde

Re: [PATCH v6 02/22] iommu: introduce device fault data

2019-03-21 Thread Jacob Pan
On Sun, 17 Mar 2019 18:22:12 +0100 Eric Auger wrote: > From: Jacob Pan > > Device faults detected by IOMMU can be reported outside the IOMMU > subsystem for further processing. This patch introduces > a generic device fault data structure. > > The fault can be either an u

Re: [PATCH v6 05/22] iommu: Introduce cache_invalidate API

2019-03-20 Thread Jacob Pan
are proposed here, > model specific IOMMU drivers need to convert them into their own > format. > > Signed-off-by: Liu, Yi L > Signed-off-by: Jean-Philippe Brucker > Signed-off-by: Jacob Pan > Signed-off-by: Ashok Raj > Signed-off-by: Eric Auger > > --- > v5 -

Re: [PATCH v5 05/22] iommu: Introduce cache_invalidate API

2019-03-15 Thread Jacob Pan
are proposed here, > model specific IOMMU drivers need to convert them into their own > format. > > Signed-off-by: Liu, Yi L > Signed-off-by: Jean-Philippe Brucker > Signed-off-by: Jacob Pan > Signed-off-by: Ashok Raj > Signed-off-by: Eric Auger > > --- > v3

Re: [PATCH v4 03/22] iommu: introduce device fault report API

2019-03-06 Thread Jacob Pan
GE) { > > + evt_pending = kmemdup(evt, sizeof(struct > > iommu_fault_event), > > + GFP_KERNEL); > > + if (!evt_pending) { > > + ret = -ENOMEM; > > + goto done_unlock; > > +

Re: [PATCH v4 05/22] iommu: Introduce cache_invalidate API

2019-03-06 Thread Jacob Pan
d to convert them > >> into their own format. > >> > >> Signed-off-by: Liu, Yi L > >> Signed-off-by: Jean-Philippe Brucker > >> Signed-off-by: Jacob Pan > >> Signed-off-by: Ashok Raj > >> Signed-off-by: Eric Auger > >> > &

Re: [RFC v3 14/21] iommu: introduce device fault data

2019-01-14 Thread Jacob Pan
On Fri, 11 Jan 2019 11:06:29 + Jean-Philippe Brucker wrote: > On 10/01/2019 18:45, Jacob Pan wrote: > > On Tue, 8 Jan 2019 11:26:26 +0100 > > Eric Auger wrote: > > > >> From: Jacob Pan > >> > >> Device faults detected by IOMMU can be r

Re: [RFC v3 14/21] iommu: introduce device fault data

2019-01-10 Thread Jacob Pan
On Tue, 8 Jan 2019 11:26:26 +0100 Eric Auger wrote: > From: Jacob Pan > > Device faults detected by IOMMU can be reported outside IOMMU > subsystem for further processing. This patch intends to provide > a generic device fault data such that device drivers can be > commu

Re: [RFC v2 14/20] iommu: introduce device fault data

2018-12-14 Thread Jacob Pan
On Wed, 12 Dec 2018 09:21:43 +0100 Auger Eric wrote: > Hi Jacob, > > On 9/21/18 12:06 AM, Jacob Pan wrote: > > On Tue, 18 Sep 2018 16:24:51 +0200 > > Eric Auger wrote: > > > >> From: Jacob Pan > >> > >> Device faults detected by

Re: [RFC v2 01/20] iommu: Introduce bind_pasid_table API

2018-09-21 Thread Jacob Pan
On Tue, 18 Sep 2018 16:24:38 +0200 Eric Auger wrote: > From: Jacob Pan > > In virtualization use case, when a guest is assigned > a PCI host device, protected by a virtual IOMMU on a guest, > the physical IOMMU must be programmed to be consistent with > the guest mapping

Re: [RFC v2 14/20] iommu: introduce device fault data

2018-09-21 Thread Jacob Pan
On Tue, 18 Sep 2018 16:24:51 +0200 Eric Auger wrote: > From: Jacob Pan > > Device faults detected by IOMMU can be reported outside IOMMU > subsystem for further processing. This patch intends to provide > a generic device fault data such that device drivers can be > commu

Re: [RFC v2 14/20] iommu: introduce device fault data

2018-09-21 Thread Jacob Pan
On Fri, 21 Sep 2018 11:54:56 +0200 Auger Eric wrote: > Hi Jacob, > > On 9/21/18 12:06 AM, Jacob Pan wrote: > > On Tue, 18 Sep 2018 16:24:51 +0200 > > Eric Auger wrote: > > > >> From: Jacob Pan > >> > >> Device faults detected by