[libav-devel] [PATCH 4/6] alsa: Coalesce source files after outdev removal

2017-10-04 Thread Diego Biurrun
--- libavdevice/Makefile | 2 +- libavdevice/alsa.c | 190 ++--- libavdevice/alsa.h | 94 libavdevice/alsa_dec.c | 178 - 4 files changed, 182 insertions(+), 282

[libav-devel] Removing output devices

2017-10-04 Thread Diego Biurrun
So, as we discussed at VDD, output devices as muxers were never a good idea to begin with. This set of patches drops them all. A suggestion for a better log message for 1/6 is welcome. Probably I also need to bump library versions somewhere. ___

[libav-devel] [PATCH 5/6] avfoundation: Drop silly _dec suffix from filename

2017-10-04 Thread Diego Biurrun
--- libavdevice/Makefile | 2 +- libavdevice/{avfoundation_dec.m => avfoundation.m} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename libavdevice/{avfoundation_dec.m => avfoundation.m} (100%) diff --git a/libavdevice/Makefile b/libavdevice/Makefile index

[libav-devel] [PATCH 3/6] oss: Coalesce source files after outdev removal

2017-10-04 Thread Diego Biurrun
--- libavdevice/Makefile | 2 +- libavdevice/oss.c | 122 ++--- libavdevice/oss.h | 45 libavdevice/oss_dec.c | 146 -- 4 files changed, 117 insertions(+), 198 deletions(-) delete

[libav-devel] [PATCH 2/6] sndio: Coalesce source files after outdev removal

2017-10-04 Thread Diego Biurrun
--- libavdevice/Makefile| 2 +- libavdevice/sndio.c | 108 +-- libavdevice/sndio.h | 48 --- libavdevice/sndio_dec.c | 120 4 files changed, 104 insertions(+), 174 deletions(-)

[libav-devel] [PATCH 1/6] Remove all output devices

2017-10-04 Thread Diego Biurrun
--- configure| 22 ++--- doc/avconv.texi | 1 - doc/avplay.texi | 1 - doc/outdevs.texi | 33 - libavdevice/Makefile | 5 +- libavdevice/alldevices.c | 39 ++-- libavdevice/alsa.c | 16 ---

[libav-devel] [PATCH 2/2] configure: Use test_pkg_config() for the SDL check

2017-10-04 Thread Diego Biurrun
From: James Almer <jamr...@gmail.com> Removes the extra code to preserve global CFLAGS. Signed-off-by: James Almer <jamr...@gmail.com> Signed-off-by: Diego Biurrun <di...@biurrun.de> --- Simplified the code a bit and reworded a comment. configure | 10 +++--- 1 file cha

[libav-devel] [PATCH 1/2] configure: Add test_pkg_config()

2017-10-04 Thread Diego Biurrun
From: James Almer <jamr...@gmail.com> This helper is split off check_pkg_config(), setting only the pkg CFLAGS and extralibs. This is useful for checks that do not require or do not benefit from setting global CFLAGS. Signed-off-by: James Almer <jamr...@gmail.com> Signed-off-by: D

Re: [libav-devel] [PATCH 7/7] lavc: Deprecate av_hwaccel_next()

2017-10-04 Thread Diego Biurrun
On Wed, Oct 04, 2017 at 09:07:16AM +0100, Mark Thompson wrote: > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -4907,12 +4907,18 @@ unsigned int av_xiphlacing(unsigned char *s, unsigned > int v); > +#if FF_API_HWACCEL_NEXT > /** > * If hwaccel is NULL, returns the first

Re: [libav-devel] [PATCH 1/2 v2] configure: add test_pkg_config()

2017-10-03 Thread Diego Biurrun
On Fri, Sep 29, 2017 at 10:56:08PM -0300, James Almer wrote: > --- a/configure > +++ b/configure > @@ -1039,8 +1039,15 @@ check_pkg_config(){ > pkg_libs=$($pkg_config --libs $pkg_config_flags $pkg) > check_func_headers "$headers" "$funcs" $pkg_cflags $pkg_libs "$@" && > enable

Re: [libav-devel] [PATCH 1/2 v2] configure: add test_pkg_config()

2017-10-03 Thread Diego Biurrun
On Mon, Oct 02, 2017 at 11:49:27AM +0200, Diego Biurrun wrote: > On Fri, Sep 29, 2017 at 10:56:08PM -0300, James Almer wrote: > > --- a/configure > > +++ b/configure > > @@ -1025,8 +1025,8 @@ check_lib(){ > > > > -check_pkg_config(){ > > -log che

Re: [libav-devel] [PATCH 1/2 v2] configure: add test_pkg_config()

2017-10-02 Thread Diego Biurrun
On Fri, Sep 29, 2017 at 10:56:08PM -0300, James Almer wrote: > --- a/configure > +++ b/configure > @@ -1025,8 +1025,8 @@ check_lib(){ > > -check_pkg_config(){ > -log check_pkg_config "$@" > +test_pkg_config(){ > +log test_pkg_config "$@" > name="$1" > pkg_version="$2" >

Re: [libav-devel] [PATCH 2/2 v2] configure: use test_pkg_config() for the SDL check

2017-10-02 Thread Diego Biurrun
On Fri, Sep 29, 2017 at 10:56:09PM -0300, James Almer wrote: > --- a/configure > +++ b/configure > @@ -4873,10 +4873,7 @@ fi > > # SDL is "special" and adds some CFLAGS that should not pollute anything > else. > if enabled avplay; then > -CFLAGS_SAVE=$CFLAGS > -check_pkg_config sdl

Re: [libav-devel] Quick notes from the Tech Meeting held at the VDD

2017-09-28 Thread Diego Biurrun
On Tue, Sep 26, 2017 at 01:54:56PM +0200, Luca Barbato wrote: > • release/14 Items (what needs more time and won't fit 13) > • Rewrite YADIF from scratch (Anton), some assumptions made while that > code was written are going to not apply anymore. We should mention here what the problem

Re: [libav-devel] [PATCH 2/2] qsv: Join the derived session to the parent

2017-09-26 Thread Diego Biurrun
On Mon, Sep 25, 2017 at 10:04:30AM +, Luca Barbato wrote: > --- a/libavcodec/qsv.c > +++ b/libavcodec/qsv.c > @@ -594,6 +594,11 @@ int ff_qsv_init_session_device(AVCodecContext *avctx, > mfxSession *psession, > > +err = MFXJoinSession(parent_session, session); > +if (err !=

Re: [libav-devel] [PATCH 1/2] qsv: Make sure the session is set with the latest version

2017-09-26 Thread Diego Biurrun
On Mon, Sep 25, 2017 at 10:04:29AM +, Luca Barbato wrote: > --- a/libavutil/hwcontext_qsv.c > +++ b/libavutil/hwcontext_qsv.c > @@ -1029,6 +1029,24 @@ static int > qsv_device_derive_from_child(AVHWDeviceContext *ctx, > +if (err != MFX_ERR_NONE) { > +av_log(ctx, AV_LOG_ERROR,

Re: [libav-devel] [PATCH 2/2] smacker: fix integer overflow with pts_inc

2017-09-24 Thread Diego Biurrun
On Sun, Sep 24, 2017 at 01:34:49PM +0200, Sean McGovern wrote: > From: Michael Niedermayer > > Bug-Id: 1073 > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > Signed-off-by: Sean McGovern > --- > libavformat/smacker.c | 5 + > 1 file

Re: [libav-devel] [PATCH 1/2] smacker: return meaningful error codes on failure

2017-09-24 Thread Diego Biurrun
On Sun, Sep 24, 2017 at 01:34:48PM +0200, Sean McGovern wrote: > --- > libavformat/smacker.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [RFC][PATCH] lavf: Wrap _DEFAULT_SOURCE symbols

2017-09-24 Thread Diego Biurrun
On Thu, Sep 21, 2017 at 07:09:04PM +0200, Vittorio Giovara wrote: > On Thu, Sep 21, 2017 at 6:35 PM, Diego Biurrun <di...@biurrun.de> wrote: > > On Thu, Sep 21, 2017 at 01:44:44PM +0200, Vittorio Giovara wrote: > > > Silence warnings such as: > > > >

Re: [libav-devel] [PATCH] cbs_h264: Fix writing streams with auxiliary pictures

2017-09-24 Thread Diego Biurrun
On Sat, Sep 23, 2017 at 04:46:11PM +0100, Mark Thompson wrote: > On 22/09/17 15:24, James Almer wrote: > > On 9/21/2017 8:51 AM, Vittorio Giovara wrote: > >> --- > >> This is to silence this warning (which, admittedly, could also be ignored) > >> > >> cbs_h2645.c:1007:58: warning: variable

Re: [libav-devel] [PATCH] configure: cosmetics: Wrap a configure error string to the paragraph length

2017-09-23 Thread Diego Biurrun
On Thu, Sep 21, 2017 at 07:08:00PM +0200, Vittorio Giovara wrote: > On Thu, Sep 21, 2017 at 6:34 PM, Diego Biurrun <di...@biurrun.de> wrote: > > On Thu, Sep 21, 2017 at 01:37:03PM +0200, Vittorio Giovara wrote: > > > --- a/configure > > > +++ b/configure > >

Re: [libav-devel] [PATCH 3/3] qsvenc: use 'else' on exclusive code

2017-09-21 Thread Diego Biurrun
On Thu, Sep 21, 2017 at 03:52:27PM +0200, Steve Lhomme wrote: > --- > libavcodec/qsvenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) What is "exclusive code"? > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -1122,7 +1122,7 @@ static int encode_frame(AVCodecContext

Re: [libav-devel] [RFC][PATCH] lavf: Wrap _DEFAULT_SOURCE symbols

2017-09-21 Thread Diego Biurrun
On Thu, Sep 21, 2017 at 01:44:44PM +0200, Vittorio Giovara wrote: > Silence warnings such as: > > libavformat/udp.c:27:9: warning: '_DEFAULT_SOURCE' >macro redefined [-Wmacro-redefined] > #define _DEFAULT_SOURCE > ^ > :4:9: note: previous definition is here > #define

Re: [libav-devel] [PATCH] configure: cosmetics: Wrap a configure error string to the paragraph length

2017-09-21 Thread Diego Biurrun
On Thu, Sep 21, 2017 at 01:37:03PM +0200, Vittorio Giovara wrote: > --- a/configure > +++ b/configure > @@ -401,8 +401,8 @@ include the log this produces with your report. > EOF > else > cat < -Include the log file "$logfile" produced by configure as this will help > -solving the

Re: [libav-devel] [PATCH 09/11] cbs: Add some read/write tests

2017-09-21 Thread Diego Biurrun
On Wed, Sep 20, 2017 at 09:03:40PM +0100, Mark Thompson wrote: > On 20/09/17 19:48, Diego Biurrun wrote: > > On Sun, Sep 10, 2017 at 12:09:13AM +0100, Mark Thompson wrote: > >> --- /dev/null > >> +++ b/tests/fate/cbs.mak > >> @@ -0,0 +1,74 @@ > >>

Re: [libav-devel] [PATCH 09/11] cbs: Add some read/write tests

2017-09-20 Thread Diego Biurrun
On Sun, Sep 10, 2017 at 12:09:13AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/tests/fate/cbs.mak > @@ -0,0 +1,74 @@ > + > +define FATE_CBS_TEST > +# (codec, test_name, sample_file, output_format) > +FATE_CBS_$(1) += fate-cbs-$(1)-$(2) > +fate-cbs-$(1)-$(2): CMD = md5 -i

Re: [libav-devel] [PATCH 7/9] cbs: Add some read/write tests

2017-09-19 Thread Diego Biurrun
On Mon, Aug 28, 2017 at 06:08:53PM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/tests/fate/cbs.mak > @@ -0,0 +1,76 @@ > + > +define FATE_CBS_SAMPLE_TEST > +FATE_CBS_$(1) += fate-cbs-$(1)-$(2) > +fate-cbs-$(1)-$(2): CMD = md5 -i $(TARGET_SAMPLES)/$(3) -c:v copy -bsf:v > $(1)_metadata -f

Re: [libav-devel] [PATCH] cpu: split flag checks per arch in av_cpu_max_align()

2017-09-14 Thread Diego Biurrun
On Mon, Aug 28, 2017 at 12:53:09PM -0300, James Almer wrote: > On 8/28/2017 12:08 PM, wm4 wrote: > > On Mon, 28 Aug 2017 11:52:52 -0300 > > James Almer wrote: > >> --- a/libavutil/cpu.c > >> +++ b/libavutil/cpu.c > >> @@ -184,12 +185,20 @@ int av_cpu_count(void) > >> > >>

Re: [libav-devel] [PATCH] checkasm: Test more h264 idct variants

2017-09-03 Thread Diego Biurrun
On Sat, Sep 02, 2017 at 10:24:45PM +0300, Martin Storsjö wrote: > --- > tests/checkasm/h264dsp.c | 90 > +++- > 1 file changed, 89 insertions(+), 1 deletion(-) > --- a/tests/checkasm/h264dsp.c > +++ b/tests/checkasm/h264dsp.c > @@ -223,10 +224,97 @@

Re: [libav-devel] [PATCH 4/5] configure: Use dllexport/dllimport for data symbols across DLLs with mingw

2017-09-02 Thread Diego Biurrun
On Fri, Aug 25, 2017 at 10:46:43AM +0300, Martin Storsjö wrote: > --- a/configure > +++ b/configure > @@ -4032,6 +4032,10 @@ case $target_os in > elif enabled arm; then > LIBTARGET=arm-wince > fi > +if enabled shared; then > +# Cannot build both

Re: [libav-devel] [PATCH] lavf: make avio_read_partial() public

2017-08-19 Thread Diego Biurrun
On Sat, Aug 19, 2017 at 07:28:43PM +0200, Anton Khirnov wrote: > Quoting wm4 (2017-08-18 15:35:49) > > On Fri, 18 Aug 2017 15:22:28 +0200 > > Anton Khirnov wrote: > > > > > Quoting wm4 (2017-08-18 14:44:45) > > > > On Fri, 18 Aug 2017 15:40:32 +0300 (EEST) > > > > Martin

Re: [libav-devel] [PATCH 01/14] lavc: Add coded bitstream read/write API

2017-08-12 Thread Diego Biurrun
On Sat, Aug 12, 2017 at 07:21:49PM +0100, Mark Thompson wrote: > On 12/08/17 09:40, Diego Biurrun wrote: > > On Fri, Aug 11, 2017 at 12:36:56AM +0100, Mark Thompson wrote: > >> --- /dev/null > >> +++ b/libavcodec/cbs.h > >> @@ -0,0 +1,274 @@ > &g

Re: [libav-devel] [PATCH 02/14] lavc: Add coded bitstream read/write support for H.264

2017-08-12 Thread Diego Biurrun
On Sat, Aug 12, 2017 at 07:23:50PM +0100, Mark Thompson wrote: > On 12/08/17 09:44, Diego Biurrun wrote: > > On Fri, Aug 11, 2017 at 12:36:57AM +0100, Mark Thompson wrote: > >> --- /dev/null > >> +++ b/libavcodec/cbs_h2645.c > >> @@ -0,0 +1,997 @@ >

Re: [libav-devel] [PATCH V2] libavcodec/mjpeg_qsv: Add the QSV MJPEG encoder

2017-08-12 Thread Diego Biurrun
On Fri, Jul 21, 2017 at 10:08:15AM +0800, Huang, Zhengxu wrote: > > > On 2017/7/20 20:07, Diego Biurrun wrote: > > On Wed, Jul 19, 2017 at 02:41:31PM +0800, Huang, Zhengxu wrote: > > > --- a/libavcodec/qsvenc.c > > > +++ b/libavcodec

Re: [libav-devel] [PATCH] h264dec: add a CUVID hwaccel

2017-08-12 Thread Diego Biurrun
On Thu, Jul 27, 2017 at 01:30:52PM +0300, Martin Storsjö wrote: > On Thu, 27 Jul 2017, Anton Khirnov wrote: > > Quoting Sean McGovern (2017-07-27 07:42:29) > > > On Mon, Jul 24, 2017 at 12:50 PM, Anton Khirnov wrote: > > > > Quoting Luca Barbato (2017-07-24 18:21:20) > > > >>

Re: [libav-devel] [PATCH 1/2 V4] libavfilter/overlay_qsv: Add QSV overlay vpp filter

2017-08-12 Thread Diego Biurrun
On Thu, Aug 10, 2017 at 09:21:25AM +0800, Huang, Zhengxu wrote: > The second one I am not quite sure the format of the filters.texi. So I don't > do this in the new patch. Look at filters.texi, experiment a bit; it should not be hard. If you have trouble, just ask. Diego

Re: [libav-devel] [PATCH 00/14] Coded bitstream editing (v6)

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:36:55AM +0100, Mark Thompson wrote: > The build system changes want some review, but after that hopefully 1-9 are > done. OK, minor nits noted as replies. Kudos for this whole effort from my side btw. Diego ___ libav-devel

Re: [libav-devel] [PATCH 13/14] qsvenc_hevc: Replace ad-hoc VPS writing with CBS implementation

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:08AM +0100, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -2288,7 +2288,7 @@ > h264_vaapi_encoder_deps="VAEncPictureParameterBufferH264" > h264_vaapi_encoder_select="vaapi_encode cbs_h264 golomb" > hevc_nvenc_encoder_deps="nvenc" >

Re: [libav-devel] [PATCH 11/14] vaapi_h265: Convert to use coded bitstream infrastructure

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:06AM +0100, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -2290,7 +2290,7 @@ hevc_nvenc_encoder_deps="nvenc" > hevc_qsv_decoder_select="hevc_mp4toannexb_bsf hevc_parser hevc_qsv_hwaccel > qsvdec" > hevc_qsv_encoder_select="hevc_ps qsvenc" >

Re: [libav-devel] [PATCH 08/14] vaapi_h264: Convert to use coded bitstream infrastructure

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:03AM +0100, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -2285,7 +2285,7 @@ h264_omx_encoder_deps="omx" > h264_qsv_decoder_select="h264_mp4toannexb_bsf h264_parser qsvdec > h264_qsv_hwaccel" > h264_qsv_encoder_select="qsvenc" >

Re: [libav-devel] [PATCH 07/14] lavc: Add hevc_metadata bitstream filter

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:02AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/libavcodec/h265_metadata_bsf.c > @@ -0,0 +1,458 @@ > + > +typedef struct H265MetadataContext { > +const AVClass *class; Unused, the same as with H.264? Diego ___

Re: [libav-devel] [PATCH 05/14] lavc: Add h264_metadata bitstream filter

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:00AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/libavcodec/h264_metadata_bsf.c > @@ -0,0 +1,511 @@ > + > +typedef struct H264MetadataContext { > +const AVClass *class; Isn't the class member unused? Or did I just miss where this is used for logging?

Re: [libav-devel] [PATCH 02/14] lavc: Add coded bitstream read/write support for H.264

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:36:57AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/libavcodec/cbs_h2645.c > @@ -0,0 +1,997 @@ > + > +#define FUNC(name) FUNC_H264(READWRITE, name) > +#include "cbs_h264_syntax.c" > +#undef FUNC > + > +#define FUNC(name) FUNC_H264(READWRITE, name) > +#include

Re: [libav-devel] [PATCH 01/14] lavc: Add coded bitstream read/write API

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:36:56AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/libavcodec/cbs.c > @@ -0,0 +1,461 @@ > + > +int ff_cbs_init(CodedBitstreamContext *ctx, > +enum AVCodecID codec_id, void *log_ctx) > +{ > +ctx->log_ctx = log_ctx; > + > +ctx->codec =

Re: [libav-devel] [PATCH 1/2 V6] libavfilter/overlay_qsv: Add QSV overlay vpp filter

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 09:46:17AM +0800, Huang, Zhengxu wrote: > From c4e8d8c22f2100bd9bffaccca628c5bd3bfd7281 Mon Sep 17 00:00:00 2001 > From: "Huang, Zhengxu" > Date: Tue, 25 Jul 2017 21:55:50 +0800 > Subject: [PATCH] libavfilter/overlay_qsv: Add QSV overlay vpp

[libav-devel] [PATCH] xwddec: support 8bpp grayscale

2017-08-12 Thread Diego Biurrun
From: Piotr Bandurski <ami_st...@o2.pl> (cherry picked from commit b9c94e826e7551027754ecfa60e3e487e0c28fcb) Signed-off-by: Diego Biurrun <di...@biurrun.de> --- Includes the check for bpp == pixdepth now. libavcodec/xwddec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deleti

Re: [libav-devel] [PATCH 2/2] xwddec: Check bpp more completely

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 09:35:32PM +0200, Luca Barbato wrote: > On 11/08/2017 20:46, Diego Biurrun wrote: > > From: Michael Niedermayer <mich...@niedermayer.cc> > > > > Fixes out of array access > > Fixes: 1399/clusterfuzz-testcase-minimized-4866094172995584

Re: [libav-devel] [PATCH 1/2] cdxl: Avoid setting wrong pixfmt for CHUNKY format

2017-08-11 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 09:33:07PM +0200, Luca Barbato wrote: > On 11/08/2017 20:28, Diego Biurrun wrote: > > --- a/libavcodec/cdxl.c > > +++ b/libavcodec/cdxl.c > > @@ -244,9 +244,9 @@ static int cdxl_decode_frame(AVCodecContext *avctx, > > void *data, > >

[libav-devel] [PATCH 2/2] xwddec: Check bpp more completely

2017-08-11 Thread Diego Biurrun
ed-off-by: Michael Niedermayer <mich...@niedermayer.cc> (cherry picked from commit 441026fcb13ac23aa10edc312bdacb6445a0ad06) Signed-off-by: Diego Biurrun <di...@biurrun.de> --- libavcodec/xwddec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/xwd

[libav-devel] [PATCH 1/2] xwddec: support 8bpp grayscale

2017-08-11 Thread Diego Biurrun
From: Piotr Bandurski <ami_st...@o2.pl> (cherry picked from commit b9c94e826e7551027754ecfa60e3e487e0c28fcb) Signed-off-by: Diego Biurrun <di...@biurrun.de> --- libavcodec/xwddec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/xwddec.c

[libav-devel] [PATCH 1/2] cdxl: Avoid setting wrong pixfmt for CHUNKY format

2017-08-11 Thread Diego Biurrun
https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> (cherry picked from commit e1b60aad77c27ed5d4dfc11e5e6a05a38c70489d) (cherry picked from commit 1e42736b95065c69a7481d0cf55247024f54b660) Signed-off-by: Diego Biurrun <d

[libav-devel] [PATCH 2/2] dfa: Disallow odd width/height and add proper bounds check for DDS1 chunks

2017-08-11 Thread Diego Biurrun
DDS1 chunks are decoded in 2x2 blocks, odd chunk width or height is not allowed in that case. Also ensure that the decode buffer is big enough for all blocks being processed. Bug-Id: CVE-2017-9992 CC: libav-sta...@libav.org --- libavcodec/dfa.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [libav-devel] [PATCH V2] libavcodec/mjpeg_qsv: Add the QSV MJPEG encoder

2017-07-20 Thread Diego Biurrun
On Wed, Jul 19, 2017 at 02:41:31PM +0800, Huang, Zhengxu wrote: > --- > Changes from v1: > * separate the mjpeg encoder from h264/hevc/mpeg2 as per Luca's review > * reuse the global_quality option as per Luca's review > * modify some coding-style and add changlog as per Diego's review > --- >

Re: [libav-devel] [PATCH 2/2] png: Support RGBA64 pixel format

2017-07-17 Thread Diego Biurrun
On Sun, Jul 16, 2017 at 04:05:00PM +0200, Luca Barbato wrote: > --- > libavcodec/pngdec.c | 3 +++ > 1 file changed, 3 insertions(+) probably OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/2] png: Report more details regarding unsupported pixel formats

2017-07-17 Thread Diego Biurrun
On Sun, Jul 16, 2017 at 04:04:59PM +0200, Luca Barbato wrote: > --- > libavcodec/pngdec.c | 3 +++ > 1 file changed, 3 insertions(+) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] libavcodec/mjpeg_qsv: Add the QSV MJPEG encoder

2017-07-17 Thread Diego Biurrun
On Mon, Jul 17, 2017 at 04:40:38PM +0800, Huang, Zhengxu wrote: > > From 45be66259e8fb99b05796748ead308f0fc73c68c Mon Sep 17 00:00:00 2001 > From: "Huang, Zhengxu" > Date: Tue, 18 Jul 2017 01:13:24 +0800 > Subject: [PATCH] libavcodec/mjpeg_qsv: Add the QSV MJPEG

Re: [libav-devel] [PATCH v2] rmdec: don't ignore the return value of av_get_packet()

2017-07-17 Thread Diego Biurrun
On Sun, Jul 16, 2017 at 12:24:06PM -0400, Sean McGovern wrote: > --- a/libavformat/rmdec.c > +++ b/libavformat/rmdec.c > @@ -778,11 +779,17 @@ ff_rm_parse_packet (AVFormatContext *s, AVIOContext *pb, > } else { > -av_get_packet(pb, pkt, len); > +ret =

[libav-devel] [PATCH] build: Add feature test macros for glibc 2.19+

2017-07-10 Thread Diego Biurrun
glibc introduced _DEFAULT_SOURCE in version 2.19 to replace _BSD_SOURCE and _SVID_SOURCE, which were deprecated in version 2.20. Add _DEFAULT_SOURCE where the latter two are used to be forwards-compatible and avoid warnings about the use of deprecated definitions. --- libavformat/os_support.c | 1

Re: [libav-devel] [PATCH] bitstream: Make bitstream_skip more robust

2017-07-09 Thread Diego Biurrun
On Sun, Jul 09, 2017 at 12:46:39AM +0200, Luca Barbato wrote: > On 7/8/17 11:48 PM, Luca Barbato wrote: > > Do not use skip_remaining to fully wipe the cache. > > Thanks to Uoti for pointing out the problem. > > > > CC: libav-sta...@libav.org > > Uoti suggested: > > bitstream: Avoid

[libav-devel] [PATCH] bink: Split read_dct_coeffs()

2017-07-05 Thread Diego Biurrun
This works around type aliasing violations and related warnings. Also add some missing error checking. --- Now without any dubious casts and whatnot. libavcodec/bink.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git

Re: [libav-devel] [PATCH 1/2] d3d11va: Check WINAPI_FAMILY instead of HAVE_LOADLIBRARY

2017-07-05 Thread Diego Biurrun
On Wed, Jul 05, 2017 at 12:42:21PM +0300, Martin Storsjö wrote: > --- a/configure > +++ b/configure > @@ -4892,9 +4893,21 @@ if enabled libxcb; then > check_pkg_config libxcb_xfixes xcb-xfixes xcb/xfixes.h > xcb_xfixes_get_cursor_image > fi > > +check_cpp < +#ifdef WINAPI_FAMILY >

Re: [libav-devel] [PATCH] d3d11va: Check WINAPI_FAMILY instead of HAVE_LOADLIBRARY

2017-07-04 Thread Diego Biurrun
On Tue, Jul 04, 2017 at 10:18:21PM +0300, Martin Storsjö wrote: > --- a/configure > +++ b/configure > @@ -4894,7 +4894,14 @@ fi > > # d3d11va requires linking directly to dxgi and d3d11 if not building for > # the desktop api partition > -enabled LoadLibrary || d3d11va_extralibs="-ldxgi

Re: [libav-devel] [PATCH] d3d11va: Check WINAPI_FAMILY instead of HAVE_LOADLIBRARY

2017-07-04 Thread Diego Biurrun
On Tue, Jul 04, 2017 at 10:57:41PM +0300, Martin Storsjö wrote: > On Tue, 4 Jul 2017, wm4 wrote: > >On Tue, 4 Jul 2017 22:18:21 +0300 Martin Storsjö wrote: > >>--- a/libavutil/hwcontext_d3d11va.c > >>+++ b/libavutil/hwcontext_d3d11va.c > >>@@ -47,6 +47,13 @@ > >> > >>+#ifdef

[libav-devel] [PATCH] [RFC] Add Cinepak encoder

2017-07-04 Thread Diego Biurrun
From: Tomas Härdin Signed-off-by: Diego Biurrun <di...@biurrun.de> --- The whole set squashed together, to ease Luca's review. Changelog|1 + doc/general.texi |2 +- libavcodec/Makefile |1 + libavcodec/allco

Re: [libav-devel] [PATCH 8/9] cinepakenc: misc small changes

2017-07-04 Thread Diego Biurrun
On Mon, Jul 03, 2017 at 08:18:32PM +0200, Luca Barbato wrote: > On 6/28/17 12:27 AM, Diego Biurrun wrote: > > --- a/libavcodec/cinepakenc.c > > +++ b/libavcodec/cinepakenc.c > > @@ -212,10 +211,10 @@ static av_cold int cinepak_encode_init(AVCodecContext > > *

Re: [libav-devel] [PATCH 1/9] Adding Cinepak encoder

2017-07-04 Thread Diego Biurrun
On Mon, Jul 03, 2017 at 08:20:20PM +0200, Luca Barbato wrote: > On 6/28/17 12:27 AM, Diego Biurrun wrote: > > +av_log(avctx, AV_LOG_INFO, "strip coding stats: %i V1 mode, %i V4 > > mode, %i MC mode (%i V1 encs, %i V4 encs, %i skips)\n", > > +s-

Re: [libav-devel] [PATCH] lavf: Remove codec_tag from dashend and smoothstreamingenc

2017-06-30 Thread Diego Biurrun
On Fri, Jun 30, 2017 at 12:52:08PM +0300, Martin Storsjö wrote: > Currently, the tags enforced and set on the segmenter muxer level > mismatches what the mp4/ismv muxer uses (since 713efb2c0d013). s/mismatches/mismatch/ > Skip the codec_tag altogether here, to let the user (try to) set >

Re: [libav-devel] [PATCH] lavu: Add DRM hwcontext

2017-06-29 Thread Diego Biurrun
On Thu, Jun 29, 2017 at 10:32:16AM +0100, Mark Thompson wrote: > On 29/06/17 08:31, Diego Biurrun wrote: > > On Sun, Jun 18, 2017 at 07:08:02PM +0100, Mark Thompson wrote: > >> --- /dev/null > >> +++ b/libavutil/hwcontext_drm.h > >> @@ -0,0 +1,145 @@ > &g

Re: [libav-devel] [PATCH 04/12] hwcontext_opencl: QSV to OpenCL mapping for Intel Media SDK

2017-06-29 Thread Diego Biurrun
On Tue, Jun 27, 2017 at 10:50:46PM +0100, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -1720,6 +1720,7 @@ HAVE_LIST=" > libc_msvcrt > MMAL_PARAMETER_VIDEO_MAX_NUM_CALLBACKS > opencl_beignet_vaapi > +opencl_intel_media_vaapi OK, I see that you add a second

Re: [libav-devel] [PATCH 03/12] hwcontext_opencl: VAAPI to OpenCL mapping for Intel i965+beignet

2017-06-29 Thread Diego Biurrun
On Tue, Jun 27, 2017 at 10:50:45PM +0100, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -1719,6 +1719,7 @@ HAVE_LIST=" > dos_paths > libc_msvcrt > MMAL_PARAMETER_VIDEO_MAX_NUM_CALLBACKS > +opencl_beignet_vaapi > sdl > section_data_rel_ro > threads

Re: [libav-devel] [PATCH 22/25] aac: Allow pass-through transcoding of ambisonic audio

2017-06-29 Thread Diego Biurrun
On Wed, Jun 28, 2017 at 06:11:06PM -0400, Vittorio Giovara wrote: > The defacto mov standard mandates support for PCM and AAC: only the de facto MOV Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 20/25] lavf: Add non diegetic stream disposition flag

2017-06-29 Thread Diego Biurrun
On Wed, Jun 28, 2017 at 06:11:04PM -0400, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > libavformat/avformat.h | 6 ++ > libavformat/dump.c | 2 ++ > 2 files changed, 8 insertions(+) non-diegetic > --- a/libavformat/dump.c > +++

Re: [libav-devel] [PATCH 08/25] libavfilter changes for the new channel layout API

2017-06-29 Thread Diego Biurrun
On Wed, Jun 28, 2017 at 06:10:52PM -0400, Vittorio Giovara wrote: > --- a/libavfilter/af_aformat.c > +++ b/libavfilter/af_aformat.c > @@ -94,6 +94,13 @@ static int get_sample_rate(const char *samplerate) > +static int get_channel_layout(const char *channel_layout) > +{ > +AVChannelLayout

Re: [libav-devel] [PATCH] lavu: Add DRM hwcontext

2017-06-29 Thread Diego Biurrun
On Sun, Jun 18, 2017 at 07:08:02PM +0100, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -190,6 +190,7 @@ External library support: >--enable-avisynth video frameserver >--enable-avxsynth Linux version of AviSynth >--enable-bzlib bzip2

Re: [libav-devel] [PATCH 18/25] lavr: Only let pass-through ambisonic channel layouts

2017-06-29 Thread Diego Biurrun
On Wed, Jun 28, 2017 at 06:11:02PM -0400, Vittorio Giovara wrote: > Resampling or conversion to/from ambisonic audio are currently > unsupported features. Maybe you mean something like lavr: Only allow pass-through of ambisonic channel layouts ? Your current commit title does not parse...

Re: [libav-devel] [PATCH 24/25] fate: Add ambisonic tests

2017-06-29 Thread Diego Biurrun
On Wed, Jun 28, 2017 at 06:11:08PM -0400, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > tests/fate/mov.mak| 3 +++ > tests/fate/opus.mak | 5 + > tests/ref/fate/mov-ambisonic | 1 + > tests/ref/fate/opus-ambisonic | 1 + >

Re: [libav-devel] [libav-commits] dvbsubdec: Fixed segfault when decoding subtitles

2017-06-28 Thread Diego Biurrun
On Wed, Jun 28, 2017 at 04:14:23PM +0200, Lorenz Brun wrote: > Module: libav > Branch: master > Commit: 1cfd566324f4a9be066ea400685b81c0695e64d9 > > Author:Lorenz Brun > Committer: Vittorio Giovara > Date: Fri Oct 21 22:51:37 2016

[libav-devel] [PATCH 1/9] Adding Cinepak encoder

2017-06-27 Thread Diego Biurrun
From: Tomas Härdin With permission of Tomas Härdin applied by Rl aetey.se Signed-off-by: Diego Biurrun <di...@biurrun.de> --- Changelog | 1 + doc/general.texi| 2 +- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 2 +- libavcodec/cinepakenc.c

[libav-devel] [PATCH 7/9] cinepakenc: K formatting cosmetics

2017-06-27 Thread Diego Biurrun
--- libavcodec/cinepakenc.c | 872 1 file changed, 444 insertions(+), 428 deletions(-) diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c index afa0c8e..05a7b88 100644 --- a/libavcodec/cinepakenc.c +++ b/libavcodec/cinepakenc.c @@

[libav-devel] [PATCH 6/9] cinepakenc: Drop commented-out cruft

2017-06-27 Thread Diego Biurrun
--- libavcodec/cinepakenc.c | 38 +- 1 file changed, 5 insertions(+), 33 deletions(-) diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c index ddf560a..afa0c8e 100644 --- a/libavcodec/cinepakenc.c +++ b/libavcodec/cinepakenc.c @@ -308,8 +308,6 @@

[libav-devel] [PATCH 2/9] cinepakenc: fixes and improvements

2017-06-27 Thread Diego Biurrun
From: "addr-see-the-webs...@aetey.se" <addr-see-the-webs...@aetey.se> Fixed/improved multistrip adaptivity. Improved R/D by optimized codebook generation. Support for the correct color space. Vintage compatibility. Signed-off-by: Diego Biurrun <di...@biurrun.de> --- l

[libav-devel] [PATCH 5/9] cinepakenc: Stop using AVPicture

2017-06-27 Thread Diego Biurrun
From: Timothy Gu --- libavcodec/cinepakenc.c | 271 +--- 1 file changed, 163 insertions(+), 108 deletions(-) diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c index 951d851..ddf560a 100644 ---

[libav-devel] [PATCH 9/9] fate: Add cinepak encoder vsynth tests

2017-06-27 Thread Diego Biurrun
--- tests/fate/vcodec.mak| 4 tests/ref/vsynth/vsynth1-cinepak | 4 tests/ref/vsynth/vsynth2-cinepak | 4 3 files changed, 12 insertions(+) create mode 100644 tests/ref/vsynth/vsynth1-cinepak create mode 100644 tests/ref/vsynth/vsynth2-cinepak diff --git

[libav-devel] [PATCH 8/9] cinepakenc: misc small changes

2017-06-27 Thread Diego Biurrun
Avoid anonymously typedeffed structs and enums, drop an unused context member, a small wording fix, sizeof(type) ---> sizeof(*variable), silence a needlessly verbose log message. --- libavcodec/cinepakenc.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git

[libav-devel] [PATCH 4/9] cinepakenc: Drop broken debug code

2017-06-27 Thread Diego Biurrun
--- libavcodec/cinepakenc.c | 148 ++-- 1 file changed, 5 insertions(+), 143 deletions(-) diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c index 619ee83..951d851 100644 --- a/libavcodec/cinepakenc.c +++ b/libavcodec/cinepakenc.c @@

[libav-devel] [PATCH 3/9] cinepakenc: add option handling for flexibility

2017-06-27 Thread Diego Biurrun
From: "addr-see-the-webs...@aetey.se" <addr-see-the-webs...@aetey.se> Now it is possible to adjust compression speed vs R/D when needed and also skip vintage player compatibility at will. Signed-off-by: Diego Biurrun <di...@biurrun.de> --- libavc

Re: [libav-devel] [RFC] JPEG2000: optimisation of mct using SSE instructions

2017-06-27 Thread Diego Biurrun
On Tue, Jun 27, 2017 at 02:32:34PM +, maxime taisant wrote: > From: Maxime Taisant > > This code aim to improve the performances of the mct using SSE instructions. > It was submitted by Nicolas Bertrand a while ago and was rejected. > I would like to have some

Re: [libav-devel] [libav-commits] doc: Drop the legacy symlink to README

2017-06-27 Thread Diego Biurrun
On Mon, Jun 19, 2017 at 11:24:06AM +0200, Luca Barbato wrote: > Module: libav > Branch: master > Commit: c5c76370ae240b5e451c4a00a7ab485c0c0e0e98 > > Author:Luca Barbato > Committer: Luca Barbato > Date: Wed Jun 14 01:40:40 2017 +0200 > > doc:

Re: [libav-devel] [libav-commits] openssl: Support version 1.1.0.

2017-06-26 Thread Diego Biurrun
On Mon, Jun 26, 2017 at 12:38:20PM +0300, Martin Storsjö wrote: > On Mon, 26 Jun 2017, Diego Biurrun wrote: > > >On Sun, Oct 23, 2016 at 09:08:50PM +0200, Matt Oliver wrote: > >>Module: libav > >>Branch: master > >>Commit: ee050797664c7c74cae262ffab05006b5

Re: [libav-devel] [libav-commits] openssl: Support version 1.1.0.

2017-06-26 Thread Diego Biurrun
On Sun, Oct 23, 2016 at 09:08:50PM +0200, Matt Oliver wrote: > Module: libav > Branch: master > Commit: ee050797664c7c74cae262ffab05006b55d47a11 > > Author:Matt Oliver > Committer: Martin Storsjö > Date: Mon Oct 10 06:49:54 2016 +1100 > >

Re: [libav-devel] [v12] [PATCH 2/2] configure: Simplify and fix libxcb check

2017-06-25 Thread Diego Biurrun
On Fri, Jun 23, 2017 at 02:06:29PM +0200, Diego Biurrun wrote: > Check for xcb as well as xcb-shape before enabling libxcb since newer > versions of libxcb have xcb-foo pkg-config files that do not declare > their xcb dependency so that required linker flags will not be generated. >

Re: [libav-devel] [PATCH] configure: Try adding -Werror=unknown-warning-option before testing for -Werror=partial-availability

2017-06-24 Thread Diego Biurrun
On Wed, Jun 21, 2017 at 10:32:24PM +0300, Martin Storsjö wrote: > Using check_cflags with -Werror parameters in clang is normally > futile, since the tests always pass, but add new warnings instead. > > Since the check for -Werror=partial-availability is in the OS section > of configure, we need

[libav-devel] [PATCH] configure: Reset X86ASM_DEP(FLAGS) when probing for the assembler program

2017-06-24 Thread Diego Biurrun
These variables might be set from a previous probe run, but one or the other program that is probed for may not grok the flags, resulting in errors during assembling when the values of those variables are passed to the assembler. --- Now resets the unused variable in each probe branch.

Re: [libav-devel] [PATCH] configure: Reset X86ASM_DEPFLAGS when probing for Yasm assembler

2017-06-24 Thread Diego Biurrun
On Sat, Jun 24, 2017 at 04:17:09PM -0300, James Almer wrote: > On 6/24/2017 3:14 PM, Diego Biurrun wrote: > > --- a/configure > > +++ b/configure > > @@ -4521,6 +4521,7 @@ EOF > > x86asm_type=yasm > > x86asm_debug="-g dwarf2&qu

[libav-devel] [PATCH] configure: Reset X86ASM_DEPFLAGS when probing for Yasm assembler

2017-06-24 Thread Diego Biurrun
These flags might be set from a previous probe for NASM, but Yasm does not grok the flags, resulting in errors during assembling. --- James, please test. configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index ce0f6c9..7ff329b 100755 --- a/configure +++

Re: [libav-devel] [PATCH] configure: fix assignment of assembler specific flags

2017-06-24 Thread Diego Biurrun
On Fri, Jun 23, 2017 at 12:25:56PM -0300, James Almer wrote: > If the first assembler to be probed is an old nasm build, X86ASM_DEPFLAGS > will be set and remain so after yasm is ultimately used as fallback. > This results in yasm being called with said nasm specific flags and failing > during

Re: [libav-devel] [PATCH 01/15] h264: Add stream constraint values to the common header

2017-06-24 Thread Diego Biurrun
On Sat, Jun 24, 2017 at 11:56:07AM -0300, James Almer wrote: > On 6/23/2017 8:39 PM, Mark Thompson wrote: > > --- a/libavcodec/h264.h > > +++ b/libavcodec/h264.h > > @@ -44,4 +44,49 @@ enum { > > + > > +enum { > > enum seems like a weird choice for this to be honest. Same with the > following

Re: [libav-devel] [v12] [PATCH 1/2] build: Add an option for passing linker flags to the shared library build

2017-06-23 Thread Diego Biurrun
On Fri, Jun 23, 2017 at 02:06:28PM +0200, Diego Biurrun wrote: > From: Janne Grunau <janne-li...@jannau.net> > > Also employ this mechanism to pass $libdir to the runtime library search > path if rpath is enabled. This fixes underlinking of some test binaries > on some

[libav-devel] [v12] [PATCH 1/2] build: Add an option for passing linker flags to the shared library build

2017-06-23 Thread Diego Biurrun
From: Janne Grunau <janne-li...@jannau.net> Also employ this mechanism to pass $libdir to the runtime library search path if rpath is enabled. This fixes underlinking of some test binaries on some systems. (cherry picked from commit 857e26b655a769e5a56bada1a0d9adb44cc176b7) Signed-off-by:

[libav-devel] [v12] [PATCH 2/2] configure: Simplify and fix libxcb check

2017-06-23 Thread Diego Biurrun
picked from commit 1ea77aae927c7310034b1f75d4f1c2676fe641f2) (cherry picked from commit a97563c889fefd81ad6b3758471434d8c2e2e550) (cherry picked from commit 871b4f3654636ed64560e86b9faa33828d195ceb) Signed-off-by: Diego Biurrun <di...@biurrun.de> --- configure | 9 - 1 file changed, 4 inse

<    1   2   3   4   5   6   7   8   9   10   >