Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Sebastian Spaeth
On Fri, 29 Oct 2010 21:41:26 +0100, Michael Meeks michael.me...@novell.com wrote: ...post the branch / freeze over the weekend... May I nag a little? Besides some rumours I did not know anything about a branching over the weekend (and it does not seem to have happened anyway). Neither could I

Re: [Libreoffice] Building on CentOS 5

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 01:03 -0400, Terrell Prude' Jr. wrote: - gperf - libXaw-devel - GConf2-devel - gnome-vfs2-devel Added these to the wiki. There is also one I'm not sure how to satisfy within CentOS 5's packaging. This would be Qt4. Here are the messages from make. Does

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 09:27 +0100, Sebastian Spaeth wrote: On Fri, 29 Oct 2010 21:41:26 +0100, Michael Meeks michael.me...@novell.com wrote: ...post the branch / freeze over the weekend... May I nag a little? Besides some rumours I did not know anything about a branching over the weekend

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Caolán McNamara
On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); Paint(rEvent.UpdateRect); I'm thinking I should change this guard with a SolarMutexGuard aSolarGuard; Someone has an opinion on this ? Because it's protecting

Re: [Libreoffice] [Review Request] remove a confusing use of GetMutex() when a SolarMutexGuard is really meant

2010-11-01 Thread Caolán McNamara
On Sun, 2010-10-31 at 23:07 -0500, Norbert Thiebaud wrote: The attached patches are pending... I am submitting them to the list for comments or objections before pushing them. Looks reasonable to me anyway, most of this is in toolkit, maybe Thorsten can have a double-check of that as I'd guess

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread David Tardon
On Mon, Nov 01, 2010 at 09:24:09AM +, Caolán McNamara wrote: On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); Paint(rEvent.UpdateRect); I'm thinking I should change this guard with a SolarMutexGuard

[Libreoffice] [PUSHED] Re: [PUSHED, partially] Re: [PATCH] cppcheck Common realloc mistake

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 09:02 +0100, Gert Faller wrote: I was just wondering if freeing some bytes was worth while. A patch for this... re: realloc_patch_3.patch Yeah, it's probably a bit expensive to realloc in order to drop a tiny amount of bytes, but its an unlikely code path anyway so patch

Re: [Libreoffice] Bug Triage Process

2010-11-01 Thread Sophie Gautier
Hi all, On Sun, Oct 31, 2010 at 1:07 AM, Caolán McNamara caol...@redhat.com wrote: On Thu, 2010-10-21 at 04:36 -0600, Muthu Subramanian wrote: Hi, I wrote a simple wiki for bug triage process, http://wiki.documentfoundation.org/BugTriage as a starting point. This would help anyone who is

Re: [Libreoffice] Bug Triage Process

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 11:29 +0100, Sophie Gautier wrote: Also, I would like to help on closing some issues that are fixed. Is it ok if I check them against a build provided by Cedric some days ago, or is it better to wait for the next beta? I reckon you can go ahead and close anything that you

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

2010-11-01 Thread Caolán McNamara
On Thu, 2010-10-28 at 13:21 +0100, Caolán McNamara wrote: Hmm, sort of looks like the underlying cppu stuff, or something it uses, got pulled out from under it during the test. I don't think it could have gotten that far for the uno::sequence dtor (which looks up the type of its argument) to

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 10:54 +0100, David Tardon wrote: Yes, but the situation here is different. The Paint method is actually defined in the same class and has nothing in common with VCL's Window::Paint. The actual painting is done through Canvas. Can anyone convince me that its not cargo-cult

Re: [Libreoffice] [PATCH][Pushed] emacs.el: Replace all mentions of OOo with LO

2010-11-01 Thread Norbert Thiebaud
On Sat, Oct 30, 2010 at 5:35 AM, Tim Retout t...@retout.co.uk wrote: Hello, world! This is a naive replacement of OpenOffice.org with LibreOffice in emacs.el in the build repository. Thanks Tim, Pushed. Will patches sent with git send-email be accepted? I speak only for myself, but due

[Libreoffice] Decrease installer size by 1 MB for each language

2010-11-01 Thread Kálmán „KAMI” Szalai
Hi All, I would like to consulate related to topic. I found that every wizards' bitmap enclosed for every language however it has no language dependent bitmaps in it. My suggestion to remove language dependency, so we can save around 1 MB of every installer. I created two patches however they are

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Norbert Thiebaud
On Mon, Nov 1, 2010 at 6:05 AM, Caolán McNamara caol...@redhat.com wrote: On Mon, 2010-11-01 at 10:54 +0100, David Tardon wrote: Yes, but the situation here is different. The Paint method is actually defined in the same class and has nothing in common with VCL's Window::Paint. The actual

Re: [Libreoffice] Macro Cleanup in UNO

2010-11-01 Thread Joseph Powers
On Oct 31, 2010, at 10:40 PM, Norbert Thiebaud wrote: On Sun, Oct 31, 2010 at 11:44 PM, Joseph Powers jpower...@cox.net wrote: [...] The defaults for the classes where defined in the header (good); however, they used generic names like DEFAULT_VALUE, FREESPACE, … (bad). I went ahead and

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Jan Holesovsky
Hi Sebastian, On 2010-11-01 at 09:17 +, Caolán McNamara wrote: ...post the branch / freeze over the weekend... May I nag a little? Besides some rumours I did not know anything about a branching over the weekend (and it does not seem to have happened anyway). Neither could I find

[Libreoffice] [PATCH] have git diff treat dictionaries/*.idx|dic|dat as binary

2010-11-01 Thread Sebastian Spaeth
The git contributor script crunches through repos and invokes git to gather data. However, the dictionaries are 100k lines of code changes and git log --numstat literally works for hours on those commits. All other LO git repos take about 5-10 minutes to analyze. lib-extern-sys takes about 5

Re: [Libreoffice] Building on CentOS 5

2010-11-01 Thread Terrell Prude' Jr.
Caolán McNamara wrote: On Mon, 2010-11-01 at 01:03 -0400, Terrell Prude' Jr. wrote: - gperf - libXaw-devel - GConf2-devel - gnome-vfs2-devel Added these to the wiki. There is also one I'm not sure how to satisfy within CentOS 5's packaging. This would be Qt4. Here are the

Re: [Libreoffice] [PATCH] Enable testtool (and possibly other stuff) to run with LibO soffice

2010-11-01 Thread Giuseppe Castagno
Caolán McNamara wrote: So, let me get this straight. Various bits of tooling etc depend on a /usr/bin/soffice right ? Is that the problem. So perhaps the solution right, depends on a /usr/bin/soffice to reach the installation location is to simply add a /usr/bin/soffice to go alongside

Re: [Libreoffice] Apple Java update on Mac OSX breaks all java functionality in LibO - Issue 115180

2010-11-01 Thread Caolán McNamara
On Sun, 2010-10-24 at 21:35 +0200, Alexander Thurgood wrote: Hi all, Just a heads up coz I don't know whether you've heard about this yet. Reported in Issue 115180 on OOo Issue Tracker. The problem also affects LibO in its latest incarnations. The fix for this of issuezill#115180 is now

[Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-01 Thread Sebastian Spaeth
Currently the deprecated binfilter are build by default as the inner configure explicitely requires --disable-binfilter to get rid of them. This patch defaults to disabled and require --enable-binfilter to turn them on. Ran configure with both options and it worked fine. Signed-off-by: Sebastian

Re: [Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 17:11 +0100, Sebastian Spaeth wrote: Currently the deprecated binfilter are build by default as the inner configure explicitely requires --disable-binfilter to get rid of them. This patch defaults to disabled and require --enable-binfilter to turn them on. Ran configure

Re: [Libreoffice] [PATCH] Fix comments in filters/xmerge

2010-11-01 Thread Nigel Hawkins
Well, since the first lot worked, a few more patches on the same lines. Nigel From a4d81a4e0da75696c8210cecb57a3e4c7bcc0e93 Mon Sep 17 00:00:00 2001 From: Nigel Hawkins n.hawk...@gmx.com Date: Thu, 28 Oct 2010 13:41:37 +0100 Subject: [PATCH 10/17] Fix javadoc comments in EmbeddedXMLObject.java

Re: [Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-01 Thread Sebastian Spaeth
On Mon, 01 Nov 2010 16:14:35 +, Caolán McNamara caol...@redhat.com wrote: On Mon, 2010-11-01 at 17:11 +0100, Sebastian Spaeth wrote: Currently the deprecated binfilter are build by default as the inner configure explicitely requires --disable-binfilter to get rid of them. This patch

[Libreoffice] Branched for LibreOffice 3.3

2010-11-01 Thread Jan Holesovsky
Hi all, I created the 'libreoffice-3-3' branch for the stabilization for the 3.3 release [aka feature freeze ;-)] You can again unleash your creativity in 'master' - so please do so! One of the things that will be done in master is the deprecation of the 'build' repo (discussed in the 'build

[Libreoffice] [PATCH] Removed deprecated option --with-unzip-home

2010-11-01 Thread Niko Rönkkö
MPL 1.1 / GPLv3+ / LGPLv3+ From 8d356d68781be2a312072c7b2855f45c9a60a169 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niko=20R=C3=B6nkk=C3=B6?= ron...@iki.fi In-Reply-To: 4cceeef3.5050...@iki.fi References: 4cceeef3.5050...@iki.fi Date: Mon, 1 Nov 2010 18:41:45 +0200 Subject: [PATCH] Removed

Re: [Libreoffice] LibreOffice Icon Naming

2010-11-01 Thread Andrew
Regarding https://bugs.freedesktop.org/show_bug.cgi?id=30425 The way that LibreOffice packages its icon themes if far too complex and difficult and therefore stifles creativity when it comes to creating new icon themes. Icon are given cryptic names such as envvl_l.png in cryptic directories such

[Libreoffice] supported compilers?

2010-11-01 Thread Jani Monoses
Is there a list of which compilers are supported and what versions recommeneded for building LO? I was thinking of the feasibility of using gcc's __builtin_constant_p in a macro to differentiate fast and not so fast paths for createFromAscii cases to keep the code uniform but still get the

Re: [Libreoffice] [PUSHED] Re: (no subject)

2010-11-01 Thread Rene Engelhard
Hi, On Mon, Nov 01, 2010 at 10:11:07AM +, Caolán McNamara wrote: caolanm-rene: Think we should use AS_HELP_STRING everywhere ? Yeah. Good idea. Sounds like a easy hack :) Grüße/Regards, René ___ LibreOffice mailing list

Re: [Libreoffice] LibreOffice Icon Naming

2010-11-01 Thread Andrew C. E. Dent
Hi Andrew I'm another Andrew who also cares about Icons! (Normally people refer to me by my User name of 'ace_dent').I first started to analyse the problem about 5yrs ago(!) but gave in under the original Sun ownership.I have started the bare seeds of this over on the

Re: [Libreoffice] [PUSHED] Re: (no subject)

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 21:06 +0100, Rene Engelhard wrote: Hi, On Mon, Nov 01, 2010 at 10:11:07AM +, Caolán McNamara wrote: caolanm-rene: Think we should use AS_HELP_STRING everywhere ? Yeah. Good idea. Sounds like a easy hack :) oky doky, added as an easy hack. caolanm-ronkko:

[Libreoffice] [Pushed] Bogus comments, commented lines removed and some comments translated.

2010-11-01 Thread Michael Meeks
Hi Robert, On Mon, 2010-11-01 at 20:26 +0200, Roth Robert wrote: Attached you'll find 4 patches, colicensed with LGPLv3+, GPLv3+ and MPL, with some bogus comments removed containing only changed date, some commented lines removed, and some german comments translated. I hope this is the right

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 4

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 20:28 +0100, Gert Faller wrote: Hi, more of that... Mostly good, though createFromAscii_7.patch has... OUString::createFromAscii( GetWindowState( WINDOWSTATE_MASK_POS ).GetBuffer() ) ); that one can't be changed to use RTL_CONSTASCII_USTRINGPARAM because

[Libreoffice] [Pushed] Fix comments in filters/xmerge

2010-11-01 Thread Michael Meeks
Hi Nigel, On Mon, 2010-11-01 at 16:16 +, Nigel Hawkins wrote: Well, since the first lot worked, a few more patches on the same lines. Thanks :-) lots of nice cleanups; pushed ... Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 4

2010-11-01 Thread Gert Faller
Selon Caolán McNamara caol...@redhat.com: Mostly good, though createFromAscii_7.patch has... OUString::createFromAscii( GetWindowState( WINDOWSTATE_MASK_POS ).GetBuffer() ) ); that one can't be changed to use RTL_CONSTASCII_USTRINGPARAM because GetWindowState is a method rather than a

[Libreoffice] build failure in dbaccess/qa/complex/dbaccess

2010-11-01 Thread Thomas Klausner
Entering /build/libreoffice-3.2.99.2/dbaccess/qa/complex/dbaccess Making:DbaComplexTests.dpj /usr/pkg/java/openjdk7/bin/javac -source 1.5 -target 1.5 -classpath

Re: [Libreoffice] build failure loading pythonloader.uno.so

2010-11-01 Thread Thomas Klausner
On Sun, Oct 24, 2010 at 12:56:39PM +0100, Caolán McNamara wrote: This sucks, looks like catch throw and catch catch don't work on NetBSD. Or maybe its too old a gdb or something. Maybe add a break main and reorganize the gdb script in the hope that it needs libstdc++ to be loaded before it'll

[Libreoffice] [PATCH] Another Qt/gtk configure patch

2010-11-01 Thread Wols Lists
I've now got configure autodetecting Qt4, and created an automagic patch. Things are still partly broken because to fix things properly I need to get rid of OOO_WIDGET_FLAGS, and that's probably a big job ... Anyways, the patch does the following: Adds a new --enable-automagic option. As the

Re: [Libreoffice] Help concerning code style and documentation

2010-11-01 Thread Thorsten Behrens
Regina Henschel wrote: There is no mathematical problem, but I'm uncertain about coding style. The algorithms work on matrices. They have a lot of parts which are nearly identical but the matrices are transposed. How to handle that? Hi Regina, I'd suggest using templates to achieve that -

Re: [Libreoffice] SW_DLLPUBLIC limitations ...

2010-11-01 Thread Thorsten Behrens
Cedric Bosdonnat wrote: I finally got it working with SAL_DLLPUBLIC_EXPORT as michael suggested. If there is any possible trouble, let me know ;) Hi - oh wow, dynamic_casting on interfaces is really nasty - we should truly put up a bunch of big red warning signs around that. FWIW, if you try

Re: [Libreoffice] OpenBSD patch #1

2010-11-01 Thread Thorsten Behrens
Michael Meeks wrote: As for the csh .Set file - hopefully we can bin that in a gnumake world, by having a single set of makefile variables generated instead of whacking them all in the environment via a given shell. Please - bin both .Set and .Set.sh then - since this

Re: [Libreoffice] Export OLE objects as PDF / graphics

2010-11-01 Thread Thorsten Behrens
gertfal...@aliceadsl.fr wrote: in draw : easy rotate, crop, resize and right click 'save as...' in impress : same features and same toolbars in calc : easy resize, right click 'rotate', but no crop nor 'save as...' in writer : no 'rotate', easy resize, right click 'crop', right click 'save

Re: [Libreoffice] [Review Request] remove a confusing use of GetMutex() when a SolarMutexGuard is really meant

2010-11-01 Thread Thorsten Behrens
Norbert Thiebaud wrote: The attached patches are pending... I am submitting them to the list for comments or objections before pushing them. Hi Norbert - patches seem to be pushed - many thanks for the cleanup! Cheers, -- Thorsten pgp52GbxTjXhW.pgp Description: PGP signature

[Libreoffice] [PUSHED] EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

2010-11-01 Thread Kohei Yoshida
Hello Joost, Thanks for the patch. Just pushed to the master branch. :-) On Mon, 2010-11-01 at 23:38 +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ What must be done with empty strings ()? I did only the replacement with the macro: For empty strings, I would simply construct

[Libreoffice] Build Issue on Mac OS X

2010-11-01 Thread Joseph Powers
Ok, I need a build system expert: Making:test_pathutils.dylib illegal combination shl/OOO/NONE at /Users/jpowers27/build/build/libreoffice-3.2.99.2/solenv/bin/macosx-change-install-names.pl line 54, IN line 5. dmake: Error code 9, while making '../unxmacxi.pro/lib/test_pathutils.dylib'

Re: [Libreoffice] Help concerning code style and documentation

2010-11-01 Thread Kohei Yoshida
Hi Regina, On Sun, 2010-10-24 at 18:13 +0200, Regina Henschel wrote: Hi all, I'm currently working on LINEST and have attached a draft to issue http://www.openoffice.org/issues/show_bug.cgi?id=115189 There is no mathematical problem, but I'm uncertain about coding style. The algorithms

Re: [Libreoffice] Build Issue on Mac OS X

2010-11-01 Thread LeMoyne
Hi Joseph, Not a build expert but can see that your run dies because 'shl/OOO/NONE' isn't defined in the action set. I would copy paste line with shl/NONE/OOO and edit in the required (fallback?) key like: ... 'shl/NONE/OOO' = '@__VIA_LIBRARY_PATH__', 'shl/OOO/NONE' =

[Libreoffice] Icons

2010-11-01 Thread Joseph Powers
Andrew, I'm a little crazy, but I want to work on the icon issues. I'm a programmer, so I've been looking at things from the other side... Currently the system is a mess, the top level determines if if we're in high-contrast mode or not and then requests the correct image. On top of this, we