Re: [Libreoffice] Easy Hack

2011-02-13 Thread Bálint Dózsa
Hy Miklos, Thank you for the help. Here is the correction patch Regards, Balint Dozsa 2011/2/13 Miklos Vajna vmik...@frugalware.org On Sat, Feb 12, 2011 at 11:34:52AM +0100, Bálint Dózsa dozsabal...@gmail.com wrote: void DomainMapperTableHandler::startTable(unsigned int nRows, -

Re: [Libreoffice] duplicate code (binfilter)

2011-02-13 Thread Tor Lillqvist
Well, all of binfilter *is* more or less duplicate code, isn't that the very point of it? (Duplicate of code as it existed at some point back in history.) Please, we should stop paying too close attention to binfilter. It is not worth it to spend too much time on making it cleaner as binfilter

[Libreoffice] [PATCH] Remove bogus comments in components and impress

2011-02-13 Thread Guillaume Poussel
Hi, Find attached new patches that remove bogus comments (still under LGPLv3+/MPL) in components and impress. Comments with kind of 'revision control' (with dates) remain in writer and binfilter. I will work on writer and write it on the wiki. Regards, Guillaume Poussel

[Libreoffice] compilation and bundled extensions

2011-02-13 Thread Jean-Baptiste Faure
Hi, I compiled LibO (branch master) on my notebook under Ubuntu 10.04 (x86_64). All worked fine. It took ~ 4 hours with 2 CPUs underclocked to 63% to prevent overheating. I did make dev-install to try the result. No problem although I wonder why this command did not install the bundled

[Libreoffice] FOSDEM feedback, re: Improved bug filing form / flow

2011-02-13 Thread Dirk Haun
I attended the Easy hacks to get involved with[1] session at FOSDEM. The item Improved bug filing form / flow[2] from the wiki page that Michael mentioned reminded me of similar issues that the Mozilla guys apparently had, as mentioned in their presentation[3] on Saturday. Effectively, SUMO as

Re: [Libreoffice] build error with cppunit - Making install in DllPlugInTester

2011-02-13 Thread Kishan Bhat
Hi Michael, I could successfully make dev-install on my lubuntu 10.10, yay!! I'm sorry I could not provide you with results from the command you suggested - objdump -T /lib/libdl.so.2. I had formatted and re-installed lubuntu already. Thanks for all your help on the ML and the IRC. On Fri, Feb

Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments in components and impress

2011-02-13 Thread Thomas Arnhold
Thanks for all of them! I pushed them all. I deleted one additional line in cui/source/tabpages/numfmt.cxx: //@ aEdFormat.SetText( aLbFormat.GetSelectEntry() ); as this also belong to a deleted comment. Thomas On 02/13/2011 02:08 PM, Guillaume Poussel wrote: Second part.

Re: [Libreoffice] [PUSHED] [Patch] Remove bogus comments and dead code from editeng

2011-02-13 Thread Thomas Arnhold
Hi, nice, thanks for this! I pushed it. As far as I know there is no need to reformat the code, because this should be done by a script some time later (and we want to be compatible to diffs from OOo). Thomas On 02/13/2011 03:29 PM, Arnaud Versini wrote: Hi, Remove some comments from

Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments

2011-02-13 Thread Thomas Arnhold
Looks good. Thanks! I pushed it. Didn't know that there are bug numbers like this #b449874#. Thomas On 02/13/2011 01:57 AM, Antoine Proulx wrote: Hi, Here's a patch (another one) who removes bogus comments. It's released under the LGPLv3+ / MPL. Antoine

Re: [Libreoffice] [PUSHED] [Patch] Easy hack: idl removed and translated comments

2011-02-13 Thread Thomas Arnhold
Thanks! I pushed it all. Thomas On 02/13/2011 01:26 AM, Michael Münch wrote: Hi, first attempt so I will take any advise (split the patch into smaller files?). License is LGPLv3+/MPL. I would have edited the wiki that I am working on this directory but the registration is disabled.

[Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-13 Thread Luke Dixon
Hi Michael, Jonas, On Fri, 2011-02-11 at 10:15 +, Michael Meeks wrote: Quick question, while I'm here: what are the blockers for enabling this by default on master ? was it undo/redo ? or do we have any malingering known crashers / mis-features left. I think Jonas fixed the crash I

Re: [Libreoffice] [PUSHED] [Patch] Remove bogus comments and dead code from editeng

2011-02-13 Thread Arnaud Versini
Hi, Next part, no reformating this time. thanks 2011/2/13 Thomas Arnhold tho...@arnhold.org Hi, nice, thanks for this! I pushed it. As far as I know there is no need to reformat the code, because this should be done by a script some time later (and we want to be compatible to diffs from

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

2011-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32894 --- Comment #20 from vitriol vitriol_vitr...@katamail.com 2011-02-13 09:59:56 PST --- Nominating Bug 34226. Regression from 3.3.0 final to 3.3.1 RC1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are

Re: [Libreoffice] Tools - Media Player

2011-02-13 Thread Thomas Arnhold
Christoph thanks for the discussion link and the specs! On 02/12/2011 10:01 PM, Michael Meeks wrote: On Fri, 2011-02-11 at 23:08 +0100, Christoph Noack wrote: what the heck do we do with Tools - Media Player? Do we need this within an office suite? Is anyone using this?! :-) My

[Libreoffice] l10n of patches

2011-02-13 Thread Andras Timar
Hi, There are still a few patches in build/patches/dev300 which contain localizable text. When we move to new l10n framework on master this will become a problem, because we would like to get rid of lo-build.sdf/po hack. Please decide if these patches should be integrated or deleted. Otherwise it

[Libreoffice] [PATCH] fixed spelling menues - menus

2011-02-13 Thread Christina Roßmanith
Hi, I've removed some 'e's from menues and ouer. It builds successfully. It's LGPLv3+/MPL. Christina Rossmanith From 96718e8fd485eab2bf261bccf7a34421b297b29a Mon Sep 17 00:00:00 2001 From: Christina Rossmanith chrrossman...@web.de Date: Sat, 12 Feb 2011 21:19:41 +0100 Subject: [PATCH] fixed

[Libreoffice] modules to remove? javainstaller2, crashrep

2011-02-13 Thread Andras Timar
Hi, components/javainstaller2 and components/crashrep are not built for LibreOffice. AFAIK javainstaller2 is used only by the commercial product (StarOffice/OOO). If you do not plan to use and to implement the server side of crashrep, it can be removed, too. A few strings less for localizers...

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

2011-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32894 --- Comment #21 from tester8 iamtest...@gmail.com 2011-02-13 12:08:29 PST --- to vitriol You need not only wrote that you nominate some bug but also add it to the Depends on. -- Configure bugmail:

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

2011-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32894 vitriol vitriol_vitr...@katamail.com changed: What|Removed |Added Depends on||34226 --

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

2011-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32894 --- Comment #22 from vitriol vitriol_vitr...@katamail.com 2011-02-13 12:12:09 PST --- Added bug 34226 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-13 Thread Jonas Finnemann Jensen
Hi Luke, It seems that undo/redo is the major one and I just worked out why undo/redo wasn't working, noticed it while looking at Caolán's unit tests for starmath. I've attached the patch. It would be major step to get that issue fixed... And you're going the right way, but your patch doesn't

[Libreoffice] Easy Hacks: Migrate module descriptions to our wiki

2011-02-13 Thread Christoph Herzog
I'm busy with this easy hack, i.e. filling http://wiki.documentfoundation.org/Development/Code_Overview. It is proposed to copy and paste text from http://wiki.services.openoffice.org/w/index.php?title=Source_code_directoriesoldid=6821 But

Re: [Libreoffice] [PATCH] Remove Xine

2011-02-13 Thread Caolán McNamara
On Sat, 2011-02-12 at 18:07 +0100, Julien Nabet wrote: Hello, Here is a patch to remove xine. I think that was an Easy Hack, can you remove it from that list and move it to the completed one, stick you name on it there then. C. ___ LibreOffice

Re: [Libreoffice] [PATCH] Remove Xine

2011-02-13 Thread Thomas Arnhold
I did this already, as the registration for the wiki doesn't work at the moment. Thomas On 02/13/2011 10:19 PM, Caolán McNamara wrote: On Sat, 2011-02-12 at 18:07 +0100, Julien Nabet wrote: Hello, Here is a patch to remove xine. I think that was an Easy Hack, can you remove it from that

Re: [Libreoffice] compilation and bundled extensions

2011-02-13 Thread Caolán McNamara
On Sun, 2011-02-13 at 11:22 +0100, Jean-Baptiste Faure wrote: I did make dev-install to try the result. No problem although I wonder why this command did not install the bundled extensions. Is there some option to add to do a complete installation ? I wondered this too earlier today, try

Re: [Libreoffice] Segmentation faults in unit tests

2011-02-13 Thread Caolán McNamara
On Sat, 2011-02-12 at 20:34 +0100, Francois Tigeot wrote: LibreOffice builds now run for almost 3 hours before failing on DragonFly. The errors are always of the same sort: some kind of segmentation fault with an unit test : See

Re: [Libreoffice] [PATCH] Remove Xine

2011-02-13 Thread Julien Nabet
Le 13/02/2011 22:19, Caolán McNamara a écrit : On Sat, 2011-02-12 at 18:07 +0100, Julien Nabet wrote: Hello, Here is a patch to remove xine. I think that was an Easy Hack, can you remove it from that list and move it to the completed one, stick you name on it there then. C.

Re: [Libreoffice] [PATCH] Easy hack: remove obsolete gjc aot compilation

2011-02-13 Thread Caolán McNamara
On Sat, 2011-02-12 at 17:02 +0100, Thomas Arnhold wrote: And I removed configure.cmd as it's a personal file (local paths and so on). Yeah, remove that, and the aot removal looks good too. I added that in as a desperate measure to shrink the helpcontent2 build time from 28 hours to 8 or so back

Re: [Libreoffice] [PUSHED] [PATCH] Easy hack: remove obsolete gjc aot compilation

2011-02-13 Thread Thomas Arnhold
I pushed it now. Wanted that someone had a look at it ;) On 02/13/2011 10:38 PM, Caolán McNamara wrote: On Sat, 2011-02-12 at 17:02 +0100, Thomas Arnhold wrote: And I removed configure.cmd as it's a personal file (local paths and so on). Yeah, remove that, and the aot removal looks good too.

Re: [Libreoffice] modules to remove? javainstaller2, crashrep

2011-02-13 Thread Christian Lohmaier
Hi *, On Sun, Feb 13, 2011 at 9:00 PM, Andras Timar tima...@gmail.com wrote: components/javainstaller2 and components/crashrep are not built for LibreOffice. AFAIK javainstaller2 is used only by the commercial product (StarOffice/OOO). No, also for OOo, but it is useless to have it, since

Re: [Libreoffice] Segmentation faults in unit tests

2011-02-13 Thread Francois Tigeot
On Sun, Feb 13, 2011 at 09:30:17PM +, Caolán McNamara wrote: On Sat, 2011-02-12 at 20:34 +0100, Francois Tigeot wrote: LibreOffice builds now run for almost 3 hours before failing on DragonFly. The errors are always of the same sort: some kind of segmentation fault with an unit test :

[Libreoffice] [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vectorControl* in sw.

2011-02-13 Thread Rafael Dominguez
Well the patch is related to sw, tab entries in Insert-Indexes and Tables - Indexes and Tables. 0001-.git-COMMIT_EDITMSG.save.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-13 Thread Luke Dixon
Hi Jonas, On Sun, 2011-02-13 at 21:44 +0100, Jonas Finnemann Jensen wrote: It would be major step to get that issue fixed... And you're going the right way, but your patch doesn't work if the formula is written in multiple lines... try, writing the formula 3+3+3 \n \n \n \n +4+4 (replace \n