Re: [PATCH] Implement support for treeview headers native rendering, add GTK implementation

2012-07-09 Thread David Ostrovsky
On 09.07.2012 01:51, Ruslan Kabatsayev wrote: Please update the version in gerrit (I haven't yet figured out how to do this myself). To create a subsequent patchset for already pushed gerrit patch, you have to squash the sebsequent commits with git rebase -i HEAD~n, where n is the number of

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-07-09 Thread Norbert Thiebaud
\ Now I went to https://gerrit.libreoffice.org/#/c/267/; there are at this time three patchsets, but it seems there is no easy / convenient way to see the differences (interdiff) between them. QT have patched their gerrit to do the 'right thing' See

Re: Bogus call to OUString::matchAsciiL in /framework/source/lomenubar/MenuItemStatusListener.cxx ?

2012-07-09 Thread David Tardon
Hi, On Sun, Jul 08, 2012 at 02:37:49PM +0200, Christophe JAILLET wrote: Hi, At line 60 of /framework/source/lomenubar/MenuItemStatusListener.cxx, we can find : if ((Event.State = oULabel) !oULabel.matchAsciiL (private:, 8, 0) !oULabel.matchAsciiL (.uno:, 5, 0)

Re: [Libreoffice-qa] minutes of ESC call ...

2012-07-09 Thread Petr Mladek
Michael Meeks píše v Čt 05. 07. 2012 v 16:13 +0100: * Pending Action Items + check new templates are using auto-fitting functionality (Thorsten) I think that Astron fixed this. All the new templates resize when you resize the application window now. I checked this before pushing the

[Libreoffice-commits] .: connectivity/Library_postgresql-sdbc-impl.mk extensions/source postgresql/makefile.mk RepositoryExternal.mk solenv/gbuild solenv/inc

2012-07-09 Thread Fridrich Strba
RepositoryExternal.mk |6 -- connectivity/Library_postgresql-sdbc-impl.mk |1 + extensions/source/config/ldap/ldapaccess.cxx |2 +- extensions/source/config/ldap/wrapldapinclude.hxx | 14 ++ postgresql/makefile.mk

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-07-09 Thread David Ostrovsky
On 09.07.2012 08:53, Norbert Thiebaud wrote: QT have patched their gerrit to do the 'right thing' we too and we are even better: we pushed it upstream ;-) https://gerrit-review.googlesource.com/#/c/36640/ Regards David ___ LibreOffice mailing list

[Libreoffice-commits] .: vcl/source

2012-07-09 Thread Gökcen Eraslan
vcl/source/gdi/pdfwriter_impl.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit c8dc0647bab24a0062c2acd2fa366e046a572f02 Author: Gökçen Eraslan gokcen.eras...@gmail.com Date: Mon Jul 9 10:57:49 2012 +0300 Remove faulty DBG_ASSERT. Change-Id:

[Libreoffice-commits] .: vcl/inc

2012-07-09 Thread Gökcen Eraslan
vcl/inc/vcl/pdfwriter.hxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit a96d2f339c913e6a53f6003fda024ddc7a6adbbf Author: Gökçen Eraslan gokcen.eras...@gmail.com Date: Mon Jul 9 11:08:53 2012 +0300 Fix 'will be initialized after' error of GCC.

[Libreoffice-commits] .: Branch 'feature/svg-export' - 9 commits - filter/source sd/source sd/xml

2012-07-09 Thread Marco Cecchetti
filter/source/svg/presentation_engine.js | 649 --- sd/source/core/CustomAnimationEffect.cxx | 13 sd/xml/effects.xml | 12 3 files changed, 524 insertions(+), 150 deletions(-) New commits: commit 248f71c2486c8b651827f960b82b8294f9f79913

[ONGERRIT] Better center status bar items between separators

2012-07-09 Thread Bjoern Michaelsen
On Sun, Jul 08, 2012 at 09:34:18PM +0400, Ruslan Kabatsayev wrote: This patch fixes status bar separators position so that status bar items appears better centered between them. As a side effect, it also gives more space for rendering separators for themes which have thicker separators than

Change in core[master]: Make bottom tabbar items follow native theme

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has uploaded a new change for review. Change subject: Make bottom tabbar items follow native theme .. Make bottom tabbar items follow native theme

[Libreoffice] [GSoC 2012][svg export filter] Weekly Report #7

2012-07-09 Thread Marco Cecchetti
Hi everybody, it follows my last weekly report before mid-term evaluation: Report #7 - This week I provided full support for skipping both a single effect (Right/Down key) and all left effects (Page Down key). Symmetrically, I provided full support for rewinding both a single effect,

[ONGERRIT] - use indexOfAsciiL and avoid static variable

2012-07-09 Thread Bjoern Michaelsen
On Sun, Jul 08, 2012 at 07:04:57PM +0200, Christophe JAILLET wrote: in 'comphelper\source\misc\logging.cxx' we can read : // (if ::rtl::OUString had an indexOfAscii, we could save those ugly statics ...) Pushed for review to gerrit as: https://gerrit.libreoffice.org/269 Best, Bjoern

Change in core[master]: Remove ugly statics in comphelper

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has uploaded a new change for review. Change subject: Remove ugly statics in comphelper .. Remove ugly statics in comphelper in

Garbage collecting the LibreOffice development wiki entry pages

2012-07-09 Thread Bjoern Michaelsen
Hi all, just cleaned and sorted the LibreOffice development pages: - https://wiki.documentfoundation.org/Development - https://wiki.documentfoundation.org/Development/Native_Build which still contained lots of old, obsolete and even misleading content in a huge unsorted page, which likely

Re: [PUSHED][PATCH] build problem with gcc 4.5.2

2012-07-09 Thread Michael Meeks
On Sat, 2012-07-07 at 16:25 -0400, Terrence Enger wrote: On Sat, 2012-07-07 at 21:59 +0200, David Ostrovsky wrote: May I kindly ask you to use in future our new Code Review System gerrit: Alas, gerrit requires OpenId, which I do not have. This is deliberate, for reasons discussed in the

RE: Cppunit-1.13.0 released

2012-07-09 Thread Michael Meeks
Hi Dennis, On Sat, 2012-07-07 at 12:39 -0700, Dennis E. Hamilton wrote: It is obviously a fork. Ho hum; you're aware of the interaction history we have had with those working on the original cppunit ? I'd be interested in how they would characterise it. making a clean fork ... better

Re: bug 36681 still present in 3.6beta3

2012-07-09 Thread Michael Meeks
Hi Luc, On Sat, 2012-07-07 at 20:54 +0200, Luc Castermans wrote: https://bugs.freedesktop.org/show_bug.cgi?id=36681 If the bug has not been marked fixed; it will still be present in later versions :-) However - this is the developers list: it is for discussing fixes to bugs,

[Libreoffice-commits] .: Branch 'update' - check.php

2012-07-09 Thread Petr Mladek
check.php |9 + 1 file changed, 5 insertions(+), 4 deletions(-) New commits: commit 289ab6420a08cb32be436b21a6232e3ebdac57d4 Author: Petr Mladek pmla...@suse.cz Date: Mon Jul 9 10:57:44 2012 +0200 Offer update to 3.6.0.0.beta3 diff --git a/check.php b/check.php index

Change in core[master]: fdo#39468: translate German comments (= sw/source/core/crsr...

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has uploaded a new change for review. Change subject: fdo#39468: translate German comments (= sw/source/core/crsr) .. fdo#39468: translate German comments (=

Change in core[master]: adjusted existing comments (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has uploaded a new change for review. Change subject: adjusted existing comments (in sw/source/core/crsr/) .. adjusted existing comments (in sw/source/core/crsr/)

Change in core[master]: add/remove blank lines and braces (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has uploaded a new change for review. Change subject: add/remove blank lines and braces (in sw/source/core/crsr/) .. add/remove blank lines and braces (in

Change in core[master]: sal_Bool = bool if internal use only (in sw/source/core/crs...

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has uploaded a new change for review. Change subject: sal_Bool = bool if internal use only (in sw/source/core/crsr/) .. sal_Bool = bool if internal use only (in

Change in core[master]: renamed German variables (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has uploaded a new change for review. Change subject: renamed German variables (in sw/source/core/crsr/) .. renamed German variables (in sw/source/core/crsr/)

Change in core[master]: belated code cleanup (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has uploaded a new change for review. Change subject: belated code cleanup (in sw/source/core/crsr/) .. belated code cleanup (in sw/source/core/crsr/) {

Change in core[master]: removed dead code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has uploaded a new change for review. Change subject: removed dead code (in sw/source/core/crsr/) .. removed dead code (in sw/source/core/crsr/) Change-Id:

Change in core[master]: re-indented code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has uploaded a new change for review. Change subject: re-indented code (in sw/source/core/crsr/) .. re-indented code (in sw/source/core/crsr/) Change-Id:

Re: [PUSHED][PATCH] build problem with gcc 4.5.2

2012-07-09 Thread Bjoern Michaelsen
Hi Terrence, On Mon, Jul 09, 2012 at 09:47:18AM +0100, Michael Meeks wrote: On Sat, 2012-07-07 at 16:25 -0400, Terrence Enger wrote: On Sat, 2012-07-07 at 21:59 +0200, David Ostrovsky wrote: May I kindly ask you to use in future our new Code Review System gerrit: Alas, gerrit

Re: [PUSHED][PATCH] build problem with gcc 4.5.2

2012-07-09 Thread Bjoern Michaelsen
On Sat, Jul 07, 2012 at 04:25:33PM -0400, Terrence Enger wrote: I apologize for being awkward. ...oh and: you are indeed awkward. But dont bother, around here everyone is and we like it that way ;) Best, Bjoern ___ LibreOffice mailing list

[Libreoffice-commits] .: offapi/com sw/inc sw/source xmloff/inc xmloff/source

2012-07-09 Thread Miklos Vajna
offapi/com/sun/star/style/PageProperties.idl | 10 +--- sw/inc/cmdid.h|7 ++ sw/inc/pagedesc.hxx | 12 +++--- sw/inc/unoprnms.hxx |9 +++ sw/source/core/doc/docdesc.cxx

[Libreoffice-commits] .: 3 commits - vcl/source

2012-07-09 Thread Michael Stahl
vcl/source/gdi/pdfwriter_impl.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit 43d7d0684af0df1d5bde69d361365e786bf249bf Author: Michael Stahl mst...@redhat.com Date: Mon Jul 9 11:41:55 2012 +0200 PDFWriterImpl::createControl:

Change in core[master]: make code more explicit (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: make code more explicit (in sw/source/core/crsr/) .. Patch Set 1: I would prefer that you didn't

Change in core[master]: Replaced deprecated tools/String with OUString in ScAddInCol

2012-07-09 Thread Gerrit
From Eike Rathke er...@redhat.com: Eike Rathke has posted comments on this change. Change subject: Replaced deprecated tools/String with OUString in ScAddInCol .. Patch Set 2: I would prefer that you didn't submit this (2

[Libreoffice-commits] Changes to 'feature/remote'

2012-07-09 Thread Andrzej J.R. Hunt
New branch 'feature/remote' available with the following commits: commit 2821e10dd564d2431db1917c3a725ae157e33fc2 Author: Andrzej J. R. Hunt andr...@ahunt.org Date: Mon Jul 9 10:57:32 2012 +0100 Initial checkin of remote control. Change-Id: I71ac6c302c963dd2f8cffdcdf80d58c2a1074695

Change in core[master]: belated code cleanup (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: belated code cleanup (in sw/source/core/crsr/) .. Patch Set 1: I would prefer that you didn't submit

Change in core[master]: sal_Bool = bool if internal use only (in sw/source/core/crs...

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: sal_Bool = bool if internal use only (in sw/source/core/crsr/) .. Patch Set 1: Looks good to me, but

Change in core[master]: removed dead code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: removed dead code (in sw/source/core/crsr/) .. Patch Set 1: Looks good to me, but someone else must

[Libreoffice-commits] .: Branch 'feature/remote' - android/sdremote

2012-07-09 Thread Andrzej J.R. Hunt
android/sdremote/.classpath |8 android/sdremote/.project | 33 ++ android/sdremote/AndroidManifest.xml |

[Libreoffice-commits] .: cui/source svtools/source svx/inc svx/source

2012-07-09 Thread Eike Rathke
cui/source/options/optgdlg.cxx |6 +++--- svtools/source/misc/langtab.src |1 + svx/inc/svx/langbox.hxx |1 + svx/source/dialog/langbox.cxx | 11 +++ 4 files changed, 16 insertions(+), 3 deletions(-) New commits: commit 02b435f235d2863ee344054262200152edbba3a3

Change in core[master]: - fdo#45830 - Language/User Interface: current choice indica...

2012-07-09 Thread Gerrit
From Eike Rathke er...@redhat.com: Eike Rathke has posted comments on this change. Change subject: - fdo#45830 - Language/User Interface: current choice indicated as default .. Patch Set 3: Verified; Looks good to me,

Change in core[master]: renamed German variables (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: renamed German variables (in sw/source/core/crsr/) .. Patch Set 1: Looks good to me, but someone else

Change in core[master]: - fdo#45830 - Language/User Interface: current choice indica...

2012-07-09 Thread Gerrit
From Eike Rathke er...@redhat.com: Eike Rathke has submitted this change and it was merged. Change subject: - fdo#45830 - Language/User Interface: current choice indicated as default .. - fdo#45830 - Language/User Interface:

license statement

2012-07-09 Thread sdafsadfsadfadsf sadfsafsagasd
Hi! All my current and past contributions made to the LibreOffice project are done under MPL1.1+ / GPLv3+ / LGPLv3+. Until further notice, all my future contributions to the LibreOffice project are available under MPL1.1+ / GPLv3+ / LGPLv3+. Best regards, Bartek András

[Libreoffice-commits] .: sw/source

2012-07-09 Thread Michael Meeks
sw/source/core/crsr/bookmrk.cxx |3 +-- sw/source/core/crsr/crsrsh.cxx |4 ++-- sw/source/core/crsr/crstrvl.cxx |2 +- sw/source/core/crsr/findattr.cxx |8 sw/source/core/crsr/findtxt.cxx |9 - sw/source/core/crsr/pam.cxx | 14 +-

Change in core[master]: removed dead code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Michael Meeks michael.me...@suse.com: Michael Meeks has posted comments on this change. Change subject: removed dead code (in sw/source/core/crsr/) .. Patch Set 1: Verified; Looks good to me, approved Pushed this one to

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - cui/source svtools/source svx/inc svx/source

2012-07-09 Thread Eike Rathke
cui/source/options/optgdlg.cxx |6 +++--- svtools/source/misc/langtab.src |1 + svx/inc/svx/langbox.hxx |1 + svx/source/dialog/langbox.cxx | 11 +++ 4 files changed, 16 insertions(+), 3 deletions(-) New commits: commit 860b321d81633268e4b80b8fe10b73df615c28ae

Fwd: bug 36681 still present in 3.6beta3

2012-07-09 Thread Luc Castermans
2012/7/9 Michael Meeks michael.me...@suse.com: Hi Luc, On Sat, 2012-07-07 at 20:54 +0200, Luc Castermans wrote: https://bugs.freedesktop.org/show_bug.cgi?id=36681 If the bug has not been marked fixed; it will still be present in later versions :-) However - this is the

[Libreoffice-commits] .: vcl/source

2012-07-09 Thread Gökcen Eraslan
vcl/source/gdi/pdfwriter_impl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1a1e953ee33c213dc8b88dd96a69ca9fc5e42d50 Author: Gökçen Eraslan gokcen.eras...@gmail.com Date: Mon Jul 9 13:53:38 2012 +0300 We use hidden signatures for now.

[PATCH] for Draw

2012-07-09 Thread gokul
Hi, Generally people prefer closing an window with *ctrl+w *keyboard shortcut, i Found for Tools - XML Filter Settings window was not closed on Ctrl+w. I have added the code to perform the Related Task. I have enclosed the Patch with Mail. Kindly find the mail for the same With Regards S

[Libreoffice-commits] .: Branch 'feature/remote' - sd/source

2012-07-09 Thread Michael Meeks
sd/source/ui/remotecontrol/Receiver.cxx | 17 - sd/source/ui/remotecontrol/Receiver.hxx |9 - sd/source/ui/remotecontrol/RemoteDialog.cxx |7 --- sd/source/ui/remotecontrol/RemoteDialog.hxx |5 + sd/source/ui/remotecontrol/Server.cxx |

Change in core[master]: fdo#39468: translate German comments (= sw/source/core/crsr...

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: fdo#39468: translate German comments (= sw/source/core/crsr) .. Patch Set 1: Looks good to me, but

Change in core[master]: re-indented code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: re-indented code (in sw/source/core/crsr/) .. Patch Set 1: I would prefer that you didn't submit this

Change in core[master]: add/remove blank lines and braces (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: add/remove blank lines and braces (in sw/source/core/crsr/) .. Patch Set 1: I would prefer that you

Change in core[master]: adjusted existing comments (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: adjusted existing comments (in sw/source/core/crsr/) .. Patch Set 1: Looks good to me, but someone

[Libreoffice-commits] .: Branch 'feature/remote' - sd/inc sd/source

2012-07-09 Thread Michael Meeks
sd/inc/sddll.hxx |1 + sd/source/ui/app/sddll.cxx|3 +++ sd/source/ui/remotecontrol/Server.cxx | 12 +--- 3 files changed, 13 insertions(+), 3 deletions(-) New commits: commit 44a2e6d924cfa84ad40220b38ec18932f3e908c0 Author: Michael Meeks

Re: Bogus call to OUString::matchAsciiL in /framework/source/lomenubar/MenuItemStatusListener.cxx ?

2012-07-09 Thread Lubos Lunak
On Monday 09 of July 2012, David Tardon wrote: Hi, On Sun, Jul 08, 2012 at 02:37:49PM +0200, Christophe JAILLET wrote: Hi, At line 60 of /framework/source/lomenubar/MenuItemStatusListener.cxx, we can find if ((Event.State = oULabel) !oULabel.matchAsciiL (private:, 8,

[Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-09 Thread Jesso Murugan
Hi, There were some repeated calls in two for loops in ExpandColumnSelection function in swnewtable.cxx so I combined the two loops so that the same calls need not be made again. I debugged and tested after making the changes, everything works as expected. - Jesso Clarence

Change in core[master]: re-indented code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Michael Meeks michael.me...@suse.com: Michael Meeks has posted comments on this change. Change subject: re-indented code (in sw/source/core/crsr/) .. Patch Set 1: Fails; Do not submit So - IMHO we should hold fire on any

Change in core[master]: re-indented code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Michael Meeks michael.me...@suse.com: Michael Meeks has posted comments on this change. Change subject: re-indented code (in sw/source/core/crsr/) .. Patch Set 1: So - IMHO we should hold fire on any of this (nice) sort

Re: Question about calling a method with a default parameter

2012-07-09 Thread Lubos Lunak
On Sunday 08 of July 2012, Christophe JAILLET wrote: Hi, Sometimes some methods are declared with some default value(s) As an example, here is the definition of matchAsciiL for OUString sal_Bool matchAsciiL( const sal_Char* asciiStr, sal_Int32 asciiStrLength, sal_Int32 fromIndex = 0 )

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - i18npool/inc

2012-07-09 Thread Eike Rathke
i18npool/inc/i18npool/lang.h |1 + 1 file changed, 1 insertion(+) New commits: commit 2e3e332e5207b771fb05e6844ea96f742024001f Author: Eike Rathke er...@redhat.com Date: Mon Jul 9 13:48:54 2012 +0200 added LANGUAGE_USER_SYSTEM_CONFIG 0xFFFE for configuration context fdo#45830

REMINDER: Release 3.6.0-rc1 from libreoffice-3-6 branch

2012-07-09 Thread Petr Mladek
Hi, please note that the commit deadline for 3.6.0-rc1 is tomorrow (Tuesday), July 10, 2012. IMPORTANT: we are reaching the final phase, so all changes need get one review beginning with Wednesday, July 11, 2012. See also http://wiki.documentfoundation.org/ReleasePlan#3.5_release

Change in core[master]: re-indented code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Miklos Vajna vmik...@suse.cz: Miklos Vajna has posted comments on this change. Change subject: re-indented code (in sw/source/core/crsr/) .. Patch Set 1: abandoning, as requested -- To view, visit

Change in core[master]: re-indented code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Miklos Vajna vmik...@suse.cz: Miklos Vajna has posted comments on this change. Change subject: re-indented code (in sw/source/core/crsr/) .. Patch Set 1: abandoning, as requested -- To view, visit

Change in core[master]: fdo#39468: translate German comments (= sw/source/core/crsr...

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has posted comments on this change. Change subject: fdo#39468: translate German comments (= sw/source/core/crsr) .. Patch Set 1: (1 inline comment) So what would be

Change in core[master]: re-indented code (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has abandoned this change. Change subject: re-indented code (in sw/source/core/crsr/) .. Patch Set 1: Abandoned abandoning for real. -- To view, visit

Build errors in nss and jurt modules (Mac OS X).

2012-07-09 Thread Issa Alkurtass
Hello all. I ran into some issues while trying to build LibreOffice on my Mac. I followed a few workarounds available on this list. The modules I am currently getting errors in are nss and jurt. I tried disabling them but to no avail. I am running Mac OS X 10.7.3 64-bits with Xcode version 4.2.1.

[Patch] Bug 51716 - enlarge and reduce font size shortcut CTRL +] and CTRL + [ not working

2012-07-09 Thread Abdulmajeed A. Alabdulrazzaq
Hi the bug is missing shortcut for enlarge and reduce font size on impress and draw which is CTRL + [ and CTRL + ] i have solve it by adding the shortcuts to it from Accelerators.xcu file Warning: This message and its attachment, if any, are confidential and may contain information

[PATCH] Build problem.

2012-07-09 Thread Román Ginés Martínez Ferrández
Hello, I had to make the following change to compile because the printf function in the source (git diff): diff --git a/oox/source/ppt/slidefragmenthandler.cxx b/oox/source/ppt/slidefragmenthandler.cxx index 2b010be..d255b04 100644 --- a/oox/source/ppt/slidefragmenthandler.cxx +++

Long delay after lpsolve

2012-07-09 Thread Waitman Gobble
Hello, What is the general time delay after 'lpsolve deliver'? It sits for quite a long time, then stops on building sal. mythes deliver Module 'mythes' delivered successfully. 3 files copied, 2 files unchanged In file included from ../lp_utils.c:8:0: /usr/include/sys/timeb.h:42:2: warning:

Long delay after lpsolve

2012-07-09 Thread Waitman Gobble
Hello, What is the general time delay after 'lpsolve deliver'? It sits for quite a long time, then stops on building sal. mythes deliver Module 'mythes' delivered successfully. 3 files copied, 2 files unchanged In file included from ../lp_utils.c:8:0: /usr/include/sys/timeb.h:42:2: warning:

Re: Proposal/Prototype support for fill in character in Calc Number Format Strings

2012-07-09 Thread Kohei Yoshida
Hi Johann, I hope you don't mind me forwarding this nice work of yours to our main development mailing list, to let other interested developers know of your work. Let me also CC Noel since he's done a very similar work for 3.6. There may be some overlap between his work and yours...

Re: minutes of ESC call ...

2012-07-09 Thread Eike Rathke
Hi, On Thursday, 2012-07-05 16:13:32 +0100, Michael Meeks wrote: * ohloh non-updating (Eike) + they have been poked about it are working on it. This appears to have been fixed, current update was July-08 Eike -- LibreOffice Calc developer. Number formatter stricken i18n

Change in core[master]: add/remove blank lines and braces (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From Philipp Riemer ruderphil...@gmail.com: Philipp Riemer has posted comments on this change. Change subject: add/remove blank lines and braces (in sw/source/core/crsr/) .. Patch Set 1: To be honest, I don't understand how

Re: [PATCH] Build problem.

2012-07-09 Thread Lubos Lunak
On Saturday 07 of July 2012, Román Ginés Martínez Ferrández wrote: Hello, I had to make the following change to compile because the printf function in the source (git diff): Thanks, but the printf was committed by mistake and has already been removed, so the code should compile fine again.

gerrit lame / non-reviews ...

2012-07-09 Thread Michael Meeks
Hi guys, On Mon, 2012-07-09 at 10:28 +, Gerrit wrote: Björn Michaelsen has posted comments on this change. Let me pick on Bjoern because he is a big guy :-) Change subject: renamed German variables (in sw/source/core/crsr/)

Change in core[master]: add/remove blank lines and braces (in sw/source/core/crsr/)

2012-07-09 Thread Gerrit
From David Ostrovsky david.ostrov...@gmx.de: David Ostrovsky has posted comments on this change. Change subject: add/remove blank lines and braces (in sw/source/core/crsr/) .. Patch Set 1: I described here:

[Libreoffice-commits] .: l10ntools/source

2012-07-09 Thread Caolán McNamara
l10ntools/source/help/HelpIndexer.cxx | 77 +++-- l10ntools/source/help/HelpIndexer_main.cxx | 12 2 files changed, 44 insertions(+), 45 deletions(-) New commits: commit 4c912d3d8bd1ae01131e90fb4a2d8371a53ee888 Author: Caolán McNamara caol...@redhat.com

[Libreoffice-commits] .: 2 commits - sw/source

2012-07-09 Thread Miklos Vajna
sw/source/core/inc/frame.hxx |1 + sw/source/core/layout/flowfrm.cxx |5 - sw/source/core/layout/pagechg.cxx | 16 +--- sw/source/core/layout/trvlfrm.cxx | 17 + 4 files changed, 35 insertions(+), 4 deletions(-) New commits: commit

Change in core[master]: fdo#51179: SearchAscii() is equal to indexOfAsciiL(), not ma...

2012-07-09 Thread Gerrit
From Eike Rathke er...@redhat.com: Eike Rathke has posted comments on this change. Change subject: fdo#51179: SearchAscii() is equal to indexOfAsciiL(), not match() .. Patch Set 1: I would prefer that you didn't submit this

[Libreoffice-commits] .: 2 commits - basctl/Library_basctl.mk basic/CppunitTest_basic_enable.mk basic/CppunitTest_basic_nested_struct.mk basic/CppunitTest_basic_scanner.mk basic/Library_sb.mk dbaccess

2012-07-09 Thread Michael Meeks
Repository.mk |2 basctl/Library_basctl.mk |2 basic/CppunitTest_basic_enable.mk |2 basic/CppunitTest_basic_nested_struct.mk |2 basic/CppunitTest_basic_scanner.mk |2

[Libreoffice-commits] .: vcl/source

2012-07-09 Thread Ivan Timofeev
vcl/source/window/toolbox.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 89de7eef5090c5efdca1314f8838bdc977001e5d Author: Ivan Timofeev timofeev@gmail.com Date: Mon Jul 9 17:24:54 2012 +0400 fdo#47071: Undocked toolbars do not show all icons in

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/source

2012-07-09 Thread Ivan Timofeev
vcl/source/window/toolbox.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 20ed0cf74cc4dc4e181b5403a1faf351b6eb38b7 Author: Ivan Timofeev timofeev@gmail.com Date: Mon Jul 9 17:24:54 2012 +0400 fdo#47071: Undocked toolbars do not show all icons in

[Libreoffice-commits] .: sw/source

2012-07-09 Thread Caolán McNamara
sw/source/core/txtnode/ndtxt.cxx |4 1 file changed, 4 insertions(+) New commits: commit 99bd0d846fd2daf4905b986cae4cfb31fde04964 Author: Caolán McNamara caol...@redhat.com Date: Mon Jul 9 14:31:17 2012 +0100 Resolves: fdo#51908 drop word/char count cache when numbering rule

Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-09 Thread Matteo Casalin
Hi all, just a minor hint from my side: in the original code nBox was incremented only when pBox == rBoxes[nBox], while in the new one it happens unconditionally. I don't know if this could be an issue or not. To preserve the original behaviour a single conditional if ( nBox nBoxCnt

[Libreoffice-commits] .: sc/qa

2012-07-09 Thread Kohei Yoshida
sc/qa/unit/ucalc.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit ebc60c3297ae464898f6135e4cc5a652fb53b935 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon Jul 9 10:12:53 2012 -0400 Unit test for string input with custom string handling policy.

Change in core[libreoffice-3-5]: fdo#47071: Undocked toolbars do not show all icons in specia...

2012-07-09 Thread Gerrit
From Ivan Timofeev timofeev@gmail.com: Ivan Timofeev has uploaded a new change for review. Change subject: fdo#47071: Undocked toolbars do not show all icons in special ratio .. fdo#47071: Undocked toolbars do not show all

Re: Long delay after lpsolve

2012-07-09 Thread Michael Meeks
On Sat, 2012-07-07 at 23:18 -0700, Waitman Gobble wrote: What is the general time delay after 'lpsolve deliver'? It sits for quite a long time, then stops on building sal. lpsolve deliver is usually rather quick. I suspect you're taking a hit from the next 'make'. {appears to sit

Re: Bug 37559 pixel artefacts in graphic objects in exported PDF

2012-07-09 Thread Thorsten Behrens
Johannes Sixt wrote: I've discoverd a document that shows the pixel artefacts on screen, not only after it is exported to PDF. I would like to investigate this. Where can I find the code that renders LO draw objects (e.g. a rectangle with rounded corners) to the screen? Hi Johannes, the

Re: Build errors in nss and jurt modules (Mac OS X).

2012-07-09 Thread Michael Meeks
Hi there, On Sat, 2012-07-07 at 06:50 +, Issa Alkurtass wrote: Hello all. I ran into some issues while trying to build LibreOffice on my Mac. I followed a few workarounds available on this list. Great. The modules I am currently getting errors in are nss and jurt. I tried

Re: gerrit lame / non-reviews ...

2012-07-09 Thread Bjoern Michaelsen
Hi Michael, On Mon, Jul 09, 2012 at 01:29:42PM +0100, Michael Meeks wrote: Hi guys, On Mon, 2012-07-09 at 10:28 +, Gerrit wrote: Björn Michaelsen has posted comments on this change. Let me pick on Bjoern because he is a big guy :-) I only have havy bones!!1!eleven Change

Re: [PATCH] [IGNORE] Converting SV_DECL_PTRARR_SORT (9)

2012-07-09 Thread Noel Grandin
Hi Please ignore these, I just figured out a better way to implement them (Instead of using std::vector, I should be using the version of std::set that allows a custom comparator) Thanks, Noel Grandin. On 2012-07-09 10:47, Noel Grandin wrote: Hi These patches convert various places in the

Re: [Patch] Removed repeated calls in for loops in swnewtable.cxx

2012-07-09 Thread Jesso Murugan
Hi Matteo, just a minor hint from my side: in the original code nBox was incremented only when pBox == rBoxes[nBox], while in the new one it happens unconditionally. Sorry for over looking that. I don't know if this could be an issue or not. I tested by re building and putting a

[Libreoffice-commits] .: framework/source

2012-07-09 Thread Stephan Bergmann
framework/source/services/backingcomp.cxx |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit 228a3f8b9f279e80917968d9780e822a1d684ada Author: Stephan Bergmann sberg...@redhat.com Date: Mon Jul 9 16:32:47 2012 +0200 Handle attachFrame on disposed object

Change in core[master]: removed deserted Lotus 1-2-3 export filter

2012-07-09 Thread Gerrit
From Takeshi Abe t...@fixedpoint.jp: Takeshi Abe has uploaded a new change for review. Change subject: removed deserted Lotus 1-2-3 export filter .. removed deserted Lotus 1-2-3 export filter which has never enabled so far

[Libreoffice-commits] .: Branch 'feature/remote' - sd/Library_sd.mk sd/source

2012-07-09 Thread Andrzej J.R. Hunt
sd/Library_sd.mk|6 + sd/source/ui/remotecontrol/Receiver.cxx | 50 ++- sd/source/ui/remotecontrol/Receiver.hxx | 17 ++--- sd/source/ui/remotecontrol/Server.cxx | 103 ++-- sd/source/ui/remotecontrol/Server.hxx | 23

[Libreoffice-commits] .: sc/qa

2012-07-09 Thread Kohei Yoshida
sc/qa/extras/sceditfieldobj-cell.cxx | 40 ++- 1 file changed, 39 insertions(+), 1 deletion(-) New commits: commit 54e592926be7410bbd44b1482288305ea568073a Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon Jul 9 10:59:18 2012 -0400 UNO API test for

Re: [REVIEWED] - use indexOfAsciiL and avoid static variable

2012-07-09 Thread Ivan Timofeev
Hi Christophe See comments at https://gerrit.libreoffice.org/#/c/269/ @Bjoern: maybe it's not a good idea to post patches from the list on gerrit?.. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [REVIEWED] - use indexOfAsciiL and avoid static variable

2012-07-09 Thread Ivan Timofeev
On 09.07.2012 19:01, Ivan Timofeev wrote: See comments at https://gerrit.libreoffice.org/#/c/269/ Oh, Bjoern already provided the link, my message filters placed his mail in the other folder. ugh... Sorry, Ivan ___ LibreOffice mailing list

New Whiteboard Status to Reflect decision pending

2012-07-09 Thread Joel Madero
Hi All, There are quite a few open bugs that are currently being discussed by dev/qa/UX etcI was wondering if everyone (or most everyone) is comfortable adding a new white board status so we can mark the bugs as NEW but set them as DECISIONPENDING. Then a quick comment to say that we're

  1   2   3   4   >