[PATCH] silence odk check

2013-04-22 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3536 to look at the new patch set (#5). Change subject: silence odk check .. silence odk check Change-Id:

[Libreoffice-commits] core.git: external/Module_external.mk

2013-04-22 Thread David Tardon
external/Module_external.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fdd24a57655c3d15addeeca12e844cc1cd4e1765 Author: David Tardon dtar...@redhat.com Date: Mon Apr 22 06:43:52 2013 +0200 msvc80 dlls are only needed for mozab driver Change-Id:

[PATCH] add a check to catch typos in Package names

2013-04-22 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3542 to look at the new patch set (#3). Change subject: add a check to catch typos in Package names .. add a

[PATCH] Replace chained O(U)StringBuffer::append() with operator+

2013-04-22 Thread Anurag Kanungo (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3546 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/3546/1 Replace chained O(U)StringBuffer::append() with operator+ modified:

[Libreoffice-commits] core.git: jurt/Package_jnilib.mk

2013-04-22 Thread David Tardon
jurt/Package_jnilib.mk |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 6e205903f044186392a9aca24203148167552159 Author: David Tardon dtar...@redhat.com Date: Mon Apr 22 06:55:25 2013 +0200 add missing package name This means the file has not been

[PATCH] add a check to catch typos in Package names

2013-04-22 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3542 to look at the new patch set (#4). Change subject: add a check to catch typos in Package names .. add a

Fwd: Help to make it possible to add custom animation to Master Slides.

2013-04-22 Thread Janit Anjaria
-- Forwarded message -- From: Janit Anjaria jani...@gmail.com Date: Tue, Apr 16, 2013 at 2:55 PM Subject: Help to make it possible to add custom animation to Master Slides. To: libreoffice-dev libreoffice@lists.freedesktop.org Hey! I have been looking into this bug/feature( and

[PATCH] Bug 62096 - Replace O(U)String compareTo with ==

2013-04-22 Thread Anurag Kanungo (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3547 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3547/1 Bug 62096 - Replace O(U)String compareTo with == Change-Id: I3a8befcf51cea862e9bcc2670bce506004c1be9a --- M

Re: [PROPOSAL] enable gerrit buildbot trigger for all in group commiter

2013-04-22 Thread Lionel Elie Mamane
On Sun, Apr 21, 2013 at 11:06:20PM +0200, Bjoern Michaelsen wrote: so this is a proposal to enable the ability to trigger a build for all in the group commiter (...) This sounds attractive. We can do this ~immediately and do the through web interface / gerrit when we figured out how to do it.

[REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

2013-04-22 Thread Winfried Donkers
Can this fix be cherry-picked for 4.0 releases (4.0.3 would be extremely nice)? The fix solves various small erroneous results of the calc function YEARFAC. BTW, http://wiki.services.openoffice.org/wiki/Documentation/How_Tos/Calc:_YEARFRAC_function now no lnger applies for LibreOffice ;-)

[Libreoffice-commits] core.git: 3 commits - jpeg/ExternalPackage_jpeg.mk jurt/CustomTarget_jnilib.mk jurt/Package_jnilib.mk vcl/source

2013-04-22 Thread David Tardon
jpeg/ExternalPackage_jpeg.mk |1 - jurt/CustomTarget_jnilib.mk | 13 +++-- jurt/Package_jnilib.mk|6 ++ vcl/source/filter/jpeg/transupp.c | 34 +++--- 4 files changed, 32 insertions(+), 22 deletions(-) New commits: commit

[PATCH] add a check to catch typos in Package names

2013-04-22 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3542 to look at the new patch set (#5). Change subject: add a check to catch typos in Package names .. add a

[PATCH] replace python-core zip built in pyuno with direct use of Pa...

2013-04-22 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3525 to look at the new rebased patch set (#3). Change subject: replace python-core zip built in pyuno with direct use of Package

[Libreoffice-commits] core.git: jurt/Package_jnilib.mk

2013-04-22 Thread David Tardon
jurt/Package_jnilib.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 65d3bc8d40f0e10557523117464fa7c2a103636b Author: David Tardon dtar...@redhat.com Date: Mon Apr 22 08:44:58 2013 +0200 fix stupid typo Change-Id:

[REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

2013-04-22 Thread Winfried Donkers
Can this fix be cherry-picked for 4.0 releases (4.0.3 would be extremely nice)? The fix solves various small erroneous results of the calc function YEARFAC. Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] add a check to catch typos in Package names

2013-04-22 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3542 to look at the new patch set (#6). Change subject: add a check to catch typos in Package names .. add a

RE: [REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

2013-04-22 Thread Winfried Donkers
Please disregard thuis second review proposal; I accidentily sent the request twice... Winfried Van: Winfried Donkers Verzonden: maandag 22 april 2013 08:45 Aan: libreoffice@lists.freedesktop.org Onderwerp: [REVIEW 4.0] fdo#40100 YEARFRAC function returns incorrect results for some dates

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk odk/util

2013-04-22 Thread David Tardon
odk/CustomTarget_check.mk |8 ++- odk/util/check.pl | 121 +- 2 files changed, 73 insertions(+), 56 deletions(-) New commits: commit e640cd59ea191e82102865ff9729adc070fea293 Author: David Tardon dtar...@redhat.com Date: Sun Apr 21

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk

2013-04-22 Thread David Tardon
odk/CustomTarget_check.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit df09d47db035e08b3f86bb44a88b12fce6757325 Author: David Tardon dtar...@redhat.com Date: Sun Apr 21 15:40:28 2013 +0200 fix typo Change-Id:

[Libreoffice-commits] core.git: odk/CustomTarget_bin.mk odk/CustomTarget_check.mk odk/CustomTarget_odkcommon.mk odk/Module_odk.mk odk/Package_bin.mk odk/Package_macosx.mk scp2/source

2013-04-22 Thread David Tardon
odk/CustomTarget_bin.mk| 42 - odk/CustomTarget_check.mk |2 + odk/CustomTarget_odkcommon.mk |1 odk/Module_odk.mk |8 ++- odk/Package_bin.mk | 28

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk odk/CustomTarget_cli.mk odk/CustomTarget_odkcommon.mk odk/Module_odk.mk odk/Package_cli.mk scp2/source

2013-04-22 Thread David Tardon
odk/CustomTarget_check.mk |1 + odk/CustomTarget_cli.mk| 29 - odk/CustomTarget_odkcommon.mk |3 +-- odk/Module_odk.mk |2 +- odk/Package_cli.mk | 22 ++

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk odk/CustomTarget_classes.mk odk/CustomTarget_unowinreg.mk odk/Module_odk.mk odk/Package_unowinreg.mk odk/Zip_uno_loader_classes.mk scp2/source

2013-04-22 Thread David Tardon
odk/CustomTarget_check.mk |1 + odk/CustomTarget_classes.mk|7 --- odk/CustomTarget_unowinreg.mk | 12 +--- odk/Module_odk.mk |3 ++- odk/Package_unowinreg.mk | 28

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk odk/CustomTarget_lib.mk odk/CustomTarget_odkcommon.mk odk/Module_odk.mk odk/Package_lib.mk scp2/source

2013-04-22 Thread David Tardon
odk/CustomTarget_check.mk |1 odk/CustomTarget_lib.mk| 40 - odk/CustomTarget_odkcommon.mk |1 odk/Module_odk.mk |2 - odk/Package_lib.mk | 28 +

[PUSHED] allow odk/util/check.pl to use two base dirs

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3527 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3527 To unsubscribe,

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk odk/CustomTarget_config_win.mk odk/CustomTarget_html.mk odk/CustomTarget_odkcommon.mk odk/Module_odk.mk odk/Package_config.mk odk/Package_conf

2013-04-22 Thread David Tardon
odk/CustomTarget_check.mk |9 +++ odk/CustomTarget_config_win.mk | 19 +++ odk/CustomTarget_html.mk | 25 ++ odk/CustomTarget_odkcommon.mk | 92 - odk/Module_odk.mk | 15 ++

[PUSHED] fix typo

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3528 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3528 To unsubscribe,

[PUSHED] replace CustomTarget_odk/odkcommon/cli by Package

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3530 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3530 To unsubscribe,

[PUSHED] use Package for unowinreg

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3531 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3531 To unsubscribe,

[PUSHED] replace CustomTarget_odk/odkcommon/lib by Package

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3532 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3532 To unsubscribe,

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk odk/CustomTarget_odkcommon.mk odk/CustomTarget_settings.mk odk/Module_odk.mk odk/Package_settings_generated.mk odk/Package_settings.mk scp2/so

2013-04-22 Thread David Tardon
odk/CustomTarget_check.mk |2 ++ odk/CustomTarget_odkcommon.mk |1 - odk/CustomTarget_settings.mk | 20 ++-- odk/Module_odk.mk |2 ++ odk/Package_settings.mk| 21 +

[Libreoffice-commits] core.git: odk/Module_odk.mk

2013-04-22 Thread David Tardon
odk/Module_odk.mk |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 085c5c6beade545e4e93cf8463b6848cf2d19060 Author: David Tardon dtar...@redhat.com Date: Sun Apr 21 17:42:17 2013 +0200 make odk inst. check a check target Change-Id:

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk odk/util

2013-04-22 Thread David Tardon
odk/CustomTarget_check.mk | 13 +++-- odk/util/check.pl |1 - 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 43c422ebb7a7c1431d179ed1b9572fabf9845aa8 Author: David Tardon dtar...@redhat.com Date: Sun Apr 21 18:15:15 2013 +0200 silence odk check

[PUSHED] chip more files off the odkcommon.zip block

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3533 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3533 To unsubscribe,

[PUSHED] replace CustomTarget_odk/odkcommon/settings by Package

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3534 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3534 To unsubscribe,

[PUSHED] make odk inst. check a check target

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3535 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3535 To unsubscribe,

[PATCH] silence odk check

2013-04-22 Thread Fridrich Strba (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3536 to look at the new rebased patch set (#6). Change subject: silence odk check .. silence odk check

[PUSHED] silence odk check

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3536 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3536 To unsubscribe,

[PATCH] Do not store return value for later, just exit

2013-04-22 Thread Fridrich Strba (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3541 to look at the new rebased patch set (#2). Change subject: Do not store return value for later, just exit

[Libreoffice-commits] core.git: editeng/source

2013-04-22 Thread Matteo Casalin
editeng/source/misc/hangulhanja.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit d1f99bdf2abf591994b6efb2e73dcd31fdee8384 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Apr 21 17:38:39 2013 +0200 bDocumentDone is always false

[PUSHED] sal_Bool to bool

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3537 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3537 To unsubscribe,

[PATCH] replace python-core zip built in pyuno with direct use of Pa...

2013-04-22 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3525 to look at the new rebased patch set (#4). Change subject: replace python-core zip built in pyuno with direct use of Package

[PUSHED] bDocumentDone is always false

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3538 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3538 To unsubscribe,

[Libreoffice-commits] core.git: 3 commits - editeng/source vcl/source

2013-04-22 Thread Stephan Bergmann
editeng/source/misc/hangulhanja.cxx |8 +++- vcl/source/filter/jpeg/transupp.c | 12 2 files changed, 15 insertions(+), 5 deletions(-) New commits: commit 6e2bc6403be0f9cf4cf324f870623c87f45cfa93 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Apr 22 09:20:09

[Libreoffice-commits] core.git: editeng/source

2013-04-22 Thread Matteo Casalin
editeng/source/editeng/textconv.cxx | 148 +--- editeng/source/editeng/textconv.hxx | 36 2 files changed, 91 insertions(+), 93 deletions(-) New commits: commit 43513fec9c74d70da83a71c9a06e191db3f02d40 Author: Matteo Casalin matteo.casa...@yahoo.com

[Libreoffice-commits] core.git: editeng/source

2013-04-22 Thread Matteo Casalin
editeng/source/editeng/textconv.cxx |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) New commits: commit e7bfe847114d7fd95e6820db01ca9ee876468fbe Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Apr 21 18:38:40 2013 +0200 Do not store return value for later, just

[PUSHED] Slightly simplify loop

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3539 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3539 To unsubscribe,

[PUSHED] Prefer standard prefix for data members

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3540 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3540 To unsubscribe,

[PATCH] Do not store return value for later, just exit

2013-04-22 Thread Fridrich Strba (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3541 to look at the new rebased patch set (#3). Change subject: Do not store return value for later, just exit

[PUSHED] Do not store return value for later, just exit

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3541 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3541 To unsubscribe,

[Libreoffice-commits] core.git: ucb/source xmlhelp/source

2013-04-22 Thread Sameer Deshmukh
ucb/source/ucp/webdav-neon/NeonPropFindRequest.cxx |2 +- xmlhelp/source/cxxhelp/provider/databases.hxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 560e4fd02f8a4a3e26b3810b12d02a2d2e78593f Author: Sameer Deshmukh sameer.deshmuk...@gmail.com Date:

[Libreoffice-commits] core.git: xmlhelp/source

2013-04-22 Thread Sameer Deshmukh
xmlhelp/source/cxxhelp/provider/db.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ca54015d7ea10f5648bccb2adfb7a321747e70f9 Author: Sameer Deshmukh sameer.deshmuk...@gmail.com Date: Mon Apr 22 00:43:56 2013 +0530 fdo#62096 Corrected stupid error in

Re: Build failure on master with OSX - datetime.hxx

2013-04-22 Thread Alexander Thurgood
Le 20/04/13 12:09, Jonathan Aquilina a écrit : Still failing for me in dbconversion.cxx:42 : error : integer constant is too large for 'long' type Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PUSHED] fdo#62096 - Changed a few compareTo's to '=='

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3523 Approvals: Thomas Arnhold: Looks good to me, but someone else must approve Fridrich Strba: Verified; Looks good to me, approved -- To

[ABANDONED] fdo#62096 - Replaced compareTo with ==

2013-04-22 Thread Fridrich Strba (via Code Review)
Fridrich Strba has abandoned this change. Change subject: fdo#62096 - Replaced compareTo with == .. Patch Set 1: Abandoned Abandon change that failed review -- To view, visit https://gerrit.libreoffice.org/3544 To

[ABANDONED] fdo#62096 replaced some compareTo's with ==

2013-04-22 Thread Fridrich Strba (via Code Review)
Fridrich Strba has abandoned this change. Change subject: fdo#62096 replaced some compareTo's with == .. Patch Set 1: Abandoned abandoning, since a sane part was submitted as a separate patch -- To view, visit

[PUSHED] fdo#62096 Corrected stupid error in previous patch

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3545 Approvals: Thomas Arnhold: Verified; Looks good to me, but someone else must approve Fridrich Strba: Verified; Looks good to me, approved

[PATCH] Bug 60265 - Document converter wizard fails to find powerpoi...

2013-04-22 Thread Anurag Kanungo (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3548 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3548/1 Bug 60265 - Document converter wizard fails to find powerpoint files to convert ppt,pps,pptx,ppsx,pptm,ppsm are

[Libreoffice-commits] core.git: sal/inc sal/qa writerfilter/source

2013-04-22 Thread Sameer Deshmukh
sal/inc/rtl/string.hxx|8 sal/qa/rtl_strings/rtl_OString.cxx|6 +++--- writerfilter/source/ooxml/OOXMLStreamImpl.cxx | 14 +++--- 3 files changed, 14 insertions(+), 14 deletions(-) New commits: commit

Re: Python scripts other than Logo missing in master build

2013-04-22 Thread David Tardon
Hi, On Sun, Apr 21, 2013 at 10:46:35AM -0700, julien2412 wrote: Hello Alex, I've made some changes on this lately and noticed a typo in scripting/Package_ScriptsPython.mk The third line shows Scripting instead of scripting. Badfully i don't have access to my laptop to change this. Could

[PATCH] fdo#62096: Replaced some compareTo with ==

2013-04-22 Thread Fridrich Strba (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3509 to look at the new patch set (#2). Change subject: fdo#62096: Replaced some compareTo with == ..

[PUSHED] fdo#62096: Replaced some compareTo with ==

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3509 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3509 To unsubscribe,

[PATCH] fdo#62096: Replaced some compareTo with ==

2013-04-22 Thread Fridrich Strba (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3509 to look at the new patch set (#3). Change subject: fdo#62096: Replaced some compareTo with == ..

[Libreoffice-commits] core.git: basctl/source

2013-04-22 Thread anuragkanungo
basctl/source/basicide/basides2.cxx | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) New commits: commit 97f6625d9a49f62f09b0f9ddab8fa4935de45ae5 Author: anuragkanungo anuragkanu...@gmail.com Date: Sun Apr 21 23:58:21 2013 +0530 Replace chained O(U)StringBuffer::append()

[PATCH] related to fdo#63546.

2013-04-22 Thread navin patidar (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3549 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/3549/1 related to fdo#63546. set appropriate alignment when wrt direction of selected cells is changed. Change-Id:

[PUSHED] Replace chained O(U)StringBuffer::append() with operator+

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3546 Approvals: Thomas Arnhold: Verified; Looks good to me, but someone else must approve Fridrich Strba: Verified; Looks good to me, approved

[Libreoffice-commits] core.git: sal/inc sal/qa writerfilter/source

2013-04-22 Thread Fridrich Štrba
sal/inc/rtl/string.hxx|8 sal/qa/rtl_strings/rtl_OString.cxx|6 +++--- writerfilter/source/ooxml/OOXMLStreamImpl.cxx | 14 +++--- 3 files changed, 14 insertions(+), 14 deletions(-) New commits: commit

Re: [PROPOSAL] enable gerrit buildbot trigger for all in group commiter

2013-04-22 Thread Bjoern Michaelsen
On Sun, Apr 21, 2013 at 07:02:29PM -0500, Norbert Thiebaud wrote: On Sun, Apr 21, 2013 at 4:06 PM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: Opinions? as of now the only way to do that is to give buildbot admin ACL and to use a command line to schedule build... So what is

Re: [PROPOSAL] enable gerrit buildbot trigger for all in group commiter

2013-04-22 Thread Bjoern Michaelsen
Hi, On Mon, Apr 22, 2013 at 07:50:55AM +0200, Lionel Elie Mamane wrote: On Sun, Apr 21, 2013 at 11:06:20PM +0200, Bjoern Michaelsen wrote: so this is a proposal to enable the ability to trigger a build for all in the group commiter (...) This sounds attractive. We can do this

Re: [PROPOSAL] enable gerrit buildbot trigger for all in group commiter

2013-04-22 Thread Lionel Elie Mamane
On Mon, Apr 22, 2013 at 10:10:46AM +0200, Bjoern Michaelsen wrote: On Mon, Apr 22, 2013 at 07:50:55AM +0200, Lionel Elie Mamane wrote: On Sun, Apr 21, 2013 at 11:06:20PM +0200, Bjoern Michaelsen wrote: so this is a proposal to enable the ability to trigger a build for all in the group

[Libreoffice-commits] core.git: xmloff/source

2013-04-22 Thread Radu Ioan
xmloff/source/chart/SchXMLImport.cxx | 22 +++-- xmloff/source/chart/SchXMLLegendContext.cxx |6 ++-- xmloff/source/chart/SchXMLPlotAreaContext.cxx | 32 ++ xmloff/source/chart/SchXMLSeries2Context.cxx | 25 +---

[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3526 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3526 To unsubscribe,

Re: Build failure on master with OSX - datetime.hxx

2013-04-22 Thread Lionel Elie Mamane
On Mon, Apr 22, 2013 at 09:29:45AM +0200, Alexander Thurgood wrote: Still failing for me in dbconversion.cxx:42 : error : integer constant is too large for 'long' type Should have been fixed by commit 693d25f8a601ee3738a396fbd8a9b838f19e39c9 Author: Norbert Thiebaud nthieb...@gmail.com Date:

[Libreoffice-commits] core.git: vcl/source

2013-04-22 Thread Tor Lillqvist
vcl/source/window/window2.cxx | 56 +++--- 1 file changed, 20 insertions(+), 36 deletions(-) New commits: commit c16de2eb12cc8d2885d55f7d240a17fa0444a3ca Author: Tor Lillqvist t...@iki.fi Date: Sun Apr 21 18:16:12 2013 +0300 Factor out identical code

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - basic/source

2013-04-22 Thread Eike Rathke
basic/source/sbx/sbxscan.cxx | 202 +-- 1 file changed, 121 insertions(+), 81 deletions(-) New commits: commit 565c2dd3039a7c9aa1d82eadc4d5e54ea87cda9c Author: Eike Rathke er...@redhat.com Date: Tue Mar 19 23:23:16 2013 +0100 resolved rhbz#919020

Re: Build failure on master with OSX - datetime.hxx

2013-04-22 Thread Alexander Thurgood
Le 22/04/13 10:20, Lionel Elie Mamane a écrit : On Mon, Apr 22, 2013 at 09:29:45AM +0200, Alexander Thurgood wrote: Should have been fixed by commit 693d25f8a601ee3738a396fbd8a9b838f19e39c9 Author: Norbert Thiebaud nthieb...@gmail.com Date: Sat Apr 20 17:31:26 2013 -0500

[PATCH] Replace chained O(U)StringBuffer::append() with operator+

2013-04-22 Thread Anurag Kanungo (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3550 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/3550/1 Replace chained O(U)StringBuffer::append() with operator+ Change-Id: I24923acfe693eca63d641b6d685c0f4e3dcd9298

[PUSHED libreoffice-3-6] resolved rhbz#919020 Basic CDbl() and CSng() scan localized ...

2013-04-22 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3486 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3486 To unsubscribe,

Re: Build failure on master with OSX - datetime.hxx

2013-04-22 Thread Lionel Elie Mamane
On Mon, Apr 22, 2013 at 10:28:21AM +0200, Alexander Thurgood wrote: Le 22/04/13 10:20, Lionel Elie Mamane a écrit : On Mon, Apr 22, 2013 at 09:29:45AM +0200, Alexander Thurgood wrote: Should have been fixed by commit 693d25f8a601ee3738a396fbd8a9b838f19e39c9 Ah, OK, I started my build

[Libreoffice-commits] core.git: solenv/bin

2013-04-22 Thread Tor Lillqvist
0 files changed New commits: commit 6d18625207aa6c9a1861a0bc1e266f0c931fdd79 Author: Tor Lillqvist t...@iki.fi Date: Mon Apr 22 11:51:24 2013 +0300 chmod +x Change-Id: I2358b2241bf260afb85005c247cb8be82104e2e5 diff --git a/solenv/bin/install-gdb-printers

RE : RE : Difficulties to build LO for windows

2013-04-22 Thread Gay, Matthieu
Hello Sorry for the late update, but I did succeed building on windows I had to modify setup_osl.inf and delete the call to gid_MergeModule_Microsoft_VC100_CRT_x86. Now I tried to add language parameter: --with-lang=en-US fr de it es I had this bug http://d.hatena.ne.jp/foral/2027 which

[Libreoffice-commits] core.git: 2 commits - sc/source

2013-04-22 Thread Markus Mohrhard
sc/source/core/data/table2.cxx |6 ++ sc/source/ui/view/viewfun3.cxx |4 +--- 2 files changed, 7 insertions(+), 3 deletions(-) New commits: commit 07a7f97b21a02284456e575fe4404f0d216a6723 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed Apr 17 03:13:23 2013 +0200

Re: install-gdb-printers exec perms ?

2013-04-22 Thread Miklos Vajna
Hi, On Sat, Apr 20, 2013 at 10:40:45PM +0100, Michael Meeks michael.me...@suse.com wrote: I just built master from clean and got a non-executable solenv/bin/install-gdb-printers which apparently caused a build failure. Too late to fix it for me just now - hope it helps; chmod +x

Re: Python extension not working on Mac (LibreOffice 4.0.2.2)

2013-04-22 Thread Carles Pina i Estany
Hello, On Apr/19/2013, Norbert Thiebaud wrote: On Monday I can try using LO 4.0.3 RC1, sadly I don't have access to Mac hardware before. 4.0.3.1 has been rebuilt and will be mirrored soonish... and should not have that bug. by monday you should be able to download a working 4.0.3.1

[PATCH] Allow switching between HarfBuzz and LE at runtime

2013-04-22 Thread Fridrich Strba (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3521 to look at the new rebased patch set (#2). Change subject: Allow switching between HarfBuzz and LE at runtime

[Libreoffice-commits] core.git: smoketest/com smoketest/data

2013-04-22 Thread Stephan Bergmann
smoketest/com/sun/star/comp/smoketest/description.xml |2 +- smoketest/data/Basic/Standard/Test_Ext.xml|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit b9cc769926fa2558b8e76181b0cc850347410a09 Author: Stephan Bergmann sberg...@redhat.com Date: Mon

new feature: how to document it?

2013-04-22 Thread Lionel Elie Mamane
(Moving discussion to documentation team ML. Please keep me in CC, I'm not subscribed / I don't read that ML often.) On Sun, Apr 21, 2013 at 11:46:56AM +0200, Alex Thurgood wrote: Le 20/04/2013 23:34, Lionel Elie Mamane a écrit : One last question: where can I edit the help to document a new

Re: install-gdb-printers exec perms ?

2013-04-22 Thread Michael Meeks
On Mon, 2013-04-22 at 11:01 +0200, Miklos Vajna wrote: Hmm, I guess that was a local problem at you -- here it's already executable and git log says it always was. Plenty of scope for user error here ;-) PEBKAC etc. Thanks ! Michael. --

[Libreoffice-commits] libvisio.git: configure.ac

2013-04-22 Thread Fridrich Štrba
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 28509115f7f60541d69b37bea0720305ea13d363 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Mon Apr 22 11:18:32 2013 +0200 Bump version diff --git a/configure.ac b/configure.ac index

Re: new feature: how to document it?

2013-04-22 Thread Lionel Elie Mamane
On Mon, Apr 22, 2013 at 11:11:46AM +0200, Lionel Elie Mamane wrote: Le 20/04/2013 23:34, Lionel Elie Mamane a écrit : One last question: where can I edit the help to document a new feature I'm introducing (namely, the option that the storage value is the index in the list)? I grepped for a

[Libreoffice-commits] core.git: extras/source svx/inc svx/source

2013-04-22 Thread Armin Le Grand
dev/null |binary svx/inc/galtheme.hrc |2 +- svx/inc/svx/gallery.hxx |1 + svx/source/gallery2/galtheme.src |8 4 files changed, 10 insertions(+), 1 deletion(-) New commits: commit 36557ab053c5bb28bf5203cabcb4d6cb2ae893b0 Author:

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - fe/e688fd96329f628f83623ea91c32e10eeb134b

2013-04-22 Thread Michael Meeks
fe/e688fd96329f628f83623ea91c32e10eeb134b |1 + 1 file changed, 1 insertion(+) New commits: commit 35b264363973bf1b5bef9d39239f791138a58248 Author: Michael Meeks michael.me...@suse.com Date: Mon Apr 22 10:23:55 2013 +0100 Notes added by 'git notes add' diff --git

[PUSHED] fdo#63749: #118845# corrected missing ressource for gallery ...

2013-04-22 Thread Michael Meeks (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3507 Approvals: Michael Meeks: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3507 To unsubscribe,

Re: new feature: how to document it?

2013-04-22 Thread Sophie Gautier
Hi Lionel, On 22/04/2013 11:20, Lionel Elie Mamane wrote: On Mon, Apr 22, 2013 at 11:11:46AM +0200, Lionel Elie Mamane wrote: Le 20/04/2013 23:34, Lionel Elie Mamane a écrit : One last question: where can I edit the help to document a new feature I'm introducing (namely, the option that the

[Libreoffice-commits] libvisio.git: Changes to 'refs/tags/libvisio-0.0.26'

2013-04-22 Thread Fridrich Štrba
Tag 'libvisio-0.0.26' created by Fridrich Å trba fridrich.st...@bluewin.ch at 2013-04-22 10:35 -0700 Tagging 0.0.26 release Changes since libvisio-0.0.25-14: --- 0 files changed --- ___ Libreoffice-commits mailing list

[Libreoffice-commits] core.git: sfx2/source

2013-04-22 Thread Noel Power
sfx2/source/doc/zoomitem.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit ad57664323e3ddf04ae99dba14ddaa22da2aacba Author: Noel Power noel.po...@suse.com Date: Mon Apr 22 10:29:02 2013 +0100 fdo#63659 sigh fix brain lapse, missing break Change-Id:

[PATCH libreoffice-4-0] fdo#63659 sigh fix brain lapse, missing break

2013-04-22 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3551 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/3551/1 fdo#63659 sigh fix brain lapse, missing break Change-Id: I02ab972cfad577423585d25587b925b5b1153506 (cherry

[Libreoffice-commits] core.git: extras/Package_gallsystem.mk

2013-04-22 Thread Michael Meeks
extras/Package_gallsystem.mk |3 --- 1 file changed, 3 deletions(-) New commits: commit 3bcd2d3787c5c6598656b34c00f04612bc99d8d2 Author: Michael Meeks michael.me...@suse.com Date: Mon Apr 22 10:40:51 2013 +0100 remove sg25 gallery packaging rules. diff --git

[Libreoffice-commits] core.git: touch/Library_libotouch.mk

2013-04-22 Thread Tor Lillqvist
touch/Library_libotouch.mk |5 - 1 file changed, 5 deletions(-) New commits: commit 0b3a76048a57f8a3e8c033d6f41dae5f83165c9b Author: Tor Lillqvist t...@iki.fi Date: Mon Apr 22 12:43:55 2013 +0300 Bin bogus include setting Change-Id:

Re: Build failure on master with OSX - datetime.hxx

2013-04-22 Thread Alexander Thurgood
Le 22/04/13 10:34, Lionel Elie Mamane a écrit : to see the state of that file in the central repository, and see if the failing line has been changed since you last pulled. Cheers, I must admit to not really understanding the details of how git works in practice (despite reading some of the

[Libreoffice-commits] core.git: 3 commits - autogen.sh boost/boost.6369.warnings.patch editeng/inc editeng/source

2013-04-22 Thread Caolán McNamara
autogen.sh |1 + boost/boost.6369.warnings.patch | 21 + editeng/inc/editeng/numitem.hxx |1 + editeng/source/items/numitem.cxx | 17 + 4 files changed, 40 insertions(+) New commits: commit

  1   2   3   4   5   >