Hi Michael, Regina,
(jumping in late, so trying to reply to all your concerns)
So - just one quick query; if you check:
vcl/unx/generic/app/soicon.cxx
you'll see that we calculate the resource id at run-time (this is a bit
of a gotcha):
[snipped]
Did you
Did you mean LGPLv3/MPL ?
Yes, that was a typo. Corrected line below:
All current and past contributions made to the LibreOffice project are
done under the LGPLv3 / MPL or later version of these licenses.
Until further notice, all future contributions to the LibreOffice
project are available
.
Thanks,
Julien Chaffraix
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
some physical images removed here are
lx03139.png
sx03139.png
oth_16_8.png
oth_32_8.png
oth_48_8.png
these images are associated with SV_ICON_ID_HTML_DOCUMENT which according to
opengrok ( assuming it is correct ) isn't used in code.
however there are still entries for these in
I think your change was a mistake: SV_ICON_ID_HTML_DOCUMENT is used
but never mentioned.
not sure what you mean by used but never mentioned where is it used ?
I tried removing SV_ICON_ID_HTML_DOCUMENT because I also did not see
it during my grepping. However I would get some errors during
Hi,
please find attached a patch to remove most of the unused functions in basic/.
The patch is contributed under the LGPLv3+ / MPL.
Thanks,
Julien
From 2e65408accabe86f9b2b47666fea43910e30f845 Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date: Sun, 13 Nov 2011 22
Very straightforward change attached.
The change is contributed under the LGPLv3+ / MPL.
Thanks,
Julien
From 9dd61fd109964d7db42e1509249c62420611d593 Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date: Wed, 9 Nov 2011 19:50:38 -0800
Subject: [PATCH 1/2] FDO#42453
Another simple change attached.
The change is contributed under the LGPLv3+ / MPL.
Thanks,
Julien
From a8d064a78058693d7d2bf5ceaabc779b8290242d Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date: Thu, 10 Nov 2011 07:23:29 -0800
Subject: [PATCH 2/2] Removed several
practise, and there is
a lot of dangerous duplication.
Sounds like a worthy goal, do you have some pointers to areas that
duplicate the code?
Thanks,
Julien
From 219182324770e28d12b7ee179af1c5c594ea6da1 Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date: Sat, 30 Apr
Hi,
following some of my previous changes, here are more change to the way
we use write(2) and read(2).
The changes are made available under LGPLv3+/MPL.
Thanks,
Julien
From 1020d181fdc5b326497ddbbac21457f16b4e7e55 Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date
7ce65499e18e68f83c2e45515ed37bd964847a74 Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date: Sat, 16 Apr 2011 17:42:15 -0700
Subject: [PATCH] Fixed write(2) usage in process.c.
Shared the code in a new function (safeWrite) that can handle partial write.
Fixed the 2 usages of write in the file
Applied - would you want to look into the TODO case as well? A rather
nasty cause for errors ...
While it is theoretically possible to hit this, I doubt in practice
that writing an int to a file descriptor will ever do a partial write.
It may just be better to change that to an OSL_ASSERT
Hi,
please find attached some changes to OSL. Those are bugs reported by CLang++.
The patches are contributed under the LGPLv3+ / MPL.
Thanks,
Julien
From 7a8e6017129480a6a353dd81764f9c7e572389e2 Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date: Mon, 11 Apr 2011
13 matches
Mail list logo
