Change in core[libreoffice-4-0]: docx export: fix regression on table borders export

2013-01-16 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: docx export: fix regression on table borders export .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/1705 To unsubscribe, visit

[PATCH] Change in core[libreoffice-4-0]: docx export: fix regression on table borders export

2013-01-15 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1705 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1705/1 docx export: fix regression on table borders export The removed code was supposed to allow LO to write cell

[PATCH] Change in core[libreoffice-4-0]: docx export: add missing arg to impl_pageBorders call

2013-01-14 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1672 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/1672/1 docx export: add missing arg to impl_pageBorders call The missing argument could cause data loss due to

sal: add timeout option when using pipe in connect mode

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: sal: add timeout option when using pipe in connect mode .. Patch Set 1: Abandoned Not needed anymore. -- To view, visit

[PATCH] sw unit test: add call to CalcLayout before using the layout

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1645 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/1645/1 sw unit test: add call to CalcLayout before using the layout Change-Id:

[PATCH] doc export: add unit test for bug i106749

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1646 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/1646/1 doc export: add unit test for bug i106749 Change-Id: I1df4cbb013d94cff7ae5195427044b1e1b2d8895 --- A

[PATCH] docx export: invalid sectPr added at the beginning of the do...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1647 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/1647/1 docx export: invalid sectPr added at the beginning of the doc This reverts commit

[PATCH] sw unit test: layout dump must be resetted in 'reload' metho...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1643 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/1643/1 sw unit test: layout dump must be resetted in 'reload' method Otherwise tests relying on layout dumps will

[PATCH] docx export: add test case for paragraph mark export

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1650 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/1650/1 docx export: add test case for paragraph mark export Change-Id: I2701ee12221460f8ff19397ea215cc1484648d18 --- A

[PATCH] doc export: add unit test for fdo#56513

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1644 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/1644/1 doc export: add unit test for fdo#56513 Change-Id: Ie87648368f877af56878bc83fe3d5ece66f77304 --- A

[PATCH] docx export: also export rPr in pPr (paragraph mark stylin...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1649 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/1649/1 docx export: also export rPr in pPr (paragraph mark styling) Change-Id:

[PATCH] sax: add methods to duplicate current top marker and reapply...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1648 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/1648/1 sax: add methods to duplicate current top marker and reapply it later The need for this is ooxml: we need to

[PATCH] docx import: don't apply complex font size to non-complex fo...

2012-12-20 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1454 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/1454/1 docx import: don't apply complex font size to non-complex font OOXML spec says: [szCs] specifies the font size

[PATCH] docx import: table styles and rPr/pPr tags

2012-12-20 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1455 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/1455/1 docx import: table styles and rPr/pPr tags When importing a style with type=table, apply rPr/pPr tags content

[PATCH] docx export: graphics relativeFrom attributes now matches im...

2012-12-14 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1342 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/1342/1 docx export: graphics relativeFrom attributes now matches import code Change-Id:

[PATCH] office ipc: use timeout pipe feature when connecting to self

2012-12-12 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1311 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/1311/1 office ipc: use timeout pipe feature when connecting to self Prevent deadlock situation that may occur with

[PATCH] sal: add timeout option when using pipe in connect mode

2012-12-12 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1310 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/1310/1 sal: add timeout option when using pipe in connect mode Change-Id: I94b9edccf194e971f375853459d73c37bdb4c6a3

[PATCH] startup: allow multiple tries to connect to other soffice in...

2012-11-16 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1089 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/1089/1 startup: allow multiple tries to connect to other soffice instance On startup if new soffice instance (S2)

docx export: if table has no width use w:tblW 'auto' type

2012-11-02 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: docx export: if table has no width use w:tblW 'auto' type .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/657 To unsubscribe,

[PATCH] docx import: handle start/end attribute in tcBorders

2012-10-25 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/908 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/908/1 docx import: handle start/end attribute in tcBorders Change-Id: I148345485534ae50b616857d971ef1c8b1594f28 --- M

[PATCH] docx export: explicitely use 'none' type for disabled cell b...

2012-10-25 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/909 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/909/1 docx export: explicitely use 'none' type for disabled cell borders Otherwise, the table default borders will be

[PATCH] docx export: unit test table/cell borders export

2012-10-25 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/910 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/910/1 docx export: unit test table/cell borders export Change-Id: Ibd651c0d027dcf8b63b9208ffdcbcfaee3165b38 --- A

[PATCH] vml import: only apply width-percent attribute if it's != 0

2012-10-05 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/775 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/775/1 vml import: only apply width-percent attribute if it's != 0 This fixes an issue with a shape defined with these

[PATCH] Improve vml path parsing to handle repeated commands

2012-10-05 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/774 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/774/1 Improve vml path parsing to handle repeated commands Previously commands were executed only when the parser found

[PATCH] docx export: add unit test for 7a2be96

2012-09-28 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/717 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/717/1 docx export: add unit test for 7a2be96 Change-Id: I25aa07d3e1811fdf4ab0124e14794e70d7de82ec --- M

[PATCH] docx import: add table position unit test

2012-09-28 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/715 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/715/1 docx import: add table position unit test Change-Id: I21aa721e20be4b7f9984bf6910a94a7b7bf09c7a --- A

[PATCH] docx import: properly import table position

2012-09-28 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/714 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/714/1 docx import: properly import table position This a follow up of commit 53b7f7df0617bcbd7bbef9a34ef53e5097eb16dc

[PATCH] docx export: export default table cell margins, based on 1st...

2012-09-28 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/716 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/716/1 docx export: export default table cell margins, based on 1st cell Change-Id:

docx export: export default table cell margins and borders

2012-09-28 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: docx export: export default table cell margins and borders .. Patch Set 2: Abandoned Replaced by new patchset #713 - #718 -- To view, visit

[PATCH] docx export: always write tblInd attribute (even when equal ...

2012-09-28 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/718 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/718/1 docx export: always write tblInd attribute (even when equal to 0) Otherwise when opening the docx in Office table

[PATCH] docx import: set table above/bottom spacing to 0

2012-09-28 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/713 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/713/1 docx import: set table above/bottom spacing to 0 Change-Id: I3e0397dd3d5d14f1e584ac7bc3d22d4638393b06 --- A

[PATCH] docx import: position table using tblInd OR tblCellMar

2012-09-20 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/655 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/655/1 docx import: position table using tblInd OR tblCellMar Previously cell-margin was unconditionnaly used to compute

[PATCH] docx export: if table has no width use w:tblW 'auto' type

2012-09-20 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/657 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/657/1 docx export: if table has no width use w:tblW 'auto' type Change-Id: I085febf04205181e7c4488bc948f346f92070fe2

[PATCH] solaris/unobridge: prevent inlining of callVirtualMethod fun...

2012-09-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/595 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/595/1 solaris/unobridge: prevent inlining of callVirtualMethod function If this function get inlined, exception

solaris/unobridge: prevent inlining of callVirtualMethod fun...

2012-09-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: solaris/unobridge: prevent inlining of callVirtualMethod function .. Patch Set 1: Abandoned My bad ; I submitted an incorrect version of the patch. Also as