Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-04-20 Thread Noel Power
On 19/04/11 22:09, Caolán McNamara wrote: You*did* run the smoketest didn't you. I'm sure you did. you *are* joking right? such confidence in me doing the right thing is completely misplaced, I am ashamed I didn't run it :-( I did some touch testing with basic but I have to admit running

Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-04-20 Thread Bjoern Michaelsen
On Wed, 20 Apr 2011 09:22:46 +0100 Noel Power nopo...@novell.com wrote: On 19/04/11 22:09, Caolán McNamara wrote: You*did* run the smoketest didn't you. I'm sure you did. you *are* joking right? such confidence in me doing the right thing is completely misplaced, I am ashamed I didn't

Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-04-19 Thread Noel Power
On Tue, 2011-03-22 at 17:22 +, Caolán McNamara wrote: On Tue, 2011-03-22 at 16:39 +, Caolán McNamara wrote: among others Yeah, the catch is that there's a hierarchy of virtual methods in there, we can't change *some* of the signatures on impls of a specific virtual method we need

Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-04-19 Thread Caolán McNamara
On Tue, 2011-04-19 at 20:31 +0100, Noel Power wrote: sigh I am sorry it seems I am reverting your revert ( I didn't see your mail at all, only saw it now from searching the archives because I didn't see my own mail due some mail client problems :-( ) I committed this today ( hopefully with the

Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-03-22 Thread David Tardon
On Tue, Mar 15, 2011 at 01:10:58PM +0100, Xisco Faulí wrote: Hello, It's the first time I do it so I searched for previous commits in order to get a referent. i couldn't find any example for String.AssignAscii so I replace it with OUStringBuffer.appendAscii. Yeah, that is good. I only

Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-03-22 Thread Caolán McNamara
On Tue, 2011-03-22 at 08:11 +0100, David Tardon wrote: On Tue, Mar 15, 2011 at 01:10:58PM +0100, Xisco Faulí wrote: Hello, It's the first time I do it so I searched for previous commits in order to get a referent. i couldn't find any example for String.AssignAscii so I replace it

Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-03-22 Thread Caolán McNamara
On Tue, 2011-03-22 at 16:39 +, Caolán McNamara wrote: among others Yeah, the catch is that there's a hierarchy of virtual methods in there, we can't change *some* of the signatures on impls of a specific virtual method we need to change all or none. I'll have to revert this for a bit because