Re: [Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-17 Thread Cedric Bosdonnat
Hi Michael, On Wed, 2011-11-16 at 16:20 +0100, Michael Stahl wrote: now i remember: this bug is exactly the one i fixed in OOo in CWS sw34bf04 (issue i102333). the fix is not merged in libreoffice-3-4, but is in master (230fcf4a456636bb466f72834cd57238621d206d), but LO master still crashes

Re: [Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-16 Thread Tomofumi Yagi
Hi Cedric, Thanks a lot for your reviewing. I am very happy to hear the opinions of the expert. (11/11/15 18:30), Cedric Bosdonnat wrote: * The if should be like the following or we still have the crash when the last line is removed. if( pSavePos pSavePos-nNode uNodeCount ) I was

Re: [Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-16 Thread Michael Stahl
On 12/11/11 08:27, Tomofumi Yagi wrote: Hi All, This patch will fix fdo#40831 Writer will crash when searching text with using regular expressions. Please review my attached patch. Bug URL: https://bugs.freedesktop.org/show_bug.cgi?id=40831 I reproduced this bug on LibO 3.4 and 3.5.

Re: [Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-15 Thread Cedric Bosdonnat
Hello, On Sat, 2011-11-12 at 16:27 +0900, Tomofumi Yagi wrote: This patch will fix fdo#40831 Writer will crash when searching text with using regular expressions. Please review my attached patch. Bug URL: https://bugs.freedesktop.org/show_bug.cgi?id=40831 I reproduced this bug on LibO

[Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-11 Thread Tomofumi Yagi
Hi All, This patch will fix fdo#40831 Writer will crash when searching text with using regular expressions. Please review my attached patch. Bug URL: https://bugs.freedesktop.org/show_bug.cgi?id=40831 I reproduced this bug on LibO 3.4 and 3.5. This bug occurs when a row or column containing