Re: [Libreoffice] [PUSHED] [PATCH] Part of FDO #42454 - Remove code associated with unused icons

2011-11-15 Thread Noel Power
On 14/11/11 15:53, Julien Chaffraix wrote: Hi everyone, please find attached the removal of some of the unused icons. Make sure you double-check that I did not miss some usage when grepping and testing! The PNG and code removals are squashed in this change, let me know if you would like them

Re: [Libreoffice] [PUSHED] [PATCH] Part of FDO #42454 - Remove code associated with unused icons

2011-11-15 Thread Julien Chaffraix
some physical images removed here are lx03139.png sx03139.png oth_16_8.png oth_32_8.png oth_48_8.png these images are associated with SV_ICON_ID_HTML_DOCUMENT which according to opengrok ( assuming it is correct ) isn't used in code. however there are still entries for these in

Re: [Libreoffice] [PUSHED] [PATCH] Part of FDO #42454 - Remove code associated with unused icons

2011-11-15 Thread Noel Power
On 15/11/11 15:16, Julien Chaffraix wrote: some physical images removed here are lx03139.png sx03139.png oth_16_8.png oth_32_8.png oth_48_8.png these images are associated with SV_ICON_ID_HTML_DOCUMENT which according to opengrok ( assuming it is correct ) isn't used in code. however there are

Re: [Libreoffice] [PUSHED] [PATCH] Part of FDO #42454 - Remove code associated with unused icons

2011-11-15 Thread Julien Chaffraix
I think your change was a mistake: SV_ICON_ID_HTML_DOCUMENT is used but never mentioned. not sure what you mean by used but never mentioned where is it used ? I tried removing SV_ICON_ID_HTML_DOCUMENT because I also did not see it during my grepping. However I would get some errors during

Re: [Libreoffice] [PUSHED] [PATCH] Part of FDO #42454 - Remove code associated with unused icons

2011-11-15 Thread Noel Power
On 15/11/11 16:55, Julien Chaffraix wrote: [...] I tried removing SV_ICON_ID_HTML_DOCUMENT because I also did not see it during my grepping. However I would get some errors during make dev-install about the missing icons (I don't have the error with me sorry). I think this was some side-affect