Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments

2011-03-01 Thread Thomas Arnhold
Hi Antoine, pushed this, thanks! Probably your name isn't set in the gitconfig, only your mail address was given as author. You could set this with: git config --global user.name Your Name Thomas On 02/28/2011 12:06 AM, Antoine Proulx wrote: Hi, Here's a patch who removes bogus comments.

Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments

2011-02-14 Thread Thorsten Behrens
Thomas Arnhold wrote: Didn't know that there are bug numbers like this #b449874#. Those are from the old Sun-internal bugtracker (in contrast to the old StarDivision-internal bugtracker, which is w/o letter prefix) - and can be elided as well. Pushed a change that does that. Cheers, --

Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments

2011-02-14 Thread Thomas Arnhold
Thanks! On 02/14/2011 02:01 PM, Thorsten Behrens wrote: Thomas Arnhold wrote: Didn't know that there are bug numbers like this #b449874#. Those are from the old Sun-internal bugtracker (in contrast to the old StarDivision-internal bugtracker, which is w/o letter prefix) - and can be elided

Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments in components and impress

2011-02-13 Thread Thomas Arnhold
Thanks for all of them! I pushed them all. I deleted one additional line in cui/source/tabpages/numfmt.cxx: //@ aEdFormat.SetText( aLbFormat.GetSelectEntry() ); as this also belong to a deleted comment. Thomas On 02/13/2011 02:08 PM, Guillaume Poussel wrote: Second part.

Re: [Libreoffice] [PUSHED] [Patch] Remove bogus comments and dead code from editeng

2011-02-13 Thread Thomas Arnhold
Hi, nice, thanks for this! I pushed it. As far as I know there is no need to reformat the code, because this should be done by a script some time later (and we want to be compatible to diffs from OOo). Thomas On 02/13/2011 03:29 PM, Arnaud Versini wrote: Hi, Remove some comments from

Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments

2011-02-13 Thread Thomas Arnhold
Looks good. Thanks! I pushed it. Didn't know that there are bug numbers like this #b449874#. Thomas On 02/13/2011 01:57 AM, Antoine Proulx wrote: Hi, Here's a patch (another one) who removes bogus comments. It's released under the LGPLv3+ / MPL. Antoine

Re: [Libreoffice] [PUSHED] [Patch] Remove bogus comments and dead code from editeng

2011-02-13 Thread Arnaud Versini
Hi, Next part, no reformating this time. thanks 2011/2/13 Thomas Arnhold tho...@arnhold.org Hi, nice, thanks for this! I pushed it. As far as I know there is no need to reformat the code, because this should be done by a script some time later (and we want to be compatible to diffs from