Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-25 Thread Jan Holesovsky
Hi Wol, On 2010-11-23 at 20:49 +, Wols Lists wrote: String aFoo = String::createFromAscii( Something ) should be replaced, with String aFoo( RTL_CONSTASCII_USTRINGPARAM( Something ) ) Fine. Fixes in base will appear as I spot them :-) Just one important little point - the

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-23 Thread Jan Holesovsky
Hi Wol, Kevin, all, On 2010-11-21 at 23:48 -0500, Kevin Hunter wrote: Forgive what might be a stupid question, but I've seen String::createFromAscii Will version 2 find those, and should they be replaced? Not a stupid question at all. Regular expressions aren't the most

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-23 Thread Wols Lists
On 23/11/10 19:00, Jan Holesovsky wrote: Hi Wol, Kevin, all, On 2010-11-21 at 23:48 -0500, Kevin Hunter wrote: Forgive what might be a stupid question, but I've seen String::createFromAscii Will version 2 find those, and should they be replaced? Not a stupid question at all. Regular

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-21 Thread Wols Lists
On 18/11/10 13:36, Kevin Hunter wrote: As I assume you're using a regex, you might consider catching this by doing the search and replace in series. Here's an example: 1. Catch the 'OUString +?= ...createFromAscii...' case and replace with 'OUString var( RTL...)' search:

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-21 Thread Kevin Hunter
At 4:58pm -0500 Sun, 21 Nov 2010, Wols Lists wrote: On 18/11/10 13:36, Kevin Hunter wrote: As I assume you're using a regex, you might consider catching this by doing the search and replace in series. Here's an example: 1. Catch the 'OUString +?= ...createFromAscii...' case and replace with

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-18 Thread Kevin Hunter
As I assume you're using a regex, you might consider catching this by doing the search and replace in series. Here's an example: 1. Catch the 'OUString +?= ...createFromAscii...' case and replace with 'OUString var( RTL...)' search: OUString\s*\w+\s*\+?=\s*\S*createFromAscii\(\s*([^]*)\s*\)