Re: [Libreoffice] [Patch] Unreachable code ?

2011-11-18 Thread Muthu Subramanian K
That code is inside the constructor. and the constructor sets the variable pUndoSet to NULL right on the top. So, the if would always fail! Unless I am missing something. Looks too trivial to be true ;) On 11/17/2011 09:48 PM, Michael Meeks wrote: Hi Muthu, On Wed, 2011-11-16 at 17:34 +0530,

Re: [Libreoffice] [Patch] Unreachable code ?

2011-11-18 Thread Ivan Timofeev
Hi Muthu, 18.11.2011 15:38, Muthu Subramanian K пишет: That code is inside the constructor. and the constructor sets the variable pUndoSet to NULL right on the top. So, the if would always fail! Unless I am missing something. Looks too trivial to be true ;) I don't see any way to assign

Re: [Libreoffice] [Patch] Unreachable code ?

2011-11-18 Thread Terrence Enger
On Fri, 2011-11-18 at 15:49 +0400, Ivan Timofeev wrote: Hi Muthu, 18.11.2011 15:38, Muthu Subramanian K пишет: That code is inside the constructor. and the constructor sets the variable pUndoSet to NULL right on the top. So, the if would always fail! Unless I am missing something. Looks

Re: [Libreoffice] [Patch] Unreachable code ?

2011-11-17 Thread Michael Meeks
Hi Muthu, On Wed, 2011-11-16 at 17:34 +0530, Muthu Subramanian K wrote: I have attached a trivial code removal with this mail. I read the code, (since pUndoSet is set to null in the very constructor, I guess this if() would never get executed), but, I could have missed something here - hence

Re: [Libreoffice] [Patch] Unreachable code ?

2011-11-17 Thread Michael Stahl
On 17/11/11 17:18, Michael Meeks wrote: Hi Muthu, On Wed, 2011-11-16 at 17:34 +0530, Muthu Subramanian K wrote: I have attached a trivial code removal with this mail. I read the code, (since pUndoSet is set to null in the very constructor, I guess this if() would never get executed), but, I

[Libreoffice] [Patch] Unreachable code ?

2011-11-16 Thread Muthu Subramanian K
Hi, I have attached a trivial code removal with this mail. I read the code, (since pUndoSet is set to null in the very constructor, I guess this if() would never get executed), but, I could have missed something here - hence the need for review. Thank you so much! Muthu Subramanian diff --git