Re: [Libreoffice] [REVIEW] bug#36874 to be patched in 3.4.5 as well?

2011-12-23 Thread Winfried Donkers
Your code looks definitely better than the original one. Well, I am still not sure about the calculation. It makes perfect sense when I imagine the paper with blank labels. On the other hand, please look at http://download.go-oo.org/tmp/labels.png. I looked at a lot of (blank) labels and also

[Libreoffice] [REVIEW] bug#36874 to be patched in 3.4.5 as well?

2011-12-19 Thread Winfried Donkers
Is it an option to push it to 3.4.5 as well? In case you haven't known this yet: if you want to do this, you have to send a mail to this dev list with a subject like [REVIEW] $subject and pointing to your commit. Then wait for someone to review. This probably is still not the correct way to