Re: [Libreoffice] [REVIEW-3-4-5] bug#36874 to be patched in 3.4.5 as well?

2012-01-03 Thread Tommy
On Tue, 03 Jan 2012 04:38:05 +0100, Korrawit Pruegsanusak detective.conan.1...@gmail.com wrote: Just a reminder. As you are the third reviewer, could you please cherry-pick it to 3-4-5? Thanks! Best Regards, a last minute 3.4.5 cherry-pick would be a bless!!!

Re: [Libreoffice] [REVIEW-3-4-5] bug#36874 to be patched in 3.4.5 as well?

2012-01-03 Thread Petr Mladek
Korrawit Pruegsanusak píše v Út 03. 01. 2012 v 10:38 +0700: I see the point and agree with your assumption. Your patch makes sense and I have pushed it to the 3-4 branch, see http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id =502ef71db74c3cdb1433c3402a0d93971dc47f1b

Re: [Libreoffice] [REVIEW-3-4-5] bug#36874 to be patched in 3.4.5 as well?

2012-01-02 Thread Petr Mladek
Winfried Donkers píše v Pá 23. 12. 2011 v 17:04 +0100: Your code looks definitely better than the original one. Well, I am still not sure about the calculation. It makes perfect sense when I imagine the paper with blank labels. On the other hand, please look at

Re: [Libreoffice] [REVIEW-3-4-5] bug#36874 to be patched in 3.4.5 as well?

2012-01-02 Thread Bjoern Michaelsen
On Mon, Jan 02, 2012 at 02:46:11PM +0100, Petr Mladek wrote: Bjoern pushed your patch to master. I wonder if he could vote here ;-) Looking good to me for 3.4.5. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [REVIEW-3-4-5] bug#36874 to be patched in 3.4.5 as well?

2012-01-02 Thread Lubos Lunak
On Monday 02 of January 2012, Petr Mladek wrote: Winfried Donkers píše v Pá 23. 12. 2011 v 17:04 +0100: Your code looks definitely better than the original one. Well, I am still not sure about the calculation. It makes perfect sense when I imagine the paper with blank labels. On the other