Hi Janit,
On Wednesday, 2013-04-10 00:42:49 +0530, Janit Anjaria wrote:
I am hereby attaching my bug after making all the needed changes :
I fail to see where this patch actually changes code (except two cases)
and not just spacing or ordering of variables. If it was meant as an
additional
Hey!
I am hereby attaching my bug after making all the needed changes :
*I have removed all the unnecessary changes i had made to the code,i.e. i
did undo all the useless changes i had made to the code,thereby cleaning up
the code.
*removed the command that gave the output :
debug: max width 78
Hey!
I am hereby submitting my patch for review on the bug/feature which i had
worked long back which solves the problem where the comboboxes now do
appear when the toolbar is vertical.
Regards,
Janit
0001-fdo-55846-Comboboxes-weren-t-displayed-when-the-tool.patch
Description: Binary data
Hi Janit,
first: I am not a developer, so don't expect code pointers here, but I
tried your patch out of interest.
While it does build, your patch doesn't seem to work well:
* my LibreOffice window now shows no toolbar icons whatsoever
* I get lots of messages à la
debug: max width
Janit Anjaria wrote:
I am hereby submitting my patch for review on the bug/feature which i had
worked long back which solves the problem where the comboboxes now do
appear when the toolbar is vertical.
Hi Janit,
the patch contains a lot of changes ala
if ( eAlign == WINDOWALIGN_TOP )
Hey Thorsten,Stefan ,
I just saw the patch,yes it definitely need clean up based on the white
spaces ,and yeah the numbers in the patch are added so that the UI fixes
right and hence the toolbar appears to be right.I am not sure about the
reason why the icons dont appear in your case,as it does