Re: Font family case-sensitiveness

2013-05-23 Thread Thomas Arnhold
Thanks, Stephan. Here are some more, now compared case-insensitive: https://gerrit.libreoffice.org/#/c/4015/ Thomas On 22.05.2013 11:09, Stephan Bergmann wrote: On 05/20/2013 03:35 PM, Caolán McNamara wrote: On Sun, 2013-05-19 at 18:24 +0200, Thomas Arnhold wrote: And maybe there is more

Re: Font family case-sensitiveness

2013-05-22 Thread Stephan Bergmann
On 05/20/2013 03:35 PM, Caolán McNamara wrote: On Sun, 2013-05-19 at 18:24 +0200, Thomas Arnhold wrote: And maybe there is more work with GetFamilyName()..., see 79e5615fa103a52ce41ed682b624c13fd9a9d1eb. Well, its kind of weird to have a test to see if the names are the same, before going on

Re: Font family case-sensitiveness

2013-05-20 Thread Caolán McNamara
On Sun, 2013-05-19 at 18:24 +0200, Thomas Arnhold wrote: Hi, A quick grep on the source reveals that there case-sensitive and case-insensitive comparisons for the font family name. This looks pretty suspicious. git grep -i \starsymbol\ -- *.cxx Should we always check case-insensitive

Font family case-sensitiveness

2013-05-19 Thread Thomas Arnhold
Hi, A quick grep on the source reveals that there case-sensitive and case-insensitive comparisons for the font family name. This looks pretty suspicious. git grep -i \starsymbol\ -- *.cxx Should we always check case-insensitive or convert all lower-case ones to StarSymbol (most/all?