Re: LibreOffice Development [ Comments in .pptx ] (Annotations Issue)

2013-02-19 Thread Thorsten Behrens
Vinaya Mandke wrote: I followed the PPT (ImportComment10) flow and was able to display the comments!!! Hi Vinaya, just checking in - how's it going, any patch you would be comfortable submitting to gerrit already? ;) (https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch)

Re: LibreOffice Development [ Comments in .pptx ] (Annotations Issue)

2013-02-19 Thread Thorsten Behrens
I write: just checking in - how's it going, any patch you would be comfortable submitting to gerrit already? ;) My apologies - seeing https://gerrit.libreoffice.org/#/c/2048/ now. :/ -- Thorsten signature.asc Description: Digital signature ___

Re: LibreOffice Development [ Comments in .pptx ] (Annotations Issue)

2013-02-01 Thread Vinaya Mandke
Hi, I have now improved on the representation and am storing the fields in CommentList vector inside SlidePersist. Again I have found out a few more things... - CreateXShapes (presentationfragmenthandler) calls - CreateAndInsert() // pptshape which further calls createAndInsert() //

Re: LibreOffice Development [ Comments in .pptx ] (Annotations Issue)

2013-01-28 Thread Vinaya Mandke
Hi, PFA the diff file... I know that its incomplete and should have a separate handler, but as of now I can atleast save the comment data... This is what I have done - I have handled comments exactly as notes - In slidefragmenthandler added tokens to handle the comment attributes -

Re: LibreOffice Development [ Comments in .pptx ] (Annotations Issue)

2013-01-25 Thread Thorsten Behrens
Vinaya Mandke wrote: Now I can collect (parse) and save all the comment info on a particular slide. As of now I am saving it in std::strings. Any chance to upload a work-in-progress version of that to gerrit? Code talks better than emails. ;) How are annotations actually displayed on the

Re: LibreOffice Development [ Comments in .pptx ] (Annotations Issue)

2013-01-24 Thread Vinaya Mandke
Hi, Now I can collect (parse) and save all the comment info on a particular slide. As of now I am saving it in std::strings. How are annotations actually displayed on the slide ? Which paint function is called ? On Thu, Jan 24, 2013 at 1:46 AM, Thorsten Behrens t...@documentfoundation.org

Re: LibreOffice Development [ Comments in .pptx ] (Annotations Issue)

2013-01-23 Thread Thorsten Behrens
Vinaya Mandke wrote: I am a trainee and have been assigned a project to debug and correct one bug of LiBo. Hi Vinaya, this is cool - great to have you looking into that! As of now I have identified this much:- - Comments folder with comment1.xml , CommentAuthors are getting created