Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal

2010-10-15 Thread David Tardon
On Thu, Oct 14, 2010 at 09:11:26AM +0100, Caolán McNamara wrote: On Wed, 2010-10-13 at 22:34 +0200, Jacek Wolszczak wrote: http://wiki.services.openoffice.org/wiki/Debug_Levels. Some additional questions. What should I replace DBG_ERROR with? Hmm, DBG_ERROR takes no condition, and just

Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal

2010-10-13 Thread Cédric Bosdonnat
Hi Jacek, I removed a hunk that wasn't valid, but otherwise, the patch looks good to me. I've pushed it. Many thanks for your help! -- Cedric On Wed, 2010-10-13 at 22:34 +0200, Jacek Wolszczak wrote: Hi, As in the topic. I replaced some assert items with OSL equivalents. I also replaced