Re: git-hook: Catch tab indentation also for makefiles

Hi, On Mon, Sep 04, 2017 at 02:30:06PM +0100, Tamas Zolnai wrote: > I just noticed that for makefiles (*.mk) git does not check whether the > commit contains tab indentation. As I know we use spaces also for makefiles > for indentation, right? So I added a patch changing pre-commit hook to check

Re: git-hook: Catch tab indentation also for makefiles

2017-09-04 17:13 GMT+02:00 jani libreoffice : > > I think temporary GNU make still needs recipe lines to start with tab >> characters? And in any case, our makefiles are apparently written with >> lots of tab characters all over the place. I'd suggest to revert (at least

Re: git-hook: Catch tab indentation also for makefiles

>> I think temporary GNU make still needs recipe lines to start with tab >> characters? And in any case, our makefiles are apparently written with lots >> of tab characters all over the place. I'd suggest to revert (at least for >> now). > > Yeah, I see that tabs and spaces are mixed in

Re: git-hook: Catch tab indentation also for makefiles

2017-09-04 15:43 GMT+02:00 Stephan Bergmann : > On 09/04/2017 03:30 PM, Tamas Zolnai wrote: > >> I just noticed that for makefiles (*.mk) git does not check whether the >> commit contains tab indentation. As I know we use spaces also for makefiles >> for indentation, right?

Re: git-hook: Catch tab indentation also for makefiles

On 09/04/2017 03:30 PM, Tamas Zolnai wrote: I just noticed that for makefiles (*.mk) git does not check whether the commit contains tab indentation. As I know we use spaces also for makefiles for indentation, right? So I added a patch changing pre-commit hook to check tab also for makfiles:

git-hook: Catch tab indentation also for makefiles

Hi there, I just noticed that for makefiles (*.mk) git does not check whether the commit contains tab indentation. As I know we use spaces also for makefiles for indentation, right? So I added a patch changing pre-commit hook to check tab also for makfiles: