Re: stack-allocated Window subclasses

2014-09-24 Thread Chris Sherlock
Oh, I just saw this email. I recently posted a gerrit change for review around FontCharMap, you can find it here: https://gerrit.libreoffice.org/#/c/11565/ I've never looked at what Reference actually does, but now that I do it seems that it relies on a class that exposes an acquire() and

Re: stack-allocated Window subclasses

2014-09-24 Thread Lubos Lunak
On Tuesday 23 of September 2014, Michael Meeks wrote: The question is; what should we replace it with. Personally I'm more of a fan of intrusive reference counting for VCL - we don't want lots of atomics, so that the optimizer can rid us of size inefficiency - and at least for now we

stack-allocated Window subclasses

2014-09-23 Thread Noel Grandin
Hi I ran my clang plugin over master last night. This is the output. There is lots of duplication in the warnings, so running: $ grep not heap allocated stack-alloc.txt | sort -u | wc -l gives 569 fields that need to be changed. so there is a fair amount of work involved :-) But looking

Re: stack-allocated Window subclasses

2014-09-23 Thread Michael Meeks
Hi Noel, On Tue, 2014-09-23 at 10:01 +0200, Noel Grandin wrote: I ran my clang plugin over master last night. This is the output. Awesome - I've up-loaded a log here: http://users.freedesktop.org/~michael/non-heap-windows.txt so there is a fair amount of work involved :-)

Re: stack-allocated Window subclasses

2014-09-23 Thread Noel Grandin
On 2014-09-23 02:40 PM, Michael Meeks wrote: The question is; what should we replace it with. Personally I'm more of a fan of intrusive reference counting for VCL - we don't want lots of atomics, so that the optimizer can rid us of size inefficiency - and at least for now we can't ref-count

Re: stack-allocated Window subclasses

2014-09-23 Thread Michael Meeks
Hi Noel, On Tue, 2014-09-23 at 14:52 +0200, Noel Grandin wrote: Otherwise we should just standardise on boost::intrusive_ptr and remove SvRef. Yep - my concern is only that boost::intrusive_ptr Window - is some horribly long horror =) and that having some semi-standard means of having