[Libreoffice-commits] core.git: sc/qa

2013-03-20 Thread Tor Lillqvist
sc/qa/unit/ucalc.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit e7419364c4ef7986657974382076a52094aeb7dc Author: Tor Lillqvist t...@iki.fi Date: Wed Mar 20 08:20:35 2013 +0200 'size_t' is not the same as 'unsigned long' So using %lu to

[Libreoffice-commits] core.git: configure.ac

2013-03-20 Thread Christian Lohmaier
configure.ac |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit f44f1719efafd811bb604f7fcc3534d5ec344ad0 Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com Date: Tue Mar 19 17:39:58 2013 +0100 lowering baseline for python used during building

[PUSHED] lowering baseline for python used during building

2013-03-20 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2862 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2862 To unsubscribe,

[PUSHED] fix fdo#62050 : Initially disable RTL for comment window.

2013-03-20 Thread Ahmad Harthi (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2831 Approvals: Ahmad Harthi: Verified; Looks good to me, approved abdulmajeed ahmed: Looks good to me, but someone else must approve -- To

[Libreoffice-commits] core.git: sc/inc

2013-03-20 Thread Tor Lillqvist
sc/inc/column.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 76f03b163fa2134fbeaf655d67effc3265964665 Author: Tor Lillqvist t...@iki.fi Date: Wed Mar 20 09:42:13 2013 +0200 WaE: class 'ScFormulaCellGroup' was previously declared as a struct

[PUSHED] coverity#735389 Copy-paste error

2013-03-20 Thread Thorsten Behrens (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2858 Approvals: Thorsten Behrens: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2858 To unsubscribe,

[Libreoffice-commits] core.git: sw/source

2013-03-20 Thread Julien Nabet
sw/source/filter/html/css1atr.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 22ae2982bd95d36cc242f8b9eda6eec0c5a3a10c Author: Julien Nabet serval2...@yahoo.fr Date: Tue Mar 19 23:55:29 2013 +0100 coverity#735389 Copy-paste error Change-Id:

[Libreoffice-commits] core.git: sw/JunitTest_sw_complex.mk sw/qa

2013-03-20 Thread David Ostrovsky
sw/JunitTest_sw_complex.mk |2 sw/qa/complex/writer/VarFields.java | 183 2 files changed, 185 insertions(+) New commits: commit 1bf65d1d57856491431fdb4b90f5a228ee592da1 Author: David Ostrovsky da...@ostrovsky.org Date: Wed Mar 20 10:26:36

[ABANDONED] coverity#735383 Copy-paste error

2013-03-20 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#735383 Copy-paste error .. Patch Set 1: Abandoned I was not sure at all for this one. You confirmed my doubts so I can abandon this patch and set false positive

Re: Pivot Table data provider extension framework (removal possibility)

2013-03-20 Thread Eike Rathke
Hi Kohei, On Thursday, 2013-03-14 09:26:55 -0400, Kohei Yoshida wrote: I believe the same functionality can be achieve via database connectivity, by having such external data provider register as a database, and use it to act as a data provider for pivot tables. So, I don't see a reason

[Libreoffice-commits] core.git: RepositoryExternal.mk

2013-03-20 Thread Christian Lohmaier
RepositoryExternal.mk | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) New commits: commit 04032bd6062638f6945e3911a491fa311404c507 Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com Date: Tue Mar 19 17:27:01 2013 +0100 allow to use internal

[PATCH] simplify OUString assignments

2013-03-20 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2863 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/2863/1 simplify OUString assignments Change-Id: Ieffd80aa84c9a041785bb81b3a904a32d00cb2bb --- M

[PATCH] Replace String with OUString (unotools)

2013-03-20 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2864 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/2864/1 Replace String with OUString (unotools) Change-Id: I9a0677cb36805d0a27514824c937901f73fee1c8 --- M

[PUSHED] allow to use internal python for build-stuff on Mac

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2849 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2849 To unsubscribe, visit

[PATCH] fdo#39468 German comments in vcl/unx/generic/...

2013-03-20 Thread Christian M. Heller (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2865 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/2865/1 fdo#39468 German comments in vcl/unx/generic/... Change-Id: I869f5ac346b378ee63832e01ce099f366b7c184f --- M

[Libreoffice-commits] dev-tools.git: ccache-msvc/bin ccache-msvc/patches ccache-msvc/README.txt

2013-03-20 Thread Peter Foley
ccache-msvc/README.txt | 24 ccache-msvc/bin/ccache.exe |binary ccache-msvc/patches/0001-MSVC-Add-MSVC-under-Cygwin-support.patch | 726 --

Re: return value of GetTextBreak()

2013-03-20 Thread Eike Rathke
Hi Christina, On Tuesday, 2013-03-19 15:31:55 +0100, Christina Roßmanith wrote: GetTextBreak() returns STRING_LENGTH if text breaking isn't necessary (if I get it right). indexOf() returns -1 if searching failed. Would that be a choice for GetTextBreak() as well? Sounds sensible. What

[PUSHED] update ccache for MSVC from 2.4 to 3.1.8

2013-03-20 Thread Jan Holesovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2856 Approvals: Jan Holesovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2856 To unsubscribe,

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - basic/source

2013-03-20 Thread Eike Rathke
basic/source/sbx/sbxscan.cxx | 195 +-- 1 file changed, 117 insertions(+), 78 deletions(-) New commits: commit 96b079e24f86f7f49a624573783c6e103012f942 Author: Eike Rathke er...@redhat.com Date: Tue Mar 19 23:23:16 2013 +0100 resolved rhbz#919020

[PUSHED libreoffice-4-0] resolved rhbz#919020 Basic CDbl() and CSng() scan localized ...

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2859 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2859 To unsubscribe, visit

Re: #ifdef vs #if for feature checks

2013-03-20 Thread Thomas Arnhold
Yes, but our internal RSC doesn't support #pragma once ;) On 19.03.2013 07:53, vincent wrote: HI, I found some wiki about #pragma once compiler support http://en.wikipedia.org/wiki/Pragma_once#Portability http://en.wikipedia.org/wiki/Pragma_once#Portability Compiler#pragma once Clang

[Libreoffice-commits] core.git: basegfx/test chart2/source comphelper/source connectivity/source testtools/source ucb/source unotools/source unoxml/source xmloff/source

2013-03-20 Thread Chr . Rossmanith
basegfx/test/basegfx2d.cxx | 18 -- chart2/source/controller/main/ConfigurationAccess.cxx |6 comphelper/source/container/embeddedobjectcontainer.cxx|2 comphelper/source/misc/locale.cxx |6

Re: Trouble building master with ccache on Windows

2013-03-20 Thread d . ostrovsky
Quoting Kohei Yoshida kohei.yosh...@gmail.com: On Tue, Mar 19, 2013 at 6:51 PM, David Ostrovsky d.ostrov...@idaia.de wrote: Anyway gcc-wrapper should work with ccache enabled now: https://gerrit.libreoffice.org/#/c/2857/ Yup, I confirm that it works now. :-) After thinking about it i

[PUSHED] simplify OUString assignments

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2863 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2863 To unsubscribe, visit

[PATCH] use -isystem instead of -I for 3rd party headers

2013-03-20 Thread via Code Review
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2846 to look at the new patch set (#2). Change subject: use -isystem instead of -I for 3rd party headers ..

[PUSHED] use -isystem instead of -I for 3rd party headers

2013-03-20 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2846 -- To view, visit https://gerrit.libreoffice.org/2846 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[Libreoffice-commits] core.git: 2 commits - sw/qa sw/source xmloff/source

2013-03-20 Thread Miklos Vajna
sw/qa/extras/odfexport/data/fdo60769.odt |binary sw/qa/extras/odfexport/odfexport.cxx | 28 sw/source/core/unocore/unoportenum.cxx | 12 xmloff/source/text/txtparae.cxx | 20 4 files changed, 52 insertions(+), 8

make error

2013-03-20 Thread Winfried Donkers
I upgraded my machine to openSUSE 12.3, did a ./g pull --rebase and ran make dev-install, resulting in the following error: […] [build CXX] codemaker/source/commonjava/commonjava.cxx [build LNK] StaticLibrary/libcodemaker_java.a [build CXX] codemaker/source/javamaker/classfile.cxx [build CXX]

Re: make error

2013-03-20 Thread Michael Stahl
On 20/03/13 11:54, Winfried Donkers wrote: I upgraded my machine to openSUSE 12.3, did a ./g pull --rebase and ran make dev-install, resulting in the following error: [build JCS] Jar/ridl javac: error: unrecognized command line option ‘-source’ javac: error: 1.5: Bestand of map

[Libreoffice-commits] core.git: sw/qa

2013-03-20 Thread Yifan J
sw/qa/extras/ooxmlimport/data/tools-line-numbering.docx |binary sw/qa/extras/ooxmlimport/ooxmlimport.cxx| 37 2 files changed, 37 insertions(+) New commits: commit 9a7d2e0f5e7adb791fff6a52acd7425b31c11f61 Author: Yifan J yfji...@suse.com Date: Wed Mar 20

Re: [SCRIPT] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-20 Thread Stephan Bergmann
On 03/19/2013 07:38 PM, Thomas Arnhold wrote: #!/usr/bin/perl # git grep 'RTL_CONSTASCII_USTRINGPARAM' -- '*.[hc]xx' | cut -d':' -f1 | sort -u | xargs perl constascii.pl foreach (@ARGV) { my $file = $_; my $data = ; my $fh; open($fh, $file); while

Re: make error

2013-03-20 Thread d . ostrovsky
Quoting Michael Stahl mst...@redhat.com: that is very odd, your javac does not understand -source and -target parameters. [...] that is not odd at all: http://linux.die.net/man/1/gcj the arguments are different there -fsource -ftarget and because it is not the first time someone fails into

Re: make error

2013-03-20 Thread Michael Stahl
On 20/03/13 12:22, d.ostrov...@idaia.de wrote: Quoting Michael Stahl mst...@redhat.com: that is very odd, your javac does not understand -source and -target parameters. [...] that is not odd at all: http://linux.die.net/man/1/gcj the arguments are different there -fsource -ftarget

RE: make error

2013-03-20 Thread Winfried Donkers
Hi Michael, that is very odd, your javac does not understand -source and -target parameters. can you try installing OpenJDK instead? I have java-1_6_0-openjdk installed. I also trried with java-1_7_0-openjdk, but that had the same result, so I switched backup to 1_6. Should I remove

[Libreoffice-commits] core.git: sc/qa

2013-03-20 Thread Stephan Bergmann
sc/qa/extras/macros-test.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 917b57001351d839fc091eab8ea4a97a0e77914e Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 20 12:37:44 2013 +0100 -Werror=undef Change-Id:

Re: #ifdef vs #if for feature checks

2013-03-20 Thread Noel Grandin
On 2013-03-20 12:16, Thomas Arnhold wrote: Yes, but our internal RSC doesn't support #pragma once ;) Maybe we could make that a Medium Hack project? Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list

Re: make error

2013-03-20 Thread Michael Stahl
On 20/03/13 12:33, Winfried Donkers wrote: Hi Michael, that is very odd, your javac does not understand -source and -target parameters. can you try installing OpenJDK instead? I have java-1_6_0-openjdk installed. I also trried with java-1_7_0-openjdk, but that had the same result, so

[Libreoffice-commits] core.git: officecfg/registry sd/inc sd/Library_sdui.mk sd/sdi sd/source sd/uiconfig sd/UI_simpress.mk

2013-03-20 Thread Gergő Mocsi
officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu | 9 sd/Library_sdui.mk | 4 sd/UI_simpress.mk| 1 sd/inc/app.hrc

[PUSHED] fdo#35546, implementing 'Create Photo Album' function

2013-03-20 Thread Andras Timar (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2582 Approvals: Andras Timar: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2582 To unsubscribe,

[Libreoffice-commits] core.git: vcl/unx

2013-03-20 Thread Christian M . Heller
vcl/unx/generic/app/saldisp.cxx | 29 ++--- vcl/unx/generic/gdi/salgdi.cxx | 10 +- 2 files changed, 19 insertions(+), 20 deletions(-) New commits: commit c86fa81bcd5db0db4b343a27cc7ca979613fc2ad Author: Christian M. Heller christian.helle...@gmail.com Date:

[Libreoffice-commits] core.git: sc/source sw/source

2013-03-20 Thread gerhard oettl
sc/source/core/data/table4.cxx | 122 sw/source/core/text/porglue.cxx | 48 +++ 2 files changed, 83 insertions(+), 87 deletions(-) New commits: commit b4966ea69ff0ad6944bd16d8a09ecb27a1704c10 Author: gerhard oettl lo...@ogersoft.at Date:

RE: make error

2013-03-20 Thread Winfried Donkers
Hi Michael, try removing gcj instead. I did; autogen.sh went fine, make is now running. Thank you for your advise, I will report when it doesn't help in the end :) Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PUSHED] fdo#39468 German comments in vcl/unx/generic/...

2013-03-20 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2865 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2865 To unsubscribe,

[PUSHED] fdo#39468: Translated German comments

2013-03-20 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2847 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2847 To unsubscribe,

[PATCH] coverity#704618 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2866 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2866/1 coverity#704618 Explicit null dereferenced Change-Id: I9f3befc235b0fb7933294be4a97d168ef203a79c --- M

[Libreoffice-commits] core.git: 6 commits - connectivity/source cppuhelper/source editeng/source extensions/source filter/source forms/source framework/source sal/inc sal/qa sd/source sfx2/source stoc

2013-03-20 Thread Stephan Bergmann
connectivity/source/commontools/dbmetadata.cxx | 4 +- connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 8 ++-- cppuhelper/source/shlib.cxx| 2 - editeng/source/items/frmitems.cxx

Re: #ifdef vs #if for feature checks

2013-03-20 Thread Michael Stahl
On 20/03/13 12:41, Noel Grandin wrote: On 2013-03-20 12:16, Thomas Arnhold wrote: Yes, but our internal RSC doesn't support #pragma once ;) Maybe we could make that a Medium Hack project? i've already filed https://bugs.freedesktop.org/show_bug.cgi?id=55324 about the CPP proliferation

[Libreoffice-commits] core.git: cui/source fpicker/source sd/source sfx2/source svtools/source svx/source unotools/inc unotools/source uui/source

2013-03-20 Thread Chr . Rossmanith
cui/source/dialogs/hldocntp.cxx | 16 cui/source/dialogs/hldoctp.cxx|6 +++--- cui/source/dialogs/hltpbase.cxx |4 ++-- cui/source/dialogs/multipat.cxx |6 +++--- fpicker/source/office/iodlg.cxx

[PUSHED] Replace String with OUString (unotools)

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2864 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2864 To unsubscribe, visit

[PATCH] coverity#704622 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2867 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2867/1 coverity#704622 Explicit null dereferenced Change-Id: I3328390799a87f2acff6ee689879325e4aa4357e --- M

[Libreoffice-commits] core.git: chart2/source

2013-03-20 Thread Muthu Subramanian
chart2/source/view/main/ChartView.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit 2903c5f59d257b6ab94f32df64513f2edf94fb0b Author: Muthu Subramanian sumu...@suse.com Date: Wed Mar 20 17:39:30 2013 +0530 n#734735: Use full available size for pie

[Libreoffice-commits] core.git: sw/source

2013-03-20 Thread Miklos Vajna
sw/source/core/doc/docfld.cxx | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) New commits: commit 62344016de056965a58ea2016d912a68eac0d6b0 Author: Miklos Vajna vmik...@suse.cz Date: Wed Mar 20 13:19:32 2013 +0100 fdo#55814 SwDoc::UpdateExpFlds: hiding the last

Re: make error

2013-03-20 Thread Rene Engelhard
Hi, On Wed, Mar 20, 2013 at 12:26:35PM +0100, Michael Stahl wrote: But why do we still stick to 1.5 source and target version of bytecode anyway? AFAIK the reason for that is called Debian GNU/kFreeBSD, which does not have a Java 1.6 implementation available (otherwise it would be 1.6

[Libreoffice-commits] core.git: basegfx/source

2013-03-20 Thread Thorsten Behrens
basegfx/source/polygon/b2dpolygontools.cxx | 116 +--- basegfx/source/polygon/b3dpolypolygontools.cxx | 240 + 2 files changed, 182 insertions(+), 174 deletions(-) New commits: commit 46b56dd6d422dfae325dee2b47b395e62817db1a Author: Thorsten Behrens

[PATCH] coverity#704628/704629/704630 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2869 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/2869/1 coverity#704628/704629/704630 Explicit null dereferenced + return early if no whichid or after default case

[Libreoffice-commits] core.git: dbaccess/source

2013-03-20 Thread Julien Nabet
dbaccess/source/ui/dlg/dbwizsetup.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1890f4ba4c0b345a73185adf320d06d0974f644b Author: Julien Nabet serval2...@yahoo.fr Date: Wed Mar 20 13:00:45 2013 +0100 coverity#704618 Explicit null dereferenced

[PUSHED] coverity#704618 Explicit null dereferenced

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2866 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2866 To unsubscribe, visit

[Libreoffice-commits] core.git: configure.ac

2013-03-20 Thread Luboš Luňák
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0e6cbfe0b1513af1a5d5ab7bc604cfda8eb8e27f Author: Luboš Luňák l.lu...@suse.cz Date: Wed Mar 20 13:40:17 2013 +0100 remove leftover from copypaste diff --git a/configure.ac b/configure.ac index

Re: make error

2013-03-20 Thread Rene Engelhard
On Wed, Mar 20, 2013 at 12:22:59PM +0100, d.ostrov...@idaia.de wrote: But why do we still stick to 1.5 source and target version of bytecode anyway? Wven when we didn't, you need to use =1.6 (if you built with java7) which would still keep the need for -target so this is (at least half) a no-op

[Libreoffice-commits] core.git: configure.ac

2013-03-20 Thread Stephan Bergmann
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c499fb240c422eb5e6d15e7f8db2408a55140c7f Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 20 13:52:15 2013 +0100 Work around -Werror,-Wundef ...from

[Libreoffice-commits] core.git: sw/source

2013-03-20 Thread Thorsten Behrens
sw/source/core/text/porglue.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 631eb6141bae5569dc6331fa39891c5227d4a2e4 Author: Thorsten Behrens tbehr...@suse.com Date: Wed Mar 20 13:50:38 2013 +0100 Slight touch-up of German translation. Fixup

Re: [Libreoffice-commits] core.git: TODO: Unclear whether comparisons against Ruby shall use == or startsWith

2013-03-20 Thread Stephan Bergmann
Maybe somebody with deeper insight into the Writer code can resolve that TODO. Thanks, Stephan On 03/20/2013 01:06 PM, Stephan Bergmann wrote: commit dc06576d8809760b79f771831bed3122878e0505 Author: Stephan Bergmannsberg...@redhat.com Date: Wed Mar 20 12:54:59 2013 +0100 TODO: Unclear

[PATCH] coverity#704774 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2870 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2870/1 coverity#704774 Explicit null dereferenced Change-Id: Ief63d63233d11015f64f5e6a19544889f0389ca3 --- M

Re: rtl::OUString::compareToAscii is dangerous

2013-03-20 Thread Stephan Bergmann
On 03/19/2013 06:37 PM, Stephan Bergmann wrote: On 03/19/2013 06:29 PM, Noel Grandin wrote: On Tue, Mar 19, 2013 at 6:54 PM, Stephan Bergmann sberg...@redhat.com wrote: * compareToAscii(char cosnt * asciiStr, sal_Int32 maxLength) does a shortened comparison of only up to maxLength characters

[Libreoffice-commits] core.git: sw/source

2013-03-20 Thread Michael Stahl
sw/source/core/unocore/unoport.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b19c601bc4e4700b9d193a86795424e847759b4b Author: Michael Stahl mst...@redhat.com Date: Wed Mar 20 14:16:08 2013 +0100 SwXTextPortion has 4 properties whose names start with

Re: [Libreoffice-commits] core.git: TODO: Unclear whether comparisons against Ruby shall use == or startsWith

2013-03-20 Thread Michael Stahl
On 20/03/13 14:00, Stephan Bergmann wrote: Maybe somebody with deeper insight into the Writer code can resolve that TODO. if (GetTextPortionType() == PORTION_RUBY_START -!rPropertyName.compareToAscii( RTL_CONSTASCII_STRINGPARAM(Ruby) )) +

[PATCH] Related to coverity#704822 (Explicit null dereference)

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2872 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/2872/1 Related to coverity#704822 (Explicit null dereference) aSlotIds.push_back(0) = aSlotIds can't be empty =

[Libreoffice-commits] core.git: vcl/aqua

2013-03-20 Thread Stephan Bergmann
vcl/aqua/source/gdi/salgdicommon.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 334212593313199bc4549efdca849964c313b037 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 20 14:38:57 2013 +0100 -Werror,-Wundef Change-Id:

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-3.6' - 2 commits - chart2/source

2013-03-20 Thread Muthu Subramanian
chart2/source/view/charttypes/PieChart.cxx |2 +- chart2/source/view/main/ChartView.cxx |5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) New commits: commit c56f5aca62ccc8a641f3eaa304d9c1ff004c0ea6 Author: Muthu Subramanian sumu...@suse.com Date: Thu Mar 14 12:54:28 2013

Re: [SCRIPT] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-20 Thread Thomas Arnhold
On 20.03.2013 12:09, Stephan Bergmann wrote: On 03/19/2013 07:38 PM, Thomas Arnhold wrote: #!/usr/bin/perl # git grep 'RTL_CONSTASCII_USTRINGPARAM' -- '*.[hc]xx' | cut -d':' -f1 | sort -u | xargs perl constascii.pl foreach (@ARGV) { my $file = $_; my $data = ; my $fh;

[Libreoffice-commits] core.git: configure.ac

2013-03-20 Thread Tor Lillqvist
configure.ac |1 + 1 file changed, 1 insertion(+) New commits: commit 4ea575298464faf3e02d519b4fc6ea6e1d59beb1 Author: Tor Lillqvist t...@iki.fi Date: Wed Mar 20 16:03:06 2013 +0200 Use -isystem for NPAPI CFLAGS when available and necessary Change-Id:

[Libreoffice-commits] core.git: extensions/source ucb/source

2013-03-20 Thread Thomas Arnhold
extensions/source/update/ui/updatecheckui.cxx |2 +- ucb/source/ucp/webdav/DAVProperties.cxx | 20 +++- 2 files changed, 8 insertions(+), 14 deletions(-) New commits: commit 11878c68c6e22373c95d4b7707aaf2c91e6a1fa1 Author: Thomas Arnhold tho...@arnhold.org Date: Wed

[Libreoffice-commits] core.git: connectivity/source

2013-03-20 Thread Thomas Arnhold
connectivity/source/drivers/mozab/bootstrap/MNSInit.hxx |4 ++-- connectivity/source/drivers/mozab/mozillasrc/MNSInclude.hxx |2 +- connectivity/source/drivers/mozab/mozillasrc/MNameMapper.hxx |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) New commits: commit

[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 60769, which changed state. Bug 60769 Summary: FILEOPEN, FILESAVE, Could not save document, error in writing sub document context.xml then corrupt file. https://bugs.freedesktop.org/show_bug.cgi?id=60769

[PATCH libreoffice-4-0] fdo#60769 implement odf export of multi-paragraph comment ra...

2013-03-20 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2873 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/2873/1 fdo#60769 implement odf export of multi-paragraph comment ranges (cherry picked from commits

Re: rtl::OUString::compareToAscii is dangerous

2013-03-20 Thread d . ostrovsky
Quoting Stephan Bergmann sberg...@redhat.com: On 03/19/2013 06:37 PM, Stephan Bergmann wrote: I apologize in advance for any remaining occurrences that my build didn't catch. (Where is the gerrit tinderbox trigger when one needs them?) Currently only gerrit admins can schedule gerrit

[Libreoffice-commits] core.git: svx/source

2013-03-20 Thread Julien Nabet
svx/source/form/fmshimp.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5879775875cd769bca29ca87e758c13e34a7ff00 Author: Julien Nabet serval2...@yahoo.fr Date: Wed Mar 20 14:25:23 2013 +0100 Related to coverity#704822 (Explicit null dereference)

[PUSHED] Related to coverity#704822 (Explicit null dereference)

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2872 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2872 To unsubscribe, visit

[Libreoffice-commits] core.git: extensions/source

2013-03-20 Thread Stephan Bergmann
extensions/source/update/ui/updatecheckui.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 463417f8867b61dbae1ed993ac9a9668acc9f84b Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 20 15:09:56 2013 +0100 Assume that this shall check full string

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/inc sc/qa sc/source

2013-03-20 Thread Kohei Yoshida
sc/inc/stringutil.hxx | 21 - sc/qa/unit/ucalc.cxx|4 +--- sc/source/core/data/dbdocutl.cxx|4 +--- sc/source/core/data/document.cxx|4 +--- sc/source/core/data/dpoutput.cxx| 13 +++--

[Libreoffice-commits] core.git: sd/source

2013-03-20 Thread Julien Nabet
sd/source/ui/view/OutlinerIterator.cxx |4 1 file changed, 4 insertions(+) New commits: commit c40a774c203f4a55df67cd8da22e426b3edf0da1 Author: Julien Nabet serval2...@yahoo.fr Date: Wed Mar 20 13:58:03 2013 +0100 coverity#704774 Explicit null dereferenced Change-Id:

[PUSHED] coverity#704774 Explicit null dereferenced

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2870 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2870 To unsubscribe, visit

[Libreoffice-commits] core.git: vcl/aqua

2013-03-20 Thread Stephan Bergmann
vcl/aqua/source/gdi/salgdicommon.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 0b3c72fe89d3e1d56d148114a64ddaf97040a179 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 20 15:24:16 2013 +0100 Improve previous __BIG_ENDIAN__ fix

[PATCH] this looks better

2013-03-20 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2874 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/2874/1 this looks better Change-Id: I10af9ff8513f8f583867d0d6a18af03b3b5b1a28 --- M

Re: #ifdef vs #if for feature checks [proof of concept]

2013-03-20 Thread Thomas Arnhold
Hi, https://gerrit.libreoffice.org/#/c/2875/ At least on Linux with --without-java --enable-werror works for me. I only replaced guards like *_HXX_, *_HXX__ and *_HXX_INCLUDED which are not used at any other place. Those are ~8700 matches. Approx. 500 look like guards, but don't match the

[ABANDONED] this looks better

2013-03-20 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change. Change subject: this looks better .. Patch Set 1: Abandoned already seen committed as 5e2fd3b3c96362368a516f59555a42450126be85 -- To view, visit https://gerrit.libreoffice.org/2874

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 7c/a8a404adfc6f871cdc42fd1ccf5f3c5070ed6c

2013-03-20 Thread Eike Rathke
7c/a8a404adfc6f871cdc42fd1ccf5f3c5070ed6c |1 + 1 file changed, 1 insertion(+) New commits: commit 9b0452fbaf3a8125b7bca8f53b6b84e3bcddd735 Author: Eike Rathke er...@redhat.com Date: Wed Mar 20 15:35:52 2013 +0100 Notes added by 'git notes add' diff --git

Re: make error

2013-03-20 Thread d . ostrovsky
Quoting Rene Engelhard r...@debian.org: On Wed, Mar 20, 2013 at 12:22:59PM +0100, d.ostrov...@idaia.de wrote: But why do we still stick to 1.5 source and target version of bytecode anyway? Wven when we didn't, you need to use =1.6 (if you built with java7) Which bring me to the question

[PATCH libreoffice-4-0] fdo#55814 SwDoc::UpdateExpFlds: hiding the last section may ...

2013-03-20 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2876 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/2876/1 fdo#55814 SwDoc::UpdateExpFlds: hiding the last section may be safe In case we know there is a non-section

Re: make error

2013-03-20 Thread Miklos Vajna
On Wed, Mar 20, 2013 at 03:37:45PM +0100, d.ostrov...@idaia.de wrote: Which bring me to the question why? UNO java bridge doesn't support 1.7? Generic Linux builds are created on RHEL5, that only has openjdk6. Likewise, Android only supports 1.6 as well. signature.asc Description: Digital

[Libreoffice-commits] core.git: svx/source

2013-03-20 Thread Regina Henschel
svx/source/customshapes/EnhancedCustomShapeGeometry.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit e6a7c555cc6919cbe2fdaf794d57ca0819760c92 Author: Regina Henschel reg...@apache.org Date: Mon Aug 6 10:35:23 2012 + i#78247# and i#78029# wrong glue

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sw/source

2013-03-20 Thread Miklos Vajna
sw/source/core/doc/docfld.cxx | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) New commits: commit 326be48e3e3edd151e59abbafac6c70077296675 Author: Miklos Vajna vmik...@suse.cz Date: Wed Mar 20 13:19:32 2013 +0100 fdo#55814 SwDoc::UpdateExpFlds: hiding the last

[PUSHED libreoffice-4-0] fdo#55814 SwDoc::UpdateExpFlds: hiding the last section may ...

2013-03-20 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2876 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2876 To unsubscribe,

Re: make error

2013-03-20 Thread Rene Engelhard
Hi, On Wed, Mar 20, 2013 at 03:37:45PM +0100, d.ostrov...@idaia.de wrote: Quoting Rene Engelhard r...@debian.org: On Wed, Mar 20, 2013 at 12:22:59PM +0100, d.ostrov...@idaia.de wrote: But why do we still stick to 1.5 source and target version of bytecode anyway? Wven when we didn't, you

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - svx/source

2013-03-20 Thread Regina Henschel
svx/source/customshapes/EnhancedCustomShapeGeometry.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 0bebb6b7ee44db2554a74a77ffaffb304a7d9b3b Author: Regina Henschel reg...@apache.org Date: Mon Aug 6 10:35:23 2012 + i#78247# and i#78029# wrong glue

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sw/qa sw/source xmloff/source

2013-03-20 Thread Miklos Vajna
sw/qa/extras/odfexport/data/fdo60769.odt |binary sw/qa/extras/odfexport/odfexport.cxx | 28 sw/source/core/unocore/unoportenum.cxx | 12 xmloff/source/text/txtparae.cxx | 20 4 files changed, 52 insertions(+), 8

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 26/e91b07a559692b4f8acdd04f5bd28d0daa68b3

2013-03-20 Thread Eike Rathke
26/e91b07a559692b4f8acdd04f5bd28d0daa68b3 |1 + 1 file changed, 1 insertion(+) New commits: commit d05da358b35bca5ac99b3e59db12c5083900558f Author: Eike Rathke er...@redhat.com Date: Wed Mar 20 16:06:41 2013 +0100 Notes added by 'git notes add' diff --git

[PUSHED libreoffice-4-0] fdo#60769 implement odf export of multi-paragraph comment ra...

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2873 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2873 To unsubscribe, visit

Re: [PATCH libreoffice-4-0] fdo#55814 SwDoc::UpdateExpFlds: hiding the last section may ...

2013-03-20 Thread d . ostrovsky
Hi, Quoting Miklos Vajna (via Code Review) ger...@gerrit.libreoffice.org: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2876 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/2876/1 fdo#55814 SwDoc::UpdateExpFlds:

[Libreoffice-commits] core.git: extensions/source

2013-03-20 Thread Stephan Bergmann
extensions/source/plugin/aqua/macmgr.mm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 720243baae25d15acd6ac0dbe144a02102867a16 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 20 16:13:18 2013 +0100 -Werror,-Wundef Change-Id:

  1   2   3   4   >