On Sun, 2010-10-31 at 11:56 +0100, Joost Eekhoorn wrote:
MPL 1.1 / GPLv3+ / LGPLv3+
Excellent, pushed, thanks.
About coding conventions:
In /desktop/source/app/dispatchwatcher.cxx starts with
using ::rtl::OUString; and then there are:
::rtl::OUString
rtl::OUString
OUString
What is the
Hi,
I'am not sure of my previous mail...
Regards.
createFromAscii_5.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi,
Quote : I'am not sure of my previous mail.
I sent it 3 hours ago but it did not appear (and it's in my 'sent-mail'
directory) : maybe some problem with my ISP because of the end of DST this
night...
Regards.
___
LibreOffice mailing list
MPL 1.1 / GPLv3+ / LGPLv3+
In ./cui/source/tabpages/numpages.cxx (line 2852):
String sMsg( RTL_CONSTASCII_USTRINGPARAM( Preview) );
Should that not be RTL_CONSTASCII_STRINGPARAM, because sMsg is a String and
not a OUString?
Joost
diff --git a/cui/source/tabpages/autocdlg.cxx
On Sun, 2010-10-31 at 15:37 +0100, Joost Eekhoorn wrote:
MPL 1.1 / GPLv3+ / LGPLv3+
All good, committed and pushed, thanks :-)
In ./cui/source/tabpages/numpages.cxx (line 2852):
String sMsg( RTL_CONSTASCII_USTRINGPARAM( Preview) );
Should that not be RTL_CONSTASCII_STRINGPARAM, because
Correct description would be:
Grouped inner Optional Features (--enable/disable-) and
Optional Packages (--with/without-) to ease maintenance.
Minor fix: ]\n] - ]\n
Option --with-servlet-api-jar=JARFILE was named wrong in --help.
(It was named as --servlet-api-jar=JARFILE.)
No changes to the
On Sun, 2010-10-31 at 13:41 +0100, Gert Faller wrote:
Hi,
I'am not sure of my previous mail...
This looks good. I pushed this patch as well.
I see (again this was already there and not added by your patch) a few
rather odd rtl::OUString sEmpty(OUString::createFromAscii()) in there
to create
On Sat, 2010-10-30 at 22:08 +0100, Caolán McNamara wrote:
old: OUString sFoo(OUString::createFromAscii(bBool ? true : false));
new: OUString sFoo(RTL_CONSTASCII_USTRINGPARAM(bBool ? true :
false));
would be expanded as...
OUString sFoo(bBool ? true : false, ((sal_Int32)(sizeof(bBool ?
While building Go/LibO for ArchLinux I've run into a few issues today
after we had updated our mono packages to the 2.8 release.
1) the patches/mono/*.diff call mkbundle2 at several places.
mkbundle2 (that called /usr/lib/mono/2.0/mkbundle.exe) isn't
shipped anymore in the mono 2.8 release
On Sun, 2010-10-31 at 21:18 +0100, Joost Eekhoorn wrote:
MPL 1.1 / GPLv3+ / LGPLv3+
Excellent, all good. Thanks for the stylistic improvement in
cFA_joost_5.patch while you were adding the
RTL_CONSTASCII_USTRINGPARAM's :-)
C.
___
LibreOffice mailing
From 09a62885c6c5aea12412d9bcb37a997bce87fa2d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niko=20R=C3=B6nkk=C3=B6?= ron...@iki.fi
Date: Mon, 1 Nov 2010 00:36:23 +0200
Subject: [PATCH] Wrong option name in help
MIME-Version: 1.0
Content-Type: multipart/mixed;
11 matches
Mail list logo